github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
02f0a3ee91
kubernetes/pkg/volume
History
Stephen Benjamin b351745c1c Replace use of Sprintf with net.JoinHostPort 
On IPv6 clusters, one of the most frequent problems I encounter is
assumptions that one can build a URL with a host and port simply by
using Sprintf, like this:

```go
fmt.Sprintf("http://%s:%d/foo", host, port)
```

When `host` is an IPv6 address, this produces an invalid URL as it must
be bracketed, like this:

```
http://[2001:4860:4860::8888]:9443
```

This change fixes the occurences of joining a host and port with the
purpose built `net.JoinHostPort` function.

I encounter this problem often enough that I started to [write a linter
for it](https://github.com/stbenjam/go-sprintf-host-port).  I don't
think the linter is quite ready for wide use yet, but I did run it
against the Kube codebase and found these.  While the host portion in
some of these changes may always be an FQDN or IPv4 IP today, it's an
easy thing that can break later on.
2022-05-04 06:37:50 -04:00
..
awsebs Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
azure_file Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
azuredd Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
cephfs Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
cinder Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
configmap Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
csi csi: add nodeExpandSecret support for CSI client 2022-04-05 11:36:23 +08:00
csimigration Next step in CSI migration for openstack 2022-01-10 22:07:44 -05:00
downwardapi Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
emptydir Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
fc Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
flexvolume Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
flocker Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
gcepd Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
git_repo Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
glusterfs Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
hostpath Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
iscsi enhance and fix log calls 2022-03-24 11:13:50 +01:00
local Log StructuredLog: spelling formatting 2022-04-26 17:04:06 +08:00
nfs Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
portworx Replace use of Sprintf with net.JoinHostPort 2022-05-04 06:37:50 -04:00
projected Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
quobyte Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
rbd Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
secret Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
storageos Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
testing Merge pull request #99685 from yangjunmyfm192085/run-test24 2022-05-03 17:16:47 -07:00
util Merge pull request #103911 from swiftslee/log-format 2022-05-03 17:17:32 -07:00
validation hack/update-bazel.sh 2021-02-28 15:17:29 -08:00
vsphere_volume Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00
doc.go
metrics_block_test.go The test was not very useful and required elevated access 2021-06-04 15:48:35 -04:00
metrics_block.go add volume type and seperated histogram for volume stat collection 2022-01-19 22:33:37 +08:00
metrics_cached.go
metrics_du_test.go generated: Run hack/update-gofmt.sh 2021-08-24 15:47:49 -04:00
metrics_du.go set metric_source to du or fsquota accordingly 2022-01-20 10:56:02 +08:00
metrics_errors.go Add helper functions for Block volume Capacity detection 2021-05-20 16:37:12 +02:00
metrics_nil_test.go Add SupportsMetrics() for Block-mode volumes 2021-05-20 17:10:23 +02:00
metrics_nil.go Add SupportsMetrics() for Block-mode volumes 2021-05-20 17:10:23 +02:00
metrics_statfs_test.go
metrics_statfs.go add volume type and seperated histogram for volume stat collection 2022-01-19 22:33:37 +08:00
noop_expandable_plugin.go plumb service account token down to csi driver 2020-11-12 09:26:43 -08:00
OWNERS Check in OWNERS modified by update-yamlfmt.sh 2021-12-09 21:31:26 -05:00
plugins_test.go Fixed a possible nil pointer dereference caused by variable plug 2021-05-21 10:17:04 +08:00
plugins.go Do not update PVC if it already has updated size 2022-03-28 11:32:49 -04:00
volume_linux_test.go kubelet: Remove the deprecated flag --experimental-check-node-capabilities-before-mount 2022-01-06 11:47:11 +08:00
volume_linux.go Fix the wrong log 2021-11-17 09:07:07 +08:00
volume_unsupported.go generated: Run hack/update-gofmt.sh 2021-08-24 15:47:49 -04:00
volume.go Merge pull request #104732 from mengjiao-liu/remove-flag-experimental-check-node-capabilities-before-mount 2022-02-24 07:56:30 -08:00