a07022ae8a
Changes in pkg/apis/scheduler reflecting the changes from staging. The weights of following priority plugins were increased: - TaintTolerations - NodeAffinity - InterPodAffinity as they're user facing priorities and they should be more influential when compared to default plugins which don't have any user say. xref: https://github.com/kubernetes/enhancements/pull/2850
699 lines
22 KiB
Go
699 lines
22 KiB
Go
/*
|
|
Copyright 2021 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package v1beta3
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
|
|
v1 "k8s.io/api/core/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
|
|
"k8s.io/apiserver/pkg/util/feature"
|
|
componentbaseconfig "k8s.io/component-base/config/v1alpha1"
|
|
"k8s.io/component-base/featuregate"
|
|
featuregatetesting "k8s.io/component-base/featuregate/testing"
|
|
"k8s.io/kube-scheduler/config/v1beta3"
|
|
"k8s.io/kubernetes/pkg/features"
|
|
"k8s.io/kubernetes/pkg/scheduler/framework/plugins/names"
|
|
"k8s.io/utils/pointer"
|
|
)
|
|
|
|
var pluginConfigs = []v1beta3.PluginConfig{
|
|
{
|
|
Name: "DefaultPreemption",
|
|
Args: runtime.RawExtension{
|
|
Object: &v1beta3.DefaultPreemptionArgs{
|
|
TypeMeta: metav1.TypeMeta{
|
|
Kind: "DefaultPreemptionArgs",
|
|
APIVersion: "kubescheduler.config.k8s.io/v1beta3",
|
|
},
|
|
MinCandidateNodesPercentage: pointer.Int32Ptr(10),
|
|
MinCandidateNodesAbsolute: pointer.Int32Ptr(100),
|
|
}},
|
|
},
|
|
{
|
|
Name: "InterPodAffinity",
|
|
Args: runtime.RawExtension{
|
|
Object: &v1beta3.InterPodAffinityArgs{
|
|
TypeMeta: metav1.TypeMeta{
|
|
Kind: "InterPodAffinityArgs",
|
|
APIVersion: "kubescheduler.config.k8s.io/v1beta3",
|
|
},
|
|
HardPodAffinityWeight: pointer.Int32Ptr(1),
|
|
}},
|
|
},
|
|
{
|
|
Name: "NodeAffinity",
|
|
Args: runtime.RawExtension{Object: &v1beta3.NodeAffinityArgs{
|
|
TypeMeta: metav1.TypeMeta{
|
|
Kind: "NodeAffinityArgs",
|
|
APIVersion: "kubescheduler.config.k8s.io/v1beta3",
|
|
},
|
|
}},
|
|
},
|
|
{
|
|
Name: "NodeResourcesBalancedAllocation",
|
|
Args: runtime.RawExtension{Object: &v1beta3.NodeResourcesBalancedAllocationArgs{
|
|
TypeMeta: metav1.TypeMeta{
|
|
Kind: "NodeResourcesBalancedAllocationArgs",
|
|
APIVersion: "kubescheduler.config.k8s.io/v1beta3",
|
|
},
|
|
Resources: []v1beta3.ResourceSpec{{Name: "cpu", Weight: 1}, {Name: "memory", Weight: 1}},
|
|
}},
|
|
},
|
|
{
|
|
Name: "NodeResourcesFit",
|
|
Args: runtime.RawExtension{Object: &v1beta3.NodeResourcesFitArgs{
|
|
TypeMeta: metav1.TypeMeta{
|
|
Kind: "NodeResourcesFitArgs",
|
|
APIVersion: "kubescheduler.config.k8s.io/v1beta3",
|
|
},
|
|
ScoringStrategy: &v1beta3.ScoringStrategy{
|
|
Type: v1beta3.LeastAllocated,
|
|
Resources: []v1beta3.ResourceSpec{{Name: "cpu", Weight: 1}, {Name: "memory", Weight: 1}},
|
|
},
|
|
}},
|
|
},
|
|
{
|
|
Name: "PodTopologySpread",
|
|
Args: runtime.RawExtension{Object: &v1beta3.PodTopologySpreadArgs{
|
|
TypeMeta: metav1.TypeMeta{
|
|
Kind: "PodTopologySpreadArgs",
|
|
APIVersion: "kubescheduler.config.k8s.io/v1beta3",
|
|
},
|
|
DefaultingType: v1beta3.SystemDefaulting,
|
|
}},
|
|
},
|
|
{
|
|
Name: "VolumeBinding",
|
|
Args: runtime.RawExtension{Object: &v1beta3.VolumeBindingArgs{
|
|
TypeMeta: metav1.TypeMeta{
|
|
Kind: "VolumeBindingArgs",
|
|
APIVersion: "kubescheduler.config.k8s.io/v1beta3",
|
|
},
|
|
BindTimeoutSeconds: pointer.Int64Ptr(600),
|
|
}},
|
|
},
|
|
}
|
|
|
|
func TestSchedulerDefaults(t *testing.T) {
|
|
enable := true
|
|
tests := []struct {
|
|
name string
|
|
config *v1beta3.KubeSchedulerConfiguration
|
|
expected *v1beta3.KubeSchedulerConfiguration
|
|
}{
|
|
{
|
|
name: "empty config",
|
|
config: &v1beta3.KubeSchedulerConfiguration{},
|
|
expected: &v1beta3.KubeSchedulerConfiguration{
|
|
Parallelism: pointer.Int32Ptr(16),
|
|
DebuggingConfiguration: componentbaseconfig.DebuggingConfiguration{
|
|
EnableProfiling: &enable,
|
|
EnableContentionProfiling: &enable,
|
|
},
|
|
LeaderElection: componentbaseconfig.LeaderElectionConfiguration{
|
|
LeaderElect: pointer.BoolPtr(true),
|
|
LeaseDuration: metav1.Duration{Duration: 15 * time.Second},
|
|
RenewDeadline: metav1.Duration{Duration: 10 * time.Second},
|
|
RetryPeriod: metav1.Duration{Duration: 2 * time.Second},
|
|
ResourceLock: "leases",
|
|
ResourceNamespace: "kube-system",
|
|
ResourceName: "kube-scheduler",
|
|
},
|
|
ClientConnection: componentbaseconfig.ClientConnectionConfiguration{
|
|
QPS: 50,
|
|
Burst: 100,
|
|
ContentType: "application/vnd.kubernetes.protobuf",
|
|
},
|
|
PercentageOfNodesToScore: pointer.Int32Ptr(0),
|
|
PodInitialBackoffSeconds: pointer.Int64Ptr(1),
|
|
PodMaxBackoffSeconds: pointer.Int64Ptr(10),
|
|
Profiles: []v1beta3.KubeSchedulerProfile{
|
|
{
|
|
Plugins: getDefaultPlugins(),
|
|
PluginConfig: pluginConfigs,
|
|
SchedulerName: pointer.StringPtr("default-scheduler"),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "no scheduler name",
|
|
config: &v1beta3.KubeSchedulerConfiguration{
|
|
Profiles: []v1beta3.KubeSchedulerProfile{{}},
|
|
},
|
|
expected: &v1beta3.KubeSchedulerConfiguration{
|
|
Parallelism: pointer.Int32Ptr(16),
|
|
DebuggingConfiguration: componentbaseconfig.DebuggingConfiguration{
|
|
EnableProfiling: &enable,
|
|
EnableContentionProfiling: &enable,
|
|
},
|
|
LeaderElection: componentbaseconfig.LeaderElectionConfiguration{
|
|
LeaderElect: pointer.BoolPtr(true),
|
|
LeaseDuration: metav1.Duration{Duration: 15 * time.Second},
|
|
RenewDeadline: metav1.Duration{Duration: 10 * time.Second},
|
|
RetryPeriod: metav1.Duration{Duration: 2 * time.Second},
|
|
ResourceLock: "leases",
|
|
ResourceNamespace: "kube-system",
|
|
ResourceName: "kube-scheduler",
|
|
},
|
|
ClientConnection: componentbaseconfig.ClientConnectionConfiguration{
|
|
QPS: 50,
|
|
Burst: 100,
|
|
ContentType: "application/vnd.kubernetes.protobuf",
|
|
},
|
|
PercentageOfNodesToScore: pointer.Int32Ptr(0),
|
|
PodInitialBackoffSeconds: pointer.Int64Ptr(1),
|
|
PodMaxBackoffSeconds: pointer.Int64Ptr(10),
|
|
Profiles: []v1beta3.KubeSchedulerProfile{
|
|
{
|
|
SchedulerName: pointer.StringPtr("default-scheduler"),
|
|
Plugins: getDefaultPlugins(),
|
|
PluginConfig: pluginConfigs},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "two profiles",
|
|
config: &v1beta3.KubeSchedulerConfiguration{
|
|
Parallelism: pointer.Int32Ptr(16),
|
|
Profiles: []v1beta3.KubeSchedulerProfile{
|
|
{
|
|
PluginConfig: []v1beta3.PluginConfig{
|
|
{Name: "FooPlugin"},
|
|
},
|
|
},
|
|
{
|
|
SchedulerName: pointer.StringPtr("custom-scheduler"),
|
|
Plugins: &v1beta3.Plugins{
|
|
Bind: v1beta3.PluginSet{
|
|
Enabled: []v1beta3.Plugin{
|
|
{Name: "BarPlugin"},
|
|
},
|
|
Disabled: []v1beta3.Plugin{
|
|
{Name: names.DefaultBinder},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
expected: &v1beta3.KubeSchedulerConfiguration{
|
|
Parallelism: pointer.Int32Ptr(16),
|
|
DebuggingConfiguration: componentbaseconfig.DebuggingConfiguration{
|
|
EnableProfiling: &enable,
|
|
EnableContentionProfiling: &enable,
|
|
},
|
|
LeaderElection: componentbaseconfig.LeaderElectionConfiguration{
|
|
LeaderElect: pointer.BoolPtr(true),
|
|
LeaseDuration: metav1.Duration{Duration: 15 * time.Second},
|
|
RenewDeadline: metav1.Duration{Duration: 10 * time.Second},
|
|
RetryPeriod: metav1.Duration{Duration: 2 * time.Second},
|
|
ResourceLock: "leases",
|
|
ResourceNamespace: "kube-system",
|
|
ResourceName: "kube-scheduler",
|
|
},
|
|
ClientConnection: componentbaseconfig.ClientConnectionConfiguration{
|
|
QPS: 50,
|
|
Burst: 100,
|
|
ContentType: "application/vnd.kubernetes.protobuf",
|
|
},
|
|
PercentageOfNodesToScore: pointer.Int32Ptr(0),
|
|
PodInitialBackoffSeconds: pointer.Int64Ptr(1),
|
|
PodMaxBackoffSeconds: pointer.Int64Ptr(10),
|
|
Profiles: []v1beta3.KubeSchedulerProfile{
|
|
{
|
|
Plugins: getDefaultPlugins(),
|
|
PluginConfig: []v1beta3.PluginConfig{
|
|
{Name: "FooPlugin"},
|
|
{
|
|
Name: "DefaultPreemption",
|
|
Args: runtime.RawExtension{
|
|
Object: &v1beta3.DefaultPreemptionArgs{
|
|
TypeMeta: metav1.TypeMeta{
|
|
Kind: "DefaultPreemptionArgs",
|
|
APIVersion: "kubescheduler.config.k8s.io/v1beta3",
|
|
},
|
|
MinCandidateNodesPercentage: pointer.Int32Ptr(10),
|
|
MinCandidateNodesAbsolute: pointer.Int32Ptr(100),
|
|
}},
|
|
},
|
|
{
|
|
Name: "InterPodAffinity",
|
|
Args: runtime.RawExtension{
|
|
Object: &v1beta3.InterPodAffinityArgs{
|
|
TypeMeta: metav1.TypeMeta{
|
|
Kind: "InterPodAffinityArgs",
|
|
APIVersion: "kubescheduler.config.k8s.io/v1beta3",
|
|
},
|
|
HardPodAffinityWeight: pointer.Int32Ptr(1),
|
|
}},
|
|
},
|
|
{
|
|
Name: "NodeAffinity",
|
|
Args: runtime.RawExtension{Object: &v1beta3.NodeAffinityArgs{
|
|
TypeMeta: metav1.TypeMeta{
|
|
Kind: "NodeAffinityArgs",
|
|
APIVersion: "kubescheduler.config.k8s.io/v1beta3",
|
|
},
|
|
}},
|
|
},
|
|
{
|
|
Name: "NodeResourcesBalancedAllocation",
|
|
Args: runtime.RawExtension{Object: &v1beta3.NodeResourcesBalancedAllocationArgs{
|
|
TypeMeta: metav1.TypeMeta{
|
|
Kind: "NodeResourcesBalancedAllocationArgs",
|
|
APIVersion: "kubescheduler.config.k8s.io/v1beta3",
|
|
},
|
|
Resources: []v1beta3.ResourceSpec{{Name: "cpu", Weight: 1}, {Name: "memory", Weight: 1}},
|
|
}},
|
|
},
|
|
{
|
|
Name: "NodeResourcesFit",
|
|
Args: runtime.RawExtension{Object: &v1beta3.NodeResourcesFitArgs{
|
|
TypeMeta: metav1.TypeMeta{
|
|
Kind: "NodeResourcesFitArgs",
|
|
APIVersion: "kubescheduler.config.k8s.io/v1beta3",
|
|
},
|
|
ScoringStrategy: &v1beta3.ScoringStrategy{
|
|
Type: v1beta3.LeastAllocated,
|
|
Resources: []v1beta3.ResourceSpec{{Name: "cpu", Weight: 1}, {Name: "memory", Weight: 1}},
|
|
},
|
|
}},
|
|
},
|
|
{
|
|
Name: "PodTopologySpread",
|
|
Args: runtime.RawExtension{Object: &v1beta3.PodTopologySpreadArgs{
|
|
TypeMeta: metav1.TypeMeta{
|
|
Kind: "PodTopologySpreadArgs",
|
|
APIVersion: "kubescheduler.config.k8s.io/v1beta3",
|
|
},
|
|
DefaultingType: v1beta3.SystemDefaulting,
|
|
}},
|
|
},
|
|
{
|
|
Name: "VolumeBinding",
|
|
Args: runtime.RawExtension{Object: &v1beta3.VolumeBindingArgs{
|
|
TypeMeta: metav1.TypeMeta{
|
|
Kind: "VolumeBindingArgs",
|
|
APIVersion: "kubescheduler.config.k8s.io/v1beta3",
|
|
},
|
|
BindTimeoutSeconds: pointer.Int64Ptr(600),
|
|
}},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
SchedulerName: pointer.StringPtr("custom-scheduler"),
|
|
Plugins: &v1beta3.Plugins{
|
|
QueueSort: v1beta3.PluginSet{
|
|
Enabled: []v1beta3.Plugin{
|
|
{Name: names.PrioritySort},
|
|
},
|
|
},
|
|
PreFilter: v1beta3.PluginSet{
|
|
Enabled: []v1beta3.Plugin{
|
|
{Name: names.NodeResourcesFit},
|
|
{Name: names.NodePorts},
|
|
{Name: names.VolumeRestrictions},
|
|
{Name: names.PodTopologySpread},
|
|
{Name: names.InterPodAffinity},
|
|
{Name: names.VolumeBinding},
|
|
{Name: names.NodeAffinity},
|
|
},
|
|
},
|
|
Filter: v1beta3.PluginSet{
|
|
Enabled: []v1beta3.Plugin{
|
|
{Name: names.NodeUnschedulable},
|
|
{Name: names.NodeName},
|
|
{Name: names.TaintToleration},
|
|
{Name: names.NodeAffinity},
|
|
{Name: names.NodePorts},
|
|
{Name: names.NodeResourcesFit},
|
|
{Name: names.VolumeRestrictions},
|
|
{Name: names.EBSLimits},
|
|
{Name: names.GCEPDLimits},
|
|
{Name: names.NodeVolumeLimits},
|
|
{Name: names.AzureDiskLimits},
|
|
{Name: names.VolumeBinding},
|
|
{Name: names.VolumeZone},
|
|
{Name: names.PodTopologySpread},
|
|
{Name: names.InterPodAffinity},
|
|
},
|
|
},
|
|
PostFilter: v1beta3.PluginSet{
|
|
Enabled: []v1beta3.Plugin{
|
|
{Name: names.DefaultPreemption},
|
|
},
|
|
},
|
|
PreScore: v1beta3.PluginSet{
|
|
Enabled: []v1beta3.Plugin{
|
|
{Name: names.InterPodAffinity},
|
|
{Name: names.PodTopologySpread},
|
|
{Name: names.TaintToleration},
|
|
{Name: names.NodeAffinity},
|
|
},
|
|
},
|
|
Score: v1beta3.PluginSet{
|
|
Enabled: []v1beta3.Plugin{
|
|
{Name: names.NodeResourcesBalancedAllocation, Weight: pointer.Int32Ptr(1)},
|
|
{Name: names.ImageLocality, Weight: pointer.Int32Ptr(1)},
|
|
{Name: names.NodeResourcesFit, Weight: pointer.Int32Ptr(1)},
|
|
{Name: names.InterPodAffinity, Weight: pointer.Int32Ptr(2)},
|
|
{Name: names.NodeAffinity, Weight: pointer.Int32Ptr(2)},
|
|
{Name: names.PodTopologySpread, Weight: pointer.Int32Ptr(2)},
|
|
{Name: names.TaintToleration, Weight: pointer.Int32Ptr(3)},
|
|
},
|
|
},
|
|
Reserve: v1beta3.PluginSet{
|
|
Enabled: []v1beta3.Plugin{
|
|
{Name: names.VolumeBinding},
|
|
},
|
|
},
|
|
PreBind: v1beta3.PluginSet{
|
|
Enabled: []v1beta3.Plugin{
|
|
{Name: names.VolumeBinding},
|
|
},
|
|
},
|
|
Bind: v1beta3.PluginSet{
|
|
Enabled: []v1beta3.Plugin{
|
|
{Name: "BarPlugin"},
|
|
},
|
|
},
|
|
},
|
|
PluginConfig: pluginConfigs,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "Prallelism with no port",
|
|
config: &v1beta3.KubeSchedulerConfiguration{
|
|
Parallelism: pointer.Int32Ptr(16),
|
|
},
|
|
expected: &v1beta3.KubeSchedulerConfiguration{
|
|
Parallelism: pointer.Int32Ptr(16),
|
|
DebuggingConfiguration: componentbaseconfig.DebuggingConfiguration{
|
|
EnableProfiling: &enable,
|
|
EnableContentionProfiling: &enable,
|
|
},
|
|
LeaderElection: componentbaseconfig.LeaderElectionConfiguration{
|
|
LeaderElect: pointer.BoolPtr(true),
|
|
LeaseDuration: metav1.Duration{Duration: 15 * time.Second},
|
|
RenewDeadline: metav1.Duration{Duration: 10 * time.Second},
|
|
RetryPeriod: metav1.Duration{Duration: 2 * time.Second},
|
|
ResourceLock: "leases",
|
|
ResourceNamespace: "kube-system",
|
|
ResourceName: "kube-scheduler",
|
|
},
|
|
ClientConnection: componentbaseconfig.ClientConnectionConfiguration{
|
|
QPS: 50,
|
|
Burst: 100,
|
|
ContentType: "application/vnd.kubernetes.protobuf",
|
|
},
|
|
PercentageOfNodesToScore: pointer.Int32Ptr(0),
|
|
PodInitialBackoffSeconds: pointer.Int64Ptr(1),
|
|
PodMaxBackoffSeconds: pointer.Int64Ptr(10),
|
|
Profiles: []v1beta3.KubeSchedulerProfile{
|
|
{
|
|
Plugins: getDefaultPlugins(),
|
|
PluginConfig: pluginConfigs,
|
|
SchedulerName: pointer.StringPtr("default-scheduler"),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "set non default parallelism",
|
|
config: &v1beta3.KubeSchedulerConfiguration{
|
|
Parallelism: pointer.Int32Ptr(8),
|
|
},
|
|
expected: &v1beta3.KubeSchedulerConfiguration{
|
|
Parallelism: pointer.Int32Ptr(8),
|
|
DebuggingConfiguration: componentbaseconfig.DebuggingConfiguration{
|
|
EnableProfiling: &enable,
|
|
EnableContentionProfiling: &enable,
|
|
},
|
|
LeaderElection: componentbaseconfig.LeaderElectionConfiguration{
|
|
LeaderElect: pointer.BoolPtr(true),
|
|
LeaseDuration: metav1.Duration{Duration: 15 * time.Second},
|
|
RenewDeadline: metav1.Duration{Duration: 10 * time.Second},
|
|
RetryPeriod: metav1.Duration{Duration: 2 * time.Second},
|
|
ResourceLock: "leases",
|
|
ResourceNamespace: "kube-system",
|
|
ResourceName: "kube-scheduler",
|
|
},
|
|
ClientConnection: componentbaseconfig.ClientConnectionConfiguration{
|
|
QPS: 50,
|
|
Burst: 100,
|
|
ContentType: "application/vnd.kubernetes.protobuf",
|
|
},
|
|
PercentageOfNodesToScore: pointer.Int32Ptr(0),
|
|
PodInitialBackoffSeconds: pointer.Int64Ptr(1),
|
|
PodMaxBackoffSeconds: pointer.Int64Ptr(10),
|
|
Profiles: []v1beta3.KubeSchedulerProfile{
|
|
{
|
|
Plugins: getDefaultPlugins(),
|
|
PluginConfig: pluginConfigs,
|
|
SchedulerName: pointer.StringPtr("default-scheduler"),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
for _, tc := range tests {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
SetDefaults_KubeSchedulerConfiguration(tc.config)
|
|
if diff := cmp.Diff(tc.expected, tc.config); diff != "" {
|
|
t.Errorf("Got unexpected defaults (-want, +got):\n%s", diff)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestPluginArgsDefaults(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
features map[featuregate.Feature]bool
|
|
in runtime.Object
|
|
want runtime.Object
|
|
}{
|
|
{
|
|
name: "DefaultPreemptionArgs empty",
|
|
in: &v1beta3.DefaultPreemptionArgs{},
|
|
want: &v1beta3.DefaultPreemptionArgs{
|
|
MinCandidateNodesPercentage: pointer.Int32Ptr(10),
|
|
MinCandidateNodesAbsolute: pointer.Int32Ptr(100),
|
|
},
|
|
},
|
|
{
|
|
name: "DefaultPreemptionArgs with value",
|
|
in: &v1beta3.DefaultPreemptionArgs{
|
|
MinCandidateNodesPercentage: pointer.Int32Ptr(50),
|
|
},
|
|
want: &v1beta3.DefaultPreemptionArgs{
|
|
MinCandidateNodesPercentage: pointer.Int32Ptr(50),
|
|
MinCandidateNodesAbsolute: pointer.Int32Ptr(100),
|
|
},
|
|
},
|
|
{
|
|
name: "InterPodAffinityArgs empty",
|
|
in: &v1beta3.InterPodAffinityArgs{},
|
|
want: &v1beta3.InterPodAffinityArgs{
|
|
HardPodAffinityWeight: pointer.Int32Ptr(1),
|
|
},
|
|
},
|
|
{
|
|
name: "InterPodAffinityArgs explicit 0",
|
|
in: &v1beta3.InterPodAffinityArgs{
|
|
HardPodAffinityWeight: pointer.Int32Ptr(0),
|
|
},
|
|
want: &v1beta3.InterPodAffinityArgs{
|
|
HardPodAffinityWeight: pointer.Int32Ptr(0),
|
|
},
|
|
},
|
|
{
|
|
name: "InterPodAffinityArgs with value",
|
|
in: &v1beta3.InterPodAffinityArgs{
|
|
HardPodAffinityWeight: pointer.Int32Ptr(5),
|
|
},
|
|
want: &v1beta3.InterPodAffinityArgs{
|
|
HardPodAffinityWeight: pointer.Int32Ptr(5),
|
|
},
|
|
},
|
|
{
|
|
name: "NodeResourcesBalancedAllocationArgs resources empty",
|
|
in: &v1beta3.NodeResourcesBalancedAllocationArgs{},
|
|
want: &v1beta3.NodeResourcesBalancedAllocationArgs{
|
|
Resources: []v1beta3.ResourceSpec{
|
|
{Name: "cpu", Weight: 1}, {Name: "memory", Weight: 1},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "NodeResourcesBalancedAllocationArgs with scalar resource",
|
|
in: &v1beta3.NodeResourcesBalancedAllocationArgs{
|
|
Resources: []v1beta3.ResourceSpec{
|
|
{Name: "scalar.io/scalar1", Weight: 1},
|
|
},
|
|
},
|
|
want: &v1beta3.NodeResourcesBalancedAllocationArgs{
|
|
Resources: []v1beta3.ResourceSpec{
|
|
{Name: "scalar.io/scalar1", Weight: 1},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "NodeResourcesBalancedAllocationArgs with mixed resources",
|
|
in: &v1beta3.NodeResourcesBalancedAllocationArgs{
|
|
Resources: []v1beta3.ResourceSpec{
|
|
{Name: string(v1.ResourceCPU), Weight: 1},
|
|
{Name: "scalar.io/scalar1", Weight: 1},
|
|
},
|
|
},
|
|
want: &v1beta3.NodeResourcesBalancedAllocationArgs{
|
|
Resources: []v1beta3.ResourceSpec{
|
|
{Name: string(v1.ResourceCPU), Weight: 1},
|
|
{Name: "scalar.io/scalar1", Weight: 1},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "NodeResourcesBalancedAllocationArgs have resource no weight",
|
|
in: &v1beta3.NodeResourcesBalancedAllocationArgs{
|
|
Resources: []v1beta3.ResourceSpec{
|
|
{Name: string(v1.ResourceCPU)},
|
|
{Name: "scalar.io/scalar0"},
|
|
{Name: "scalar.io/scalar1", Weight: 1},
|
|
},
|
|
},
|
|
want: &v1beta3.NodeResourcesBalancedAllocationArgs{
|
|
Resources: []v1beta3.ResourceSpec{
|
|
{Name: string(v1.ResourceCPU), Weight: 1},
|
|
{Name: "scalar.io/scalar0", Weight: 1},
|
|
{Name: "scalar.io/scalar1", Weight: 1},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "PodTopologySpreadArgs resources empty",
|
|
in: &v1beta3.PodTopologySpreadArgs{},
|
|
want: &v1beta3.PodTopologySpreadArgs{
|
|
DefaultingType: v1beta3.SystemDefaulting,
|
|
},
|
|
},
|
|
{
|
|
name: "PodTopologySpreadArgs resources with value",
|
|
in: &v1beta3.PodTopologySpreadArgs{
|
|
DefaultConstraints: []v1.TopologySpreadConstraint{
|
|
{
|
|
TopologyKey: "planet",
|
|
WhenUnsatisfiable: v1.DoNotSchedule,
|
|
MaxSkew: 2,
|
|
},
|
|
},
|
|
},
|
|
want: &v1beta3.PodTopologySpreadArgs{
|
|
DefaultConstraints: []v1.TopologySpreadConstraint{
|
|
{
|
|
TopologyKey: "planet",
|
|
WhenUnsatisfiable: v1.DoNotSchedule,
|
|
MaxSkew: 2,
|
|
},
|
|
},
|
|
DefaultingType: v1beta3.SystemDefaulting,
|
|
},
|
|
},
|
|
{
|
|
name: "PodTopologySpreadArgs empty, DefaultPodTopologySpread feature disabled",
|
|
features: map[featuregate.Feature]bool{
|
|
features.DefaultPodTopologySpread: false,
|
|
},
|
|
in: &v1beta3.PodTopologySpreadArgs{},
|
|
want: &v1beta3.PodTopologySpreadArgs{
|
|
DefaultingType: v1beta3.ListDefaulting,
|
|
},
|
|
},
|
|
{
|
|
name: "NodeResourcesFitArgs not set",
|
|
in: &v1beta3.NodeResourcesFitArgs{},
|
|
want: &v1beta3.NodeResourcesFitArgs{
|
|
ScoringStrategy: &v1beta3.ScoringStrategy{
|
|
Type: v1beta3.LeastAllocated,
|
|
Resources: defaultResourceSpec,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "NodeResourcesFitArgs Resources empty",
|
|
in: &v1beta3.NodeResourcesFitArgs{
|
|
ScoringStrategy: &v1beta3.ScoringStrategy{
|
|
Type: v1beta3.MostAllocated,
|
|
},
|
|
},
|
|
want: &v1beta3.NodeResourcesFitArgs{
|
|
ScoringStrategy: &v1beta3.ScoringStrategy{
|
|
Type: v1beta3.MostAllocated,
|
|
Resources: defaultResourceSpec,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "VolumeBindingArgs empty, VolumeCapacityPriority disabled",
|
|
features: map[featuregate.Feature]bool{
|
|
features.VolumeCapacityPriority: false,
|
|
},
|
|
in: &v1beta3.VolumeBindingArgs{},
|
|
want: &v1beta3.VolumeBindingArgs{
|
|
BindTimeoutSeconds: pointer.Int64Ptr(600),
|
|
},
|
|
},
|
|
{
|
|
name: "VolumeBindingArgs empty, VolumeCapacityPriority enabled",
|
|
features: map[featuregate.Feature]bool{
|
|
features.VolumeCapacityPriority: true,
|
|
},
|
|
in: &v1beta3.VolumeBindingArgs{},
|
|
want: &v1beta3.VolumeBindingArgs{
|
|
BindTimeoutSeconds: pointer.Int64Ptr(600),
|
|
Shape: []v1beta3.UtilizationShapePoint{
|
|
{Utilization: 0, Score: 0},
|
|
{Utilization: 100, Score: 10},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
for _, tc := range tests {
|
|
scheme := runtime.NewScheme()
|
|
utilruntime.Must(AddToScheme(scheme))
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
for k, v := range tc.features {
|
|
defer featuregatetesting.SetFeatureGateDuringTest(t, feature.DefaultFeatureGate, k, v)()
|
|
}
|
|
scheme.Default(tc.in)
|
|
if diff := cmp.Diff(tc.in, tc.want); diff != "" {
|
|
t.Errorf("Got unexpected defaults (-want, +got):\n%s", diff)
|
|
}
|
|
})
|
|
}
|
|
}
|