Kubernetes Submit Queue 5f92042610 Merge pull request #56483 from dixudx/fix_cli_attach_format ...

Automatic merge from submit-queue (batch tested with PRs 57127, 57011, 56754, 56601, 56483). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

fix bad output format for attaching pods

**What this PR does / why we need it**:
If the user wants to attach stdin, wants a TTY, and `o.In` is a terminal, `t.Raw` is set to true, which is causing bad format like #56450.

We should avoid print extra logs in `SafeFunc`. Move it outer.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #56450

**Special notes for your reviewer**:
/assign @thockin @kubernetes/sig-cli-bugs  

**Release note**:

```release-note
None
```

2017-12-17 06:26:01 -08:00

..

auth

All commands must declare Unstructured or Internal

2017-11-19 20:41:02 -05:00

config

ensure PrinterForCommand is consumed through cmdutil.Factory

2017-12-05 13:39:29 -05:00

resource

pass printOpts by pointer

2017-11-20 14:49:23 -05:00

rollout

All commands must declare Unstructured or Internal

2017-11-19 20:41:02 -05:00

set

All commands must declare Unstructured or Internal

2017-11-19 20:41:02 -05:00

templates

update BUILD files

2017-10-15 18:18:13 -07:00

testdata/edit

Remove use of VersionedObject and simplify builder in generic methods

2017-11-19 19:16:49 -05:00

testing

pass printOpts by pointer

2017-11-20 14:49:23 -05:00

util

Merge pull request #54881 from juanvallejo/jvallejo/use-printer-for-cmd-through-factory

2017-12-16 19:19:44 -08:00

alpha.go

Implement kubectl alpha diff to diff resources

2017-10-23 10:49:02 -07:00

annotate_test.go

remove internal version api from kubectl annotate command

2017-11-13 17:29:40 +08:00

annotate.go

Unify Object and UnstructuredObject

2017-11-19 19:16:50 -05:00

apiversions.go

move i18n to kubectl/util

2017-08-16 12:27:36 -07:00

apply_edit_last_applied.go

enforce include-uninitialized in several kubectl commands

2017-08-31 16:30:56 +08:00

apply_set_last_applied.go

Unify Object and UnstructuredObject

2017-11-19 19:16:50 -05:00

apply_test.go

support openapi in apply

2017-11-21 10:22:43 -08:00

apply_view_last_applied.go

Remove use of VersionedObject and simplify builder in generic methods

2017-11-19 19:16:49 -05:00

apply.go

build patch from openapi only for registered types

2017-12-01 13:44:11 -08:00

attach_test.go

pkg/apis/core: mechanical import fixes in dependencies

2017-11-09 12:14:08 +01:00

attach.go

fix bad output format for attaching pods

2017-11-28 18:15:51 +08:00

autoscale.go

Merge pull request #55913 from wackxu/refauto

2017-12-14 00:45:18 -08:00

BUILD

support openapi in apply

2017-11-21 10:22:43 -08:00

certificates.go

All commands must declare Unstructured or Internal

2017-11-19 20:41:02 -05:00

clusterinfo_dump_test.go

Move the common test functions from cmd_test.go to cmd/testing/fake.go

2016-10-19 08:53:26 +10:00

clusterinfo_dump.go

pkg/apis/core: mechanical import fixes in dependencies

2017-11-09 12:14:08 +01:00

clusterinfo.go

All commands must declare Unstructured or Internal

2017-11-19 20:41:02 -05:00

cmd_test.go

consolidate printer OutputOpts w PrintOpts

2017-11-20 14:49:23 -05:00

cmd.go

Merge pull request #54881 from juanvallejo/jvallejo/use-printer-for-cmd-through-factory

2017-12-16 19:19:44 -08:00

completion.go

Update help/example for kubectl completion

2017-08-18 14:29:42 -07:00

convert_test.go

Unify Object and UnstructuredObject

2017-11-19 19:16:50 -05:00

convert.go

pass printOpts by pointer

2017-11-20 14:49:23 -05:00

cp_test.go

The cp command must call Close() on files, and does not pass on Mac

2017-11-03 22:21:29 -04:00

cp.go

The cp command must call Close() on files, and does not pass on Mac

2017-11-03 22:21:29 -04:00

create_clusterrole_test.go

All commands must declare Unstructured or Internal

2017-11-19 20:41:02 -05:00

create_clusterrole.go

move cmd/util/printing.go#PrintSuccess to factory_builder.go

2017-11-15 10:46:39 -05:00

create_clusterrolebinding_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

create_clusterrolebinding.go

Merge pull request #48267 from superbrothers/clusterrole-flag-completion

2017-10-03 22:04:00 -07:00

create_configmap_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

create_configmap.go

Add --append-hash flag to kubectl create configmap/secret

2017-08-28 14:17:47 -07:00

create_deployment_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

create_deployment.go

Avoid fetching entire discovery tree when possible

2017-10-12 00:27:42 -04:00

create_namespace_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

create_namespace.go

move i18n to kubectl/util

2017-08-16 12:27:36 -07:00

create_pdb_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

create_pdb.go

move i18n to kubectl/util

2017-08-16 12:27:36 -07:00

create_priorityclass_test.go

add create subcommand for priorityclass

2017-11-07 15:03:01 +08:00

create_priorityclass.go

add create subcommand for priorityclass

2017-11-07 15:03:01 +08:00

create_quota_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

create_quota.go

move i18n to kubectl/util

2017-08-16 12:27:36 -07:00

create_role_test.go

All commands must declare Unstructured or Internal

2017-11-19 20:41:02 -05:00

create_role.go

move cmd/util/printing.go#PrintSuccess to factory_builder.go

2017-11-15 10:46:39 -05:00

create_rolebinding_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

create_rolebinding.go

move i18n to kubectl/util

2017-08-16 12:27:36 -07:00

create_secret_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

create_secret.go

update .dockercfg content to config.json

2017-10-18 14:33:14 -04:00

create_service_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

create_service.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

create_serviceaccount_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

create_serviceaccount.go

move i18n to kubectl/util

2017-08-16 12:27:36 -07:00

create_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

create.go

Remove use of VersionedObject and simplify builder in generic methods

2017-11-19 19:16:49 -05:00

delete_test.go

pkg/apis/core: mechanical import fixes in dependencies

2017-11-09 12:14:08 +01:00

delete.go

Remove use of VersionedObject and simplify builder in generic methods

2017-11-19 19:16:49 -05:00

describe_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

describe.go

All commands must declare Unstructured or Internal

2017-11-19 20:41:02 -05:00

diff_test.go

Implement kubectl alpha diff to diff resources

2017-10-23 10:49:02 -07:00

diff.go

Fix a typo in kubectl/diff cmd long description.

2017-12-01 14:31:12 +08:00

drain_test.go

move cmd/util/printing.go#PrintSuccess to factory_builder.go

2017-11-15 10:46:39 -05:00

drain.go

Merge pull request #56413 from supereagle/policy-client-with-version

2017-12-15 16:43:47 -08:00

edit_test.go

Make edit test use subtests to identify flake

2017-11-16 15:45:59 -05:00

edit.go

enforce include-uninitialized in several kubectl commands

2017-08-31 16:30:56 +08:00

exec_test.go

pkg/apis/core: mechanical import fixes in dependencies

2017-11-09 12:14:08 +01:00

exec.go

Merge pull request #55131 from stewart-yu/addnamespaces

2017-11-15 23:06:22 -08:00

explain.go

Kubectl explain now also prints the Kind and APIVersion of the resource

2017-11-14 11:05:19 +01:00

expose_test.go

pkg/apis/core: mechanical import fixes in dependencies

2017-11-09 12:14:08 +01:00

expose.go

All commands must declare Unstructured or Internal

2017-11-19 20:41:02 -05:00

help.go

move i18n to kubectl/util

2017-08-16 12:27:36 -07:00

label_test.go

remove internal version api from kubectl label command

2017-11-13 17:30:09 +08:00

label.go

Unify Object and UnstructuredObject

2017-11-19 19:16:50 -05:00

logs_test.go

Merge pull request #54902 from YuxiJin-tobeyjin/addunitforlogs

2017-12-16 09:15:26 -08:00

logs.go

All commands must declare Unstructured or Internal

2017-11-19 20:41:02 -05:00

options.go

move i18n to kubectl/util

2017-08-16 12:27:36 -07:00

patch_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

patch.go

Remove unstructured error checking from affected code

2017-11-19 19:16:50 -05:00

plugin_test.go

kubectl plugins have access config, global flags and environment

2017-05-19 19:17:43 -03:00

plugin.go

exit with correct exit code on plugin failure

2017-10-18 19:01:29 -04:00

portforward_test.go

pkg/apis/core: mechanical import fixes in dependencies

2017-11-09 12:14:08 +01:00

portforward.go

pkg/apis/core: mechanical import fixes in dependencies

2017-11-09 12:14:08 +01:00

proxy.go

move i18n to kubectl/util

2017-08-16 12:27:36 -07:00

replace_test.go

pkg/apis/core: mechanical import fixes in dependencies

2017-11-09 12:14:08 +01:00

replace.go

All commands must declare Unstructured or Internal

2017-11-19 20:41:02 -05:00

rollingupdate_test.go

small change to clear

2017-05-11 20:09:31 +08:00

rollingupdate.go

rollingupdate should use explicit casting

2017-11-19 20:41:02 -05:00

run_test.go

pkg/apis/core: mechanical import fixes in dependencies

2017-11-09 12:14:08 +01:00

run.go

All commands must declare Unstructured or Internal

2017-11-19 20:41:02 -05:00

scale.go

All commands must declare Unstructured or Internal

2017-11-19 20:41:02 -05:00

taint_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

taint.go

All commands must declare Unstructured or Internal

2017-11-19 20:41:02 -05:00

top_node_test.go

remove dependency from top command

2017-10-31 16:15:32 +08:00

top_node.go

use core client with explicit version

2017-11-25 08:14:10 +08:00

top_pod_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

top_pod.go

use core client with explicit version

2017-11-25 08:14:10 +08:00

top_test.go

remove dependency from top command

2017-10-31 16:15:32 +08:00

top.go

Merge pull request #50620 from juanvallejo/jvallejo/update-kubectl-top-validation

2017-08-21 08:26:23 -07:00

version.go

move i18n to kubectl/util

2017-08-16 12:27:36 -07:00