07a67c252c
The verification function is fixed to check the value of RunAsNonRoot, not just the existence of it. Also adds unit tests to verify the correct behavior.
102 lines
2.4 KiB
Go
102 lines
2.4 KiB
Go
/*
|
|
Copyright 2016 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package kuberuntime
|
|
|
|
import (
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/types"
|
|
"k8s.io/kubernetes/pkg/api/v1"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"testing"
|
|
)
|
|
|
|
func TestVerifyRunAsNonRoot(t *testing.T) {
|
|
pod := &v1.Pod{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
UID: "12345678",
|
|
Name: "bar",
|
|
Namespace: "new",
|
|
},
|
|
Spec: v1.PodSpec{
|
|
Containers: []v1.Container{
|
|
{
|
|
Name: "foo",
|
|
Image: "busybox",
|
|
ImagePullPolicy: v1.PullIfNotPresent,
|
|
Command: []string{"testCommand"},
|
|
WorkingDir: "testWorkingDir",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
rootUser := types.UnixUserID(0)
|
|
runAsNonRootTrue := true
|
|
runAsNonRootFalse := false
|
|
|
|
for _, test := range []struct {
|
|
desc string
|
|
sc *v1.SecurityContext
|
|
errStr string
|
|
}{
|
|
{
|
|
desc: "Pass if SecurityContext is not set",
|
|
sc: nil,
|
|
errStr: "",
|
|
},
|
|
{
|
|
desc: "Pass if RunAsNonRoot is not set",
|
|
sc: &v1.SecurityContext{
|
|
RunAsUser: &rootUser,
|
|
},
|
|
errStr: "",
|
|
},
|
|
{
|
|
desc: "Pass if RunAsNonRoot is false",
|
|
sc: &v1.SecurityContext{
|
|
RunAsNonRoot: &runAsNonRootFalse,
|
|
RunAsUser: &rootUser,
|
|
},
|
|
errStr: "",
|
|
},
|
|
{
|
|
desc: "Fail if container's RunAsUser is root and RunAsNonRoot is true",
|
|
sc: &v1.SecurityContext{
|
|
RunAsNonRoot: &runAsNonRootTrue,
|
|
RunAsUser: &rootUser,
|
|
},
|
|
errStr: "container's runAsUser breaks non-root policy",
|
|
},
|
|
{
|
|
desc: "Fail if image's user is root and RunAsNonRoot is true",
|
|
sc: &v1.SecurityContext{
|
|
RunAsNonRoot: &runAsNonRootTrue,
|
|
},
|
|
errStr: "container has runAsNonRoot and image will run as root",
|
|
},
|
|
} {
|
|
pod.Spec.Containers[0].SecurityContext = test.sc
|
|
err := verifyRunAsNonRoot(pod, &pod.Spec.Containers[0], int64(0))
|
|
if len(test.errStr) == 0 {
|
|
assert.NoError(t, err, test.desc)
|
|
} else {
|
|
assert.EqualError(t, err, test.errStr, test.desc)
|
|
}
|
|
}
|
|
}
|