c85ede510b
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Allow env to be updated via specific key in resource **What this PR does / why we need it**: This change allows users of the `oc` client to specify a list of comma-separated keys when running `oc set env` which should be imported from a resource i.e configmap or secret This can be useful when a number of applications want to share a configuration object but don't want to pollute a resource with unused environment **Release note**: ```release-note Allow kubectl env to specify which keys to import from a config map ```
545 lines
15 KiB
Go
545 lines
15 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package set
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"net/http"
|
|
"os"
|
|
"path"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
appsv1 "k8s.io/api/apps/v1"
|
|
appsv1beta1 "k8s.io/api/apps/v1beta1"
|
|
appsv1beta2 "k8s.io/api/apps/v1beta2"
|
|
batchv1 "k8s.io/api/batch/v1"
|
|
"k8s.io/api/core/v1"
|
|
extensionsv1beta1 "k8s.io/api/extensions/v1beta1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
"k8s.io/apimachinery/pkg/runtime/schema"
|
|
restclient "k8s.io/client-go/rest"
|
|
"k8s.io/client-go/rest/fake"
|
|
"k8s.io/kubernetes/pkg/api/legacyscheme"
|
|
"k8s.io/kubernetes/pkg/api/testapi"
|
|
"k8s.io/kubernetes/pkg/kubectl/categories"
|
|
cmdtesting "k8s.io/kubernetes/pkg/kubectl/cmd/testing"
|
|
"k8s.io/kubernetes/pkg/kubectl/resource"
|
|
"k8s.io/kubernetes/pkg/kubectl/scheme"
|
|
)
|
|
|
|
func TestSetEnvLocal(t *testing.T) {
|
|
f, tf := cmdtesting.NewAPIFactory()
|
|
ns := legacyscheme.Codecs
|
|
tf.Client = &fake.RESTClient{
|
|
GroupVersion: schema.GroupVersion{Version: ""},
|
|
NegotiatedSerializer: ns,
|
|
Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) {
|
|
t.Fatalf("unexpected request: %s %#v\n%#v", req.Method, req.URL, req)
|
|
return nil, nil
|
|
}),
|
|
}
|
|
tf.Namespace = "test"
|
|
tf.ClientConfig = &restclient.Config{ContentConfig: restclient.ContentConfig{GroupVersion: &schema.GroupVersion{Version: ""}}}
|
|
|
|
buf := bytes.NewBuffer([]byte{})
|
|
cmd := NewCmdEnv(f, os.Stdin, buf, buf)
|
|
cmd.SetOutput(buf)
|
|
cmd.Flags().Set("output", "name")
|
|
cmd.Flags().Set("local", "true")
|
|
|
|
opts := EnvOptions{FilenameOptions: resource.FilenameOptions{
|
|
Filenames: []string{"../../../../examples/storage/cassandra/cassandra-controller.yaml"}},
|
|
Out: buf,
|
|
Local: true}
|
|
opts.Complete(f, cmd)
|
|
err := opts.Validate([]string{"env=prod"})
|
|
if err == nil {
|
|
err = opts.RunEnv(f)
|
|
}
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if !strings.Contains(buf.String(), "replicationcontroller/cassandra") {
|
|
t.Errorf("did not set env: %s", buf.String())
|
|
}
|
|
}
|
|
|
|
func TestSetMultiResourcesEnvLocal(t *testing.T) {
|
|
f, tf := cmdtesting.NewAPIFactory()
|
|
ns := legacyscheme.Codecs
|
|
|
|
tf.Client = &fake.RESTClient{
|
|
GroupVersion: schema.GroupVersion{Version: ""},
|
|
NegotiatedSerializer: ns,
|
|
Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) {
|
|
t.Fatalf("unexpected request: %s %#v\n%#v", req.Method, req.URL, req)
|
|
return nil, nil
|
|
}),
|
|
}
|
|
tf.Namespace = "test"
|
|
tf.ClientConfig = &restclient.Config{ContentConfig: restclient.ContentConfig{GroupVersion: &schema.GroupVersion{Version: ""}}}
|
|
|
|
buf := bytes.NewBuffer([]byte{})
|
|
cmd := NewCmdEnv(f, os.Stdin, buf, buf)
|
|
cmd.SetOutput(buf)
|
|
cmd.Flags().Set("output", "name")
|
|
cmd.Flags().Set("local", "true")
|
|
|
|
opts := EnvOptions{FilenameOptions: resource.FilenameOptions{
|
|
Filenames: []string{"../../../../test/fixtures/pkg/kubectl/cmd/set/multi-resource-yaml.yaml"}},
|
|
Out: buf,
|
|
Local: true}
|
|
opts.Complete(f, cmd)
|
|
err := opts.Validate([]string{"env=prod"})
|
|
if err == nil {
|
|
err = opts.RunEnv(f)
|
|
}
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
|
|
expectedOut := "replicationcontroller/first-rc\nreplicationcontroller/second-rc\n"
|
|
if buf.String() != expectedOut {
|
|
t.Errorf("expected out:\n%s\nbut got:\n%s", expectedOut, buf.String())
|
|
}
|
|
}
|
|
|
|
func TestSetEnvRemote(t *testing.T) {
|
|
out := new(bytes.Buffer)
|
|
inputs := []struct {
|
|
object runtime.Object
|
|
apiPrefix, apiGroup, apiVersion string
|
|
testAPIGroup string
|
|
args []string
|
|
opts *EnvOptions
|
|
}{
|
|
{
|
|
object: &extensionsv1beta1.ReplicaSet{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
Spec: extensionsv1beta1.ReplicaSetSpec{
|
|
Template: v1.PodTemplateSpec{
|
|
Spec: v1.PodSpec{
|
|
Containers: []v1.Container{
|
|
{
|
|
Name: "nginx",
|
|
Image: "nginx",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
testAPIGroup: "extensions",
|
|
apiPrefix: "/apis", apiGroup: "extensions", apiVersion: "v1beta1",
|
|
args: []string{"replicaset", "nginx", "env=prod"},
|
|
opts: &EnvOptions{Out: out, Local: false},
|
|
},
|
|
{
|
|
object: &appsv1beta2.ReplicaSet{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
Spec: appsv1beta2.ReplicaSetSpec{
|
|
Template: v1.PodTemplateSpec{
|
|
Spec: v1.PodSpec{
|
|
Containers: []v1.Container{
|
|
{
|
|
Name: "nginx",
|
|
Image: "nginx",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
testAPIGroup: "extensions",
|
|
apiPrefix: "/apis", apiGroup: "apps", apiVersion: "v1beta2",
|
|
args: []string{"replicaset", "nginx", "env=prod"},
|
|
opts: &EnvOptions{Out: out, Local: false},
|
|
},
|
|
{
|
|
object: &appsv1.ReplicaSet{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
Spec: appsv1.ReplicaSetSpec{
|
|
Template: v1.PodTemplateSpec{
|
|
Spec: v1.PodSpec{
|
|
Containers: []v1.Container{
|
|
{
|
|
Name: "nginx",
|
|
Image: "nginx",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
testAPIGroup: "extensions",
|
|
apiPrefix: "/apis", apiGroup: "apps", apiVersion: "v1",
|
|
args: []string{"replicaset", "nginx", "env=prod"},
|
|
opts: &EnvOptions{Out: out, Local: false},
|
|
},
|
|
{
|
|
object: &extensionsv1beta1.DaemonSet{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
Spec: extensionsv1beta1.DaemonSetSpec{
|
|
Template: v1.PodTemplateSpec{
|
|
Spec: v1.PodSpec{
|
|
Containers: []v1.Container{
|
|
{
|
|
Name: "nginx",
|
|
Image: "nginx",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
testAPIGroup: "extensions",
|
|
apiPrefix: "/apis", apiGroup: "extensions", apiVersion: "v1beta1",
|
|
args: []string{"daemonset", "nginx", "env=prod"},
|
|
opts: &EnvOptions{Out: out, Local: false},
|
|
},
|
|
{
|
|
object: &appsv1beta2.DaemonSet{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
Spec: appsv1beta2.DaemonSetSpec{
|
|
Template: v1.PodTemplateSpec{
|
|
Spec: v1.PodSpec{
|
|
Containers: []v1.Container{
|
|
{
|
|
Name: "nginx",
|
|
Image: "nginx",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
testAPIGroup: "extensions",
|
|
apiPrefix: "/apis", apiGroup: "apps", apiVersion: "v1beta2",
|
|
args: []string{"daemonset", "nginx", "env=prod"},
|
|
opts: &EnvOptions{Out: out, Local: false},
|
|
},
|
|
{
|
|
object: &appsv1.DaemonSet{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
Spec: appsv1.DaemonSetSpec{
|
|
Template: v1.PodTemplateSpec{
|
|
Spec: v1.PodSpec{
|
|
Containers: []v1.Container{
|
|
{
|
|
Name: "nginx",
|
|
Image: "nginx",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
testAPIGroup: "extensions",
|
|
apiPrefix: "/apis", apiGroup: "apps", apiVersion: "v1",
|
|
args: []string{"daemonset", "nginx", "env=prod"},
|
|
opts: &EnvOptions{Out: out, Local: false},
|
|
},
|
|
{
|
|
object: &extensionsv1beta1.Deployment{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
Spec: extensionsv1beta1.DeploymentSpec{
|
|
Template: v1.PodTemplateSpec{
|
|
Spec: v1.PodSpec{
|
|
Containers: []v1.Container{
|
|
{
|
|
Name: "nginx",
|
|
Image: "nginx",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
testAPIGroup: "extensions",
|
|
apiPrefix: "/apis", apiGroup: "extensions", apiVersion: "v1beta1",
|
|
args: []string{"deployment", "nginx", "env=prod"},
|
|
opts: &EnvOptions{Out: out, Local: false},
|
|
},
|
|
{
|
|
object: &appsv1beta1.Deployment{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
Spec: appsv1beta1.DeploymentSpec{
|
|
Template: v1.PodTemplateSpec{
|
|
Spec: v1.PodSpec{
|
|
Containers: []v1.Container{
|
|
{
|
|
Name: "nginx",
|
|
Image: "nginx",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
testAPIGroup: "extensions",
|
|
apiPrefix: "/apis", apiGroup: "apps", apiVersion: "v1beta1",
|
|
args: []string{"deployment", "nginx", "env=prod"},
|
|
opts: &EnvOptions{Out: out, Local: false},
|
|
},
|
|
{
|
|
object: &appsv1beta2.Deployment{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
Spec: appsv1beta2.DeploymentSpec{
|
|
Template: v1.PodTemplateSpec{
|
|
Spec: v1.PodSpec{
|
|
Containers: []v1.Container{
|
|
{
|
|
Name: "nginx",
|
|
Image: "nginx",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
testAPIGroup: "extensions",
|
|
apiPrefix: "/apis", apiGroup: "apps", apiVersion: "v1beta2",
|
|
args: []string{"deployment", "nginx", "env=prod"},
|
|
opts: &EnvOptions{Out: out, Local: false},
|
|
},
|
|
{
|
|
object: &appsv1.Deployment{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
Spec: appsv1.DeploymentSpec{
|
|
Template: v1.PodTemplateSpec{
|
|
Spec: v1.PodSpec{
|
|
Containers: []v1.Container{
|
|
{
|
|
Name: "nginx",
|
|
Image: "nginx",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
testAPIGroup: "extensions",
|
|
apiPrefix: "/apis", apiGroup: "apps", apiVersion: "v1",
|
|
args: []string{"deployment", "nginx", "env=prod"},
|
|
opts: &EnvOptions{Out: out, Local: false},
|
|
},
|
|
{
|
|
object: &appsv1beta1.StatefulSet{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
Spec: appsv1beta1.StatefulSetSpec{
|
|
Template: v1.PodTemplateSpec{
|
|
Spec: v1.PodSpec{
|
|
Containers: []v1.Container{
|
|
{
|
|
Name: "nginx",
|
|
Image: "nginx",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
testAPIGroup: "apps",
|
|
apiPrefix: "/apis", apiGroup: "apps", apiVersion: "v1beta1",
|
|
args: []string{"statefulset", "nginx", "env=prod"},
|
|
opts: &EnvOptions{Out: out, Local: false},
|
|
},
|
|
{
|
|
object: &appsv1beta2.StatefulSet{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
Spec: appsv1beta2.StatefulSetSpec{
|
|
Template: v1.PodTemplateSpec{
|
|
Spec: v1.PodSpec{
|
|
Containers: []v1.Container{
|
|
{
|
|
Name: "nginx",
|
|
Image: "nginx",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
testAPIGroup: "apps",
|
|
apiPrefix: "/apis", apiGroup: "apps", apiVersion: "v1beta2",
|
|
args: []string{"statefulset", "nginx", "env=prod"},
|
|
opts: &EnvOptions{Out: out, Local: false},
|
|
},
|
|
{
|
|
object: &appsv1.StatefulSet{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
Spec: appsv1.StatefulSetSpec{
|
|
Template: v1.PodTemplateSpec{
|
|
Spec: v1.PodSpec{
|
|
Containers: []v1.Container{
|
|
{
|
|
Name: "nginx",
|
|
Image: "nginx",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
testAPIGroup: "apps",
|
|
apiPrefix: "/apis", apiGroup: "apps", apiVersion: "v1",
|
|
args: []string{"statefulset", "nginx", "env=prod"},
|
|
opts: &EnvOptions{Out: out, Local: false},
|
|
},
|
|
{
|
|
object: &batchv1.Job{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
Spec: batchv1.JobSpec{
|
|
Template: v1.PodTemplateSpec{
|
|
Spec: v1.PodSpec{
|
|
Containers: []v1.Container{
|
|
{
|
|
Name: "nginx",
|
|
Image: "nginx",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
testAPIGroup: "batch",
|
|
apiPrefix: "/apis", apiGroup: "batch", apiVersion: "v1",
|
|
args: []string{"job", "nginx", "env=prod"},
|
|
opts: &EnvOptions{Out: out, Local: false},
|
|
},
|
|
{
|
|
object: &v1.ReplicationController{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
Spec: v1.ReplicationControllerSpec{
|
|
Template: &v1.PodTemplateSpec{
|
|
Spec: v1.PodSpec{
|
|
Containers: []v1.Container{
|
|
{
|
|
Name: "nginx",
|
|
Image: "nginx",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
testAPIGroup: "",
|
|
apiPrefix: "/api", apiGroup: "", apiVersion: "v1",
|
|
args: []string{"replicationcontroller", "nginx", "env=prod"},
|
|
opts: &EnvOptions{Out: out, Local: false},
|
|
},
|
|
{
|
|
object: &appsv1.Deployment{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
Spec: appsv1.DeploymentSpec{
|
|
Template: v1.PodTemplateSpec{
|
|
Spec: v1.PodSpec{
|
|
Containers: []v1.Container{
|
|
{
|
|
Name: "nginx",
|
|
Image: "nginx",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
testAPIGroup: "extensions",
|
|
apiPrefix: "/apis", apiGroup: "apps", apiVersion: "v1",
|
|
args: []string{"deployment", "nginx", "env=prod"},
|
|
opts: &EnvOptions{Out: out,
|
|
Local: false,
|
|
From: "configmap/myconfigmap"},
|
|
},
|
|
{
|
|
object: &appsv1.Deployment{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
Spec: appsv1.DeploymentSpec{
|
|
Template: v1.PodTemplateSpec{
|
|
Spec: v1.PodSpec{
|
|
Containers: []v1.Container{
|
|
{
|
|
Name: "nginx",
|
|
Image: "nginx",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
testAPIGroup: "extensions",
|
|
apiPrefix: "/apis", apiGroup: "apps", apiVersion: "v1",
|
|
args: []string{"deployment", "nginx"},
|
|
opts: &EnvOptions{Out: out,
|
|
Local: false,
|
|
Keys: []string{"test-key"},
|
|
From: "configmap/myconfigmap"},
|
|
},
|
|
}
|
|
for _, input := range inputs {
|
|
groupVersion := schema.GroupVersion{Group: input.apiGroup, Version: input.apiVersion}
|
|
testapi.Default = testapi.Groups[input.testAPIGroup]
|
|
f, tf := cmdtesting.NewAPIFactory()
|
|
codec := scheme.Codecs.CodecForVersions(scheme.Codecs.LegacyCodec(groupVersion), scheme.Codecs.UniversalDecoder(groupVersion), groupVersion, groupVersion)
|
|
ns := legacyscheme.Codecs
|
|
tf.Namespace = "test"
|
|
tf.CategoryExpander = categories.LegacyCategoryExpander
|
|
tf.Client = &fake.RESTClient{
|
|
GroupVersion: groupVersion,
|
|
NegotiatedSerializer: ns,
|
|
Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) {
|
|
resourcePath := testapi.Default.ResourcePath(input.args[0]+"s", tf.Namespace, input.args[1])
|
|
switch p, m := req.URL.Path, req.Method; {
|
|
case p == resourcePath && m == http.MethodGet:
|
|
return &http.Response{StatusCode: http.StatusOK, Header: defaultHeader(), Body: objBody(codec, input.object)}, nil
|
|
case p == resourcePath && m == http.MethodPatch:
|
|
stream, err := req.GetBody()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
bytes, err := ioutil.ReadAll(stream)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
assert.Contains(t, string(bytes), `"value":`+`"`+"prod"+`"`, fmt.Sprintf("env not updated for %#v", input.object))
|
|
return &http.Response{StatusCode: http.StatusOK, Header: defaultHeader(), Body: objBody(codec, input.object)}, nil
|
|
default:
|
|
t.Errorf("%s: unexpected request: %s %#v\n%#v", "image", req.Method, req.URL, req)
|
|
return nil, fmt.Errorf("unexpected request")
|
|
}
|
|
}),
|
|
VersionedAPIPath: path.Join(input.apiPrefix, testapi.Default.GroupVersion().String()),
|
|
}
|
|
cmd := NewCmdEnv(f, out, out, out)
|
|
cmd.SetOutput(out)
|
|
cmd.Flags().Set("output", "yaml")
|
|
opts := input.opts
|
|
opts.Complete(f, cmd)
|
|
err := opts.Validate(input.args)
|
|
assert.NoError(t, err)
|
|
err = opts.RunEnv(f)
|
|
assert.NoError(t, err)
|
|
}
|
|
// TODO This global state restoration needs fixing, b/c it's wrong. Tests should not modify global state
|
|
testapi.Default = testapi.Groups[""]
|
|
}
|