kubernetes/cmd
Kubernetes Submit Queue e6dc13408f Merge pull request #43951 from luxas/kubeadm_fix_reset_docker
Automatic merge from submit-queue (batch tested with PRs 43951, 43386)

kubeadm: Fix issue when kubeadm reset isn't working and the docker service is disabled

**What this PR does / why we need it**:

If the docker service is disabled, the preflight check lib will return a warning.
That warning _should not_ matter when deciding whether to reset docker state or not.
The current code skips the docker reset if the docker service is disabled, which is a bug.

Also, `Check()` must not return a `nil` slice.

It should be added that I **really don't like what we have at the moment**, I'd love to discuss with the node team to add something to CRI that basically says, "remove everything on this node" so we can stop doing this. Basically, kubeadm could talk to the specified socket (by default dockershim.sock), and call the CRI interface and say that everything should be cleaned up. This would then be cross-CRI-implementation at the same time and would work if you're using rkt, cri-o or whatever.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*:

helps in https://github.com/kubernetes/kubernetes/issues/43950

**Special notes for your reviewer**:

**Release note**:

```release-note
kubeadm: Make `kubeadm reset` tolerant of a disabled docker service.
```
@mikedanese @jbeda @dmmcquay @pipejakob @yujuhong @freehan
2017-04-07 10:56:34 -07:00
..
clicheck Enable auto-generating sources rules 2017-01-05 14:14:13 -08:00
cloud-controller-manager remove NewCloudNodeController() second return value 2017-03-25 10:54:01 +08:00
gendocs Enable auto-generating sources rules 2017-01-05 14:14:13 -08:00
genkubedocs Enable auto-generating sources rules 2017-01-05 14:14:13 -08:00
genman Enable auto-generating sources rules 2017-01-05 14:14:13 -08:00
genslateyaml Enable auto-generating sources rules 2017-01-05 14:14:13 -08:00
genswaggertypedocs start the apimachinery repo 2017-01-11 09:09:48 -05:00
genutils Enable auto-generating sources rules 2017-01-05 14:14:13 -08:00
genyaml Enable auto-generating sources rules 2017-01-05 14:14:13 -08:00
gke-certificates-controller Better messaging when GKE certificate signing fails. 2017-03-21 21:00:47 -07:00
hyperkube wire in aggregation 2017-03-27 09:44:10 -04:00
kube-apiserver Disable RBAC post-start hook if not using the RBAC authorizer 2017-03-30 23:30:04 -04:00
kube-controller-manager Merge pull request #43226 from deads2k/controller-01-health 2017-03-25 19:10:25 -07:00
kube-proxy Use shared informers for proxy endpoints and service configs 2017-04-04 12:51:41 -04:00
kubeadm Merge pull request #43951 from luxas/kubeadm_fix_reset_docker 2017-04-07 10:56:34 -07:00
kubectl *: update codegen and bazel 2017-02-21 09:26:03 -08:00
kubelet Add a separate flags struct for Kubelet flags 2017-04-03 13:28:29 -07:00
kubemark Use shared informers for proxy endpoints and service configs 2017-04-04 12:51:41 -04:00
libs/go2idl Merge pull request #43247 from mbohlool/extensions_fix 2017-03-29 16:05:21 -07:00
linkcheck Enable auto-generating sources rules 2017-01-05 14:14:13 -08:00
mungedocs Enable auto-generating sources rules 2017-01-05 14:14:13 -08:00
BUILD Merge pull request #42070 from luxas/remove_kube_discovery 2017-03-04 12:58:23 -08:00
OWNERS Updated top level owners file to match new format 2017-01-19 11:29:16 -08:00