github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
15d02afea5
kubernetes/pkg/controller
History
Kubernetes Submit Queue 29af9853fe Merge pull request #35047 from deads2k/controller-11-rs-flakes 
Automatic merge from submit-queue

fix more RS controller flakes

I saw another flake:

```
panic: Fail in goroutine after TestUpdatePods has completed
/usr/local/go/src/runtime/panic.go:500 +0x1ae
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/util/runtime/runtime.go:56 +0x17d
/usr/local/go/src/runtime/panic.go:458 +0x271
/usr/local/go/src/testing/testing.go:412 +0x182
/usr/local/go/src/testing/testing.go:484 +0x95
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/controller/replicaset/replica_set_test.go:619 +0x1d2
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/controller/replicaset/replica_set.go:414 +0x191
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/controller/replicaset/replica_set.go:403 +0x39
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/controller/replicaset/replica_set.go:169 +0x42
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/util/wait/wait.go:87 +0x70
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/util/wait/wait.go:88 +0xbe
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/util/wait/wait.go:49 +0x5b
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/controller/replicaset/replica_set_test.go:625 +0x369
```

This resolves that by separating the listers from the watch like it used to be in this set of tests.  The tests were like this before the refactor.  I think they limit utility, but I'm not prepared to re-write them all.

@kargakis
2016-10-18 19:52:48 -07:00
..
certificates Merge pull request #32876 from errordeveloper/more-cert-utils 2016-09-22 01:29:46 -07:00
daemon Add NumberReady to DaemonSet status 2016-10-12 15:15:10 +02:00
deployment Merge pull request #34548 from kargakis/estimate-available-from-rs 2016-10-17 08:44:51 -07:00
disruption remove testapi.Default.GroupVersion 2016-10-07 10:10:54 -04:00
endpoint remove testapi.Default.GroupVersion 2016-10-07 10:10:54 -04:00
garbagecollector Add +optional tag to all fields with omitempty json tag 2016-10-17 08:52:13 -07:00
informers To add service account informer 2016-10-18 09:24:54 +02:00
job cleanup the remaining 2016-10-13 16:10:24 -07:00
namespace Allow garbage collection to work against different API prefixes 2016-09-22 15:00:58 -04:00
node Merge pull request #34342 from justinsb/fix_typo_initializing 2016-10-15 09:31:53 -07:00
petset change petset replicas type from int to int32 2016-10-08 17:13:20 +08:00
podautoscaler HPA: fixed wrong count for target replicas calculations. 2016-10-18 10:20:27 +02:00
podgc PodGCController waits for informer sync before doing anything. 2016-10-14 15:24:09 +02:00
replicaset fix more RS controller flakes 2016-10-18 12:58:48 -04:00
replication remove testapi.Default.GroupVersion 2016-10-07 10:10:54 -04:00
resourcequota move informer and controller to pkg/client/cache 2016-09-15 12:50:08 -07:00
route Use strongly-typed types.NodeName for a node name 2016-09-27 10:47:31 -04:00
scheduledjob Merge pull request #32670 from soltysh/cron_update 2016-09-23 13:27:16 -07:00
service fix up service lister 2016-09-22 09:12:37 -04:00
serviceaccount move the retry util out of pkg/client/unversioned 2016-10-13 16:10:24 -07:00
volume Pass whole PVC to provisioner plugin 2016-10-12 12:22:01 +02:00
.import-restrictions add import restrictions 2016-10-13 16:10:24 -07:00
client_builder.go use service accounts as clients for controllers 2016-10-05 13:15:16 -04:00
controller_ref_manager.go fix tests; convert IsPodActive to operate on *Pod 2016-08-17 13:05:37 -07:00
controller_utils_test.go remove testapi.Default.GroupVersion 2016-10-07 10:10:54 -04:00
controller_utils.go Fix typos 2016-10-15 00:21:00 +03:00
doc.go Use Go canonical import paths 2016-07-16 13:48:21 -04:00
lookup_cache.go Remove "All rights reserved" from all the headers. 2016-06-29 17:47:36 -07:00
OWNERS Remove myself from a bunch of OWNERS files, as I am too overloaded 2016-05-11 13:34:51 -07:00