38092cb458
Currently, there are some unit tests that are failing on Windows due to various reasons: - volume mounting is a bit different on Windows: Mount will create the parent dirs and mklink at the volume path later (otherwise mklink will raise an error). - os.Chmod is not working as intended on Windows. - path.Dir() will always return "." on Windows, and filepath.Dir() should be used instead (which works correctly). - on Windows, you can't typically run binaries without extensions. If the file C:\\foo.bat exists, we can still run C:\\foo because Windows will append one of the supported file extensions ($env:PATHEXT) to it and run it. - Windows file permissions do not work the same way as the Linux ones. - /tmp directory being used, which might not exist on Windows. Instead, the OS-specific Temp directory should be used. Fixes a few other issues: - rbd.go: Return error in a case in which an error is encountered. This will prevent "rbd: failed to setup" and "rbd: successfully setup" log messages to be logged at the same time.
765 lines
22 KiB
Go
765 lines
22 KiB
Go
/*
|
|
Copyright 2014 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package glusterfs
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"reflect"
|
|
"testing"
|
|
|
|
gapi "github.com/heketi/heketi/pkg/glusterfs/api"
|
|
"k8s.io/mount-utils"
|
|
|
|
v1 "k8s.io/api/core/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
"k8s.io/apimachinery/pkg/types"
|
|
"k8s.io/client-go/kubernetes/fake"
|
|
core "k8s.io/client-go/testing"
|
|
utiltesting "k8s.io/client-go/util/testing"
|
|
"k8s.io/kubernetes/pkg/volume"
|
|
volumetest "k8s.io/kubernetes/pkg/volume/testing"
|
|
)
|
|
|
|
func TestCanSupport(t *testing.T) {
|
|
tmpDir, err := utiltesting.MkTmpdir("glusterfs_test")
|
|
if err != nil {
|
|
t.Fatalf("error creating temp dir: %v", err)
|
|
}
|
|
defer os.RemoveAll(tmpDir)
|
|
|
|
plugMgr := volume.VolumePluginMgr{}
|
|
plugMgr.InitPlugins(ProbeVolumePlugins(), nil /* prober */, volumetest.NewFakeVolumeHost(t, tmpDir, nil, nil))
|
|
plug, err := plugMgr.FindPluginByName("kubernetes.io/glusterfs")
|
|
if err != nil {
|
|
t.Fatal("Can't find the plugin by name")
|
|
}
|
|
if plug.GetPluginName() != "kubernetes.io/glusterfs" {
|
|
t.Errorf("Wrong name: %s", plug.GetPluginName())
|
|
}
|
|
if plug.CanSupport(&volume.Spec{}) {
|
|
t.Errorf("Expected false")
|
|
}
|
|
if plug.CanSupport(&volume.Spec{Volume: &v1.Volume{VolumeSource: v1.VolumeSource{}}}) {
|
|
t.Errorf("Expected false")
|
|
}
|
|
if !plug.CanSupport(&volume.Spec{Volume: &v1.Volume{VolumeSource: v1.VolumeSource{Glusterfs: &v1.GlusterfsVolumeSource{}}}}) {
|
|
t.Errorf("Expected true")
|
|
}
|
|
if plug.CanSupport(&volume.Spec{PersistentVolume: &v1.PersistentVolume{Spec: v1.PersistentVolumeSpec{}}}) {
|
|
t.Errorf("Expected false")
|
|
}
|
|
if plug.CanSupport(&volume.Spec{PersistentVolume: &v1.PersistentVolume{Spec: v1.PersistentVolumeSpec{PersistentVolumeSource: v1.PersistentVolumeSource{}}}}) {
|
|
t.Errorf("Expected false")
|
|
}
|
|
if !plug.CanSupport(&volume.Spec{PersistentVolume: &v1.PersistentVolume{Spec: v1.PersistentVolumeSpec{PersistentVolumeSource: v1.PersistentVolumeSource{Glusterfs: &v1.GlusterfsPersistentVolumeSource{}}}}}) {
|
|
t.Errorf("Expected true")
|
|
}
|
|
}
|
|
|
|
func TestGetAccessModes(t *testing.T) {
|
|
tmpDir, err := utiltesting.MkTmpdir("glusterfs_test")
|
|
if err != nil {
|
|
t.Fatalf("error creating temp dir: %v", err)
|
|
}
|
|
defer os.RemoveAll(tmpDir)
|
|
|
|
plugMgr := volume.VolumePluginMgr{}
|
|
plugMgr.InitPlugins(ProbeVolumePlugins(), nil /* prober */, volumetest.NewFakeVolumeHost(t, tmpDir, nil, nil))
|
|
|
|
plug, err := plugMgr.FindPersistentPluginByName("kubernetes.io/glusterfs")
|
|
if err != nil {
|
|
t.Errorf("Can't find the plugin by name")
|
|
}
|
|
if !volumetest.ContainsAccessMode(plug.GetAccessModes(), v1.ReadWriteOnce) || !volumetest.ContainsAccessMode(plug.GetAccessModes(), v1.ReadOnlyMany) || !volumetest.ContainsAccessMode(plug.GetAccessModes(), v1.ReadWriteMany) {
|
|
t.Errorf("Expected three AccessModeTypes: %s, %s, and %s", v1.ReadWriteOnce, v1.ReadOnlyMany, v1.ReadWriteMany)
|
|
}
|
|
}
|
|
|
|
func doTestPlugin(t *testing.T, spec *volume.Spec) {
|
|
tmpDir, err := utiltesting.MkTmpdir("glusterfs_test")
|
|
if err != nil {
|
|
t.Fatalf("error creating temp dir: %v", err)
|
|
}
|
|
defer os.RemoveAll(tmpDir)
|
|
|
|
plugMgr := volume.VolumePluginMgr{}
|
|
plugMgr.InitPlugins(ProbeVolumePlugins(), nil /* prober */, volumetest.NewFakeVolumeHost(t, tmpDir, nil, nil))
|
|
plug, err := plugMgr.FindPluginByName("kubernetes.io/glusterfs")
|
|
if err != nil {
|
|
t.Errorf("Can't find the plugin by name")
|
|
}
|
|
ep := &v1.Endpoints{ObjectMeta: metav1.ObjectMeta{Name: "foo"}, Subsets: []v1.EndpointSubset{{
|
|
Addresses: []v1.EndpointAddress{{IP: "127.0.0.1"}}}}}
|
|
pod := &v1.Pod{ObjectMeta: metav1.ObjectMeta{UID: types.UID("poduid")}}
|
|
mounter, err := plug.(*glusterfsPlugin).newMounterInternal(spec, ep, pod, mount.NewFakeMounter(nil))
|
|
volumePath := mounter.GetPath()
|
|
if err != nil {
|
|
t.Errorf("Failed to make a new Mounter: %v", err)
|
|
}
|
|
if mounter == nil {
|
|
t.Error("Got a nil Mounter")
|
|
}
|
|
expectedPath := filepath.Join(tmpDir, "pods/poduid/volumes/kubernetes.io~glusterfs/vol1")
|
|
if volumePath != expectedPath {
|
|
t.Errorf("Unexpected path, expected %q, got: %q", expectedPath, volumePath)
|
|
}
|
|
if err := mounter.SetUp(volume.MounterArgs{}); err != nil {
|
|
t.Errorf("Expected success, got: %v", err)
|
|
}
|
|
if _, err := os.Stat(volumePath); err != nil {
|
|
if os.IsNotExist(err) {
|
|
t.Errorf("SetUp() failed, volume path not created: %s", volumePath)
|
|
} else {
|
|
t.Errorf("SetUp() failed: %v", err)
|
|
}
|
|
}
|
|
unmounter, err := plug.(*glusterfsPlugin).newUnmounterInternal("vol1", types.UID("poduid"), mount.NewFakeMounter(nil))
|
|
if err != nil {
|
|
t.Errorf("Failed to make a new Unmounter: %v", err)
|
|
}
|
|
if unmounter == nil {
|
|
t.Error("Got a nil Unmounter")
|
|
}
|
|
if err := unmounter.TearDown(); err != nil {
|
|
t.Errorf("Expected success, got: %v", err)
|
|
}
|
|
if _, err := os.Stat(volumePath); err == nil {
|
|
t.Errorf("TearDown() failed, volume path still exists: %s", volumePath)
|
|
} else if !os.IsNotExist(err) {
|
|
t.Errorf("TearDown() failed: %v", err)
|
|
}
|
|
}
|
|
|
|
func TestPluginVolume(t *testing.T) {
|
|
vol := &v1.Volume{
|
|
Name: "vol1",
|
|
VolumeSource: v1.VolumeSource{Glusterfs: &v1.GlusterfsVolumeSource{EndpointsName: "ep", Path: "vol", ReadOnly: false}},
|
|
}
|
|
doTestPlugin(t, volume.NewSpecFromVolume(vol))
|
|
}
|
|
|
|
func TestPluginPersistentVolume(t *testing.T) {
|
|
vol := &v1.PersistentVolume{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "vol1",
|
|
},
|
|
Spec: v1.PersistentVolumeSpec{
|
|
PersistentVolumeSource: v1.PersistentVolumeSource{
|
|
Glusterfs: &v1.GlusterfsPersistentVolumeSource{EndpointsName: "ep", Path: "vol", ReadOnly: false},
|
|
},
|
|
},
|
|
}
|
|
|
|
doTestPlugin(t, volume.NewSpecFromPersistentVolume(vol, false))
|
|
}
|
|
|
|
func TestPersistentClaimReadOnlyFlag(t *testing.T) {
|
|
tmpDir, err := utiltesting.MkTmpdir("glusterfs_test")
|
|
if err != nil {
|
|
t.Fatalf("error creating temp dir: %v", err)
|
|
}
|
|
defer os.RemoveAll(tmpDir)
|
|
|
|
pv := &v1.PersistentVolume{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "pvA",
|
|
},
|
|
Spec: v1.PersistentVolumeSpec{
|
|
PersistentVolumeSource: v1.PersistentVolumeSource{
|
|
Glusterfs: &v1.GlusterfsPersistentVolumeSource{EndpointsName: "ep", Path: "vol", ReadOnly: false},
|
|
},
|
|
ClaimRef: &v1.ObjectReference{
|
|
Name: "claimA",
|
|
},
|
|
},
|
|
}
|
|
|
|
claim := &v1.PersistentVolumeClaim{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "claimA",
|
|
Namespace: "nsA",
|
|
},
|
|
Spec: v1.PersistentVolumeClaimSpec{
|
|
VolumeName: "pvA",
|
|
},
|
|
Status: v1.PersistentVolumeClaimStatus{
|
|
Phase: v1.ClaimBound,
|
|
},
|
|
}
|
|
|
|
ep := &v1.Endpoints{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Namespace: "nsA",
|
|
Name: "ep",
|
|
},
|
|
Subsets: []v1.EndpointSubset{{
|
|
Addresses: []v1.EndpointAddress{{IP: "127.0.0.1"}},
|
|
Ports: []v1.EndpointPort{{Name: "foo", Port: 80, Protocol: v1.ProtocolTCP}},
|
|
}},
|
|
}
|
|
|
|
client := fake.NewSimpleClientset(pv, claim, ep)
|
|
|
|
plugMgr := volume.VolumePluginMgr{}
|
|
plugMgr.InitPlugins(ProbeVolumePlugins(), nil /* prober */, volumetest.NewFakeVolumeHost(t, tmpDir, client, nil))
|
|
plug, _ := plugMgr.FindPluginByName(glusterfsPluginName)
|
|
|
|
// readOnly bool is supplied by persistent-claim volume source when its mounter creates other volumes
|
|
spec := volume.NewSpecFromPersistentVolume(pv, true)
|
|
pod := &v1.Pod{ObjectMeta: metav1.ObjectMeta{Namespace: "nsA", UID: types.UID("poduid")}}
|
|
mounter, _ := plug.NewMounter(spec, pod, volume.VolumeOptions{})
|
|
|
|
if !mounter.GetAttributes().ReadOnly {
|
|
t.Errorf("Expected true for mounter.IsReadOnly")
|
|
}
|
|
}
|
|
|
|
func TestParseClassParameters(t *testing.T) {
|
|
secret := v1.Secret{
|
|
Type: "kubernetes.io/glusterfs",
|
|
Data: map[string][]byte{
|
|
"data": []byte("mypassword"),
|
|
},
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
parameters map[string]string
|
|
secret *v1.Secret
|
|
expectError bool
|
|
expectConfig *provisionerConfig
|
|
}{
|
|
{
|
|
"password",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restuser": "admin",
|
|
"restuserkey": "password",
|
|
},
|
|
nil, // secret
|
|
false, // expect error
|
|
&provisionerConfig{
|
|
url: "https://localhost:8080",
|
|
user: "admin",
|
|
userKey: "password",
|
|
secretValue: "password",
|
|
gidMin: 2000,
|
|
gidMax: 2147483647,
|
|
volumeType: gapi.VolumeDurabilityInfo{Type: "replicate", Replicate: gapi.ReplicaDurability{Replica: 3}, Disperse: gapi.DisperseDurability{Data: 0, Redundancy: 0}},
|
|
thinPoolSnapFactor: float32(1.0),
|
|
customEpNamePrefix: "glusterfs-dynamic",
|
|
},
|
|
},
|
|
{
|
|
"secret",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restuser": "admin",
|
|
"secretname": "mysecret",
|
|
"secretnamespace": "default",
|
|
},
|
|
&secret,
|
|
false, // expect error
|
|
&provisionerConfig{
|
|
url: "https://localhost:8080",
|
|
user: "admin",
|
|
secretName: "mysecret",
|
|
secretNamespace: "default",
|
|
secretValue: "mypassword",
|
|
gidMin: 2000,
|
|
gidMax: 2147483647,
|
|
volumeType: gapi.VolumeDurabilityInfo{Type: "replicate", Replicate: gapi.ReplicaDurability{Replica: 3}, Disperse: gapi.DisperseDurability{Data: 0, Redundancy: 0}},
|
|
thinPoolSnapFactor: float32(1.0),
|
|
customEpNamePrefix: "glusterfs-dynamic",
|
|
},
|
|
},
|
|
{
|
|
"no authentication",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
},
|
|
&secret,
|
|
false, // expect error
|
|
&provisionerConfig{
|
|
url: "https://localhost:8080",
|
|
gidMin: 2000,
|
|
gidMax: 2147483647,
|
|
volumeType: gapi.VolumeDurabilityInfo{Type: "replicate", Replicate: gapi.ReplicaDurability{Replica: 3}, Disperse: gapi.DisperseDurability{Data: 0, Redundancy: 0}},
|
|
thinPoolSnapFactor: float32(1.0),
|
|
customEpNamePrefix: "glusterfs-dynamic",
|
|
},
|
|
},
|
|
{
|
|
"missing secret",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"secretname": "mysecret",
|
|
"secretnamespace": "default",
|
|
},
|
|
nil, // secret
|
|
true, // expect error
|
|
nil,
|
|
},
|
|
{
|
|
"secret with no namespace",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"secretname": "mysecret",
|
|
},
|
|
&secret,
|
|
true, // expect error
|
|
nil,
|
|
},
|
|
{
|
|
"missing url",
|
|
map[string]string{
|
|
"restuser": "admin",
|
|
"restuserkey": "password",
|
|
},
|
|
nil, // secret
|
|
true, // expect error
|
|
nil,
|
|
},
|
|
{
|
|
"unknown parameter",
|
|
map[string]string{
|
|
"unknown": "yes",
|
|
"resturl": "https://localhost:8080",
|
|
"restuser": "admin",
|
|
"restuserkey": "password",
|
|
},
|
|
nil, // secret
|
|
true, // expect error
|
|
nil,
|
|
},
|
|
{
|
|
"invalid gidMin #1",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"gidMin": "0",
|
|
},
|
|
&secret,
|
|
true, // expect error
|
|
nil,
|
|
},
|
|
{
|
|
"invalid gidMin #2",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"gidMin": "1999",
|
|
},
|
|
&secret,
|
|
true, // expect error
|
|
nil,
|
|
},
|
|
{
|
|
"invalid gidMin #3",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"gidMin": "1999",
|
|
},
|
|
&secret,
|
|
true, // expect error
|
|
nil,
|
|
},
|
|
{
|
|
"invalid gidMax #1",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"gidMax": "0",
|
|
},
|
|
&secret,
|
|
true, // expect error
|
|
nil,
|
|
},
|
|
{
|
|
"invalid gidMax #2",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"gidMax": "1999",
|
|
},
|
|
&secret,
|
|
true, // expect error
|
|
nil,
|
|
},
|
|
{
|
|
"invalid gidMax #3",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"gidMax": "1999",
|
|
},
|
|
&secret,
|
|
true, // expect error
|
|
nil,
|
|
},
|
|
{
|
|
"invalid gidMin:gidMax",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"gidMin": "5001",
|
|
"gidMax": "5000",
|
|
},
|
|
&secret,
|
|
true, // expect error
|
|
nil,
|
|
},
|
|
{
|
|
"valid gidMin",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"gidMin": "4000",
|
|
},
|
|
&secret,
|
|
false, // expect error
|
|
&provisionerConfig{
|
|
url: "https://localhost:8080",
|
|
gidMin: 4000,
|
|
gidMax: 2147483647,
|
|
volumeType: gapi.VolumeDurabilityInfo{Type: "replicate", Replicate: gapi.ReplicaDurability{Replica: 3}, Disperse: gapi.DisperseDurability{Data: 0, Redundancy: 0}},
|
|
thinPoolSnapFactor: float32(1.0),
|
|
customEpNamePrefix: "glusterfs-dynamic",
|
|
},
|
|
},
|
|
{
|
|
"valid gidMax",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"gidMax": "5000",
|
|
},
|
|
&secret,
|
|
false, // expect error
|
|
&provisionerConfig{
|
|
url: "https://localhost:8080",
|
|
gidMin: 2000,
|
|
gidMax: 5000,
|
|
volumeType: gapi.VolumeDurabilityInfo{Type: "replicate", Replicate: gapi.ReplicaDurability{Replica: 3}, Disperse: gapi.DisperseDurability{Data: 0, Redundancy: 0}},
|
|
thinPoolSnapFactor: float32(1.0),
|
|
customEpNamePrefix: "glusterfs-dynamic",
|
|
},
|
|
},
|
|
{
|
|
"valid gidMin:gidMax",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"gidMin": "4000",
|
|
"gidMax": "5000",
|
|
},
|
|
&secret,
|
|
false, // expect error
|
|
&provisionerConfig{
|
|
url: "https://localhost:8080",
|
|
gidMin: 4000,
|
|
gidMax: 5000,
|
|
volumeType: gapi.VolumeDurabilityInfo{Type: "replicate", Replicate: gapi.ReplicaDurability{Replica: 3}, Disperse: gapi.DisperseDurability{Data: 0, Redundancy: 0}},
|
|
thinPoolSnapFactor: float32(1.0),
|
|
customEpNamePrefix: "glusterfs-dynamic",
|
|
},
|
|
},
|
|
|
|
{
|
|
"valid volumetype: replicate",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"gidMin": "4000",
|
|
"gidMax": "5000",
|
|
"volumetype": "replicate:4",
|
|
},
|
|
&secret,
|
|
false, // expect error
|
|
&provisionerConfig{
|
|
url: "https://localhost:8080",
|
|
gidMin: 4000,
|
|
gidMax: 5000,
|
|
volumeType: gapi.VolumeDurabilityInfo{Type: "replicate", Replicate: gapi.ReplicaDurability{Replica: 4}, Disperse: gapi.DisperseDurability{Data: 0, Redundancy: 0}},
|
|
thinPoolSnapFactor: float32(1.0),
|
|
customEpNamePrefix: "glusterfs-dynamic",
|
|
},
|
|
},
|
|
|
|
{
|
|
"valid volumetype: disperse",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"gidMin": "4000",
|
|
"gidMax": "5000",
|
|
"volumetype": "disperse:4:2",
|
|
},
|
|
&secret,
|
|
false, // expect error
|
|
&provisionerConfig{
|
|
url: "https://localhost:8080",
|
|
gidMin: 4000,
|
|
gidMax: 5000,
|
|
volumeType: gapi.VolumeDurabilityInfo{Type: "disperse", Replicate: gapi.ReplicaDurability{Replica: 0}, Disperse: gapi.DisperseDurability{Data: 4, Redundancy: 2}},
|
|
thinPoolSnapFactor: float32(1.0),
|
|
customEpNamePrefix: "glusterfs-dynamic",
|
|
},
|
|
},
|
|
{
|
|
"valid snapfactor: 50",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"gidMin": "4000",
|
|
"gidMax": "5000",
|
|
"volumetype": "disperse:4:2",
|
|
"snapfactor": "50",
|
|
},
|
|
&secret,
|
|
false, // expect error
|
|
&provisionerConfig{
|
|
url: "https://localhost:8080",
|
|
gidMin: 4000,
|
|
gidMax: 5000,
|
|
volumeType: gapi.VolumeDurabilityInfo{Type: "disperse", Replicate: gapi.ReplicaDurability{Replica: 0}, Disperse: gapi.DisperseDurability{Data: 4, Redundancy: 2}},
|
|
thinPoolSnapFactor: float32(50),
|
|
customEpNamePrefix: "glusterfs-dynamic",
|
|
},
|
|
},
|
|
|
|
{
|
|
"valid volumenameprefix: dept-dev",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"gidMin": "4000",
|
|
"gidMax": "5000",
|
|
"volumetype": "disperse:4:2",
|
|
"snapfactor": "50",
|
|
"volumenameprefix": "dept-dev",
|
|
},
|
|
&secret,
|
|
false, // expect error
|
|
&provisionerConfig{
|
|
url: "https://localhost:8080",
|
|
gidMin: 4000,
|
|
gidMax: 5000,
|
|
volumeType: gapi.VolumeDurabilityInfo{Type: "disperse", Replicate: gapi.ReplicaDurability{Replica: 0}, Disperse: gapi.DisperseDurability{Data: 4, Redundancy: 2}},
|
|
thinPoolSnapFactor: float32(50),
|
|
volumeNamePrefix: "dept-dev",
|
|
customEpNamePrefix: "glusterfs-dynamic",
|
|
},
|
|
},
|
|
{
|
|
"invalid volumetype (disperse) parameter",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"volumetype": "disperse:4:asd",
|
|
},
|
|
&secret,
|
|
true, // expect error
|
|
nil,
|
|
},
|
|
{
|
|
"invalid volumetype (replicate) parameter",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"volumetype": "replicate:asd",
|
|
},
|
|
&secret,
|
|
true, // expect error
|
|
nil,
|
|
},
|
|
{
|
|
"invalid volumetype: unknown volumetype",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"volumetype": "dispersereplicate:4:2",
|
|
},
|
|
&secret,
|
|
true, // expect error
|
|
nil,
|
|
},
|
|
{
|
|
"invalid volumetype : negative value",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"volumetype": "replicate:-1000",
|
|
},
|
|
&secret,
|
|
true, // expect error
|
|
nil,
|
|
},
|
|
{
|
|
"invalid thinPoolSnapFactor: value out of range",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"snapfactor": "0.5",
|
|
},
|
|
&secret,
|
|
true, // expect error
|
|
nil,
|
|
},
|
|
{
|
|
"invalid volumenameprefix: string starting with '_'",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"volumenameprefix": "_",
|
|
},
|
|
&secret,
|
|
true, // expect error
|
|
nil,
|
|
},
|
|
{
|
|
"invalid volumenameprefix: string with '_'",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"volumenameprefix": "qe_dept",
|
|
},
|
|
&secret,
|
|
true, // expect error
|
|
nil,
|
|
},
|
|
{
|
|
"invalid thinPoolSnapFactor: value out of range",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"snapfactor": "120",
|
|
},
|
|
&secret,
|
|
true, // expect error
|
|
nil,
|
|
},
|
|
|
|
{
|
|
"enable custom ep/svc name: customEpNamePrefix: myprefix",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"gidMin": "4000",
|
|
"gidMax": "5000",
|
|
"volumetype": "replicate:4",
|
|
"customEpNamePrefix": "myprefix",
|
|
},
|
|
&secret,
|
|
false, // expect error
|
|
&provisionerConfig{
|
|
url: "https://localhost:8080",
|
|
gidMin: 4000,
|
|
gidMax: 5000,
|
|
volumeType: gapi.VolumeDurabilityInfo{Type: "replicate", Replicate: gapi.ReplicaDurability{Replica: 4}, Disperse: gapi.DisperseDurability{Data: 0, Redundancy: 0}},
|
|
thinPoolSnapFactor: float32(1.0),
|
|
customEpNamePrefix: "myprefix",
|
|
},
|
|
},
|
|
{
|
|
"empty custom ep/svc name: customEpNamePrefix:''",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"gidMin": "4000",
|
|
"gidMax": "5000",
|
|
"volumetype": "replicate:4",
|
|
"customEpNamePrefix": "",
|
|
},
|
|
&secret,
|
|
false, // expect error
|
|
&provisionerConfig{
|
|
url: "https://localhost:8080",
|
|
gidMin: 4000,
|
|
gidMax: 5000,
|
|
volumeType: gapi.VolumeDurabilityInfo{Type: "replicate", Replicate: gapi.ReplicaDurability{Replica: 4}, Disperse: gapi.DisperseDurability{Data: 0, Redundancy: 0}},
|
|
thinPoolSnapFactor: float32(1.0),
|
|
customEpNamePrefix: "",
|
|
},
|
|
},
|
|
{
|
|
"custom ep/svc name with 26 chars: customEpNamePrefix:'charstringhastwentysixchar'",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"gidMin": "4000",
|
|
"gidMax": "5000",
|
|
"volumetype": "replicate:4",
|
|
"customEpNamePrefix": "charstringhastwentysixchar",
|
|
},
|
|
&secret,
|
|
false, // expect error
|
|
&provisionerConfig{
|
|
url: "https://localhost:8080",
|
|
gidMin: 4000,
|
|
gidMax: 5000,
|
|
volumeType: gapi.VolumeDurabilityInfo{Type: "replicate", Replicate: gapi.ReplicaDurability{Replica: 4}, Disperse: gapi.DisperseDurability{Data: 0, Redundancy: 0}},
|
|
thinPoolSnapFactor: float32(1.0),
|
|
customEpNamePrefix: "charstringhastwentysixchar",
|
|
},
|
|
},
|
|
{
|
|
"invalid customepnameprefix ( ie >26 chars) parameter",
|
|
map[string]string{
|
|
"resturl": "https://localhost:8080",
|
|
"restauthenabled": "false",
|
|
"gidMin": "4000",
|
|
"gidMax": "5000",
|
|
"volumetype": "replicate:4",
|
|
"customEpNamePrefix": "myprefixhasmorethan26characters",
|
|
},
|
|
&secret,
|
|
true, // expect error
|
|
nil,
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
|
|
client := &fake.Clientset{}
|
|
client.AddReactor("get", "secrets", func(action core.Action) (handled bool, ret runtime.Object, err error) {
|
|
if test.secret != nil {
|
|
return true, test.secret, nil
|
|
}
|
|
return true, nil, fmt.Errorf("test %s did not set a secret", test.name)
|
|
})
|
|
|
|
cfg, err := parseClassParameters(test.parameters, client)
|
|
|
|
if err != nil && !test.expectError {
|
|
t.Errorf("Test %s got unexpected error %v", test.name, err)
|
|
}
|
|
if err == nil && test.expectError {
|
|
t.Errorf("test %s expected error and got none", test.name)
|
|
}
|
|
if test.expectConfig != nil {
|
|
if !reflect.DeepEqual(cfg, test.expectConfig) {
|
|
t.Errorf("Test %s returned unexpected data, expected: %+v, got: %+v", test.name, test.expectConfig, cfg)
|
|
}
|
|
}
|
|
}
|
|
}
|