github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
243e655161
kubernetes/pkg/kubectl
History
Kubernetes Submit Queue 243e655161 Merge pull request #48986 from timoreimann/relax-env-var-naming-restrictions 
Automatic merge from submit-queue (batch tested with PRs 50208, 50259, 49702, 50267, 48986)

Relax restrictions on environment variable names.

Fixes #2707

The POSIX standard restricts environment variable names to uppercase letters, digits, and the underscore character in shell contexts only. For generic application usage, it is stated that all other characters shall be tolerated. (Reference [here](http://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap08.html), my prose reasoning [here](https://github.com/kubernetes/kubernetes/issues/2707#issuecomment-285309156).)

This change relaxes the rules to some degree. Namely, we stop requiring environment variable names to be strict `C_IDENTIFIERS` and start permitting lowercase, dot, and dash characters.

Public container images using environment variable names beyond the shell-only context can benefit from this relaxation. Elasticsearch is one popular example.
2017-08-08 01:53:08 -07:00
..
cmd Merge pull request #49603 from zhangxiaoyu-zidif/fix-errorf-for-get-test 2017-08-07 13:52:08 -07:00
metricsutil Merge pull request #45389 from monopole/isolation1 2017-05-15 19:34:52 -07:00
plugins Flag support in kubectl plugins 2017-07-18 15:35:40 -03:00
resource add cronjobs to all 2017-07-21 10:56:26 -04:00
testing Update generated code 2017-07-18 09:28:49 +02:00
util switch from package syscall to x/sys/unix 2017-07-21 12:14:42 +02:00
apply.go kubectl: simplify code with help of linter 2017-06-23 09:49:30 -07:00
autoscale.go
bash_comp_utils.go
BUILD Update generated code 2017-08-06 15:32:28 +02:00
cluster_test.go run hack/update-all 2017-06-22 11:31:03 -07:00
cluster.go run hack/update-all 2017-06-22 11:31:03 -07:00
clusterrolebinding.go add validate in create rolebinding 2017-05-08 15:52:44 +08:00
configmap_test.go Relax restrictions on environment variable names. 2017-07-28 22:11:26 +02:00
configmap.go fix comment of isDir 2017-06-02 09:26:13 +08:00
delete_test.go rename this file to delete.go to avoid confusion 2017-07-29 03:29:14 +00:00
delete.go rename this file to delete.go to avoid confusion 2017-07-29 03:29:14 +00:00
deployment_test.go run hack/update-all 2017-06-22 11:31:03 -07:00
deployment.go kubectl/deployment: add BaseDeploymentGenerator to reduce duplication 2017-07-18 13:17:45 -07:00
doc.go kubectl: rewrite docstrings in several files 2017-06-23 09:49:30 -07:00
env_file_test.go kubectl: refactor addFromEnvFile, write tests 2017-06-23 09:49:30 -07:00
env_file.go Relax restrictions on environment variable names. 2017-07-28 22:11:26 +02:00
explain.go Update go-restful dependency 2017-05-05 13:57:01 -07:00
generate_test.go
generate.go kubectl: rewrite docstrings in several files 2017-06-23 09:49:30 -07:00
history.go Fix printer hack to get a versioned client 2017-08-06 15:30:13 +02:00
interfaces.go
kubectl_test.go
kubectl.go kubectl: rewrite docstrings in several files 2017-06-23 09:49:30 -07:00
namespace_test.go Add test case for namespace 2017-06-03 14:35:49 +08:00
namespace.go
OWNERS
pdb.go PDB MaxUnavailable: kubectl changes 2017-05-23 07:18:44 -07:00
proxy_server_test.go allow kubectl proxy to handle specified reject methods and default to allow all 2017-04-29 21:10:52 -05:00
proxy_server.go eliminate kubectl dependency on k8s.io/kubernetes/pkg/util 2017-06-29 14:49:51 -07:00
quota_test.go
quota.go
resource_filter_test.go Add test for kubectl resource filter. 2017-07-12 11:44:28 -07:00
resource_filter.go Correctly filter terminated pods in kubectl 2017-07-11 17:32:56 -07:00
rolebinding_test.go Supplement unit tests to kubectl create rolebinding command. 2017-03-29 16:36:22 +08:00
rolebinding.go add validate in create rolebinding 2017-05-08 15:52:44 +08:00
rollback.go Fix printer hack to get a versioned client 2017-08-06 15:30:13 +02:00
rolling_updater_test.go Fix code implicitly casting clientsets to getters 2017-08-06 15:30:13 +02:00
rolling_updater.go fix swallowed error in kubectl rolling_updater 2017-07-29 16:45:34 -07:00
rollout_status_test.go Update StatefulSet rollout status for parameterized RollingUpdate 2017-06-12 10:07:07 -07:00
rollout_status.go DS: kubectl changes 2017-07-25 11:47:57 -07:00
run_test.go Relax restrictions on environment variable names. 2017-07-28 22:11:26 +02:00
run.go Relax restrictions on environment variable names. 2017-07-28 22:11:26 +02:00
scale_test.go
scale.go Deployments under apps/v1beta1 with new defaults 2017-03-01 15:14:41 +01:00
secret_for_docker_registry_test.go Make 'docker-email' optional on dockercfg secrets 2017-02-27 17:13:08 -05:00
secret_for_docker_registry.go Make 'docker-email' optional on dockercfg secrets 2017-02-27 17:13:08 -05:00
secret_for_tls_test.go
secret_for_tls.go
secret_test.go Relax restrictions on environment variable names. 2017-07-28 22:11:26 +02:00
secret.go modify the meassage in kubectl secret command when the envFile path is not an file path 2017-06-26 16:30:43 +08:00
service_basic_test.go Populate endpoints and allow ports with headless service 2017-06-28 11:15:51 +08:00
service_basic.go Populate endpoints and allow ports with headless service 2017-06-28 11:15:51 +08:00
service_test.go Populate endpoints and allow ports with headless service 2017-06-28 11:15:51 +08:00
service.go
serviceaccount_test.go
serviceaccount.go
sorting_printer_test.go run hack/update-all 2017-06-22 11:31:03 -07:00
sorting_printer.go run hack/update-all 2017-06-22 11:31:03 -07:00
versioned_client.go Fix printer hack to get a versioned client 2017-08-06 15:30:13 +02:00