kubernetes/pkg/kubectl at 26c1a3a8ee3c3336e2aeace44541ea38ae0817df - kubernetes - Gitea: Git with a cup of tea

github/kubernetes

Files

History

Kubernetes Submit Queue 2a04c09027 Merge pull request #58144 from tomerf/kubectl_cp_prefix

Automatic merge from submit-queue (batch tested with PRs 58144, 57149). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fixed crash in kubectl cp when path has multiple leading slashes

**What this PR does / why we need it**: Fixed crash in kubectl cp when path has multiple leading slashes
For example:
```
$ kubectl cp pod://path/to/somewhere localfile
tar: Removing leading `//' from member names
panic: runtime error: slice bounds out of range

goroutine 1 [running]:
k8s.io/kubernetes/pkg/kubectl/cmd.untarAll(0x363e840, 0xc420198120, 0x7fff5fbffc13, 0x1, 0x7fff5fbffbfa, 0x18, 0x0, 0x0)
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/kubectl/cmd/cp.go:329 +0x7b4
k8s.io/kubernetes/pkg/kubectl/cmd.copyFromPod(0x3671940, 0xc420261dd0, 0xc4202f9200, 0x3644480, 0xc42000c020, 0x0, 0x0, 0x7fff5fbffbed, 0xb, 0x7fff5fbffbf9, ...)
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/kubectl/cmd/cp.go:237 +0x375
k8s.io/kubernetes/pkg/kubectl/cmd.runCopy(0x3671940, 0xc420261dd0, 0xc4202f9200, 0x3644480, 0xc42000c018, 0x3644480, 0xc42000c020, 0xc4203490a0, 0x2, 0x2, ...)
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/kubectl/cmd/cp.go:134 +0x35b
k8s.io/kubernetes/pkg/kubectl/cmd.NewCmdCp.func1(0xc4202f9200, 0xc4203490a0, 0x2, 0x2)
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/kubectl/cmd/cp.go:72 +0x89
k8s.io/kubernetes/vendor/github.com/spf13/cobra.(*Command).execute(0xc4202f9200, 0xc420348ee0, 0x2, 0x2, 0xc4202f9200, 0xc420348ee0)
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/vendor/github.com/spf13/cobra/command.go:603 +0x234
k8s.io/kubernetes/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc42038d440, 0x8000104, 0x0, 0xffffffffffffffff)
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/vendor/github.com/spf13/cobra/command.go:689 +0x2fe
k8s.io/kubernetes/vendor/github.com/spf13/cobra.(*Command).Execute(0xc42038d440, 0xc420261dd0, 0x3644440)
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/vendor/github.com/spf13/cobra/command.go:648 +0x2b
k8s.io/kubernetes/cmd/kubectl/app.Run(0x0, 0x0)
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/cmd/kubectl/app/kubectl.go:41 +0xd5
main.main()
	/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/cmd/kubectl/kubectl.go:27 +0x26
```

**Which issue(s) this PR fixes** None

**Special notes for your reviewer**: None

**Release note**:
```release-note
Fixed crash in kubectl cp when path has multiple leading slashes
```

2018-01-22 19:02:27 -08:00

..

Support retainkeys strategy in new apply merge code

2017-11-02 10:00:56 -07:00

Add support for CronJob to kind_visitor

2017-11-10 04:22:57 +00:00

Autogenerate BUILD files

2017-12-23 13:12:11 -08:00

Merge pull request #58144 from tomerf/kubectl_cp_prefix

2018-01-22 19:02:27 -08:00

Autogenerate BUILD files

2017-12-23 13:12:11 -08:00

Update generated files

2017-11-09 12:14:08 +01:00

Autogenerate BUILD files

2017-12-23 13:12:11 -08:00

Autogenerate BUILD files

2017-12-23 13:12:11 -08:00

Autogenerate BUILD files

2017-12-23 13:12:11 -08:00

remove reference to v1alpha1

2017-11-21 13:00:40 -08:00

client-go: remove import of github.com/gregjones/httpcache

2018-01-08 09:54:12 -08:00

Autogenerate BUILD files

2017-12-23 13:12:11 -08:00

.import-restrictions

Move scheduler code out of plugin directory.

2018-01-05 15:05:01 -08:00

apply.go

remove internal version api from apply

2017-12-11 13:49:39 +05:30

autoscale_test.go

refactor kubectl autoscale to use the new generator

2017-11-20 14:12:20 +08:00

autoscale.go

refactor kubectl autoscale to use the new generator

2017-11-20 14:12:20 +08:00

bash_comp_utils.go

Remove "All rights reserved" from all the headers.

2016-06-29 17:47:36 -07:00

BUILD

remove /k8s.io/kubernetes/pkg/kubectl/testing

2018-01-03 09:39:33 +08:00

clusterrolebinding_test.go

add UT for pkg/kubecl clusterrolebinding

2017-08-28 15:13:15 +08:00

clusterrolebinding.go

add UT for pkg/kubecl clusterrolebinding

2017-08-28 15:13:15 +08:00

configmap_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

configmap.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

delete_test.go

pkg/apis/core: mechanical import fixes in dependencies

2017-11-09 12:14:08 +01:00

delete.go

pkg/apis/core: mechanical import fixes in dependencies

2017-11-09 12:14:08 +01:00

deployment_test.go

add ut for pkg/kubectl/deployment.go

2017-08-22 11:10:21 +08:00

deployment.go

kubectl: deploy generators don't need to impl Generator iface

2017-07-31 12:26:17 -07:00

doc.go

kubectl: rewrite docstrings in several files

2017-06-23 09:49:30 -07:00

env_file_test.go

kubectl: refactor addFromEnvFile, write tests

2017-06-23 09:49:30 -07:00

env_file.go

Relax restrictions on environment variable names.

2017-07-28 22:11:26 +02:00

generate_test.go

UTs for pkg/kubectl generate_test.go

2017-08-03 21:34:03 +08:00

generate.go

UTs for pkg/kubectl generate_test.go

2017-08-03 21:34:03 +08:00

history_test.go

Refactor HistoryViewerFor to use Visitor design pattern

2017-11-09 08:11:19 +00:00

history.go

Add support for CronJob to kind_visitor

2017-11-10 04:22:57 +00:00

interfaces.go

find and replace

2017-01-20 08:04:53 -05:00

kubectl.go

kubectl: Move utility functions to util package

2017-09-04 20:14:16 +10:00

namespace_test.go

Remove unused code in UT files in pkg/

2018-01-15 16:02:35 +08:00

namespace.go

Remove kubectl create namespace dependencies on kubernetes/pkg/api

2017-10-25 20:26:11 +08:00

OWNERS

Revert "update kubectl approvers"

2017-01-25 17:32:22 -08:00

pdb_test.go

Print type representation on errors when checking parameter types

2017-11-01 10:36:17 +01:00

pdb.go

Print type representation on errors when checking parameter types

2017-11-01 10:36:17 +01:00

priorityclass_test.go

add create subcommand for priorityclass

2017-11-07 15:03:01 +08:00

priorityclass.go

add create subcommand for priorityclass

2017-11-07 15:03:01 +08:00

quota_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

quota.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

resource_filter_test.go

pkg/apis/core: mechanical import fixes in dependencies

2017-11-09 12:14:08 +01:00

resource_filter.go

Builder should allow moving between unstructured / versioned easily

2017-11-19 19:16:49 -05:00

rolebinding_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

rolebinding.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

rollback_test.go

Replace type switches in Rollback with Visitor pattern

2017-11-19 17:46:57 +00:00

rollback.go

Trying to make error message similar to what is expected in tests

2017-11-22 06:17:44 +00:00

rolling_updater_test.go

Remove unused code in UT files in pkg/

2018-01-15 16:02:35 +08:00

rolling_updater.go

pkg/apis/core: mechanical import fixes in dependencies

2017-11-09 12:14:08 +01:00

rollout_status_test.go

Replace some occurances of kubernetes internal api types in kubectl

2017-11-08 18:27:45 +01:00

rollout_status.go

use extensions client with explicit version

2017-11-22 21:18:14 +08:00

run_test.go

Enable batch/v1beta1.CronJobs by default

2017-09-03 11:17:33 +02:00

run.go

Merge pull request #54554 from zjj2wry/set-dep

2017-11-11 12:44:30 -08:00

scale_test.go

adds generic scaler to kubectl

2017-12-18 22:44:04 +01:00

scale.go

the changes introduced in this commit plumbs in the generic scaler into kubectl.

2018-01-12 09:21:18 +01:00

secret_for_docker_registry_test.go

Fix problem accessing private docker registries

2017-12-20 12:37:40 -05:00

secret_for_docker_registry.go

Fix problem accessing private docker registries

2017-12-20 12:37:40 -05:00

secret_for_tls_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

secret_for_tls.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

secret_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

secret.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

service_basic_test.go

Make sure the ports is valid when parsing portString

2017-11-13 20:46:05 +08:00

service_basic.go

Make sure the ports is valid when parsing portString

2017-11-13 20:46:05 +08:00

service_test.go

remove dependency from service generator

2017-10-31 15:35:36 +08:00

service.go

remove dependency from service generator

2017-10-31 15:35:36 +08:00

serviceaccount_test.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

serviceaccount.go

switch some commands to use its own scheme

2017-10-27 18:31:42 -07:00

sorting_printer_test.go

pkg/api/legacyscheme: fixup imports

2017-10-18 17:23:55 +02:00

sorting_printer.go

Make metav1.(Micro)?Time functions take pointers

2017-08-17 11:24:28 +02:00