2b69daa960
When defining a ClusterIP Service, we can specify externalIP, and the traffic policy of externalIP is subject to externalTrafficPolicy. However, the policy can't be set when type is not NodePort or LoadBalancer, and will default to Cluster when kube-proxy processes the Service. This commit updates the defaulting and validation of Service to allow specifying ExternalTrafficPolicy for ClusterIP Services with ExternalIPs. Signed-off-by: Quan Tian <qtian@vmware.com>
260 lines
7.5 KiB
Go
260 lines
7.5 KiB
Go
/*
|
|
Copyright 2016 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package service
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
api "k8s.io/kubernetes/pkg/apis/core"
|
|
utilnet "k8s.io/utils/net"
|
|
)
|
|
|
|
func TestGetLoadBalancerSourceRanges(t *testing.T) {
|
|
checkError := func(v string) {
|
|
annotations := make(map[string]string)
|
|
annotations[api.AnnotationLoadBalancerSourceRangesKey] = v
|
|
svc := api.Service{}
|
|
svc.Annotations = annotations
|
|
_, err := GetLoadBalancerSourceRanges(&svc)
|
|
if err == nil {
|
|
t.Errorf("Expected error parsing: %q", v)
|
|
}
|
|
svc = api.Service{}
|
|
svc.Spec.LoadBalancerSourceRanges = strings.Split(v, ",")
|
|
_, err = GetLoadBalancerSourceRanges(&svc)
|
|
if err == nil {
|
|
t.Errorf("Expected error parsing: %q", v)
|
|
}
|
|
}
|
|
checkError("10.0.0.1/33")
|
|
checkError("foo.bar")
|
|
checkError("10.0.0.1/32,*")
|
|
checkError("10.0.0.1/32,")
|
|
checkError("10.0.0.1/32, ")
|
|
checkError("10.0.0.1")
|
|
|
|
checkOK := func(v string) utilnet.IPNetSet {
|
|
annotations := make(map[string]string)
|
|
annotations[api.AnnotationLoadBalancerSourceRangesKey] = v
|
|
svc := api.Service{}
|
|
svc.Annotations = annotations
|
|
_, err := GetLoadBalancerSourceRanges(&svc)
|
|
if err != nil {
|
|
t.Errorf("Unexpected error parsing: %q", v)
|
|
}
|
|
svc = api.Service{}
|
|
svc.Spec.LoadBalancerSourceRanges = strings.Split(v, ",")
|
|
cidrs, err := GetLoadBalancerSourceRanges(&svc)
|
|
if err != nil {
|
|
t.Errorf("Unexpected error parsing: %q", v)
|
|
}
|
|
return cidrs
|
|
}
|
|
cidrs := checkOK("192.168.0.1/32")
|
|
if len(cidrs) != 1 {
|
|
t.Errorf("Expected exactly one CIDR: %v", cidrs.StringSlice())
|
|
}
|
|
cidrs = checkOK("192.168.0.1/32,192.168.0.1/32")
|
|
if len(cidrs) != 1 {
|
|
t.Errorf("Expected exactly one CIDR (after de-dup): %v", cidrs.StringSlice())
|
|
}
|
|
cidrs = checkOK("192.168.0.1/32,192.168.0.2/32")
|
|
if len(cidrs) != 2 {
|
|
t.Errorf("Expected two CIDRs: %v", cidrs.StringSlice())
|
|
}
|
|
cidrs = checkOK(" 192.168.0.1/32 , 192.168.0.2/32 ")
|
|
if len(cidrs) != 2 {
|
|
t.Errorf("Expected two CIDRs: %v", cidrs.StringSlice())
|
|
}
|
|
// check LoadBalancerSourceRanges not specified
|
|
svc := api.Service{}
|
|
cidrs, err := GetLoadBalancerSourceRanges(&svc)
|
|
if err != nil {
|
|
t.Errorf("Unexpected error: %v", err)
|
|
}
|
|
if len(cidrs) != 1 {
|
|
t.Errorf("Expected exactly one CIDR: %v", cidrs.StringSlice())
|
|
}
|
|
if !IsAllowAll(cidrs) {
|
|
t.Errorf("Expected default to be allow-all: %v", cidrs.StringSlice())
|
|
}
|
|
// check SourceRanges annotation is empty
|
|
annotations := make(map[string]string)
|
|
annotations[api.AnnotationLoadBalancerSourceRangesKey] = ""
|
|
svc = api.Service{}
|
|
svc.Annotations = annotations
|
|
cidrs, err = GetLoadBalancerSourceRanges(&svc)
|
|
if err != nil {
|
|
t.Errorf("Unexpected error: %v", err)
|
|
}
|
|
if len(cidrs) != 1 {
|
|
t.Errorf("Expected exactly one CIDR: %v", cidrs.StringSlice())
|
|
}
|
|
if !IsAllowAll(cidrs) {
|
|
t.Errorf("Expected default to be allow-all: %v", cidrs.StringSlice())
|
|
}
|
|
}
|
|
|
|
func TestAllowAll(t *testing.T) {
|
|
checkAllowAll := func(allowAll bool, cidrs ...string) {
|
|
ipnets, err := utilnet.ParseIPNets(cidrs...)
|
|
if err != nil {
|
|
t.Errorf("Unexpected error parsing cidrs: %v", cidrs)
|
|
}
|
|
if allowAll != IsAllowAll(ipnets) {
|
|
t.Errorf("IsAllowAll did not return expected value for %v", cidrs)
|
|
}
|
|
}
|
|
checkAllowAll(false, "10.0.0.1/32")
|
|
checkAllowAll(false, "10.0.0.1/32", "10.0.0.2/32")
|
|
checkAllowAll(false, "10.0.0.1/32", "10.0.0.1/32")
|
|
|
|
checkAllowAll(true, "0.0.0.0/0")
|
|
checkAllowAll(true, "192.168.0.0/0")
|
|
checkAllowAll(true, "192.168.0.1/32", "0.0.0.0/0")
|
|
}
|
|
|
|
func TestExternallyAccessible(t *testing.T) {
|
|
checkExternallyAccessible := func(expect bool, service *api.Service) {
|
|
res := ExternallyAccessible(service)
|
|
if res != expect {
|
|
t.Errorf("Expected ExternallyAccessible = %v, got %v", expect, res)
|
|
}
|
|
}
|
|
|
|
checkExternallyAccessible(false, &api.Service{})
|
|
checkExternallyAccessible(false, &api.Service{
|
|
Spec: api.ServiceSpec{
|
|
Type: api.ServiceTypeClusterIP,
|
|
},
|
|
})
|
|
checkExternallyAccessible(true, &api.Service{
|
|
Spec: api.ServiceSpec{
|
|
Type: api.ServiceTypeClusterIP,
|
|
ExternalIPs: []string{"1.2.3.4"},
|
|
},
|
|
})
|
|
checkExternallyAccessible(true, &api.Service{
|
|
Spec: api.ServiceSpec{
|
|
Type: api.ServiceTypeLoadBalancer,
|
|
},
|
|
})
|
|
checkExternallyAccessible(true, &api.Service{
|
|
Spec: api.ServiceSpec{
|
|
Type: api.ServiceTypeNodePort,
|
|
},
|
|
})
|
|
checkExternallyAccessible(false, &api.Service{
|
|
Spec: api.ServiceSpec{
|
|
Type: api.ServiceTypeExternalName,
|
|
},
|
|
})
|
|
checkExternallyAccessible(false, &api.Service{
|
|
Spec: api.ServiceSpec{
|
|
Type: api.ServiceTypeExternalName,
|
|
ExternalIPs: []string{"1.2.3.4"},
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestRequestsOnlyLocalTraffic(t *testing.T) {
|
|
checkRequestsOnlyLocalTraffic := func(requestsOnlyLocalTraffic bool, service *api.Service) {
|
|
res := RequestsOnlyLocalTraffic(service)
|
|
if res != requestsOnlyLocalTraffic {
|
|
t.Errorf("Expected requests OnlyLocal traffic = %v, got %v",
|
|
requestsOnlyLocalTraffic, res)
|
|
}
|
|
}
|
|
|
|
checkRequestsOnlyLocalTraffic(false, &api.Service{})
|
|
checkRequestsOnlyLocalTraffic(false, &api.Service{
|
|
Spec: api.ServiceSpec{
|
|
Type: api.ServiceTypeClusterIP,
|
|
},
|
|
})
|
|
checkRequestsOnlyLocalTraffic(false, &api.Service{
|
|
Spec: api.ServiceSpec{
|
|
Type: api.ServiceTypeNodePort,
|
|
},
|
|
})
|
|
checkRequestsOnlyLocalTraffic(false, &api.Service{
|
|
Spec: api.ServiceSpec{
|
|
Type: api.ServiceTypeNodePort,
|
|
ExternalTrafficPolicy: api.ServiceExternalTrafficPolicyCluster,
|
|
},
|
|
})
|
|
checkRequestsOnlyLocalTraffic(true, &api.Service{
|
|
Spec: api.ServiceSpec{
|
|
Type: api.ServiceTypeNodePort,
|
|
ExternalTrafficPolicy: api.ServiceExternalTrafficPolicyLocal,
|
|
},
|
|
})
|
|
checkRequestsOnlyLocalTraffic(false, &api.Service{
|
|
Spec: api.ServiceSpec{
|
|
Type: api.ServiceTypeLoadBalancer,
|
|
ExternalTrafficPolicy: api.ServiceExternalTrafficPolicyCluster,
|
|
},
|
|
})
|
|
checkRequestsOnlyLocalTraffic(true, &api.Service{
|
|
Spec: api.ServiceSpec{
|
|
Type: api.ServiceTypeLoadBalancer,
|
|
ExternalTrafficPolicy: api.ServiceExternalTrafficPolicyLocal,
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestNeedsHealthCheck(t *testing.T) {
|
|
checkNeedsHealthCheck := func(needsHealthCheck bool, service *api.Service) {
|
|
res := NeedsHealthCheck(service)
|
|
if res != needsHealthCheck {
|
|
t.Errorf("Expected needs health check = %v, got %v",
|
|
needsHealthCheck, res)
|
|
}
|
|
}
|
|
|
|
checkNeedsHealthCheck(false, &api.Service{
|
|
Spec: api.ServiceSpec{
|
|
Type: api.ServiceTypeClusterIP,
|
|
},
|
|
})
|
|
checkNeedsHealthCheck(false, &api.Service{
|
|
Spec: api.ServiceSpec{
|
|
Type: api.ServiceTypeNodePort,
|
|
ExternalTrafficPolicy: api.ServiceExternalTrafficPolicyCluster,
|
|
},
|
|
})
|
|
checkNeedsHealthCheck(false, &api.Service{
|
|
Spec: api.ServiceSpec{
|
|
Type: api.ServiceTypeNodePort,
|
|
ExternalTrafficPolicy: api.ServiceExternalTrafficPolicyLocal,
|
|
},
|
|
})
|
|
checkNeedsHealthCheck(false, &api.Service{
|
|
Spec: api.ServiceSpec{
|
|
Type: api.ServiceTypeLoadBalancer,
|
|
ExternalTrafficPolicy: api.ServiceExternalTrafficPolicyCluster,
|
|
},
|
|
})
|
|
checkNeedsHealthCheck(true, &api.Service{
|
|
Spec: api.ServiceSpec{
|
|
Type: api.ServiceTypeLoadBalancer,
|
|
ExternalTrafficPolicy: api.ServiceExternalTrafficPolicyLocal,
|
|
},
|
|
})
|
|
}
|