
Errors from staticcheck: pkg/volume/azure_dd/azure_common.go:68:2: var winDiskNumFormat is unused (U1000) pkg/volume/csi/csi_block.go:97:2: field volumeInfo is unused (U1000) pkg/volume/csi/csi_block_test.go:56:6: func prepareBlockUnmapperTest is unused (U1000) pkg/volume/csi/csi_client.go:108:2: const initialDuration is unused (U1000) pkg/volume/csi/csi_client.go:109:2: const factor is unused (U1000) pkg/volume/csi/csi_client.go:110:2: const steps is unused (U1000) pkg/volume/csi/csi_client_test.go:83:8: this value of err is never used (SA4006) pkg/volume/csi/csi_mounter.go:76:2: field options is unused (U1000) pkg/volume/csi/csi_mounter_test.go:454:13: this value of err is never used (SA4006) pkg/volume/csi/csi_plugin_test.go:766:16: this value of err is never used (SA4006) pkg/volume/csi/csi_plugin_test.go:861:13: this value of err is never used (SA4006) pkg/volume/csi/csi_plugin_test.go:1186:13: this value of err is never used (SA4006) pkg/volume/csi/csi_plugin_test.go:1249:13: this value of err is never used (SA4006) pkg/volume/csi/csi_test.go:305:5: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (SA2002) pkg/volume/flexvolume/probe_test.go:67:10: this value of err is never used (SA4006) pkg/volume/iscsi/iscsi_test.go:95:2: field attachCalled is unused (U1000) pkg/volume/iscsi/iscsi_test.go:96:2: field detachCalled is unused (U1000) pkg/volume/iscsi/iscsi_test.go:501:24: this value of err is never used (SA4006) pkg/volume/iscsi/iscsi_util_test.go:159:2: this value of exist is never used (SA4006) pkg/volume/local/local.go:351:57: argument devicePath is overwritten before first use (SA4009) pkg/volume/plugins_test.go:119:2: this value of plug is never used (SA4006) pkg/volume/plugins_test.go:125:2: this value of plug is never used (SA4006) pkg/volume/quobyte/quobyte.go:474:23: this result of append is never used, except maybe in other appends (SA4010) pkg/volume/quobyte/quobyte.go:477:23: this result of append is never used, except maybe in other appends (SA4010) pkg/volume/quobyte/quobyte.go:480:23: this result of append is never used, except maybe in other appends (SA4010) pkg/volume/rbd/rbd.go:886:2: field adminSecret is unused (U1000) pkg/volume/rbd/rbd.go:887:2: field adminID is unused (U1000) pkg/volume/rbd/rbd.go:888:2: field imageFormat is unused (U1000) pkg/volume/rbd/rbd.go:889:2: field imageFeatures is unused (U1000) pkg/volume/storageos/storageos.go:302:2: field secretName is unused (U1000) pkg/volume/storageos/storageos_util_test.go:43:2: field apiAddr is unused (U1000) pkg/volume/storageos/storageos_util_test.go:44:2: field apiUser is unused (U1000) pkg/volume/storageos/storageos_util_test.go:45:2: field apiPass is unused (U1000) pkg/volume/storageos/storageos_util_test.go:46:2: field apiVersion is unused (U1000) pkg/volume/util/atomic_writer_test.go:756:49: argument err is overwritten before first use (SA4009) pkg/volume/util/fsquota/common/quota_linux_common.go:37:2: const acct is unused (U1000) pkg/volume/util/fsquota/common/quota_linux_common.go:38:2: const enforcing is unused (U1000) pkg/volume/util/fsquota/project.go:168:31: identical expressions on the left and right side of the '==' operator (SA4000) pkg/volume/util/fsquota/quota_linux.go:306:50: argument poduid is overwritten before first use (SA4009) pkg/volume/util/fsquota/quota_linux_test.go:558:16: this value of err is never used (SA4006) pkg/volume/util/subpath/subpath_linux.go:232:81: argument err is overwritten before first use (SA4009) pkg/volume/util/subpath/subpath_linux_test.go:579:73: argument err is overwritten before first use (SA4009)
168 lines
4.2 KiB
Go
168 lines
4.2 KiB
Go
/*
|
|
Copyright 2015 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package volume
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"k8s.io/api/core/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/types"
|
|
)
|
|
|
|
const testPluginName = "kubernetes.io/testPlugin"
|
|
|
|
func TestSpecSourceConverters(t *testing.T) {
|
|
v := &v1.Volume{
|
|
Name: "foo",
|
|
VolumeSource: v1.VolumeSource{EmptyDir: &v1.EmptyDirVolumeSource{}},
|
|
}
|
|
|
|
converted := NewSpecFromVolume(v)
|
|
if converted.Volume.EmptyDir == nil {
|
|
t.Errorf("Unexpected nil EmptyDir: %#v", converted)
|
|
}
|
|
if v.Name != converted.Name() {
|
|
t.Errorf("Expected %v but got %v", converted.Name(), v.Name)
|
|
}
|
|
|
|
pv := &v1.PersistentVolume{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "bar"},
|
|
Spec: v1.PersistentVolumeSpec{
|
|
PersistentVolumeSource: v1.PersistentVolumeSource{AWSElasticBlockStore: &v1.AWSElasticBlockStoreVolumeSource{}},
|
|
},
|
|
}
|
|
|
|
converted = NewSpecFromPersistentVolume(pv, false)
|
|
if converted.PersistentVolume.Spec.AWSElasticBlockStore == nil {
|
|
t.Errorf("Unexpected nil AWSElasticBlockStore: %#v", converted)
|
|
}
|
|
if pv.Name != converted.Name() {
|
|
t.Errorf("Expected %v but got %v", converted.Name(), pv.Name)
|
|
}
|
|
}
|
|
|
|
type testPlugins struct {
|
|
}
|
|
|
|
func (plugin *testPlugins) Init(host VolumeHost) error {
|
|
return nil
|
|
}
|
|
|
|
func (plugin *testPlugins) GetPluginName() string {
|
|
return testPluginName
|
|
}
|
|
|
|
func (plugin *testPlugins) GetVolumeName(spec *Spec) (string, error) {
|
|
return "", nil
|
|
}
|
|
|
|
func (plugin *testPlugins) CanSupport(spec *Spec) bool {
|
|
return true
|
|
}
|
|
|
|
func (plugin *testPlugins) RequiresRemount() bool {
|
|
return false
|
|
}
|
|
|
|
func (plugin *testPlugins) SupportsMountOption() bool {
|
|
return false
|
|
}
|
|
|
|
func (plugin *testPlugins) SupportsBulkVolumeVerification() bool {
|
|
return false
|
|
}
|
|
|
|
func (plugin *testPlugins) NewMounter(spec *Spec, podRef *v1.Pod, opts VolumeOptions) (Mounter, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (plugin *testPlugins) NewUnmounter(name string, podUID types.UID) (Unmounter, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (plugin *testPlugins) ConstructVolumeSpec(volumeName, mountPath string) (*Spec, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func newTestPlugin() []VolumePlugin {
|
|
return []VolumePlugin{&testPlugins{}}
|
|
}
|
|
|
|
func TestVolumePluginMgrFunc(t *testing.T) {
|
|
vpm := VolumePluginMgr{}
|
|
var prober DynamicPluginProber = nil // TODO (#51147) inject mock
|
|
vpm.InitPlugins(newTestPlugin(), prober, nil)
|
|
|
|
plug, err := vpm.FindPluginByName(testPluginName)
|
|
if err != nil {
|
|
t.Errorf("Can't find the plugin by name")
|
|
}
|
|
if plug.GetPluginName() != testPluginName {
|
|
t.Errorf("Wrong name: %s", plug.GetPluginName())
|
|
}
|
|
|
|
_, err = vpm.FindPluginBySpec(nil)
|
|
if err == nil {
|
|
t.Errorf("Should return error if volume spec is nil")
|
|
}
|
|
|
|
volumeSpec := &Spec{}
|
|
_, err = vpm.FindPluginBySpec(volumeSpec)
|
|
if err != nil {
|
|
t.Errorf("Should return test plugin if volume spec is not nil")
|
|
}
|
|
}
|
|
|
|
func Test_ValidatePodTemplate(t *testing.T) {
|
|
pod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
Name: "vol",
|
|
VolumeSource: v1.VolumeSource{},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
var want error
|
|
if got := ValidateRecyclerPodTemplate(pod); got != want {
|
|
t.Errorf("isPodTemplateValid(%v) returned (%v), want (%v)", pod.String(), got.Error(), want)
|
|
}
|
|
|
|
// Check that the default recycle pod template is valid
|
|
pod = NewPersistentVolumeRecyclerPodTemplate()
|
|
want = nil
|
|
if got := ValidateRecyclerPodTemplate(pod); got != want {
|
|
t.Errorf("isPodTemplateValid(%v) returned (%v), want (%v)", pod.String(), got.Error(), want)
|
|
}
|
|
|
|
pod = &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Containers: []v1.Container{
|
|
{
|
|
Name: "pv-recycler",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
// want = an error
|
|
if got := ValidateRecyclerPodTemplate(pod); got == nil {
|
|
t.Errorf("isPodTemplateValid(%v) returned (%v), want (%v)", pod.String(), got, "Error: pod specification does not contain any volume(s).")
|
|
}
|
|
}
|