4b1179e377
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix golint warnings in daemon controller This fixes the golint errors in the daemon controller package. The only on remaining asks to rename DaemonSetsController, which is a public interface and would need proper deprecation first. **Special notes for your reviewer**: **Release note**: I don't believe a release note is required. It only fixes code comments. ```release-note NONE ```
118 lines
4.6 KiB
Go
118 lines
4.6 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package util
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"k8s.io/api/core/v1"
|
|
extensions "k8s.io/api/extensions/v1beta1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
utilfeature "k8s.io/apiserver/pkg/util/feature"
|
|
podutil "k8s.io/kubernetes/pkg/api/v1/pod"
|
|
v1helper "k8s.io/kubernetes/pkg/apis/core/v1/helper"
|
|
"k8s.io/kubernetes/pkg/features"
|
|
kubelettypes "k8s.io/kubernetes/pkg/kubelet/types"
|
|
"k8s.io/kubernetes/pkg/scheduler/algorithm"
|
|
labelsutil "k8s.io/kubernetes/pkg/util/labels"
|
|
)
|
|
|
|
// CreatePodTemplate returns copy of provided template with additional
|
|
// label which contains templateGeneration (for backward compatibility),
|
|
// hash of provided template and sets default daemon tolerations.
|
|
func CreatePodTemplate(template v1.PodTemplateSpec, generation int64, hash string) v1.PodTemplateSpec {
|
|
newTemplate := *template.DeepCopy()
|
|
// DaemonSet pods shouldn't be deleted by NodeController in case of node problems.
|
|
// Add infinite toleration for taint notReady:NoExecute here
|
|
// to survive taint-based eviction enforced by NodeController
|
|
// when node turns not ready.
|
|
v1helper.AddOrUpdateTolerationInPodSpec(&newTemplate.Spec, &v1.Toleration{
|
|
Key: algorithm.TaintNodeNotReady,
|
|
Operator: v1.TolerationOpExists,
|
|
Effect: v1.TaintEffectNoExecute,
|
|
})
|
|
|
|
// DaemonSet pods shouldn't be deleted by NodeController in case of node problems.
|
|
// Add infinite toleration for taint unreachable:NoExecute here
|
|
// to survive taint-based eviction enforced by NodeController
|
|
// when node turns unreachable.
|
|
v1helper.AddOrUpdateTolerationInPodSpec(&newTemplate.Spec, &v1.Toleration{
|
|
Key: algorithm.TaintNodeUnreachable,
|
|
Operator: v1.TolerationOpExists,
|
|
Effect: v1.TaintEffectNoExecute,
|
|
})
|
|
|
|
// According to TaintNodesByCondition feature, all DaemonSet pods should tolerate
|
|
// MemoryPressure and DisPressure taints, and the critical pods should tolerate
|
|
// OutOfDisk taint.
|
|
v1helper.AddOrUpdateTolerationInPodSpec(&newTemplate.Spec, &v1.Toleration{
|
|
Key: algorithm.TaintNodeDiskPressure,
|
|
Operator: v1.TolerationOpExists,
|
|
Effect: v1.TaintEffectNoSchedule,
|
|
})
|
|
|
|
v1helper.AddOrUpdateTolerationInPodSpec(&newTemplate.Spec, &v1.Toleration{
|
|
Key: algorithm.TaintNodeMemoryPressure,
|
|
Operator: v1.TolerationOpExists,
|
|
Effect: v1.TaintEffectNoSchedule,
|
|
})
|
|
|
|
// TODO(#48843) OutOfDisk taints will be removed in 1.10
|
|
if utilfeature.DefaultFeatureGate.Enabled(features.ExperimentalCriticalPodAnnotation) &&
|
|
kubelettypes.IsCritical(newTemplate.Namespace, newTemplate.Annotations) {
|
|
v1helper.AddOrUpdateTolerationInPodSpec(&newTemplate.Spec, &v1.Toleration{
|
|
Key: algorithm.TaintNodeOutOfDisk,
|
|
Operator: v1.TolerationOpExists,
|
|
Effect: v1.TaintEffectNoExecute,
|
|
})
|
|
}
|
|
|
|
templateGenerationStr := fmt.Sprint(generation)
|
|
newTemplate.ObjectMeta.Labels = labelsutil.CloneAndAddLabel(
|
|
template.ObjectMeta.Labels,
|
|
extensions.DaemonSetTemplateGenerationKey,
|
|
templateGenerationStr,
|
|
)
|
|
// TODO: do we need to validate if the DaemonSet is RollingUpdate or not?
|
|
if len(hash) > 0 {
|
|
newTemplate.ObjectMeta.Labels[extensions.DefaultDaemonSetUniqueLabelKey] = hash
|
|
}
|
|
return newTemplate
|
|
}
|
|
|
|
// IsPodUpdated checks if pod contains label value that either matches templateGeneration or hash
|
|
func IsPodUpdated(dsTemplateGeneration int64, pod *v1.Pod, hash string) bool {
|
|
// Compare with hash to see if the pod is updated, need to maintain backward compatibility of templateGeneration
|
|
templateMatches := pod.Labels[extensions.DaemonSetTemplateGenerationKey] == fmt.Sprint(dsTemplateGeneration)
|
|
hashMatches := len(hash) > 0 && pod.Labels[extensions.DefaultDaemonSetUniqueLabelKey] == hash
|
|
return hashMatches || templateMatches
|
|
}
|
|
|
|
// SplitByAvailablePods splits provided daemon set pods by availability
|
|
func SplitByAvailablePods(minReadySeconds int32, pods []*v1.Pod) ([]*v1.Pod, []*v1.Pod) {
|
|
unavailablePods := []*v1.Pod{}
|
|
availablePods := []*v1.Pod{}
|
|
for _, pod := range pods {
|
|
if podutil.IsPodAvailable(pod, minReadySeconds, metav1.Now()) {
|
|
availablePods = append(availablePods, pod)
|
|
} else {
|
|
unavailablePods = append(unavailablePods, pod)
|
|
}
|
|
}
|
|
return availablePods, unavailablePods
|
|
}
|