26801d6541
Since kube-proxy in LocalModeNodeCIDR needs to obtain the PodCIDR assigned to the node it watches for the Node object. However, kube-proxy startup process requires to have these watches in different places, that opens the possibility of having a race condition if the same node is recreated and a different PodCIDR is assigned. Initializing the second watch with the value obtained in the first one allows us to detect this situation. Change-Id: I6adeedb6914ad2afd3e0694dcab619c2a66135f8 Signed-off-by: Antonio Ojea <aojea@google.com>
132 lines
3.2 KiB
Go
132 lines
3.2 KiB
Go
/*
|
|
Copyright 2022 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package proxy
|
|
|
|
import (
|
|
"testing"
|
|
|
|
v1 "k8s.io/api/core/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
)
|
|
|
|
func TestNodePodCIDRHandlerAdd(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
oldNodePodCIDRs []string
|
|
newNodePodCIDRs []string
|
|
expectPanic bool
|
|
}{
|
|
{
|
|
name: "both empty",
|
|
},
|
|
{
|
|
name: "initialized correctly",
|
|
newNodePodCIDRs: []string{"192.168.1.0/24", "fd00:1:2:3::/64"},
|
|
},
|
|
{
|
|
name: "already initialized and same node",
|
|
oldNodePodCIDRs: []string{"10.0.0.0/24", "fd00:3:2:1::/64"},
|
|
newNodePodCIDRs: []string{"10.0.0.0/24", "fd00:3:2:1::/64"},
|
|
},
|
|
{
|
|
name: "already initialized and different node",
|
|
oldNodePodCIDRs: []string{"192.168.1.0/24", "fd00:1:2:3::/64"},
|
|
newNodePodCIDRs: []string{"10.0.0.0/24", "fd00:3:2:1::/64"},
|
|
expectPanic: true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
n := &NodePodCIDRHandler{
|
|
podCIDRs: tt.oldNodePodCIDRs,
|
|
}
|
|
node := &v1.Node{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-node",
|
|
ResourceVersion: "1",
|
|
},
|
|
Spec: v1.NodeSpec{
|
|
PodCIDRs: tt.newNodePodCIDRs,
|
|
},
|
|
}
|
|
defer func() {
|
|
r := recover()
|
|
if r == nil && tt.expectPanic {
|
|
t.Errorf("The code did not panic")
|
|
} else if r != nil && !tt.expectPanic {
|
|
t.Errorf("The code did panic")
|
|
}
|
|
}()
|
|
n.OnNodeAdd(node)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestNodePodCIDRHandlerUpdate(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
oldNodePodCIDRs []string
|
|
newNodePodCIDRs []string
|
|
expectPanic bool
|
|
}{
|
|
{
|
|
name: "both empty",
|
|
},
|
|
{
|
|
name: "initialize",
|
|
newNodePodCIDRs: []string{"192.168.1.0/24", "fd00:1:2:3::/64"},
|
|
},
|
|
{
|
|
name: "same node",
|
|
oldNodePodCIDRs: []string{"192.168.1.0/24", "fd00:1:2:3::/64"},
|
|
newNodePodCIDRs: []string{"192.168.1.0/24", "fd00:1:2:3::/64"},
|
|
},
|
|
{
|
|
name: "different nodes",
|
|
oldNodePodCIDRs: []string{"192.168.1.0/24", "fd00:1:2:3::/64"},
|
|
newNodePodCIDRs: []string{"10.0.0.0/24", "fd00:3:2:1::/64"},
|
|
expectPanic: true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
n := &NodePodCIDRHandler{
|
|
podCIDRs: tt.oldNodePodCIDRs,
|
|
}
|
|
oldNode := &v1.Node{}
|
|
node := &v1.Node{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test-node",
|
|
ResourceVersion: "1",
|
|
},
|
|
Spec: v1.NodeSpec{
|
|
PodCIDRs: tt.newNodePodCIDRs,
|
|
},
|
|
}
|
|
defer func() {
|
|
r := recover()
|
|
if r == nil && tt.expectPanic {
|
|
t.Errorf("The code did not panic")
|
|
} else if r != nil && !tt.expectPanic {
|
|
t.Errorf("The code did panic")
|
|
}
|
|
}()
|
|
n.OnNodeUpdate(oldNode, node)
|
|
})
|
|
}
|
|
}
|