github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
35ed5338b104f41c91efb2b842e92fded6d0b509
kubernetes/pkg/kubectl/cmd
History
Kubernetes Submit Queue 3cbb62b6bb Merge pull request #56206 from brancz/top-metrics-s 
Automatic merge from submit-queue (batch tested with PRs 56206, 58525). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

kubectl: Use metrics-server for kubectl top commands

**What this PR does / why we need it**:

This PR implements support for the kubectl top commands to use the metrics-server as an aggregated API, instead of requesting the metrics from heapster directly. If the `metrics.k8s.io` API is not served by the apiserver, then this still falls back to the previous behavior.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:

Fixes #55489

**Special notes for your reviewer**:

As utilizing heapster as well as the v1alpha1 version of the metrics API is discouraged, I intentionally implemented the support very separated, so that once it is decided, that support is entirely removed, this will make it easy.

**Release note**:

```release-note
Support metrics API in `kubectl top` commands.
```

/cc @kubernetes/sig-instrumentation-pr-reviews @DirectXMan12 @fgrzadkowski @piosz
2018-01-23 13:17:31 -08:00
..
auth
some code change
2017-12-25 16:23:38 +08:00
config
Merge pull request #53631 from dixudx/enforce_cobra_required_flags
2018-01-18 02:00:27 -08:00
resource
Merge pull request #56960 from islinwb/remove_unused_code_ut_pkg
2018-01-18 02:41:29 -08:00
rollout
Merge pull request #53631 from dixudx/enforce_cobra_required_flags
2018-01-18 02:00:27 -08:00
set
some code change
2017-12-25 16:23:38 +08:00
templates
update BUILD files
2017-10-15 18:18:13 -07:00
testdata/edit
Autogenerate BUILD files
2017-12-23 13:12:11 -08:00
testing
kubectl: Use metrics-server for kubectl top commands
2018-01-22 21:45:06 +01:00
util
kubectl: Use metrics-server for kubectl top commands
2018-01-22 21:45:06 +01:00
alpha.go
Implement kubectl alpha diff to diff resources
2017-10-23 10:49:02 -07:00
annotate_test.go
remove internal version api from kubectl annotate command
2017-11-13 17:29:40 +08:00
annotate.go
some code change
2017-12-25 16:23:38 +08:00
apiversions.go
move i18n to kubectl/util
2017-08-16 12:27:36 -07:00
apply_edit_last_applied.go
some code change
2017-12-25 16:23:38 +08:00
apply_set_last_applied.go
some code change
2017-12-25 16:23:38 +08:00
apply_test.go
support openapi in apply
2017-11-21 10:22:43 -08:00
apply_view_last_applied.go
some code change
2017-12-25 16:23:38 +08:00
apply.go
some code change
2017-12-25 16:23:38 +08:00
attach_test.go
Remove unused code in UT files in pkg/
2018-01-15 16:02:35 +08:00
attach.go
some code change
2017-12-25 16:23:38 +08:00
autoscale.go
some code change
2017-12-25 16:23:38 +08:00
BUILD
kubectl: Use metrics-server for kubectl top commands
2018-01-22 21:45:06 +01:00
certificates.go
some code change
2017-12-25 16:23:38 +08:00
clusterinfo_dump_test.go
…
clusterinfo_dump.go
pkg/apis/core: mechanical import fixes in dependencies
2017-11-09 12:14:08 +01:00
clusterinfo.go
fix typos in kubectl pkg
2018-01-05 21:04:44 -06:00
cmd_test.go
consolidate printer OutputOpts w PrintOpts
2017-11-20 14:49:23 -05:00
cmd.go
low hanging fruit for using cobra commands
2018-01-17 13:43:43 -05:00
completion.go
Merge pull request #53631 from dixudx/enforce_cobra_required_flags
2018-01-18 02:00:27 -08:00
convert_test.go
Unify Object and UnstructuredObject
2017-11-19 19:16:50 -05:00
convert.go
some code change
2017-12-25 16:23:38 +08:00
cp_test.go
The cp command must call Close() on files, and does not pass on Mac
2017-11-03 22:21:29 -04:00
cp.go
Merge pull request #58144 from tomerf/kubectl_cp_prefix
2018-01-22 19:02:27 -08:00
create_clusterrole_test.go
All commands must declare Unstructured or Internal
2017-11-19 20:41:02 -05:00
create_clusterrole.go
some code change
2017-12-25 16:23:38 +08:00
create_clusterrolebinding_test.go
switch some commands to use its own scheme
2017-10-27 18:31:42 -07:00
create_clusterrolebinding.go
some code change
2017-12-25 16:23:38 +08:00
create_configmap_test.go
switch some commands to use its own scheme
2017-10-27 18:31:42 -07:00
create_configmap.go
some code change
2017-12-25 16:23:38 +08:00
create_deployment_test.go
switch some commands to use its own scheme
2017-10-27 18:31:42 -07:00
create_deployment.go
some code change
2017-12-25 16:23:38 +08:00
create_namespace_test.go
switch some commands to use its own scheme
2017-10-27 18:31:42 -07:00
create_namespace.go
some code change
2017-12-25 16:23:38 +08:00
create_pdb_test.go
switch some commands to use its own scheme
2017-10-27 18:31:42 -07:00
create_pdb.go
some code change
2017-12-25 16:23:38 +08:00
create_priorityclass_test.go
add create subcommand for priorityclass
2017-11-07 15:03:01 +08:00
create_priorityclass.go
some code change
2017-12-25 16:23:38 +08:00
create_quota_test.go
switch some commands to use its own scheme
2017-10-27 18:31:42 -07:00
create_quota.go
some code change
2017-12-25 16:23:38 +08:00
create_role_test.go
All commands must declare Unstructured or Internal
2017-11-19 20:41:02 -05:00
create_role.go
some code change
2017-12-25 16:23:38 +08:00
create_rolebinding_test.go
switch some commands to use its own scheme
2017-10-27 18:31:42 -07:00
create_rolebinding.go
some code change
2017-12-25 16:23:38 +08:00
create_secret_test.go
switch some commands to use its own scheme
2017-10-27 18:31:42 -07:00
create_secret.go
some code change
2017-12-25 16:23:38 +08:00
create_service_test.go
switch some commands to use its own scheme
2017-10-27 18:31:42 -07:00
create_service.go
some code change
2017-12-25 16:23:38 +08:00
create_serviceaccount_test.go
switch some commands to use its own scheme
2017-10-27 18:31:42 -07:00
create_serviceaccount.go
some code change
2017-12-25 16:23:38 +08:00
create_test.go
switch some commands to use its own scheme
2017-10-27 18:31:42 -07:00
create.go
Merge pull request #53631 from dixudx/enforce_cobra_required_flags
2018-01-18 02:00:27 -08:00
delete_test.go
some code change
2017-12-25 16:23:38 +08:00
delete.go
some code change
2017-12-25 16:23:38 +08:00
describe_test.go
some code change
2017-12-25 16:23:38 +08:00
describe.go
some code change
2017-12-25 16:23:38 +08:00
diff_test.go
Implement kubectl alpha diff to diff resources
2017-10-23 10:49:02 -07:00
diff.go
some code change
2017-12-25 16:23:38 +08:00
drain_test.go
Remove unused code in UT files in pkg/
2018-01-15 16:02:35 +08:00
drain.go
Merge pull request #53631 from dixudx/enforce_cobra_required_flags
2018-01-18 02:00:27 -08:00
edit_test.go
Make edit test use subtests to identify flake
2017-11-16 15:45:59 -05:00
edit.go
some code change
2017-12-25 16:23:38 +08:00
exec_test.go
Remove unused code in UT files in pkg/
2018-01-15 16:02:35 +08:00
exec.go
some code change
2017-12-25 16:23:38 +08:00
explain.go
some code change
2017-12-25 16:23:38 +08:00
expose_test.go
pkg/apis/core: mechanical import fixes in dependencies
2017-11-09 12:14:08 +01:00
expose.go
Merge pull request #53631 from dixudx/enforce_cobra_required_flags
2018-01-18 02:00:27 -08:00
help.go
some code change
2017-12-25 16:23:38 +08:00
label_test.go
remove internal version api from kubectl label command
2017-11-13 17:30:09 +08:00
label.go
some code change
2017-12-25 16:23:38 +08:00
logs_test.go
Remove unused code in UT files in pkg/
2018-01-15 16:02:35 +08:00
logs.go
some code change
2017-12-25 16:23:38 +08:00
options.go
move i18n to kubectl/util
2017-08-16 12:27:36 -07:00
patch_test.go
switch some commands to use its own scheme
2017-10-27 18:31:42 -07:00
patch.go
some code change
2017-12-25 16:23:38 +08:00
plugin_test.go
…
plugin.go
some code change
2017-12-25 16:23:38 +08:00
portforward_test.go
Remove unused code in UT files in pkg/
2018-01-15 16:02:35 +08:00
portforward.go
some code change
2017-12-25 16:23:38 +08:00
proxy.go
some code change
2017-12-25 16:23:38 +08:00
replace_test.go
pkg/apis/core: mechanical import fixes in dependencies
2017-11-09 12:14:08 +01:00
replace.go
some code change
2017-12-25 16:23:38 +08:00
rollingupdate_test.go
…
rollingupdate.go
some code change
2017-12-25 16:23:38 +08:00
run_test.go
pkg/apis/core: mechanical import fixes in dependencies
2017-11-09 12:14:08 +01:00
run.go
Merge pull request #53631 from dixudx/enforce_cobra_required_flags
2018-01-18 02:00:27 -08:00
scale.go
some code change
2017-12-25 16:23:38 +08:00
taint_test.go
Remove unused code in UT files in pkg/
2018-01-15 16:02:35 +08:00
taint.go
some code change
2017-12-25 16:23:38 +08:00
top_node_test.go
kubectl: Use metrics-server for kubectl top commands
2018-01-22 21:45:06 +01:00
top_node.go
kubectl: Use metrics-server for kubectl top commands
2018-01-22 21:45:06 +01:00
top_pod_test.go
kubectl: Use metrics-server for kubectl top commands
2018-01-22 21:45:06 +01:00
top_pod.go
kubectl: Use metrics-server for kubectl top commands
2018-01-22 21:45:06 +01:00
top_test.go
kubectl: Use metrics-server for kubectl top commands
2018-01-22 21:45:06 +01:00
top.go
kubectl: Use metrics-server for kubectl top commands
2018-01-22 21:45:06 +01:00
version.go
move i18n to kubectl/util
2017-08-16 12:27:36 -07:00