github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
366997951b
kubernetes/pkg/controller/statefulset/stateful_set_control_test.go
Peter Schuurman 366997951b Update doc comments and change name of feature gate
2022-11-08 07:48:10 -08:00

2996 lines
95 KiB
Go
Raw Blame History

/*
Copyright 2016 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package statefulset
import (
"context"
"errors"
"fmt"
"math/rand"
"reflect"
"runtime"
"sort"
"strconv"
"strings"
"testing"
"time"
apps "k8s.io/api/apps/v1"
v1 "k8s.io/api/core/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/labels"
"k8s.io/apimachinery/pkg/types"
utilerrors "k8s.io/apimachinery/pkg/util/errors"
"k8s.io/apimachinery/pkg/util/intstr"
utilfeature "k8s.io/apiserver/pkg/util/feature"
"k8s.io/client-go/informers"
appsinformers "k8s.io/client-go/informers/apps/v1"
clientset "k8s.io/client-go/kubernetes"
"k8s.io/client-go/kubernetes/fake"
appslisters "k8s.io/client-go/listers/apps/v1"
corelisters "k8s.io/client-go/listers/core/v1"
"k8s.io/client-go/tools/cache"
featuregatetesting "k8s.io/component-base/featuregate/testing"
podutil "k8s.io/kubernetes/pkg/api/v1/pod"
"k8s.io/kubernetes/pkg/controller"
"k8s.io/kubernetes/pkg/controller/history"
"k8s.io/kubernetes/pkg/features"
)
type invariantFunc func(set *apps.StatefulSet, om *fakeObjectManager) error
func setupController(client clientset.Interface) (*fakeObjectManager, *fakeStatefulSetStatusUpdater, StatefulSetControlInterface) {
informerFactory := informers.NewSharedInformerFactory(client, controller.NoResyncPeriodFunc())
om := newFakeObjectManager(informerFactory)
spc := NewStatefulPodControlFromManager(om, &noopRecorder{})
ssu := newFakeStatefulSetStatusUpdater(informerFactory.Apps().V1().StatefulSets())
recorder := &noopRecorder{}
ssc := NewDefaultStatefulSetControl(spc, ssu, history.NewFakeHistory(informerFactory.Apps().V1().ControllerRevisions()), recorder)
// The informer is not started. The tests here manipulate the local cache (indexers) directly, and there is no waiting
// for client state to sync. In fact, because the client is not updated during tests, informer updates will break tests
// by unexpectedly deleting objects.
//
// TODO: It might be better to rewrite all these tests manipulate the client an explicitly sync to ensure consistent
// state, or to create a fake client that does not use a local cache.
// The client is passed initial sets, so we have to put them in the local setsIndexer cache.
if sets, err := client.AppsV1().StatefulSets("").List(context.TODO(), metav1.ListOptions{}); err != nil {
panic(err)
} else {
for _, set := range sets.Items {
if err := om.setsIndexer.Update(&set); err != nil {
panic(err)
}
}
}
return om, ssu, ssc
}
func burst(set *apps.StatefulSet) *apps.StatefulSet {
set.Spec.PodManagementPolicy = apps.ParallelPodManagement
return set
}
func setMinReadySeconds(set *apps.StatefulSet, minReadySeconds int32) *apps.StatefulSet {
set.Spec.MinReadySeconds = minReadySeconds
return set
}
func runTestOverPVCRetentionPolicies(t *testing.T, testName string, testFn func(*testing.T, *apps.StatefulSetPersistentVolumeClaimRetentionPolicy)) {
subtestName := "StatefulSetAutoDeletePVCDisabled"
if testName != "" {
subtestName = fmt.Sprintf("%s/%s", testName, subtestName)
}
t.Run(subtestName, func(t *testing.T) {
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.StatefulSetAutoDeletePVC, false)()
testFn(t, &apps.StatefulSetPersistentVolumeClaimRetentionPolicy{
WhenScaled: apps.RetainPersistentVolumeClaimRetentionPolicyType,
WhenDeleted: apps.RetainPersistentVolumeClaimRetentionPolicyType,
})
})
for _, policy := range []*apps.StatefulSetPersistentVolumeClaimRetentionPolicy{
{
WhenScaled: apps.RetainPersistentVolumeClaimRetentionPolicyType,
WhenDeleted: apps.RetainPersistentVolumeClaimRetentionPolicyType,
},
{
WhenScaled: apps.DeletePersistentVolumeClaimRetentionPolicyType,
WhenDeleted: apps.RetainPersistentVolumeClaimRetentionPolicyType,
},
{
WhenScaled: apps.RetainPersistentVolumeClaimRetentionPolicyType,
WhenDeleted: apps.DeletePersistentVolumeClaimRetentionPolicyType,
},
{
WhenScaled: apps.DeletePersistentVolumeClaimRetentionPolicyType,
WhenDeleted: apps.DeletePersistentVolumeClaimRetentionPolicyType,
},
// tests the case when no policy is set.
nil,
} {
subtestName := pvcDeletePolicyString(policy) + "/StatefulSetAutoDeletePVCEnabled"
if testName != "" {
subtestName = fmt.Sprintf("%s/%s", testName, subtestName)
}
t.Run(subtestName, func(t *testing.T) {
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.StatefulSetAutoDeletePVC, true)()
testFn(t, policy)
})
}
}
func pvcDeletePolicyString(policy *apps.StatefulSetPersistentVolumeClaimRetentionPolicy) string {
if policy == nil {
return "nullPolicy"
}
const retain = apps.RetainPersistentVolumeClaimRetentionPolicyType
const delete = apps.DeletePersistentVolumeClaimRetentionPolicyType
switch {
case policy.WhenScaled == retain && policy.WhenDeleted == retain:
return "Retain"
case policy.WhenScaled == retain && policy.WhenDeleted == delete:
return "SetDeleteOnly"
case policy.WhenScaled == delete && policy.WhenDeleted == retain:
return "ScaleDownOnly"
case policy.WhenScaled == delete && policy.WhenDeleted == delete:
return "Delete"
}
return "invalid"
}
func TestStatefulSetControl(t *testing.T) {
simpleSetFn := func() *apps.StatefulSet { return newStatefulSet(3) }
largeSetFn := func() *apps.StatefulSet { return newStatefulSet(5) }
testCases := []struct {
fn func(*testing.T, *apps.StatefulSet, invariantFunc)
obj func() *apps.StatefulSet
}{
{CreatesPods, simpleSetFn},
{ScalesUp, simpleSetFn},
{ScalesDown, simpleSetFn},
{ReplacesPods, largeSetFn},
{RecreatesFailedPod, simpleSetFn},
{CreatePodFailure, simpleSetFn},
{UpdatePodFailure, simpleSetFn},
{UpdateSetStatusFailure, simpleSetFn},
{PodRecreateDeleteFailure, simpleSetFn},
}
for _, testCase := range testCases {
fnName := runtime.FuncForPC(reflect.ValueOf(testCase.fn).Pointer()).Name()
if i := strings.LastIndex(fnName, "."); i != -1 {
fnName = fnName[i+1:]
}
testObj := testCase.obj
testFn := testCase.fn
runTestOverPVCRetentionPolicies(
t,
fmt.Sprintf("%s/Monotonic", fnName),
func(t *testing.T, policy *apps.StatefulSetPersistentVolumeClaimRetentionPolicy) {
set := testObj()
set.Spec.PersistentVolumeClaimRetentionPolicy = policy
testFn(t, set, assertMonotonicInvariants)
},
)
runTestOverPVCRetentionPolicies(
t,
fmt.Sprintf("%s/Burst", fnName),
func(t *testing.T, policy *apps.StatefulSetPersistentVolumeClaimRetentionPolicy) {
set := burst(testObj())
set.Spec.PersistentVolumeClaimRetentionPolicy = policy
testFn(t, set, assertBurstInvariants)
},
)
}
}
func CreatesPods(t *testing.T, set *apps.StatefulSet, invariants invariantFunc) {
client := fake.NewSimpleClientset(set)
om, _, ssc := setupController(client)
if err := scaleUpStatefulSetControl(set, ssc, om, invariants); err != nil {
t.Errorf("Failed to turn up StatefulSet : %s", err)
}
var err error
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("Error getting updated StatefulSet: %v", err)
}
if set.Status.Replicas != 3 {
t.Error("Failed to scale statefulset to 3 replicas")
}
if set.Status.ReadyReplicas != 3 {
t.Error("Failed to set ReadyReplicas correctly")
}
if set.Status.UpdatedReplicas != 3 {
t.Error("Failed to set UpdatedReplicas correctly")
}
}
func ScalesUp(t *testing.T, set *apps.StatefulSet, invariants invariantFunc) {
client := fake.NewSimpleClientset(set)
om, _, ssc := setupController(client)
if err := scaleUpStatefulSetControl(set, ssc, om, invariants); err != nil {
t.Errorf("Failed to turn up StatefulSet : %s", err)
}
*set.Spec.Replicas = 4
if err := scaleUpStatefulSetControl(set, ssc, om, invariants); err != nil {
t.Errorf("Failed to scale StatefulSet : %s", err)
}
var err error
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("Error getting updated StatefulSet: %v", err)
}
if set.Status.Replicas != 4 {
t.Error("Failed to scale statefulset to 4 replicas")
}
if set.Status.ReadyReplicas != 4 {
t.Error("Failed to set readyReplicas correctly")
}
if set.Status.UpdatedReplicas != 4 {
t.Error("Failed to set updatedReplicas correctly")
}
}
func ScalesDown(t *testing.T, set *apps.StatefulSet, invariants invariantFunc) {
client := fake.NewSimpleClientset(set)
om, _, ssc := setupController(client)
if err := scaleUpStatefulSetControl(set, ssc, om, invariants); err != nil {
t.Errorf("Failed to turn up StatefulSet : %s", err)
}
var err error
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("Error getting updated StatefulSet: %v", err)
}
*set.Spec.Replicas = 0
if err := scaleDownStatefulSetControl(set, ssc, om, invariants); err != nil {
t.Errorf("Failed to scale StatefulSet : %s", err)
}
// Check updated set.
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("Error getting updated StatefulSet: %v", err)
}
if set.Status.Replicas != 0 {
t.Error("Failed to scale statefulset to 0 replicas")
}
if set.Status.ReadyReplicas != 0 {
t.Error("Failed to set readyReplicas correctly")
}
if set.Status.UpdatedReplicas != 0 {
t.Error("Failed to set updatedReplicas correctly")
}
}
func ReplacesPods(t *testing.T, set *apps.StatefulSet, invariants invariantFunc) {
client := fake.NewSimpleClientset(set)
om, _, ssc := setupController(client)
if err := scaleUpStatefulSetControl(set, ssc, om, invariants); err != nil {
t.Errorf("Failed to turn up StatefulSet : %s", err)
}
var err error
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("Error getting updated StatefulSet: %v", err)
}
if set.Status.Replicas != 5 {
t.Error("Failed to scale statefulset to 5 replicas")
}
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
t.Error(err)
}
claims, err := om.claimsLister.PersistentVolumeClaims(set.Namespace).List(selector)
if err != nil {
t.Error(err)
}
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Error(err)
}
for _, pod := range pods {
podClaims := getPersistentVolumeClaims(set, pod)
for _, claim := range claims {
if _, found := podClaims[claim.Name]; found {
if hasOwnerRef(claim, pod) {
t.Errorf("Unexpected ownerRef on %s", claim.Name)
}
}
}
}
sort.Sort(ascendingOrdinal(pods))
om.podsIndexer.Delete(pods[0])
om.podsIndexer.Delete(pods[2])
om.podsIndexer.Delete(pods[4])
for i := 0; i < 5; i += 2 {
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Error(err)
}
if _, err = ssc.UpdateStatefulSet(context.TODO(), set, pods); err != nil {
t.Errorf("Failed to update StatefulSet : %s", err)
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("Error getting updated StatefulSet: %v", err)
}
if pods, err = om.setPodRunning(set, i); err != nil {
t.Error(err)
}
if _, err = ssc.UpdateStatefulSet(context.TODO(), set, pods); err != nil {
t.Errorf("Failed to update StatefulSet : %s", err)
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("Error getting updated StatefulSet: %v", err)
}
if _, err = om.setPodReady(set, i); err != nil {
t.Error(err)
}
}
pods, err = om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Error(err)
}
if _, err := ssc.UpdateStatefulSet(context.TODO(), set, pods); err != nil {
t.Errorf("Failed to update StatefulSet : %s", err)
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("Error getting updated StatefulSet: %v", err)
}
if e, a := int32(5), set.Status.Replicas; e != a {
t.Errorf("Expected to scale to %d, got %d", e, a)
}
}
func RecreatesFailedPod(t *testing.T, set *apps.StatefulSet, invariants invariantFunc) {
client := fake.NewSimpleClientset()
om, _, ssc := setupController(client)
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
t.Error(err)
}
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Error(err)
}
if _, err := ssc.UpdateStatefulSet(context.TODO(), set, pods); err != nil {
t.Errorf("Error updating StatefulSet %s", err)
}
if err := invariants(set, om); err != nil {
t.Error(err)
}
pods, err = om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Error(err)
}
pods[0].Status.Phase = v1.PodFailed
om.podsIndexer.Update(pods[0])
if _, err := ssc.UpdateStatefulSet(context.TODO(), set, pods); err != nil {
t.Errorf("Error updating StatefulSet %s", err)
}
if err := invariants(set, om); err != nil {
t.Error(err)
}
pods, err = om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Error(err)
}
if isCreated(pods[0]) {
t.Error("StatefulSet did not recreate failed Pod")
}
}
func CreatePodFailure(t *testing.T, set *apps.StatefulSet, invariants invariantFunc) {
client := fake.NewSimpleClientset(set)
om, _, ssc := setupController(client)
om.SetCreateStatefulPodError(apierrors.NewInternalError(errors.New("API server failed")), 2)
if err := scaleUpStatefulSetControl(set, ssc, om, invariants); err != nil && isOrHasInternalError(err) {
t.Errorf("StatefulSetControl did not return InternalError found %s", err)
}
// Update so set.Status is set for the next scaleUpStatefulSetControl call.
var err error
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("Error getting updated StatefulSet: %v", err)
}
if err := scaleUpStatefulSetControl(set, ssc, om, invariants); err != nil {
t.Errorf("Failed to turn up StatefulSet : %s", err)
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("Error getting updated StatefulSet: %v", err)
}
if set.Status.Replicas != 3 {
t.Error("Failed to scale StatefulSet to 3 replicas")
}
if set.Status.ReadyReplicas != 3 {
t.Error("Failed to set readyReplicas correctly")
}
if set.Status.UpdatedReplicas != 3 {
t.Error("Failed to updatedReplicas correctly")
}
}
func UpdatePodFailure(t *testing.T, set *apps.StatefulSet, invariants invariantFunc) {
client := fake.NewSimpleClientset(set)
om, _, ssc := setupController(client)
om.SetUpdateStatefulPodError(apierrors.NewInternalError(errors.New("API server failed")), 0)
// have to have 1 successful loop first
if err := scaleUpStatefulSetControl(set, ssc, om, invariants); err != nil {
t.Fatalf("Unexpected error: %v", err)
}
var err error
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("Error getting updated StatefulSet: %v", err)
}
if set.Status.Replicas != 3 {
t.Error("Failed to scale StatefulSet to 3 replicas")
}
if set.Status.ReadyReplicas != 3 {
t.Error("Failed to set readyReplicas correctly")
}
if set.Status.UpdatedReplicas != 3 {
t.Error("Failed to set updatedReplicas correctly")
}
// now mutate a pod's identity
pods, err := om.podsLister.List(labels.Everything())
if err != nil {
t.Fatalf("Error listing pods: %v", err)
}
if len(pods) != 3 {
t.Fatalf("Expected 3 pods, got %d", len(pods))
}
sort.Sort(ascendingOrdinal(pods))
pods[0].Name = "goo-0"
om.podsIndexer.Update(pods[0])
// now it should fail
if _, err := ssc.UpdateStatefulSet(context.TODO(), set, pods); err != nil && isOrHasInternalError(err) {
t.Errorf("StatefulSetControl did not return InternalError found %s", err)
}
}
func UpdateSetStatusFailure(t *testing.T, set *apps.StatefulSet, invariants invariantFunc) {
client := fake.NewSimpleClientset(set)
om, ssu, ssc := setupController(client)
ssu.SetUpdateStatefulSetStatusError(apierrors.NewInternalError(errors.New("API server failed")), 2)
if err := scaleUpStatefulSetControl(set, ssc, om, invariants); err != nil && isOrHasInternalError(err) {
t.Errorf("StatefulSetControl did not return InternalError found %s", err)
}
// Update so set.Status is set for the next scaleUpStatefulSetControl call.
var err error
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("Error getting updated StatefulSet: %v", err)
}
if err := scaleUpStatefulSetControl(set, ssc, om, invariants); err != nil {
t.Errorf("Failed to turn up StatefulSet : %s", err)
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("Error getting updated StatefulSet: %v", err)
}
if set.Status.Replicas != 3 {
t.Error("Failed to scale StatefulSet to 3 replicas")
}
if set.Status.ReadyReplicas != 3 {
t.Error("Failed to set readyReplicas to 3")
}
if set.Status.UpdatedReplicas != 3 {
t.Error("Failed to set updatedReplicas to 3")
}
}
func PodRecreateDeleteFailure(t *testing.T, set *apps.StatefulSet, invariants invariantFunc) {
client := fake.NewSimpleClientset(set)
om, _, ssc := setupController(client)
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
t.Error(err)
}
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Error(err)
}
if _, err := ssc.UpdateStatefulSet(context.TODO(), set, pods); err != nil {
t.Errorf("Error updating StatefulSet %s", err)
}
if err := invariants(set, om); err != nil {
t.Error(err)
}
pods, err = om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Error(err)
}
pods[0].Status.Phase = v1.PodFailed
om.podsIndexer.Update(pods[0])
om.SetDeleteStatefulPodError(apierrors.NewInternalError(errors.New("API server failed")), 0)
if _, err := ssc.UpdateStatefulSet(context.TODO(), set, pods); err != nil && isOrHasInternalError(err) {
t.Errorf("StatefulSet failed to %s", err)
}
if err := invariants(set, om); err != nil {
t.Error(err)
}
if _, err := ssc.UpdateStatefulSet(context.TODO(), set, pods); err != nil {
t.Errorf("Error updating StatefulSet %s", err)
}
if err := invariants(set, om); err != nil {
t.Error(err)
}
pods, err = om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Error(err)
}
if isCreated(pods[0]) {
t.Error("StatefulSet did not recreate failed Pod")
}
}
func emptyInvaraints(set *apps.StatefulSet, om *fakeObjectManager) error {
return nil
}
func TestStatefulSetControlWithStartOrdinal(t *testing.T) {
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.StatefulSetStartOrdinal, true)()
simpleSetFn := func() *apps.StatefulSet {
statefulSet := newStatefulSet(3)
statefulSet.Spec.Ordinals = &apps.StatefulSetOrdinals{Start: int32(2)}
return statefulSet
}
testCases := []struct {
fn func(*testing.T, *apps.StatefulSet, invariantFunc)
obj func() *apps.StatefulSet
}{
{CreatesPodsWithStartOrdinal, simpleSetFn},
}
for _, testCase := range testCases {
testObj := testCase.obj
testFn := testCase.fn
set := testObj()
testFn(t, set, emptyInvaraints)
}
}
func CreatesPodsWithStartOrdinal(t *testing.T, set *apps.StatefulSet, invariants invariantFunc) {
client := fake.NewSimpleClientset(set)
om, _, ssc := setupController(client)
if err := scaleUpStatefulSetControl(set, ssc, om, invariants); err != nil {
t.Errorf("Failed to turn up StatefulSet : %s", err)
}
var err error
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("Error getting updated StatefulSet: %v", err)
}
if set.Status.Replicas != 3 {
t.Error("Failed to scale statefulset to 3 replicas")
}
if set.Status.ReadyReplicas != 3 {
t.Error("Failed to set ReadyReplicas correctly")
}
if set.Status.UpdatedReplicas != 3 {
t.Error("Failed to set UpdatedReplicas correctly")
}
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
t.Error(err)
}
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Error(err)
}
sort.Sort(ascendingOrdinal(pods))
for i, pod := range pods {
expectedOrdinal := 2 + i
actualPodOrdinal := getOrdinal(pod)
if actualPodOrdinal != expectedOrdinal {
t.Errorf("Expected pod ordinal %d. Got %d", expectedOrdinal, actualPodOrdinal)
}
}
}
func TestStatefulSetControlScaleDownDeleteError(t *testing.T) {
runTestOverPVCRetentionPolicies(
t, "", func(t *testing.T, policy *apps.StatefulSetPersistentVolumeClaimRetentionPolicy) {
set := newStatefulSet(3)
set.Spec.PersistentVolumeClaimRetentionPolicy = policy
invariants := assertMonotonicInvariants
client := fake.NewSimpleClientset(set)
om, _, ssc := setupController(client)
if err := scaleUpStatefulSetControl(set, ssc, om, invariants); err != nil {
t.Errorf("Failed to turn up StatefulSet : %s", err)
}
var err error
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("Error getting updated StatefulSet: %v", err)
}
*set.Spec.Replicas = 0
om.SetDeleteStatefulPodError(apierrors.NewInternalError(errors.New("API server failed")), 2)
if err := scaleDownStatefulSetControl(set, ssc, om, invariants); err != nil && isOrHasInternalError(err) {
t.Errorf("StatefulSetControl failed to throw error on delete %s", err)
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("Error getting updated StatefulSet: %v", err)
}
if err := scaleDownStatefulSetControl(set, ssc, om, invariants); err != nil {
t.Errorf("Failed to turn down StatefulSet %s", err)
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("Error getting updated StatefulSet: %v", err)
}
if set.Status.Replicas != 0 {
t.Error("Failed to scale statefulset to 0 replicas")
}
if set.Status.ReadyReplicas != 0 {
t.Error("Failed to set readyReplicas to 0")
}
if set.Status.UpdatedReplicas != 0 {
t.Error("Failed to set updatedReplicas to 0")
}
})
}
func TestStatefulSetControl_getSetRevisions(t *testing.T) {
type testcase struct {
name string
existing []*apps.ControllerRevision
set *apps.StatefulSet
expectedCount int
expectedCurrent *apps.ControllerRevision
expectedUpdate *apps.ControllerRevision
err bool
}
testFn := func(test *testcase, t *testing.T) {
client := fake.NewSimpleClientset()
informerFactory := informers.NewSharedInformerFactory(client, controller.NoResyncPeriodFunc())
spc := NewStatefulPodControlFromManager(newFakeObjectManager(informerFactory), &noopRecorder{})
ssu := newFakeStatefulSetStatusUpdater(informerFactory.Apps().V1().StatefulSets())
recorder := &noopRecorder{}
ssc := defaultStatefulSetControl{spc, ssu, history.NewFakeHistory(informerFactory.Apps().V1().ControllerRevisions()), recorder}
stop := make(chan struct{})
defer close(stop)
informerFactory.Start(stop)
cache.WaitForCacheSync(
stop,
informerFactory.Apps().V1().StatefulSets().Informer().HasSynced,
informerFactory.Core().V1().Pods().Informer().HasSynced,
informerFactory.Apps().V1().ControllerRevisions().Informer().HasSynced,
)
test.set.Status.CollisionCount = new(int32)
for i := range test.existing {
ssc.controllerHistory.CreateControllerRevision(test.set, test.existing[i], test.set.Status.CollisionCount)
}
revisions, err := ssc.ListRevisions(test.set)
if err != nil {
t.Fatal(err)
}
current, update, _, err := ssc.getStatefulSetRevisions(test.set, revisions)
if err != nil {
t.Fatalf("error getting statefulset revisions:%v", err)
}
revisions, err = ssc.ListRevisions(test.set)
if err != nil {
t.Fatal(err)
}
if len(revisions) != test.expectedCount {
t.Errorf("%s: want %d revisions got %d", test.name, test.expectedCount, len(revisions))
}
if test.err && err == nil {
t.Errorf("%s: expected error", test.name)
}
if !test.err && !history.EqualRevision(current, test.expectedCurrent) {
t.Errorf("%s: for current want %v got %v", test.name, test.expectedCurrent, current)
}
if !test.err && !history.EqualRevision(update, test.expectedUpdate) {
t.Errorf("%s: for update want %v got %v", test.name, test.expectedUpdate, update)
}
if !test.err && test.expectedCurrent != nil && current != nil && test.expectedCurrent.Revision != current.Revision {
t.Errorf("%s: for current revision want %d got %d", test.name, test.expectedCurrent.Revision, current.Revision)
}
if !test.err && test.expectedUpdate != nil && update != nil && test.expectedUpdate.Revision != update.Revision {
t.Errorf("%s: for update revision want %d got %d", test.name, test.expectedUpdate.Revision, update.Revision)
}
}
updateRevision := func(cr *apps.ControllerRevision, revision int64) *apps.ControllerRevision {
clone := cr.DeepCopy()
clone.Revision = revision
return clone
}
runTestOverPVCRetentionPolicies(
t, "", func(t *testing.T, policy *apps.StatefulSetPersistentVolumeClaimRetentionPolicy) {
set := newStatefulSet(3)
set.Spec.PersistentVolumeClaimRetentionPolicy = policy
set.Status.CollisionCount = new(int32)
rev0 := newRevisionOrDie(set, 1)
set1 := set.DeepCopy()
set1.Spec.Template.Spec.Containers[0].Image = "foo"
set1.Status.CurrentRevision = rev0.Name
set1.Status.CollisionCount = new(int32)
rev1 := newRevisionOrDie(set1, 2)
set2 := set1.DeepCopy()
set2.Spec.Template.Labels["new"] = "label"
set2.Status.CurrentRevision = rev0.Name
set2.Status.CollisionCount = new(int32)
rev2 := newRevisionOrDie(set2, 3)
tests := []testcase{
{
name: "creates initial revision",
existing: nil,
set: set,
expectedCount: 1,
expectedCurrent: rev0,
expectedUpdate: rev0,
err: false,
},
{
name: "creates revision on update",
existing: []*apps.ControllerRevision{rev0},
set: set1,
expectedCount: 2,
expectedCurrent: rev0,
expectedUpdate: rev1,
err: false,
},
{
name: "must not recreate a new revision of same set",
existing: []*apps.ControllerRevision{rev0, rev1},
set: set1,
expectedCount: 2,
expectedCurrent: rev0,
expectedUpdate: rev1,
err: false,
},
{
name: "must rollback to a previous revision",
existing: []*apps.ControllerRevision{rev0, rev1, rev2},
set: set1,
expectedCount: 3,
expectedCurrent: rev0,
expectedUpdate: updateRevision(rev1, 4),
err: false,
},
}
for i := range tests {
testFn(&tests[i], t)
}
})
}
func setupPodManagementPolicy(podManagementPolicy apps.PodManagementPolicyType, set *apps.StatefulSet) *apps.StatefulSet {
set.Spec.PodManagementPolicy = podManagementPolicy
return set
}
func TestStatefulSetControlRollingUpdateWithMaxUnavailable(t *testing.T) {
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.MaxUnavailableStatefulSet, true)()
simpleParallelVerificationFn := func(
set *apps.StatefulSet,
spc *fakeObjectManager,
ssc StatefulSetControlInterface,
pods []*v1.Pod,
totalPods int,
selector labels.Selector,
) []*v1.Pod {
// in burst mode, 2 pods got deleted, so 2 new pods will be created at the same time
if len(pods) != totalPods {
t.Fatalf("Expected create pods 4/5, got pods %v", len(pods))
}
// if pod 4 ready, start to update pod 3, even though 5 is not ready
spc.setPodRunning(set, 4)
spc.setPodRunning(set, 5)
originalPods, _ := spc.setPodReady(set, 4)
sort.Sort(ascendingOrdinal(originalPods))
if _, err := ssc.UpdateStatefulSet(context.TODO(), set, originalPods); err != nil {
t.Fatal(err)
}
pods, err := spc.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Fatal(err)
}
sort.Sort(ascendingOrdinal(pods))
// pods 0, 1,2, 4,5 should be present(note 3 is missing)
if !reflect.DeepEqual(pods, append(originalPods[:3], originalPods[4:]...)) {
t.Fatalf("Expected pods %v, got pods %v", append(originalPods[:3], originalPods[4:]...), pods)
}
// create new pod 3
if _, err = ssc.UpdateStatefulSet(context.TODO(), set, pods); err != nil {
t.Fatal(err)
}
pods, err = spc.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Fatal(err)
}
if len(pods) != totalPods {
t.Fatalf("Expected create pods 2/3, got pods %v", pods)
}
return pods
}
simpleOrderedVerificationFn := func(
set *apps.StatefulSet,
spc *fakeObjectManager,
ssc StatefulSetControlInterface,
pods []*v1.Pod,
totalPods int,
selector labels.Selector,
) []*v1.Pod {
// only one pod gets created at a time due to OrderedReady
if len(pods) != 5 {
t.Fatalf("Expected create pods 5, got pods %v", len(pods))
}
spc.setPodRunning(set, 4)
pods, _ = spc.setPodReady(set, 4)
// create new pods 4(only one pod gets created at a time due to OrderedReady)
if _, err := ssc.UpdateStatefulSet(context.TODO(), set, pods); err != nil {
t.Fatal(err)
}
pods, err := spc.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Fatal(err)
}
if len(pods) != totalPods {
t.Fatalf("Expected create pods 4, got pods %v", len(pods))
}
// if pod 4 ready, start to update pod 3
spc.setPodRunning(set, 5)
originalPods, _ := spc.setPodReady(set, 5)
sort.Sort(ascendingOrdinal(originalPods))
if _, err = ssc.UpdateStatefulSet(context.TODO(), set, originalPods); err != nil {
t.Fatal(err)
}
pods, err = spc.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Fatal(err)
}
sort.Sort(ascendingOrdinal(pods))
// verify the remaining pods are 0,1,2,4,5 (3 got deleted)
if !reflect.DeepEqual(pods, append(originalPods[:3], originalPods[4:]...)) {
t.Fatalf("Expected pods %v, got pods %v", append(originalPods[:3], originalPods[4:]...), pods)
}
// create new pod 3
if _, err = ssc.UpdateStatefulSet(context.TODO(), set, pods); err != nil {
t.Fatal(err)
}
pods, err = spc.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Fatal(err)
}
if len(pods) != totalPods {
t.Fatalf("Expected create pods 2/3, got pods %v", pods)
}
return pods
}
testCases := []struct {
policyType apps.PodManagementPolicyType
verifyFn func(
set *apps.StatefulSet,
spc *fakeObjectManager,
ssc StatefulSetControlInterface,
pods []*v1.Pod,
totalPods int,
selector labels.Selector,
) []*v1.Pod
}{
{apps.OrderedReadyPodManagement, simpleOrderedVerificationFn},
{apps.ParallelPodManagement, simpleParallelVerificationFn},
}
for _, tc := range testCases {
// Setup the statefulSet controller
totalPods := 6
var partition int32 = 3
var maxUnavailable = intstr.FromInt(2)
set := setupPodManagementPolicy(tc.policyType, newStatefulSet(totalPods))
set.Spec.UpdateStrategy = apps.StatefulSetUpdateStrategy{
Type: apps.RollingUpdateStatefulSetStrategyType,
RollingUpdate: func() *apps.RollingUpdateStatefulSetStrategy {
return &apps.RollingUpdateStatefulSetStrategy{
Partition: &partition,
MaxUnavailable: &maxUnavailable,
}
}(),
}
client := fake.NewSimpleClientset()
spc, _, ssc := setupController(client)
if err := scaleUpStatefulSetControl(set, ssc, spc, assertBurstInvariants); err != nil {
t.Fatal(err)
}
set, err := spc.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatal(err)
}
// Change the image to trigger an update
set.Spec.Template.Spec.Containers[0].Image = "foo"
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
t.Fatal(err)
}
originalPods, err := spc.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Fatal(err)
}
sort.Sort(ascendingOrdinal(originalPods))
// since maxUnavailable is 2, update pods 4 and 5, this will delete the pod 4 and 5,
if _, err = ssc.UpdateStatefulSet(context.TODO(), set, originalPods); err != nil {
t.Fatal(err)
}
pods, err := spc.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Fatal(err)
}
sort.Sort(ascendingOrdinal(pods))
// expected number of pod is 0,1,2,3
if !reflect.DeepEqual(pods, originalPods[:4]) {
t.Fatalf("Expected pods %v, got pods %v", originalPods[:4], pods)
}
// create new pods
if _, err = ssc.UpdateStatefulSet(context.TODO(), set, pods); err != nil {
t.Fatal(err)
}
pods, err = spc.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Fatal(err)
}
tc.verifyFn(set, spc, ssc, pods, totalPods, selector)
// pods 3/4/5 ready, should not update other pods
spc.setPodRunning(set, 3)
spc.setPodRunning(set, 5)
spc.setPodReady(set, 5)
originalPods, _ = spc.setPodReady(set, 3)
sort.Sort(ascendingOrdinal(originalPods))
if _, err = ssc.UpdateStatefulSet(context.TODO(), set, originalPods); err != nil {
t.Fatal(err)
}
pods, err = spc.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Fatal(err)
}
sort.Sort(ascendingOrdinal(pods))
if !reflect.DeepEqual(pods, originalPods) {
t.Fatalf("Expected pods %v, got pods %v", originalPods, pods)
}
}
}
func setupForInvariant(t *testing.T) (*apps.StatefulSet, *fakeObjectManager, StatefulSetControlInterface, intstr.IntOrString, int) {
totalPods := 6
set := newStatefulSet(totalPods)
// update all pods >=3(3,4,5)
var partition int32 = 3
var maxUnavailable = intstr.FromInt(2)
set.Spec.UpdateStrategy = apps.StatefulSetUpdateStrategy{
Type: apps.RollingUpdateStatefulSetStrategyType,
RollingUpdate: func() *apps.RollingUpdateStatefulSetStrategy {
return &apps.RollingUpdateStatefulSetStrategy{
Partition: &partition,
MaxUnavailable: &maxUnavailable,
}
}(),
}
client := fake.NewSimpleClientset()
spc, _, ssc := setupController(client)
if err := scaleUpStatefulSetControl(set, ssc, spc, assertBurstInvariants); err != nil {
t.Fatal(err)
}
set, err := spc.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatal(err)
}
return set, spc, ssc, maxUnavailable, totalPods
}
func TestStatefulSetControlRollingUpdateWithMaxUnavailableInOrderedModeVerifyInvariant(t *testing.T) {
// Make all pods in statefulset unavailable one by one
// and verify that RollingUpdate doesnt proceed with maxUnavailable set
// this could have been a simple loop, keeping it like this to be able
// to add more params here.
testCases := []struct {
ordinalOfPodToTerminate []int
}{
{[]int{}},
{[]int{5}},
{[]int{3}},
{[]int{4}},
{[]int{5, 4}},
{[]int{5, 3}},
{[]int{4, 3}},
{[]int{5, 4, 3}},
{[]int{2}}, // note this is an ordinal greater than partition(3)
{[]int{1}}, // note this is an ordinal greater than partition(3)
}
for _, tc := range testCases {
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.MaxUnavailableStatefulSet, true)()
set, spc, ssc, maxUnavailable, totalPods := setupForInvariant(t)
t.Run(fmt.Sprintf("terminating pod at ordinal %d", tc.ordinalOfPodToTerminate), func(t *testing.T) {
status := apps.StatefulSetStatus{Replicas: int32(totalPods)}
updateRevision := &apps.ControllerRevision{}
for i := 0; i < len(tc.ordinalOfPodToTerminate); i++ {
// Ensure at least one pod is unavailable before trying to update
_, err := spc.addTerminatingPod(set, tc.ordinalOfPodToTerminate[i])
if err != nil {
t.Fatal(err)
}
}
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
t.Fatal(err)
}
originalPods, err := spc.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Fatal(err)
}
sort.Sort(ascendingOrdinal(originalPods))
// start to update
set.Spec.Template.Spec.Containers[0].Image = "foo"
// try to update the statefulset
// this function is only called in main code when feature gate is enabled
if _, err = updateStatefulSetAfterInvariantEstablished(context.TODO(), ssc.(*defaultStatefulSetControl), set, originalPods, updateRevision, status); err != nil {
t.Fatal(err)
}
pods, err := spc.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Fatal(err)
}
sort.Sort(ascendingOrdinal(pods))
expecteddPodsToBeDeleted := maxUnavailable.IntValue() - len(tc.ordinalOfPodToTerminate)
if expecteddPodsToBeDeleted < 0 {
expecteddPodsToBeDeleted = 0
}
expectedPodsAfterUpdate := totalPods - expecteddPodsToBeDeleted
if len(pods) != expectedPodsAfterUpdate {
t.Errorf("Expected pods %v, got pods %v", expectedPodsAfterUpdate, len(pods))
}
})
}
}
func TestStatefulSetControlRollingUpdate(t *testing.T) {
type testcase struct {
name string
invariants func(set *apps.StatefulSet, om *fakeObjectManager) error
initial func() *apps.StatefulSet
update func(set *apps.StatefulSet) *apps.StatefulSet
validate func(set *apps.StatefulSet, pods []*v1.Pod) error
}
testFn := func(test *testcase, t *testing.T) {
set := test.initial()
client := fake.NewSimpleClientset(set)
om, _, ssc := setupController(client)
if err := scaleUpStatefulSetControl(set, ssc, om, test.invariants); err != nil {
t.Fatalf("%s: %s", test.name, err)
}
set, err := om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
set = test.update(set)
if err := updateStatefulSetControl(set, ssc, om, assertUpdateInvariants); err != nil {
t.Fatalf("%s: %s", test.name, err)
}
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
if err := test.validate(set, pods); err != nil {
t.Fatalf("%s: %s", test.name, err)
}
}
tests := []testcase{
{
name: "monotonic image update",
invariants: assertMonotonicInvariants,
initial: func() *apps.StatefulSet {
return newStatefulSet(3)
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
{
name: "monotonic image update and scale up",
invariants: assertMonotonicInvariants,
initial: func() *apps.StatefulSet {
return newStatefulSet(3)
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
*set.Spec.Replicas = 5
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
{
name: "monotonic image update and scale down",
invariants: assertMonotonicInvariants,
initial: func() *apps.StatefulSet {
return newStatefulSet(5)
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
*set.Spec.Replicas = 3
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
{
name: "burst image update",
invariants: assertBurstInvariants,
initial: func() *apps.StatefulSet {
return burst(newStatefulSet(3))
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
{
name: "burst image update and scale up",
invariants: assertBurstInvariants,
initial: func() *apps.StatefulSet {
return burst(newStatefulSet(3))
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
*set.Spec.Replicas = 5
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
{
name: "burst image update and scale down",
invariants: assertBurstInvariants,
initial: func() *apps.StatefulSet {
return burst(newStatefulSet(5))
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
*set.Spec.Replicas = 3
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
}
for i := range tests {
testFn(&tests[i], t)
}
}
func TestStatefulSetControlOnDeleteUpdate(t *testing.T) {
type testcase struct {
name string
invariants func(set *apps.StatefulSet, om *fakeObjectManager) error
initial func() *apps.StatefulSet
update func(set *apps.StatefulSet) *apps.StatefulSet
validateUpdate func(set *apps.StatefulSet, pods []*v1.Pod) error
validateRestart func(set *apps.StatefulSet, pods []*v1.Pod) error
}
originalImage := newStatefulSet(3).Spec.Template.Spec.Containers[0].Image
testFn := func(t *testing.T, test *testcase, policy *apps.StatefulSetPersistentVolumeClaimRetentionPolicy) {
set := test.initial()
set.Spec.PersistentVolumeClaimRetentionPolicy = policy
set.Spec.UpdateStrategy = apps.StatefulSetUpdateStrategy{Type: apps.OnDeleteStatefulSetStrategyType}
client := fake.NewSimpleClientset(set)
om, _, ssc := setupController(client)
if err := scaleUpStatefulSetControl(set, ssc, om, test.invariants); err != nil {
t.Fatalf("%s: %s", test.name, err)
}
set, err := om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
set = test.update(set)
if err := updateStatefulSetControl(set, ssc, om, assertUpdateInvariants); err != nil {
t.Fatalf("%s: %s", test.name, err)
}
// Pods may have been deleted in the update. Delete any claims with a pod ownerRef.
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
claims, err := om.claimsLister.PersistentVolumeClaims(set.Namespace).List(selector)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
for _, claim := range claims {
for _, ref := range claim.GetOwnerReferences() {
if strings.HasPrefix(ref.Name, "foo-") {
om.claimsIndexer.Delete(claim)
break
}
}
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
if err := test.validateUpdate(set, pods); err != nil {
for i := range pods {
t.Log(pods[i].Name)
}
t.Fatalf("%s: %s", test.name, err)
}
claims, err = om.claimsLister.PersistentVolumeClaims(set.Namespace).List(selector)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
for _, claim := range claims {
for _, ref := range claim.GetOwnerReferences() {
if strings.HasPrefix(ref.Name, "foo-") {
t.Fatalf("Unexpected pod reference on %s: %v", claim.Name, claim.GetOwnerReferences())
}
}
}
replicas := *set.Spec.Replicas
*set.Spec.Replicas = 0
if err := scaleDownStatefulSetControl(set, ssc, om, test.invariants); err != nil {
t.Fatalf("%s: %s", test.name, err)
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
*set.Spec.Replicas = replicas
claims, err = om.claimsLister.PersistentVolumeClaims(set.Namespace).List(selector)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
for _, claim := range claims {
for _, ref := range claim.GetOwnerReferences() {
if strings.HasPrefix(ref.Name, "foo-") {
t.Fatalf("Unexpected pod reference on %s: %v", claim.Name, claim.GetOwnerReferences())
}
}
}
if err := scaleUpStatefulSetControl(set, ssc, om, test.invariants); err != nil {
t.Fatalf("%s: %s", test.name, err)
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
pods, err = om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
if err := test.validateRestart(set, pods); err != nil {
t.Fatalf("%s: %s", test.name, err)
}
}
tests := []testcase{
{
name: "monotonic image update",
invariants: assertMonotonicInvariants,
initial: func() *apps.StatefulSet {
return newStatefulSet(3)
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validateUpdate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != originalImage {
return fmt.Errorf("want pod %s image %s found %s", pods[i].Name, originalImage, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
validateRestart: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
{
name: "monotonic image update and scale up",
invariants: assertMonotonicInvariants,
initial: func() *apps.StatefulSet {
return newStatefulSet(3)
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
*set.Spec.Replicas = 5
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validateUpdate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if i < 3 && pods[i].Spec.Containers[0].Image != originalImage {
return fmt.Errorf("want pod %s image %s found %s", pods[i].Name, originalImage, pods[i].Spec.Containers[0].Image)
}
if i >= 3 && pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
validateRestart: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
{
name: "monotonic image update and scale down",
invariants: assertMonotonicInvariants,
initial: func() *apps.StatefulSet {
return newStatefulSet(5)
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
*set.Spec.Replicas = 3
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validateUpdate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != originalImage {
return fmt.Errorf("want pod %s image %s found %s", pods[i].Name, originalImage, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
validateRestart: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
{
name: "burst image update",
invariants: assertBurstInvariants,
initial: func() *apps.StatefulSet {
return burst(newStatefulSet(3))
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validateUpdate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != originalImage {
return fmt.Errorf("want pod %s image %s found %s", pods[i].Name, originalImage, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
validateRestart: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
{
name: "burst image update and scale up",
invariants: assertBurstInvariants,
initial: func() *apps.StatefulSet {
return burst(newStatefulSet(3))
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
*set.Spec.Replicas = 5
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validateUpdate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if i < 3 && pods[i].Spec.Containers[0].Image != originalImage {
return fmt.Errorf("want pod %s image %s found %s", pods[i].Name, originalImage, pods[i].Spec.Containers[0].Image)
}
if i >= 3 && pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
validateRestart: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
{
name: "burst image update and scale down",
invariants: assertBurstInvariants,
initial: func() *apps.StatefulSet {
return burst(newStatefulSet(5))
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
*set.Spec.Replicas = 3
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validateUpdate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != originalImage {
return fmt.Errorf("want pod %s image %s found %s", pods[i].Name, originalImage, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
validateRestart: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
}
runTestOverPVCRetentionPolicies(t, "", func(t *testing.T, policy *apps.StatefulSetPersistentVolumeClaimRetentionPolicy) {
for i := range tests {
testFn(t, &tests[i], policy)
}
})
}
func TestStatefulSetControlRollingUpdateWithPartition(t *testing.T) {
type testcase struct {
name string
partition int32
invariants func(set *apps.StatefulSet, om *fakeObjectManager) error
initial func() *apps.StatefulSet
update func(set *apps.StatefulSet) *apps.StatefulSet
validate func(set *apps.StatefulSet, pods []*v1.Pod) error
}
testFn := func(t *testing.T, test *testcase, policy *apps.StatefulSetPersistentVolumeClaimRetentionPolicy) {
set := test.initial()
set.Spec.PersistentVolumeClaimRetentionPolicy = policy
set.Spec.UpdateStrategy = apps.StatefulSetUpdateStrategy{
Type: apps.RollingUpdateStatefulSetStrategyType,
RollingUpdate: func() *apps.RollingUpdateStatefulSetStrategy {
return &apps.RollingUpdateStatefulSetStrategy{Partition: &test.partition}
}(),
}
client := fake.NewSimpleClientset(set)
om, _, ssc := setupController(client)
if err := scaleUpStatefulSetControl(set, ssc, om, test.invariants); err != nil {
t.Fatalf("%s: %s", test.name, err)
}
set, err := om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
set = test.update(set)
if err := updateStatefulSetControl(set, ssc, om, assertUpdateInvariants); err != nil {
t.Fatalf("%s: %s", test.name, err)
}
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
if err := test.validate(set, pods); err != nil {
t.Fatalf("%s: %s", test.name, err)
}
}
originalImage := newStatefulSet(3).Spec.Template.Spec.Containers[0].Image
tests := []testcase{
{
name: "monotonic image update",
invariants: assertMonotonicInvariants,
partition: 2,
initial: func() *apps.StatefulSet {
return newStatefulSet(3)
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if i < 2 && pods[i].Spec.Containers[0].Image != originalImage {
return fmt.Errorf("want pod %s image %s found %s", pods[i].Name, originalImage, pods[i].Spec.Containers[0].Image)
}
if i >= 2 && pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
{
name: "monotonic image update and scale up",
partition: 2,
invariants: assertMonotonicInvariants,
initial: func() *apps.StatefulSet {
return newStatefulSet(3)
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
*set.Spec.Replicas = 5
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if i < 2 && pods[i].Spec.Containers[0].Image != originalImage {
return fmt.Errorf("want pod %s image %s found %s", pods[i].Name, originalImage, pods[i].Spec.Containers[0].Image)
}
if i >= 2 && pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
{
name: "burst image update",
partition: 2,
invariants: assertBurstInvariants,
initial: func() *apps.StatefulSet {
return burst(newStatefulSet(3))
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if i < 2 && pods[i].Spec.Containers[0].Image != originalImage {
return fmt.Errorf("want pod %s image %s found %s", pods[i].Name, originalImage, pods[i].Spec.Containers[0].Image)
}
if i >= 2 && pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
{
name: "burst image update and scale up",
invariants: assertBurstInvariants,
partition: 2,
initial: func() *apps.StatefulSet {
return burst(newStatefulSet(3))
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
*set.Spec.Replicas = 5
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if i < 2 && pods[i].Spec.Containers[0].Image != originalImage {
return fmt.Errorf("want pod %s image %s found %s", pods[i].Name, originalImage, pods[i].Spec.Containers[0].Image)
}
if i >= 2 && pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
}
runTestOverPVCRetentionPolicies(t, "", func(t *testing.T, policy *apps.StatefulSetPersistentVolumeClaimRetentionPolicy) {
for i := range tests {
testFn(t, &tests[i], policy)
}
})
}
func TestStatefulSetHonorRevisionHistoryLimit(t *testing.T) {
runTestOverPVCRetentionPolicies(t, "", func(t *testing.T, policy *apps.StatefulSetPersistentVolumeClaimRetentionPolicy) {
invariants := assertMonotonicInvariants
set := newStatefulSet(3)
set.Spec.PersistentVolumeClaimRetentionPolicy = policy
client := fake.NewSimpleClientset(set)
om, ssu, ssc := setupController(client)
if err := scaleUpStatefulSetControl(set, ssc, om, invariants); err != nil {
t.Errorf("Failed to turn up StatefulSet : %s", err)
}
var err error
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("Error getting updated StatefulSet: %v", err)
}
for i := 0; i < int(*set.Spec.RevisionHistoryLimit)+5; i++ {
set.Spec.Template.Spec.Containers[0].Image = fmt.Sprintf("foo-%d", i)
ssu.SetUpdateStatefulSetStatusError(apierrors.NewInternalError(errors.New("API server failed")), 2)
updateStatefulSetControl(set, ssc, om, assertUpdateInvariants)
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("Error getting updated StatefulSet: %v", err)
}
revisions, err := ssc.ListRevisions(set)
if err != nil {
t.Fatalf("Error listing revisions: %v", err)
}
// the extra 2 revisions are `currentRevision` and `updateRevision`
// They're considered as `live`, and truncateHistory only cleans up non-live revisions
if len(revisions) > int(*set.Spec.RevisionHistoryLimit)+2 {
t.Fatalf("%s: %d greater than limit %d", "", len(revisions), *set.Spec.RevisionHistoryLimit)
}
}
})
}
func TestStatefulSetControlLimitsHistory(t *testing.T) {
type testcase struct {
name string
invariants func(set *apps.StatefulSet, om *fakeObjectManager) error
initial func() *apps.StatefulSet
}
testFn := func(t *testing.T, test *testcase) {
set := test.initial()
client := fake.NewSimpleClientset(set)
om, _, ssc := setupController(client)
if err := scaleUpStatefulSetControl(set, ssc, om, test.invariants); err != nil {
t.Fatalf("%s: %s", test.name, err)
}
set, err := om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
for i := 0; i < 10; i++ {
set.Spec.Template.Spec.Containers[0].Image = fmt.Sprintf("foo-%d", i)
if err := updateStatefulSetControl(set, ssc, om, assertUpdateInvariants); err != nil {
t.Fatalf("%s: %s", test.name, err)
}
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
_, err = ssc.UpdateStatefulSet(context.TODO(), set, pods)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
revisions, err := ssc.ListRevisions(set)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
if len(revisions) > int(*set.Spec.RevisionHistoryLimit)+2 {
t.Fatalf("%s: %d greater than limit %d", test.name, len(revisions), *set.Spec.RevisionHistoryLimit)
}
}
}
tests := []testcase{
{
name: "monotonic update",
invariants: assertMonotonicInvariants,
initial: func() *apps.StatefulSet {
return newStatefulSet(3)
},
},
{
name: "burst update",
invariants: assertBurstInvariants,
initial: func() *apps.StatefulSet {
return burst(newStatefulSet(3))
},
},
}
for i := range tests {
testFn(t, &tests[i])
}
}
func TestStatefulSetControlRollback(t *testing.T) {
type testcase struct {
name string
invariants func(set *apps.StatefulSet, om *fakeObjectManager) error
initial func() *apps.StatefulSet
update func(set *apps.StatefulSet) *apps.StatefulSet
validateUpdate func(set *apps.StatefulSet, pods []*v1.Pod) error
validateRollback func(set *apps.StatefulSet, pods []*v1.Pod) error
}
originalImage := newStatefulSet(3).Spec.Template.Spec.Containers[0].Image
testFn := func(t *testing.T, test *testcase) {
set := test.initial()
client := fake.NewSimpleClientset(set)
om, _, ssc := setupController(client)
if err := scaleUpStatefulSetControl(set, ssc, om, test.invariants); err != nil {
t.Fatalf("%s: %s", test.name, err)
}
set, err := om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
set = test.update(set)
if err := updateStatefulSetControl(set, ssc, om, assertUpdateInvariants); err != nil {
t.Fatalf("%s: %s", test.name, err)
}
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
if err := test.validateUpdate(set, pods); err != nil {
t.Fatalf("%s: %s", test.name, err)
}
revisions, err := ssc.ListRevisions(set)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
history.SortControllerRevisions(revisions)
set, err = ApplyRevision(set, revisions[0])
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
if err := updateStatefulSetControl(set, ssc, om, assertUpdateInvariants); err != nil {
t.Fatalf("%s: %s", test.name, err)
}
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
pods, err = om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
if err := test.validateRollback(set, pods); err != nil {
t.Fatalf("%s: %s", test.name, err)
}
}
tests := []testcase{
{
name: "monotonic image update",
invariants: assertMonotonicInvariants,
initial: func() *apps.StatefulSet {
return newStatefulSet(3)
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validateUpdate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
validateRollback: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != originalImage {
return fmt.Errorf("want pod %s image %s found %s", pods[i].Name, originalImage, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
{
name: "monotonic image update and scale up",
invariants: assertMonotonicInvariants,
initial: func() *apps.StatefulSet {
return newStatefulSet(3)
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
*set.Spec.Replicas = 5
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validateUpdate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
validateRollback: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != originalImage {
return fmt.Errorf("want pod %s image %s found %s", pods[i].Name, originalImage, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
{
name: "monotonic image update and scale down",
invariants: assertMonotonicInvariants,
initial: func() *apps.StatefulSet {
return newStatefulSet(5)
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
*set.Spec.Replicas = 3
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validateUpdate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
validateRollback: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != originalImage {
return fmt.Errorf("want pod %s image %s found %s", pods[i].Name, originalImage, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
{
name: "burst image update",
invariants: assertBurstInvariants,
initial: func() *apps.StatefulSet {
return burst(newStatefulSet(3))
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validateUpdate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
validateRollback: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != originalImage {
return fmt.Errorf("want pod %s image %s found %s", pods[i].Name, originalImage, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
{
name: "burst image update and scale up",
invariants: assertBurstInvariants,
initial: func() *apps.StatefulSet {
return burst(newStatefulSet(3))
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
*set.Spec.Replicas = 5
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validateUpdate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
validateRollback: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != originalImage {
return fmt.Errorf("want pod %s image %s found %s", pods[i].Name, originalImage, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
{
name: "burst image update and scale down",
invariants: assertBurstInvariants,
initial: func() *apps.StatefulSet {
return burst(newStatefulSet(5))
},
update: func(set *apps.StatefulSet) *apps.StatefulSet {
*set.Spec.Replicas = 3
set.Spec.Template.Spec.Containers[0].Image = "foo"
return set
},
validateUpdate: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != "foo" {
return fmt.Errorf("want pod %s image foo found %s", pods[i].Name, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
validateRollback: func(set *apps.StatefulSet, pods []*v1.Pod) error {
sort.Sort(ascendingOrdinal(pods))
for i := range pods {
if pods[i].Spec.Containers[0].Image != originalImage {
return fmt.Errorf("want pod %s image %s found %s", pods[i].Name, originalImage, pods[i].Spec.Containers[0].Image)
}
}
return nil
},
},
}
for i := range tests {
testFn(t, &tests[i])
}
}
func TestStatefulSetAvailability(t *testing.T) {
tests := []struct {
name string
inputSTS *apps.StatefulSet
expectedActiveReplicas int32
readyDuration time.Duration
}{
{
name: "replicas running for required time, when minReadySeconds is enabled",
inputSTS: setMinReadySeconds(newStatefulSet(1), int32(3600)),
readyDuration: -120 * time.Minute,
expectedActiveReplicas: int32(1),
},
{
name: "replicas not running for required time, when minReadySeconds is enabled",
inputSTS: setMinReadySeconds(newStatefulSet(1), int32(3600)),
readyDuration: -30 * time.Minute,
expectedActiveReplicas: int32(0),
},
}
for _, test := range tests {
set := test.inputSTS
client := fake.NewSimpleClientset(set)
spc, _, ssc := setupController(client)
if err := scaleUpStatefulSetControl(set, ssc, spc, assertBurstInvariants); err != nil {
t.Fatalf("%s: %s", test.name, err)
}
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
_, err = spc.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
set, err = spc.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
pods, err := spc.setPodAvailable(set, 0, time.Now().Add(test.readyDuration))
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
status, err := ssc.UpdateStatefulSet(context.TODO(), set, pods)
if err != nil {
t.Fatalf("%s: %s", test.name, err)
}
if status.AvailableReplicas != test.expectedActiveReplicas {
t.Fatalf("expected %d active replicas got %d", test.expectedActiveReplicas, status.AvailableReplicas)
}
}
}
func TestStatefulSetStatusUpdate(t *testing.T) {
var (
syncErr = fmt.Errorf("sync error")
statusErr = fmt.Errorf("status error")
)
testCases := []struct {
desc string
hasSyncErr bool
hasStatusErr bool
expectedErr error
}{
{
desc: "no error",
hasSyncErr: false,
hasStatusErr: false,
expectedErr: nil,
},
{
desc: "sync error",
hasSyncErr: true,
hasStatusErr: false,
expectedErr: syncErr,
},
{
desc: "status error",
hasSyncErr: false,
hasStatusErr: true,
expectedErr: statusErr,
},
{
desc: "sync and status error",
hasSyncErr: true,
hasStatusErr: true,
expectedErr: syncErr,
},
}
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
set := newStatefulSet(3)
client := fake.NewSimpleClientset(set)
om, ssu, ssc := setupController(client)
if tc.hasSyncErr {
om.SetCreateStatefulPodError(syncErr, 0)
}
if tc.hasStatusErr {
ssu.SetUpdateStatefulSetStatusError(statusErr, 0)
}
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
t.Error(err)
}
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
t.Error(err)
}
_, err = ssc.UpdateStatefulSet(context.TODO(), set, pods)
if ssu.updateStatusTracker.requests != 1 {
t.Errorf("Did not update status")
}
if !errors.Is(err, tc.expectedErr) {
t.Errorf("Expected error: %v, got: %v", tc.expectedErr, err)
}
})
}
}
type requestTracker struct {
requests int
err error
after int
}
func (rt *requestTracker) errorReady() bool {
return rt.err != nil && rt.requests >= rt.after
}
func (rt *requestTracker) inc() {
rt.requests++
}
func (rt *requestTracker) reset() {
rt.err = nil
rt.after = 0
}
type fakeObjectManager struct {
podsLister corelisters.PodLister
claimsLister corelisters.PersistentVolumeClaimLister
setsLister appslisters.StatefulSetLister
podsIndexer cache.Indexer
claimsIndexer cache.Indexer
setsIndexer cache.Indexer
revisionsIndexer cache.Indexer
createPodTracker requestTracker
updatePodTracker requestTracker
deletePodTracker requestTracker
}
func newFakeObjectManager(informerFactory informers.SharedInformerFactory) *fakeObjectManager {
podInformer := informerFactory.Core().V1().Pods()
claimInformer := informerFactory.Core().V1().PersistentVolumeClaims()
setInformer := informerFactory.Apps().V1().StatefulSets()
revisionInformer := informerFactory.Apps().V1().ControllerRevisions()
return &fakeObjectManager{
podInformer.Lister(),
claimInformer.Lister(),
setInformer.Lister(),
podInformer.Informer().GetIndexer(),
claimInformer.Informer().GetIndexer(),
setInformer.Informer().GetIndexer(),
revisionInformer.Informer().GetIndexer(),
requestTracker{0, nil, 0},
requestTracker{0, nil, 0},
requestTracker{0, nil, 0}}
}
func (om *fakeObjectManager) CreatePod(ctx context.Context, pod *v1.Pod) error {
defer om.createPodTracker.inc()
if om.createPodTracker.errorReady() {
defer om.createPodTracker.reset()
return om.createPodTracker.err
}
pod.SetUID(types.UID(pod.Name + "-uid"))
return om.podsIndexer.Update(pod)
}
func (om *fakeObjectManager) GetPod(namespace, podName string) (*v1.Pod, error) {
return om.podsLister.Pods(namespace).Get(podName)
}
func (om *fakeObjectManager) UpdatePod(pod *v1.Pod) error {
return om.podsIndexer.Update(pod)
}
func (om *fakeObjectManager) DeletePod(pod *v1.Pod) error {
defer om.deletePodTracker.inc()
if om.deletePodTracker.errorReady() {
defer om.deletePodTracker.reset()
return om.deletePodTracker.err
}
if key, err := controller.KeyFunc(pod); err != nil {
return err
} else if obj, found, err := om.podsIndexer.GetByKey(key); err != nil {
return err
} else if found {
return om.podsIndexer.Delete(obj)
}
return nil // Not found, no error in deleting.
}
func (om *fakeObjectManager) CreateClaim(claim *v1.PersistentVolumeClaim) error {
om.claimsIndexer.Update(claim)
return nil
}
func (om *fakeObjectManager) GetClaim(namespace, claimName string) (*v1.PersistentVolumeClaim, error) {
return om.claimsLister.PersistentVolumeClaims(namespace).Get(claimName)
}
func (om *fakeObjectManager) UpdateClaim(claim *v1.PersistentVolumeClaim) error {
// Validate ownerRefs.
refs := claim.GetOwnerReferences()
for _, ref := range refs {
if ref.APIVersion == "" || ref.Kind == "" || ref.Name == "" {
return fmt.Errorf("invalid ownerRefs: %s %v", claim.Name, refs)
}
}
om.claimsIndexer.Update(claim)
return nil
}
func (om *fakeObjectManager) SetCreateStatefulPodError(err error, after int) {
om.createPodTracker.err = err
om.createPodTracker.after = after
}
func (om *fakeObjectManager) SetUpdateStatefulPodError(err error, after int) {
om.updatePodTracker.err = err
om.updatePodTracker.after = after
}
func (om *fakeObjectManager) SetDeleteStatefulPodError(err error, after int) {
om.deletePodTracker.err = err
om.deletePodTracker.after = after
}
func findPodByOrdinal(pods []*v1.Pod, ordinal int) *v1.Pod {
for _, pod := range pods {
if getOrdinal(pod) == ordinal {
return pod.DeepCopy()
}
}
return nil
}
func (om *fakeObjectManager) setPodPending(set *apps.StatefulSet, ordinal int) ([]*v1.Pod, error) {
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
return nil, err
}
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
return nil, err
}
pod := findPodByOrdinal(pods, ordinal)
if pod == nil {
return nil, fmt.Errorf("setPodPending: pod ordinal %d not found", ordinal)
}
pod.Status.Phase = v1.PodPending
fakeResourceVersion(pod)
om.podsIndexer.Update(pod)
return om.podsLister.Pods(set.Namespace).List(selector)
}
func (om *fakeObjectManager) setPodRunning(set *apps.StatefulSet, ordinal int) ([]*v1.Pod, error) {
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
return nil, err
}
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
return nil, err
}
pod := findPodByOrdinal(pods, ordinal)
if pod == nil {
return nil, fmt.Errorf("setPodRunning: pod ordinal %d not found", ordinal)
}
pod.Status.Phase = v1.PodRunning
fakeResourceVersion(pod)
om.podsIndexer.Update(pod)
return om.podsLister.Pods(set.Namespace).List(selector)
}
func (om *fakeObjectManager) setPodReady(set *apps.StatefulSet, ordinal int) ([]*v1.Pod, error) {
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
return nil, err
}
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
return nil, err
}
pod := findPodByOrdinal(pods, ordinal)
if pod == nil {
return nil, fmt.Errorf("setPodReady: pod ordinal %d not found", ordinal)
}
condition := v1.PodCondition{Type: v1.PodReady, Status: v1.ConditionTrue}
podutil.UpdatePodCondition(&pod.Status, &condition)
fakeResourceVersion(pod)
om.podsIndexer.Update(pod)
return om.podsLister.Pods(set.Namespace).List(selector)
}
func (om *fakeObjectManager) setPodAvailable(set *apps.StatefulSet, ordinal int, lastTransitionTime time.Time) ([]*v1.Pod, error) {
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
return nil, err
}
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
return nil, err
}
pod := findPodByOrdinal(pods, ordinal)
if pod == nil {
return nil, fmt.Errorf("setPodAvailable: pod ordinal %d not found", ordinal)
}
condition := v1.PodCondition{Type: v1.PodReady, Status: v1.ConditionTrue, LastTransitionTime: metav1.Time{Time: lastTransitionTime}}
_, existingCondition := podutil.GetPodCondition(&pod.Status, condition.Type)
if existingCondition != nil {
existingCondition.Status = v1.ConditionTrue
existingCondition.LastTransitionTime = metav1.Time{Time: lastTransitionTime}
} else {
existingCondition = &v1.PodCondition{
Type: v1.PodReady,
Status: v1.ConditionTrue,
LastTransitionTime: metav1.Time{Time: lastTransitionTime},
}
pod.Status.Conditions = append(pod.Status.Conditions, *existingCondition)
}
podutil.UpdatePodCondition(&pod.Status, &condition)
fakeResourceVersion(pod)
om.podsIndexer.Update(pod)
return om.podsLister.Pods(set.Namespace).List(selector)
}
func (om *fakeObjectManager) addTerminatingPod(set *apps.StatefulSet, ordinal int) ([]*v1.Pod, error) {
pod := newStatefulSetPod(set, ordinal)
pod.SetUID(types.UID(pod.Name + "-uid")) // To match fakeObjectManager.CreatePod
pod.Status.Phase = v1.PodRunning
deleted := metav1.NewTime(time.Now())
pod.DeletionTimestamp = &deleted
condition := v1.PodCondition{Type: v1.PodReady, Status: v1.ConditionTrue}
fakeResourceVersion(pod)
podutil.UpdatePodCondition(&pod.Status, &condition)
om.podsIndexer.Update(pod)
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
return nil, err
}
return om.podsLister.Pods(set.Namespace).List(selector)
}
func (om *fakeObjectManager) setPodTerminated(set *apps.StatefulSet, ordinal int) ([]*v1.Pod, error) {
pod := newStatefulSetPod(set, ordinal)
deleted := metav1.NewTime(time.Now())
pod.DeletionTimestamp = &deleted
fakeResourceVersion(pod)
om.podsIndexer.Update(pod)
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
return nil, err
}
return om.podsLister.Pods(set.Namespace).List(selector)
}
var _ StatefulPodControlObjectManager = &fakeObjectManager{}
type fakeStatefulSetStatusUpdater struct {
setsLister appslisters.StatefulSetLister
setsIndexer cache.Indexer
updateStatusTracker requestTracker
}
func newFakeStatefulSetStatusUpdater(setInformer appsinformers.StatefulSetInformer) *fakeStatefulSetStatusUpdater {
return &fakeStatefulSetStatusUpdater{
setInformer.Lister(),
setInformer.Informer().GetIndexer(),
requestTracker{0, nil, 0},
}
}
func (ssu *fakeStatefulSetStatusUpdater) UpdateStatefulSetStatus(ctx context.Context, set *apps.StatefulSet, status *apps.StatefulSetStatus) error {
defer ssu.updateStatusTracker.inc()
if ssu.updateStatusTracker.errorReady() {
defer ssu.updateStatusTracker.reset()
return ssu.updateStatusTracker.err
}
set.Status = *status
ssu.setsIndexer.Update(set)
return nil
}
func (ssu *fakeStatefulSetStatusUpdater) SetUpdateStatefulSetStatusError(err error, after int) {
ssu.updateStatusTracker.err = err
ssu.updateStatusTracker.after = after
}
var _ StatefulSetStatusUpdaterInterface = &fakeStatefulSetStatusUpdater{}
func assertMonotonicInvariants(set *apps.StatefulSet, om *fakeObjectManager) error {
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
return err
}
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
return err
}
sort.Sort(ascendingOrdinal(pods))
for idx := 0; idx < len(pods); idx++ {
if idx > 0 && isRunningAndReady(pods[idx]) && !isRunningAndReady(pods[idx-1]) {
return fmt.Errorf("successor %s is Running and Ready while %s is not", pods[idx].Name, pods[idx-1].Name)
}
if ord := idx + getStartOrdinal(set); getOrdinal(pods[idx]) != ord {
return fmt.Errorf("pods %s deployed in the wrong order %d", pods[idx].Name, ord)
}
if !storageMatches(set, pods[idx]) {
return fmt.Errorf("pods %s does not match the storage specification of StatefulSet %s ", pods[idx].Name, set.Name)
}
for _, claim := range getPersistentVolumeClaims(set, pods[idx]) {
claim, _ := om.claimsLister.PersistentVolumeClaims(set.Namespace).Get(claim.Name)
if err := checkClaimInvarients(set, pods[idx], claim); err != nil {
return err
}
}
if !identityMatches(set, pods[idx]) {
return fmt.Errorf("pods %s does not match the identity specification of StatefulSet %s ", pods[idx].Name, set.Name)
}
}
return nil
}
func assertBurstInvariants(set *apps.StatefulSet, om *fakeObjectManager) error {
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
return err
}
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
return err
}
sort.Sort(ascendingOrdinal(pods))
for _, pod := range pods {
if !storageMatches(set, pod) {
return fmt.Errorf("pods %s does not match the storage specification of StatefulSet %s ", pod.Name, set.Name)
}
for _, claim := range getPersistentVolumeClaims(set, pod) {
claim, err := om.claimsLister.PersistentVolumeClaims(set.Namespace).Get(claim.Name)
if err != nil {
return err
}
if err := checkClaimInvarients(set, pod, claim); err != nil {
return err
}
}
if !identityMatches(set, pod) {
return fmt.Errorf("pods %s does not match the identity specification of StatefulSet %s ",
pod.Name,
set.Name)
}
}
return nil
}
func assertUpdateInvariants(set *apps.StatefulSet, om *fakeObjectManager) error {
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
return err
}
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
return err
}
sort.Sort(ascendingOrdinal(pods))
for _, pod := range pods {
if !storageMatches(set, pod) {
return fmt.Errorf("pod %s does not match the storage specification of StatefulSet %s ", pod.Name, set.Name)
}
for _, claim := range getPersistentVolumeClaims(set, pod) {
claim, err := om.claimsLister.PersistentVolumeClaims(set.Namespace).Get(claim.Name)
if err != nil {
return err
}
if err := checkClaimInvarients(set, pod, claim); err != nil {
return err
}
}
if !identityMatches(set, pod) {
return fmt.Errorf("pod %s does not match the identity specification of StatefulSet %s ", pod.Name, set.Name)
}
}
if set.Spec.UpdateStrategy.Type == apps.OnDeleteStatefulSetStrategyType {
return nil
}
if set.Spec.UpdateStrategy.Type == apps.RollingUpdateStatefulSetStrategyType {
for i := 0; i < int(set.Status.CurrentReplicas) && i < len(pods); i++ {
if want, got := set.Status.CurrentRevision, getPodRevision(pods[i]); want != got {
return fmt.Errorf("pod %s want current revision %s got %s", pods[i].Name, want, got)
}
}
for i, j := len(pods)-1, 0; j < int(set.Status.UpdatedReplicas); i, j = i-1, j+1 {
if want, got := set.Status.UpdateRevision, getPodRevision(pods[i]); want != got {
return fmt.Errorf("pod %s want update revision %s got %s", pods[i].Name, want, got)
}
}
}
return nil
}
func checkClaimInvarients(set *apps.StatefulSet, pod *v1.Pod, claim *v1.PersistentVolumeClaim) error {
policy := apps.StatefulSetPersistentVolumeClaimRetentionPolicy{
WhenScaled: apps.RetainPersistentVolumeClaimRetentionPolicyType,
WhenDeleted: apps.RetainPersistentVolumeClaimRetentionPolicyType,
}
if set.Spec.PersistentVolumeClaimRetentionPolicy != nil && utilfeature.DefaultFeatureGate.Enabled(features.StatefulSetAutoDeletePVC) {
policy = *set.Spec.PersistentVolumeClaimRetentionPolicy
}
claimShouldBeRetained := policy.WhenScaled == apps.RetainPersistentVolumeClaimRetentionPolicyType
if claim == nil {
if claimShouldBeRetained {
return fmt.Errorf("claim for Pod %s was not created", pod.Name)
}
return nil // A non-retained claim has no invariants to satisfy.
}
if pod.Status.Phase != v1.PodRunning || !podutil.IsPodReady(pod) {
// The pod has spun up yet, we do not expect the owner refs on the claim to have been set.
return nil
}
const retain = apps.RetainPersistentVolumeClaimRetentionPolicyType
const delete = apps.DeletePersistentVolumeClaimRetentionPolicyType
switch {
case policy.WhenScaled == retain && policy.WhenDeleted == retain:
if hasOwnerRef(claim, set) {
return fmt.Errorf("claim %s has unexpected owner ref on %s for StatefulSet retain", claim.Name, set.Name)
}
if hasOwnerRef(claim, pod) {
return fmt.Errorf("claim %s has unexpected owner ref on pod %s for StatefulSet retain", claim.Name, pod.Name)
}
case policy.WhenScaled == retain && policy.WhenDeleted == delete:
if !hasOwnerRef(claim, set) {
return fmt.Errorf("claim %s does not have owner ref on %s for StatefulSet deletion", claim.Name, set.Name)
}
if hasOwnerRef(claim, pod) {
return fmt.Errorf("claim %s has unexpected owner ref on pod %s for StatefulSet deletion", claim.Name, pod.Name)
}
case policy.WhenScaled == delete && policy.WhenDeleted == retain:
if hasOwnerRef(claim, set) {
return fmt.Errorf("claim %s has unexpected owner ref on %s for scaledown only", claim.Name, set.Name)
}
if !podInOrdinalRange(pod, set) && !hasOwnerRef(claim, pod) {
return fmt.Errorf("claim %s does not have owner ref on condemned pod %s for scaledown delete", claim.Name, pod.Name)
}
if podInOrdinalRange(pod, set) && hasOwnerRef(claim, pod) {
return fmt.Errorf("claim %s has unexpected owner ref on condemned pod %s for scaledown delete", claim.Name, pod.Name)
}
case policy.WhenScaled == delete && policy.WhenDeleted == delete:
if !podInOrdinalRange(pod, set) {
if !hasOwnerRef(claim, pod) || hasOwnerRef(claim, set) {
return fmt.Errorf("condemned claim %s has bad owner refs: %v", claim.Name, claim.GetOwnerReferences())
}
} else {
if hasOwnerRef(claim, pod) || !hasOwnerRef(claim, set) {
return fmt.Errorf("live claim %s has bad owner refs: %v", claim.Name, claim.GetOwnerReferences())
}
}
}
return nil
}
func fakeResourceVersion(object interface{}) {
obj, isObj := object.(metav1.Object)
if !isObj {
return
}
if version := obj.GetResourceVersion(); version == "" {
obj.SetResourceVersion("1")
} else if intValue, err := strconv.ParseInt(version, 10, 32); err == nil {
obj.SetResourceVersion(strconv.FormatInt(intValue+1, 10))
}
}
func scaleUpStatefulSetControl(set *apps.StatefulSet,
ssc StatefulSetControlInterface,
om *fakeObjectManager,
invariants invariantFunc) error {
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
return err
}
for set.Status.ReadyReplicas < *set.Spec.Replicas {
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
return err
}
sort.Sort(ascendingOrdinal(pods))
// ensure all pods are valid (have a phase)
for _, pod := range pods {
if pod.Status.Phase == "" {
if pods, err = om.setPodPending(set, getOrdinal(pod)); err != nil {
return err
}
break
}
}
// select one of the pods and move it forward in status
if len(pods) > 0 {
idx := int(rand.Int63n(int64(len(pods))))
pod := pods[idx]
switch pod.Status.Phase {
case v1.PodPending:
if pods, err = om.setPodRunning(set, getOrdinal(pod)); err != nil {
return err
}
case v1.PodRunning:
if pods, err = om.setPodReady(set, getOrdinal(pod)); err != nil {
return err
}
default:
continue
}
}
// run the controller once and check invariants
_, err = ssc.UpdateStatefulSet(context.TODO(), set, pods)
if err != nil {
return err
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
return err
}
if err := invariants(set, om); err != nil {
return err
}
}
return invariants(set, om)
}
func scaleDownStatefulSetControl(set *apps.StatefulSet, ssc StatefulSetControlInterface, om *fakeObjectManager, invariants invariantFunc) error {
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
return err
}
for set.Status.Replicas > *set.Spec.Replicas {
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
return err
}
sort.Sort(ascendingOrdinal(pods))
if idx := len(pods) - 1; idx >= 0 {
if _, err := ssc.UpdateStatefulSet(context.TODO(), set, pods); err != nil {
return err
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
return err
}
if pods, err = om.addTerminatingPod(set, getOrdinal(pods[idx])); err != nil {
return err
}
if _, err = ssc.UpdateStatefulSet(context.TODO(), set, pods); err != nil {
return err
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
return err
}
pods, err = om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
return err
}
sort.Sort(ascendingOrdinal(pods))
if len(pods) > 0 {
om.podsIndexer.Delete(pods[len(pods)-1])
}
}
if _, err := ssc.UpdateStatefulSet(context.TODO(), set, pods); err != nil {
return err
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
return err
}
if err := invariants(set, om); err != nil {
return err
}
}
// If there are claims with ownerRefs on pods that have been deleted, delete them.
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
return err
}
currentPods := map[string]bool{}
for _, pod := range pods {
currentPods[pod.Name] = true
}
claims, err := om.claimsLister.PersistentVolumeClaims(set.Namespace).List(selector)
if err != nil {
return err
}
for _, claim := range claims {
claimPodName := getClaimPodName(set, claim)
if claimPodName == "" {
continue // Skip claims not related to a stateful set pod.
}
if _, found := currentPods[claimPodName]; found {
continue // Skip claims which still have a current pod.
}
for _, refs := range claim.GetOwnerReferences() {
if refs.Name == claimPodName {
om.claimsIndexer.Delete(claim)
break
}
}
}
return invariants(set, om)
}
func updateComplete(set *apps.StatefulSet, pods []*v1.Pod) bool {
sort.Sort(ascendingOrdinal(pods))
if len(pods) != int(*set.Spec.Replicas) {
return false
}
if set.Status.ReadyReplicas != *set.Spec.Replicas {
return false
}
switch set.Spec.UpdateStrategy.Type {
case apps.OnDeleteStatefulSetStrategyType:
return true
case apps.RollingUpdateStatefulSetStrategyType:
if set.Spec.UpdateStrategy.RollingUpdate == nil || *set.Spec.UpdateStrategy.RollingUpdate.Partition <= 0 {
if set.Status.CurrentReplicas < *set.Spec.Replicas {
return false
}
for i := range pods {
if getPodRevision(pods[i]) != set.Status.CurrentRevision {
return false
}
}
} else {
partition := int(*set.Spec.UpdateStrategy.RollingUpdate.Partition)
if len(pods) < partition {
return false
}
for i := partition; i < len(pods); i++ {
if getPodRevision(pods[i]) != set.Status.UpdateRevision {
return false
}
}
}
}
return true
}
func updateStatefulSetControl(set *apps.StatefulSet,
ssc StatefulSetControlInterface,
om *fakeObjectManager,
invariants invariantFunc) error {
selector, err := metav1.LabelSelectorAsSelector(set.Spec.Selector)
if err != nil {
return err
}
pods, err := om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
return err
}
if _, err = ssc.UpdateStatefulSet(context.TODO(), set, pods); err != nil {
return err
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
return err
}
pods, err = om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
return err
}
for !updateComplete(set, pods) {
pods, err = om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
return err
}
sort.Sort(ascendingOrdinal(pods))
initialized := false
for _, pod := range pods {
if pod.Status.Phase == "" {
if pods, err = om.setPodPending(set, getOrdinal(pod)); err != nil {
return err
}
break
}
}
if initialized {
continue
}
if len(pods) > 0 {
idx := int(rand.Int63n(int64(len(pods))))
pod := pods[idx]
switch pod.Status.Phase {
case v1.PodPending:
if pods, err = om.setPodRunning(set, getOrdinal(pod)); err != nil {
return err
}
case v1.PodRunning:
if pods, err = om.setPodReady(set, getOrdinal(pod)); err != nil {
return err
}
default:
continue
}
}
if _, err = ssc.UpdateStatefulSet(context.TODO(), set, pods); err != nil {
return err
}
set, err = om.setsLister.StatefulSets(set.Namespace).Get(set.Name)
if err != nil {
return err
}
if err := invariants(set, om); err != nil {
return err
}
pods, err = om.podsLister.Pods(set.Namespace).List(selector)
if err != nil {
return err
}
}
return invariants(set, om)
}
func newRevisionOrDie(set *apps.StatefulSet, revision int64) *apps.ControllerRevision {
rev, err := newRevision(set, revision, set.Status.CollisionCount)
if err != nil {
panic(err)
}
return rev
}
func isOrHasInternalError(err error) bool {
agg, ok := err.(utilerrors.Aggregate)
return !ok && !apierrors.IsInternalError(err) || ok && len(agg.Errors()) > 0 && !apierrors.IsInternalError(agg.Errors()[0])
}
Reference in New Issue View Git Blame Copy Permalink