37761a329e
The changes (mostly in pkg/kubelet/cm) are there to adopt changed
runc 1.1 API, and simplify things a bit. In particular:
1. simplify cgroup manager instantiation, using a new, easier way of
libcontainers/cgroups/manager.New;
2. replace libcontainerAdapter with a boolean variable (all it did
was passing on whether systemd manager should be used);
3. trivial change due to removed cgroupfs.HugePageSizes and added
cgroups.HugePageSizes();
4. do not calculate cgroup paths in update / destroy, since libcontainer
cgroup managers now calculate the paths upon creation (previously,
they were doing that only in Apply, so using e.g. Set or Destroy right
after creation was impossible without specifying paths).
We currently still calculate cgroup paths in Exists -- this is to be
addressed separately.
Co-Authored-By: Elana Hashman <ehashman@redhat.com>
129 lines
3.8 KiB
Go
129 lines
3.8 KiB
Go
//go:build linux
|
|
// +build linux
|
|
|
|
/*
|
|
Copyright 2016 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package cm
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
v1 "k8s.io/api/core/v1"
|
|
"k8s.io/apimachinery/pkg/types"
|
|
)
|
|
|
|
func TestIsCgroupPod(t *testing.T) {
|
|
qosContainersInfo := QOSContainersInfo{
|
|
Guaranteed: RootCgroupName,
|
|
Burstable: NewCgroupName(RootCgroupName, strings.ToLower(string(v1.PodQOSBurstable))),
|
|
BestEffort: NewCgroupName(RootCgroupName, strings.ToLower(string(v1.PodQOSBestEffort))),
|
|
}
|
|
podUID := types.UID("123")
|
|
testCases := []struct {
|
|
input CgroupName
|
|
expectedResult bool
|
|
expectedUID types.UID
|
|
}{
|
|
{
|
|
input: RootCgroupName,
|
|
expectedResult: false,
|
|
expectedUID: types.UID(""),
|
|
},
|
|
{
|
|
input: NewCgroupName(qosContainersInfo.Guaranteed),
|
|
expectedResult: false,
|
|
expectedUID: types.UID(""),
|
|
},
|
|
{
|
|
input: NewCgroupName(qosContainersInfo.Guaranteed, GetPodCgroupNameSuffix(podUID)),
|
|
expectedResult: true,
|
|
expectedUID: podUID,
|
|
},
|
|
{
|
|
input: NewCgroupName(qosContainersInfo.Guaranteed, GetPodCgroupNameSuffix(podUID), "container.scope"),
|
|
expectedResult: false,
|
|
expectedUID: types.UID(""),
|
|
},
|
|
{
|
|
input: NewCgroupName(qosContainersInfo.Burstable),
|
|
expectedResult: false,
|
|
expectedUID: types.UID(""),
|
|
},
|
|
{
|
|
input: NewCgroupName(qosContainersInfo.Burstable, GetPodCgroupNameSuffix(podUID)),
|
|
expectedResult: true,
|
|
expectedUID: podUID,
|
|
},
|
|
{
|
|
input: NewCgroupName(qosContainersInfo.Burstable, GetPodCgroupNameSuffix(podUID), "container.scope"),
|
|
expectedResult: false,
|
|
expectedUID: types.UID(""),
|
|
},
|
|
{
|
|
input: NewCgroupName(qosContainersInfo.BestEffort),
|
|
expectedResult: false,
|
|
expectedUID: types.UID(""),
|
|
},
|
|
{
|
|
input: NewCgroupName(qosContainersInfo.BestEffort, GetPodCgroupNameSuffix(podUID)),
|
|
expectedResult: true,
|
|
expectedUID: podUID,
|
|
},
|
|
{
|
|
input: NewCgroupName(qosContainersInfo.BestEffort, GetPodCgroupNameSuffix(podUID), "container.scope"),
|
|
expectedResult: false,
|
|
expectedUID: types.UID(""),
|
|
},
|
|
{
|
|
input: NewCgroupName(RootCgroupName, "system"),
|
|
expectedResult: false,
|
|
expectedUID: types.UID(""),
|
|
},
|
|
{
|
|
input: NewCgroupName(RootCgroupName, "system", "kubelet"),
|
|
expectedResult: false,
|
|
expectedUID: types.UID(""),
|
|
},
|
|
}
|
|
for _, cgroupDriver := range []string{"cgroupfs", "systemd"} {
|
|
pcm := &podContainerManagerImpl{
|
|
cgroupManager: NewCgroupManager(nil, cgroupDriver),
|
|
enforceCPULimits: true,
|
|
qosContainersInfo: qosContainersInfo,
|
|
}
|
|
for _, testCase := range testCases {
|
|
// Give the right cgroup structure based on whether systemd is enabled.
|
|
var name string
|
|
if cgroupDriver == "systemd" {
|
|
name = testCase.input.ToSystemd()
|
|
} else {
|
|
name = testCase.input.ToCgroupfs()
|
|
}
|
|
// check if this is a pod or not with the literal cgroupfs input
|
|
result, resultUID := pcm.IsPodCgroup(name)
|
|
if result != testCase.expectedResult {
|
|
t.Errorf("Unexpected result for driver: %v, input: %v, expected: %v, actual: %v", cgroupDriver, testCase.input, testCase.expectedResult, result)
|
|
}
|
|
if resultUID != testCase.expectedUID {
|
|
t.Errorf("Unexpected result for driver: %v, input: %v, expected: %v, actual: %v", cgroupDriver, testCase.input, testCase.expectedUID, resultUID)
|
|
}
|
|
|
|
}
|
|
}
|
|
}
|