380c7f248e
This change will leverage the new PreFilterResult to reduce down the list of eligible nodes for pod using Bound Local PVs during PreFilter stage so that only the node(s) which local PV node affinity matches will be cosnidered in subsequent scheduling stages. Today, the NodeAffinity check is done during Filter which means all nodes will be considered even though there may be a large number of nodes that are not eligible due to not matching the pod's bound local PV(s)' node affinity requirement. Here we can reduce down the node list in PreFilter to ensure that during Filter we are only considering the reduced list and thus can provide a more clear message to users when node(s) are not available for scheduling since the list only contains relevant nodes. If error is encountered (e.g. PV cache read error) or if node list reduction cannot be done (e.g. pod uses no local PVs), then we will still proceed to consider all nodes for the rest of scheduling stages. Signed-off-by: Yibo Zhuang <yibzhuang@gmail.com>
81 lines
2.7 KiB
Go
81 lines
2.7 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package volumebinding
|
|
|
|
import (
|
|
"context"
|
|
|
|
v1 "k8s.io/api/core/v1"
|
|
"k8s.io/apimachinery/pkg/util/sets"
|
|
)
|
|
|
|
// FakeVolumeBinderConfig holds configurations for fake volume binder.
|
|
type FakeVolumeBinderConfig struct {
|
|
AllBound bool
|
|
FindReasons ConflictReasons
|
|
FindErr error
|
|
AssumeErr error
|
|
BindErr error
|
|
}
|
|
|
|
// NewFakeVolumeBinder sets up all the caches needed for the scheduler to make
|
|
// topology-aware volume binding decisions.
|
|
func NewFakeVolumeBinder(config *FakeVolumeBinderConfig) *FakeVolumeBinder {
|
|
return &FakeVolumeBinder{
|
|
config: config,
|
|
}
|
|
}
|
|
|
|
// FakeVolumeBinder represents a fake volume binder for testing.
|
|
type FakeVolumeBinder struct {
|
|
config *FakeVolumeBinderConfig
|
|
AssumeCalled bool
|
|
BindCalled bool
|
|
}
|
|
|
|
var _ SchedulerVolumeBinder = &FakeVolumeBinder{}
|
|
|
|
// GetPodVolumes implements SchedulerVolumeBinder.GetPodVolumes.
|
|
func (b *FakeVolumeBinder) GetPodVolumes(pod *v1.Pod) (boundClaims, unboundClaimsDelayBinding, unboundClaimsImmediate []*v1.PersistentVolumeClaim, err error) {
|
|
return nil, nil, nil, nil
|
|
}
|
|
|
|
// GetEligibleNodes implements SchedulerVolumeBinder.GetEligibleNodes.
|
|
func (b *FakeVolumeBinder) GetEligibleNodes(boundClaims []*v1.PersistentVolumeClaim) (eligibleNodes sets.String) {
|
|
return nil
|
|
}
|
|
|
|
// FindPodVolumes implements SchedulerVolumeBinder.FindPodVolumes.
|
|
func (b *FakeVolumeBinder) FindPodVolumes(pod *v1.Pod, _, _ []*v1.PersistentVolumeClaim, node *v1.Node) (podVolumes *PodVolumes, reasons ConflictReasons, err error) {
|
|
return nil, b.config.FindReasons, b.config.FindErr
|
|
}
|
|
|
|
// AssumePodVolumes implements SchedulerVolumeBinder.AssumePodVolumes.
|
|
func (b *FakeVolumeBinder) AssumePodVolumes(assumedPod *v1.Pod, nodeName string, podVolumes *PodVolumes) (bool, error) {
|
|
b.AssumeCalled = true
|
|
return b.config.AllBound, b.config.AssumeErr
|
|
}
|
|
|
|
// RevertAssumedPodVolumes implements SchedulerVolumeBinder.RevertAssumedPodVolumes
|
|
func (b *FakeVolumeBinder) RevertAssumedPodVolumes(_ *PodVolumes) {}
|
|
|
|
// BindPodVolumes implements SchedulerVolumeBinder.BindPodVolumes.
|
|
func (b *FakeVolumeBinder) BindPodVolumes(ctx context.Context, assumedPod *v1.Pod, podVolumes *PodVolumes) error {
|
|
b.BindCalled = true
|
|
return b.config.BindErr
|
|
}
|