54195d590f
We had another bug where we confused the hostname with the NodeName. To avoid this happening again, and to make the code more self-documenting, we use types.NodeName (a typedef alias for string) whenever we are referring to the Node.Name. A tedious but mechanical commit therefore, to change all uses of the node name to use types.NodeName Also clean up some of the (many) places where the NodeName is referred to as a hostname (not true on AWS), or an instanceID (not true on GCE), etc.
356 lines
10 KiB
Go
356 lines
10 KiB
Go
/*
|
|
Copyright 2014 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package config
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
"time"
|
|
|
|
"k8s.io/kubernetes/pkg/api"
|
|
"k8s.io/kubernetes/pkg/api/testapi"
|
|
"k8s.io/kubernetes/pkg/api/unversioned"
|
|
"k8s.io/kubernetes/pkg/api/validation"
|
|
kubetypes "k8s.io/kubernetes/pkg/kubelet/types"
|
|
"k8s.io/kubernetes/pkg/runtime"
|
|
"k8s.io/kubernetes/pkg/types"
|
|
utiltesting "k8s.io/kubernetes/pkg/util/testing"
|
|
)
|
|
|
|
func TestURLErrorNotExistNoUpdate(t *testing.T) {
|
|
ch := make(chan interface{})
|
|
NewSourceURL("http://localhost:49575/_not_found_", http.Header{}, "localhost", time.Millisecond, ch)
|
|
select {
|
|
case got := <-ch:
|
|
t.Errorf("Expected no update, Got %#v", got)
|
|
case <-time.After(2 * time.Millisecond):
|
|
}
|
|
}
|
|
|
|
func TestExtractFromHttpBadness(t *testing.T) {
|
|
ch := make(chan interface{}, 1)
|
|
c := sourceURL{"http://localhost:49575/_not_found_", http.Header{}, "other", ch, nil, 0, http.DefaultClient}
|
|
if err := c.extractFromURL(); err == nil {
|
|
t.Errorf("Expected error")
|
|
}
|
|
expectEmptyChannel(t, ch)
|
|
}
|
|
|
|
func TestExtractInvalidPods(t *testing.T) {
|
|
var testCases = []struct {
|
|
desc string
|
|
pod *api.Pod
|
|
}{
|
|
{
|
|
desc: "No version",
|
|
pod: &api.Pod{TypeMeta: unversioned.TypeMeta{APIVersion: ""}},
|
|
},
|
|
{
|
|
desc: "Invalid version",
|
|
pod: &api.Pod{TypeMeta: unversioned.TypeMeta{APIVersion: "v1betta2"}},
|
|
},
|
|
{
|
|
desc: "Invalid volume name",
|
|
pod: &api.Pod{
|
|
TypeMeta: unversioned.TypeMeta{APIVersion: testapi.Default.GroupVersion().String()},
|
|
Spec: api.PodSpec{
|
|
Volumes: []api.Volume{{Name: "_INVALID_"}},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
desc: "Duplicate volume names",
|
|
pod: &api.Pod{
|
|
TypeMeta: unversioned.TypeMeta{APIVersion: testapi.Default.GroupVersion().String()},
|
|
Spec: api.PodSpec{
|
|
Volumes: []api.Volume{{Name: "repeated"}, {Name: "repeated"}},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
desc: "Unspecified container name",
|
|
pod: &api.Pod{
|
|
TypeMeta: unversioned.TypeMeta{APIVersion: testapi.Default.GroupVersion().String()},
|
|
Spec: api.PodSpec{
|
|
Containers: []api.Container{{Name: ""}},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
desc: "Invalid container name",
|
|
pod: &api.Pod{
|
|
TypeMeta: unversioned.TypeMeta{APIVersion: testapi.Default.GroupVersion().String()},
|
|
Spec: api.PodSpec{
|
|
Containers: []api.Container{{Name: "_INVALID_"}},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
for _, testCase := range testCases {
|
|
data, err := json.Marshal(testCase.pod)
|
|
if err != nil {
|
|
t.Fatalf("%s: Some weird json problem: %v", testCase.desc, err)
|
|
}
|
|
fakeHandler := utiltesting.FakeHandler{
|
|
StatusCode: 200,
|
|
ResponseBody: string(data),
|
|
}
|
|
testServer := httptest.NewServer(&fakeHandler)
|
|
defer testServer.Close()
|
|
ch := make(chan interface{}, 1)
|
|
c := sourceURL{testServer.URL, http.Header{}, "localhost", ch, nil, 0, http.DefaultClient}
|
|
if err := c.extractFromURL(); err == nil {
|
|
t.Errorf("%s: Expected error", testCase.desc)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestExtractPodsFromHTTP(t *testing.T) {
|
|
nodeName := "different-value"
|
|
|
|
grace := int64(30)
|
|
var testCases = []struct {
|
|
desc string
|
|
pods runtime.Object
|
|
expected kubetypes.PodUpdate
|
|
}{
|
|
{
|
|
desc: "Single pod",
|
|
pods: &api.Pod{
|
|
TypeMeta: unversioned.TypeMeta{
|
|
Kind: "Pod",
|
|
APIVersion: "",
|
|
},
|
|
ObjectMeta: api.ObjectMeta{
|
|
Name: "foo",
|
|
UID: "111",
|
|
Namespace: "mynamespace",
|
|
},
|
|
Spec: api.PodSpec{
|
|
NodeName: string(nodeName),
|
|
Containers: []api.Container{{Name: "1", Image: "foo", ImagePullPolicy: api.PullAlways}},
|
|
SecurityContext: &api.PodSecurityContext{},
|
|
},
|
|
Status: api.PodStatus{
|
|
Phase: api.PodPending,
|
|
},
|
|
},
|
|
expected: CreatePodUpdate(kubetypes.SET,
|
|
kubetypes.HTTPSource,
|
|
&api.Pod{
|
|
ObjectMeta: api.ObjectMeta{
|
|
UID: "111",
|
|
Name: "foo" + "-" + nodeName,
|
|
Namespace: "mynamespace",
|
|
Annotations: map[string]string{kubetypes.ConfigHashAnnotationKey: "111"},
|
|
SelfLink: getSelfLink("foo-"+nodeName, "mynamespace"),
|
|
},
|
|
Spec: api.PodSpec{
|
|
NodeName: nodeName,
|
|
RestartPolicy: api.RestartPolicyAlways,
|
|
DNSPolicy: api.DNSClusterFirst,
|
|
SecurityContext: &api.PodSecurityContext{},
|
|
TerminationGracePeriodSeconds: &grace,
|
|
|
|
Containers: []api.Container{{
|
|
Name: "1",
|
|
Image: "foo",
|
|
TerminationMessagePath: "/dev/termination-log",
|
|
ImagePullPolicy: "Always",
|
|
}},
|
|
},
|
|
Status: api.PodStatus{
|
|
Phase: api.PodPending,
|
|
},
|
|
}),
|
|
},
|
|
{
|
|
desc: "Multiple pods",
|
|
pods: &api.PodList{
|
|
TypeMeta: unversioned.TypeMeta{
|
|
Kind: "PodList",
|
|
APIVersion: "",
|
|
},
|
|
Items: []api.Pod{
|
|
{
|
|
ObjectMeta: api.ObjectMeta{
|
|
Name: "foo",
|
|
UID: "111",
|
|
},
|
|
Spec: api.PodSpec{
|
|
NodeName: nodeName,
|
|
Containers: []api.Container{{Name: "1", Image: "foo", ImagePullPolicy: api.PullAlways}},
|
|
SecurityContext: &api.PodSecurityContext{},
|
|
},
|
|
Status: api.PodStatus{
|
|
Phase: api.PodPending,
|
|
},
|
|
},
|
|
{
|
|
ObjectMeta: api.ObjectMeta{
|
|
Name: "bar",
|
|
UID: "222",
|
|
},
|
|
Spec: api.PodSpec{
|
|
NodeName: nodeName,
|
|
Containers: []api.Container{{Name: "2", Image: "bar:bartag", ImagePullPolicy: ""}},
|
|
SecurityContext: &api.PodSecurityContext{},
|
|
},
|
|
Status: api.PodStatus{
|
|
Phase: api.PodPending,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
expected: CreatePodUpdate(kubetypes.SET,
|
|
kubetypes.HTTPSource,
|
|
&api.Pod{
|
|
ObjectMeta: api.ObjectMeta{
|
|
UID: "111",
|
|
Name: "foo" + "-" + nodeName,
|
|
Namespace: "default",
|
|
Annotations: map[string]string{kubetypes.ConfigHashAnnotationKey: "111"},
|
|
SelfLink: getSelfLink("foo-"+nodeName, kubetypes.NamespaceDefault),
|
|
},
|
|
Spec: api.PodSpec{
|
|
NodeName: nodeName,
|
|
RestartPolicy: api.RestartPolicyAlways,
|
|
DNSPolicy: api.DNSClusterFirst,
|
|
TerminationGracePeriodSeconds: &grace,
|
|
SecurityContext: &api.PodSecurityContext{},
|
|
|
|
Containers: []api.Container{{
|
|
Name: "1",
|
|
Image: "foo",
|
|
TerminationMessagePath: "/dev/termination-log",
|
|
ImagePullPolicy: "Always",
|
|
}},
|
|
},
|
|
Status: api.PodStatus{
|
|
Phase: api.PodPending,
|
|
},
|
|
},
|
|
&api.Pod{
|
|
ObjectMeta: api.ObjectMeta{
|
|
UID: "222",
|
|
Name: "bar" + "-" + nodeName,
|
|
Namespace: "default",
|
|
Annotations: map[string]string{kubetypes.ConfigHashAnnotationKey: "222"},
|
|
SelfLink: getSelfLink("bar-"+nodeName, kubetypes.NamespaceDefault),
|
|
},
|
|
Spec: api.PodSpec{
|
|
NodeName: nodeName,
|
|
RestartPolicy: api.RestartPolicyAlways,
|
|
DNSPolicy: api.DNSClusterFirst,
|
|
TerminationGracePeriodSeconds: &grace,
|
|
SecurityContext: &api.PodSecurityContext{},
|
|
|
|
Containers: []api.Container{{
|
|
Name: "2",
|
|
Image: "bar:bartag",
|
|
TerminationMessagePath: "/dev/termination-log",
|
|
ImagePullPolicy: "IfNotPresent",
|
|
}},
|
|
},
|
|
Status: api.PodStatus{
|
|
Phase: api.PodPending,
|
|
},
|
|
}),
|
|
},
|
|
}
|
|
|
|
for _, testCase := range testCases {
|
|
var versionedPods runtime.Object
|
|
err := testapi.Default.Converter().Convert(&testCase.pods, &versionedPods, nil)
|
|
if err != nil {
|
|
t.Fatalf("%s: error in versioning the pods: %s", testCase.desc, err)
|
|
}
|
|
data, err := runtime.Encode(testapi.Default.Codec(), versionedPods)
|
|
if err != nil {
|
|
t.Fatalf("%s: error in encoding the pod: %v", testCase.desc, err)
|
|
}
|
|
fakeHandler := utiltesting.FakeHandler{
|
|
StatusCode: 200,
|
|
ResponseBody: string(data),
|
|
}
|
|
testServer := httptest.NewServer(&fakeHandler)
|
|
defer testServer.Close()
|
|
ch := make(chan interface{}, 1)
|
|
c := sourceURL{testServer.URL, http.Header{}, types.NodeName(nodeName), ch, nil, 0, http.DefaultClient}
|
|
if err := c.extractFromURL(); err != nil {
|
|
t.Errorf("%s: Unexpected error: %v", testCase.desc, err)
|
|
continue
|
|
}
|
|
update := (<-ch).(kubetypes.PodUpdate)
|
|
|
|
if !api.Semantic.DeepEqual(testCase.expected, update) {
|
|
t.Errorf("%s: Expected: %#v, Got: %#v", testCase.desc, testCase.expected, update)
|
|
}
|
|
for _, pod := range update.Pods {
|
|
if errs := validation.ValidatePod(pod); len(errs) != 0 {
|
|
t.Errorf("%s: Expected no validation errors on %#v, Got %v", testCase.desc, pod, errs.ToAggregate())
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestURLWithHeader(t *testing.T) {
|
|
pod := &api.Pod{
|
|
TypeMeta: unversioned.TypeMeta{
|
|
APIVersion: testapi.Default.GroupVersion().String(),
|
|
Kind: "Pod",
|
|
},
|
|
ObjectMeta: api.ObjectMeta{
|
|
Name: "foo",
|
|
UID: "111",
|
|
Namespace: "mynamespace",
|
|
},
|
|
Spec: api.PodSpec{
|
|
NodeName: "localhost",
|
|
Containers: []api.Container{{Name: "1", Image: "foo", ImagePullPolicy: api.PullAlways}},
|
|
},
|
|
}
|
|
data, err := json.Marshal(pod)
|
|
if err != nil {
|
|
t.Fatalf("Unexpected json marshalling error: %v", err)
|
|
}
|
|
fakeHandler := utiltesting.FakeHandler{
|
|
StatusCode: 200,
|
|
ResponseBody: string(data),
|
|
}
|
|
testServer := httptest.NewServer(&fakeHandler)
|
|
defer testServer.Close()
|
|
ch := make(chan interface{}, 1)
|
|
header := make(http.Header)
|
|
header.Set("Metadata-Flavor", "Google")
|
|
c := sourceURL{testServer.URL, header, "localhost", ch, nil, 0, http.DefaultClient}
|
|
if err := c.extractFromURL(); err != nil {
|
|
t.Fatalf("Unexpected error extracting from URL: %v", err)
|
|
}
|
|
update := (<-ch).(kubetypes.PodUpdate)
|
|
|
|
headerVal := fakeHandler.RequestReceived.Header["Metadata-Flavor"]
|
|
if len(headerVal) != 1 || headerVal[0] != "Google" {
|
|
t.Errorf("Header missing expected entry %v. Got %v", header, fakeHandler.RequestReceived.Header)
|
|
}
|
|
if len(update.Pods) != 1 {
|
|
t.Errorf("Received wrong number of pods, expected one: %v", update.Pods)
|
|
}
|
|
}
|