kubernetes/hack/make-rules
Kubernetes Submit Queue 3ef674188d
Merge pull request #56864 from juanvallejo/jvallejo/add-selector-kubectl-drain
Automatic merge from submit-queue (batch tested with PRs 55751, 57337, 56406, 56864, 57347). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add pod-selector kubectl drain

**Release note**:
```release-note
Added the ability to select pods in a chosen node to be drained, based on given pod label-selector
```

This patch adds the ability to select pods in a chosen node to be drained, based on given pod label-selector. Related downstream issue: https://github.com/openshift/origin/issues/17554

Further, it removes explicit, specific, pod-controller check. The `drain` command currently fails if a pod has a controller of a `kind` [not explicitly handled in the command itself](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/cmd/drain.go#L331). This causes `drain` to be unusable if a node contains pods managed by third-party, or "unknown" controllers.

Based on [this comment](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/cmd/drain.go#L353), the expectation was to fail if a pod's controller was not found for whatever reason. I believe that the `drain` command should not care about the existence of a pod controller. It should only care whether a pod has one, and act according to that controller kind. This solves a downstream bug: https://github.com/openshift/origin/issues/17563

cc @fabianofranz @deads2k @kubernetes/sig-cli-misc
2017-12-18 18:50:45 -08:00
..
helpers Add sample CustomResourceDefinition controller 2017-10-19 00:21:57 +01:00
BUILD Remove all traces of federation 2017-10-26 13:37:37 -07:00
build.sh Add a verbosity concept to kubernetes scripts 2016-08-04 22:01:22 -07:00
clean.sh Move make clean to a static list 2017-09-29 12:36:18 -07:00
cross.sh Add a KUBERNETES_NODE_* section to build kubelet/kube-proxy for windows 2016-12-17 21:07:18 -08:00
make-help.sh Remove all traces of federation 2017-10-26 13:37:37 -07:00
test-cmd-util.sh Merge pull request #56864 from juanvallejo/jvallejo/add-selector-kubectl-drain 2017-12-18 18:50:45 -08:00
test-cmd.sh *: remove --insecure-allow-any-token option 2017-07-18 16:03:15 -07:00
test-e2e-node.sh Switch away from gcloud deprecated flags in compute resource listings 2017-08-30 06:41:09 +01:00
test-integration.sh Remove all traces of federation 2017-10-26 13:37:37 -07:00
test-kubeadm-cmd.sh kubeadm: updated cmd tests as discussed in SIG 2017-02-07 12:47:07 -08:00
test.sh Remove all traces of federation 2017-10-26 13:37:37 -07:00
verify.sh make quick-verify: make the output a bit more readable by showing script names without full paths. 2017-11-21 19:12:26 +01:00
vet.sh Merge pull request #46923 from dims/nuke-wrapper-go-flags 2017-06-22 20:26:29 -07:00