Kubernetes Submit Queue 850a75fe13 Merge pull request #47675 from alexandercampbell/refactor-long-kubectl-function ...

Automatic merge from submit-queue (batch tested with PRs 47675, 48001)

cmd/create_deployment: refactor long function

Refactor the `createDeployment` function under `pkg/kubectl/cmd`.

- [x] Behavior has been extracted to two helper functions.
- [x] Behavior remains identical.
- [x] Logic has been made explicit through function naming and comments.

This is essentially the pattern I've been following in my larger branches (the ones that are pending the merge of #46468). Want to get some design feedback before I get too far away from `master`.

Thanks!

cc @apelisse @mengqiy @droot 

**Release note**:

```release-note
NONE
```

2017-06-27 16:11:03 -07:00

..

auth

This change add nonResourceURL to kubectl auth cani

2017-05-31 11:25:29 +08:00

config

Get cmd uses print-column extn from Openapi schema

2017-06-06 13:30:24 -07:00

rollout

fix --local flag for kubectl set commands

2017-06-13 12:57:05 -04:00

set

fix --local flag for kubectl set commands

2017-06-13 12:57:05 -04:00

templates

Introduce visibility rules to kubernetes code.

2017-05-15 12:50:56 -07:00

testdata/edit

support setElementOrder

2017-05-31 15:08:25 -07:00

testing

fix --local flag for kubectl set commands

2017-06-13 12:57:05 -04:00

util

run hack/update-all

2017-06-22 11:31:03 -07:00

alpha.go

Create a kubectl alpha subcommand

2017-06-16 07:09:21 +00:00

annotate_test.go

kubectl/cmd: remove a bunch of unused parameters

2017-04-04 10:36:30 +01:00

annotate.go

fix --local flag for kubectl set commands

2017-06-13 12:57:05 -04:00

apiversions.go

Fix kubectl api-versions caching

2017-06-24 01:14:31 -04:00

apply_edit_last_applied.go

kubectl: fix inaccurate usage messages for --windows-line-endings

2017-06-23 09:49:30 -07:00

apply_set_last_applied.go

kubectl: simplify code with help of linter

2017-06-23 09:49:30 -07:00

apply_test.go

Merge pull request #46388 from lavalamp/whitlockjc-generic-webhook-admission

2017-06-02 23:37:42 -07:00

apply_view_last_applied.go

fix --local flag for kubectl set commands

2017-06-13 12:57:05 -04:00

apply.go

Merge pull request #45918 from juanvallejo/jvallejo/fix-kubectl-set-resources-local

2017-06-16 08:19:13 -07:00

attach_test.go

clean up: put test description in head to locate quickly

2017-05-19 02:04:59 +08:00

attach.go

fix --local flag for kubectl set commands

2017-06-13 12:57:05 -04:00

autoscale.go

fix --local flag for kubectl set commands

2017-06-13 12:57:05 -04:00

BUILD

Merge pull request #47471 from crimsonfaith91/drain

2017-06-23 05:08:30 -07:00

certificates.go

fix --local flag for kubectl set commands

2017-06-13 12:57:05 -04:00

clusterinfo_dump_test.go

Move the common test functions from cmd_test.go to cmd/testing/fake.go

2016-10-19 08:53:26 +10:00

clusterinfo_dump.go

Merge pull request #43062 from mkumatag/genfed

2017-06-23 12:30:25 -07:00

clusterinfo.go

fix --local flag for kubectl set commands

2017-06-13 12:57:05 -04:00

cmd_test.go

Move more printers to TablePrinter

2017-06-26 11:38:36 -04:00

cmd.go

Merge pull request #46151 from verb/kubectl-featuregate

2017-06-23 05:00:35 -07:00

completion.go

Merge pull request #43297 from mvdan/kubectl-params

2017-04-13 04:07:21 -07:00

convert.go

kubectl: simplify code with help of linter

2017-06-23 09:49:30 -07:00

cp_test.go

add kubectl cp

2016-10-29 20:24:54 -07:00

cp.go

kubectl: simplify code with help of linter

2017-06-23 09:49:30 -07:00

create_clusterrole_test.go

Merge pull request #46265 from waseem/printers-genericity

2017-06-02 19:53:40 -07:00

create_clusterrole.go

support NonResourceURL for kubectl create clusterrole

2017-05-26 10:07:44 +08:00

create_clusterrolebinding.go

cmd: refactor common err expr into helper function

2017-06-23 09:49:30 -07:00

create_configmap_test.go

client/restclient/fake move to client-go

2017-01-25 08:29:48 -05:00

create_configmap.go

cmd: refactor common err expr into helper function

2017-06-23 09:49:30 -07:00

create_deployment_test.go

cmd/create_deployment: refactor & test long function

2017-06-26 11:17:53 -07:00

create_deployment.go

cmd/create_deployment: refactor & test long function

2017-06-26 11:17:53 -07:00

create_namespace_test.go

client/restclient/fake move to client-go

2017-01-25 08:29:48 -05:00

create_namespace.go

cmd: refactor common err expr into helper function

2017-06-23 09:49:30 -07:00

create_pdb_test.go

add test for kubectl create pdb

2017-05-26 17:38:26 +08:00

create_pdb.go

cmd: refactor common err expr into helper function

2017-06-23 09:49:30 -07:00

create_quota_test.go

Fix test not use test flags

2017-05-24 10:14:00 +08:00

create_quota.go

cmd: refactor common err expr into helper function

2017-06-23 09:49:30 -07:00

create_role_test.go

Merge pull request #46706 from CaoShuFeng/unit-create-role

2017-06-03 18:30:40 -07:00

create_role.go

Remove redirect verb parsing

2017-06-21 11:17:24 -04:00

create_rolebinding_test.go

Supplement unit tests to kubectl create rolebinding command.

2017-03-29 16:36:22 +08:00

create_rolebinding.go

cmd: refactor common err expr into helper function

2017-06-23 09:49:30 -07:00

create_secret_test.go

client/restclient/fake move to client-go

2017-01-25 08:29:48 -05:00

create_secret.go

cmd: refactor common err expr into helper function

2017-06-23 09:49:30 -07:00

create_service_test.go

add test to cover more in kubectl create service

2017-05-16 18:45:38 +08:00

create_service.go

cmd: refactor common err expr into helper function

2017-06-23 09:49:30 -07:00

create_serviceaccount_test.go

client/restclient/fake move to client-go

2017-01-25 08:29:48 -05:00

create_serviceaccount.go

cmd: refactor common err expr into helper function

2017-06-23 09:49:30 -07:00

create_test.go

Distinguish between client and unstructuredclient in fake factory

2017-01-26 19:59:16 -05:00

create.go

kubectl: fix inaccurate usage messages for --windows-line-endings

2017-06-23 09:49:30 -07:00

delete_test.go

orphan when kubectl delete --cascade=false

2017-05-11 09:11:07 -04:00

delete.go

kubectl: simplify code with help of linter

2017-06-23 09:49:30 -07:00

describe_test.go

describe: use unstructured objects

2017-01-26 19:59:25 -05:00

describe.go

fix --local flag for kubectl set commands

2017-06-13 12:57:05 -04:00

drain_test.go

deprecate created-by annotation for pod drain

2017-06-16 13:33:26 -07:00

drain.go

Merge pull request #47471 from crimsonfaith91/drain

2017-06-23 05:08:30 -07:00

edit_test.go

kubectl: simplify code with help of linter

2017-06-23 09:49:30 -07:00

edit.go

kubectl: fix inaccurate usage messages for --windows-line-endings

2017-06-23 09:49:30 -07:00

exec_test.go

clean up: put test description in head to locate quickly

2017-05-19 02:04:59 +08:00

exec.go

Merge pull request #43663 from shiywang/quato

2017-05-22 19:07:12 -07:00

explain.go

remove --api-version

2017-05-19 10:56:35 +08:00

expose_test.go

Refactor commands to use new factory method

2017-02-23 00:28:32 -05:00

expose.go

kubectl: simplify code with help of linter

2017-06-23 09:49:30 -07:00

get_test.go

kubectl: simplify code with help of linter

2017-06-23 09:49:30 -07:00

get.go

kubectl: simplify code with help of linter

2017-06-23 09:49:30 -07:00

help.go

Signed-off-by: bruceauyeung <ouyang.qinhua@zte.com.cn>

2017-04-25 15:07:01 +08:00

label_test.go

kubectl/cmd: remove a bunch of unused parameters

2017-04-04 10:36:30 +01:00

label.go

kubectl: simplify code with help of linter

2017-06-23 09:49:30 -07:00

logs_test.go

client/restclient/fake move to client-go

2017-01-25 08:29:48 -05:00

logs.go

Merge pull request #44282 from derekwaynecarr/fix-kubectl-logs

2017-06-16 18:05:48 -07:00

options.go

cmd/options: kubectl options writes to out stream

2017-05-28 11:23:44 -07:00

patch_test.go

Denote if a printer is generic.

2017-05-31 13:02:23 +05:30

patch.go

fix --local flag for kubectl set commands

2017-06-13 12:57:05 -04:00

plugin_test.go

kubectl plugins have access config, global flags and environment

2017-05-19 19:17:43 -03:00

plugin.go

kubectl plugins have access config, global flags and environment

2017-05-19 19:17:43 -03:00

portforward_test.go

kubectl/cmd: remove a bunch of unused parameters

2017-04-04 10:36:30 +01:00

portforward.go

Move client/unversioned/remotecommand to client-go

2017-05-15 16:28:56 +03:00

proxy.go

kubectl: fixes issues #45736 and #45737

2017-05-22 18:57:11 -04:00

replace_test.go

Distinguish between client and unstructuredclient in fake factory

2017-01-26 19:59:16 -05:00

replace.go

fix --local flag for kubectl set commands

2017-06-13 12:57:05 -04:00

rollingupdate_test.go

small change to clear

2017-05-11 20:09:31 +08:00

rollingupdate.go

run hack/update-all

2017-06-22 11:31:03 -07:00

run_test.go

kubectl: rename Run() -> RunRun() to clarify purpose

2017-06-23 09:49:30 -07:00

run.go

cmd/run: use util function to deduplicate logic

2017-06-26 11:17:56 -07:00

scale.go

Merge pull request #46220 from superbrothers/add-statefulset

2017-06-24 04:15:50 -07:00

stop.go

fix --local flag for kubectl set commands

2017-06-13 12:57:05 -04:00

taint_test.go

run hack/update-all

2017-06-22 11:31:03 -07:00

taint.go

kubectl: simplify code with help of linter

2017-06-23 09:49:30 -07:00

top_node_test.go

hack/update-bazal.sh

2017-05-15 13:51:39 -07:00

top_node.go

Extract a bunch more strings from kubectl

2017-04-06 20:12:50 -07:00

top_pod_test.go

run hack/update-all

2017-06-22 11:31:03 -07:00

top_pod.go

Extract a bunch more strings from kubectl

2017-04-06 20:12:50 -07:00

top_test.go

run hack/update-all

2017-06-22 11:31:03 -07:00

top.go

Extract a bunch more strings from kubectl

2017-04-06 20:12:50 -07:00

version.go

Merge pull request #46468 from alexandercampbell/cleanup-in-kubectl

2017-06-24 08:32:09 -07:00