Kubernetes Submit Queue 194501c4aa Merge pull request #53571 from frodenas/util-metrics-error ...

Automatic merge from submit-queue (batch tested with PRs 53444, 52067, 53571, 53182). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Return an error if metric cannot be registered

**What this PR does / why we need it**:

`prometheus.MustRegister` panics if a metric cannot be registered. This PR replaces it with `prometheus.Register`, as it does not panic, and returns the error if the metric cannot be registered.

I also adds lacking tests for `RegisterMetricAndTrackRateLimiterUsage`.

**Which issue this PR fixes**:

Fixes #52872

**Special notes for your reviewer**:

None of the `metrics.RegisterMetricAndTrackRateLimiterUsage` invocations check the returned error, so I plan to submit new PRs to address this.

**Release note**:

```release-note
NONE
```
/sig instrumentation

2017-10-10 00:33:25 -07:00

..

async

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

bandwidth

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

config

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

configz

Cleanup locking in configz

2017-08-12 17:24:32 +10:00

dbus

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

ebtables

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

env

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

file

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

filesystem

Fix a potential file leak

2017-09-25 20:45:52 -07:00

flock

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

goroutinemap

Merge pull request #49826 from dixudx/fix_err_msg_on_two_lines

2017-10-03 15:43:44 -07:00

hash

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

initsystem

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

interrupt

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

io

Share /var/lib/kubernetes on startup

2017-08-30 16:45:04 +02:00

ipconfig

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

iptables

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

ipvs

implement fakeIPVS update virtual server

2017-10-06 11:58:48 +08:00

keymutex

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

labels

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

limitwriter

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

maps

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

metrics

Return an error if metric cannot be registered

2017-10-09 11:05:32 +02:00

mount

auto-gen

2017-09-26 09:57:13 +08:00

net

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

netsh

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

node

Use separate client for node status loop

2017-09-14 15:56:22 -04:00

nsenter

auto-gen

2017-09-26 09:57:13 +08:00

oom

Remove cgo flag for oom package

2017-08-29 11:14:02 -07:00

parsers

update cadvisor, docker, and runc godeps

2017-09-05 12:38:57 -07:00

pointer

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

procfs

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

reflector/prometheus

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

removeall

use GetFileType per mount.Interface to check hostpath type

2017-09-26 09:57:06 +08:00

resourcecontainer

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

rlimit

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

selinux

update cadvisor, docker, and runc godeps

2017-09-05 12:38:57 -07:00

slice

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

strings

Fix godoc comments.

2017-08-30 15:22:47 +02:00

sysctl

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

system

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

tail

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

taints

Merge pull request #52597 from smarterclayton/roundtrip_options

2017-09-23 18:48:55 -07:00

template

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

term

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

threading

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

tolerations

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

version

Fix version comparison for versions with preRelease components

2017-09-27 19:54:43 +03:00

workqueue/prometheus

Use buildozer to delete licenses() rules except under third_party/

2017-08-11 09:32:39 -07:00

BUILD

auto-gen

2017-09-26 09:57:13 +08:00

verify-util-pkg.sh

verify pkg/util contains no code

2017-08-17 15:28:27 +08:00