47320fd3f0
Automatic merge from submit-queue GC: Fix re-adoption race when orphaning dependents. **What this PR does / why we need it**: The GC expects that once it sees a controller with a non-nil DeletionTimestamp, that controller will not attempt any adoption. There was a known race condition that could cause a controller to re-adopt something orphaned by the GC, because the controller is using a cached value of its own spec from before DeletionTimestamp was set. This fixes that race by doing an uncached quorum read of the controller spec just before the first adoption attempt. It's important that this read occurs after listing potential orphans. Note that this uncached read is skipped if no adoptions are attempted (i.e. at steady state). **Which issue this PR fixes**: Fixes #42639 **Special notes for your reviewer**: **Release note**: ```release-note ``` cc @kubernetes/sig-apps-pr-reviews |
||
|---|---|---|
| .. | ||
| util | ||
| BUILD | ||
| deployment_controller_test.go | ||
| deployment_controller.go | ||
| OWNERS | ||
| progress_test.go | ||
| progress.go | ||
| recreate_test.go | ||
| recreate.go | ||
| rollback.go | ||
| rolling_test.go | ||
| rolling.go | ||
| sync_test.go | ||
| sync.go | ||