1343 lines
37 KiB
Go
1343 lines
37 KiB
Go
/*
|
|
Copyright 2019 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package nodevolumelimits
|
|
|
|
import (
|
|
"context"
|
|
"os"
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
|
|
v1 "k8s.io/api/core/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
csilibplugins "k8s.io/csi-translation-lib/plugins"
|
|
framework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1"
|
|
fakeframework "k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1/fake"
|
|
utilpointer "k8s.io/utils/pointer"
|
|
)
|
|
|
|
func TestAzureDiskLimits(t *testing.T) {
|
|
oneVolPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
AWSElasticBlockStore: &v1.AWSElasticBlockStoreVolumeSource{VolumeID: "ovp"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
twoVolPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
AWSElasticBlockStore: &v1.AWSElasticBlockStoreVolumeSource{VolumeID: "tvp1"},
|
|
},
|
|
},
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
AWSElasticBlockStore: &v1.AWSElasticBlockStoreVolumeSource{VolumeID: "tvp2"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
splitVolsPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
HostPath: &v1.HostPathVolumeSource{},
|
|
},
|
|
},
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
AWSElasticBlockStore: &v1.AWSElasticBlockStoreVolumeSource{VolumeID: "svp"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
nonApplicablePod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
HostPath: &v1.HostPathVolumeSource{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
deletedPVCPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "deletedPVC",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
twoDeletedPVCPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "deletedPVC",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "anotherDeletedPVC",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
deletedPVPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "pvcWithDeletedPV",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
// deletedPVPod2 is a different pod than deletedPVPod but using the same PVC
|
|
deletedPVPod2 := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "pvcWithDeletedPV",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
// anotherDeletedPVPod is a different pod than deletedPVPod and uses another PVC
|
|
anotherDeletedPVPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "anotherPVCWithDeletedPV",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
emptyPod := &v1.Pod{
|
|
Spec: v1.PodSpec{},
|
|
}
|
|
unboundPVCPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "unboundPVC",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
// Different pod than unboundPVCPod, but using the same unbound PVC
|
|
unboundPVCPod2 := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "unboundPVC",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
// pod with unbound PVC that's different to unboundPVC
|
|
anotherUnboundPVCPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "anotherUnboundPVC",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
tests := []struct {
|
|
newPod *v1.Pod
|
|
existingPods []*v1.Pod
|
|
filterName string
|
|
driverName string
|
|
maxVols int
|
|
test string
|
|
wantStatus *framework.Status
|
|
}{
|
|
{
|
|
newPod: oneVolPod,
|
|
existingPods: []*v1.Pod{twoVolPod, oneVolPod},
|
|
filterName: azureDiskVolumeFilterType,
|
|
maxVols: 4,
|
|
test: "fits when node capacity >= new pod's AzureDisk volumes",
|
|
},
|
|
{
|
|
newPod: twoVolPod,
|
|
existingPods: []*v1.Pod{oneVolPod},
|
|
filterName: azureDiskVolumeFilterType,
|
|
maxVols: 2,
|
|
test: "fit when node capacity < new pod's AzureDisk volumes",
|
|
},
|
|
{
|
|
newPod: splitVolsPod,
|
|
existingPods: []*v1.Pod{twoVolPod},
|
|
filterName: azureDiskVolumeFilterType,
|
|
maxVols: 3,
|
|
test: "new pod's count ignores non-AzureDisk volumes",
|
|
},
|
|
{
|
|
newPod: twoVolPod,
|
|
existingPods: []*v1.Pod{splitVolsPod, nonApplicablePod, emptyPod},
|
|
filterName: azureDiskVolumeFilterType,
|
|
maxVols: 3,
|
|
test: "existing pods' counts ignore non-AzureDisk volumes",
|
|
},
|
|
{
|
|
newPod: onePVCPod(azureDiskVolumeFilterType),
|
|
existingPods: []*v1.Pod{splitVolsPod, nonApplicablePod, emptyPod},
|
|
filterName: azureDiskVolumeFilterType,
|
|
maxVols: 3,
|
|
test: "new pod's count considers PVCs backed by AzureDisk volumes",
|
|
},
|
|
{
|
|
newPod: splitPVCPod(azureDiskVolumeFilterType),
|
|
existingPods: []*v1.Pod{splitVolsPod, oneVolPod},
|
|
filterName: azureDiskVolumeFilterType,
|
|
maxVols: 3,
|
|
test: "new pod's count ignores PVCs not backed by AzureDisk volumes",
|
|
},
|
|
{
|
|
newPod: twoVolPod,
|
|
existingPods: []*v1.Pod{oneVolPod, onePVCPod(azureDiskVolumeFilterType)},
|
|
filterName: azureDiskVolumeFilterType,
|
|
maxVols: 3,
|
|
test: "existing pods' counts considers PVCs backed by AzureDisk volumes",
|
|
},
|
|
{
|
|
newPod: twoVolPod,
|
|
existingPods: []*v1.Pod{oneVolPod, twoVolPod, onePVCPod(azureDiskVolumeFilterType)},
|
|
filterName: azureDiskVolumeFilterType,
|
|
maxVols: 4,
|
|
test: "already-mounted AzureDisk volumes are always ok to allow",
|
|
},
|
|
{
|
|
newPod: splitVolsPod,
|
|
existingPods: []*v1.Pod{oneVolPod, oneVolPod, onePVCPod(azureDiskVolumeFilterType)},
|
|
filterName: azureDiskVolumeFilterType,
|
|
maxVols: 3,
|
|
test: "the same AzureDisk volumes are not counted multiple times",
|
|
},
|
|
{
|
|
newPod: onePVCPod(azureDiskVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, deletedPVCPod},
|
|
filterName: azureDiskVolumeFilterType,
|
|
maxVols: 2,
|
|
test: "pod with missing PVC is counted towards the PV limit",
|
|
},
|
|
{
|
|
newPod: onePVCPod(azureDiskVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, deletedPVCPod},
|
|
filterName: azureDiskVolumeFilterType,
|
|
maxVols: 3,
|
|
test: "pod with missing PVC is counted towards the PV limit",
|
|
},
|
|
{
|
|
newPod: onePVCPod(azureDiskVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, twoDeletedPVCPod},
|
|
filterName: azureDiskVolumeFilterType,
|
|
maxVols: 3,
|
|
test: "pod with missing two PVCs is counted towards the PV limit twice",
|
|
},
|
|
{
|
|
newPod: onePVCPod(azureDiskVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, deletedPVPod},
|
|
filterName: azureDiskVolumeFilterType,
|
|
maxVols: 2,
|
|
test: "pod with missing PV is counted towards the PV limit",
|
|
},
|
|
{
|
|
newPod: onePVCPod(azureDiskVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, deletedPVPod},
|
|
filterName: azureDiskVolumeFilterType,
|
|
maxVols: 3,
|
|
test: "pod with missing PV is counted towards the PV limit",
|
|
},
|
|
{
|
|
newPod: deletedPVPod2,
|
|
existingPods: []*v1.Pod{oneVolPod, deletedPVPod},
|
|
filterName: azureDiskVolumeFilterType,
|
|
maxVols: 2,
|
|
test: "two pods missing the same PV are counted towards the PV limit only once",
|
|
},
|
|
{
|
|
newPod: anotherDeletedPVPod,
|
|
existingPods: []*v1.Pod{oneVolPod, deletedPVPod},
|
|
filterName: azureDiskVolumeFilterType,
|
|
maxVols: 2,
|
|
test: "two pods missing different PVs are counted towards the PV limit twice",
|
|
},
|
|
{
|
|
newPod: onePVCPod(azureDiskVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, unboundPVCPod},
|
|
filterName: azureDiskVolumeFilterType,
|
|
maxVols: 2,
|
|
test: "pod with unbound PVC is counted towards the PV limit",
|
|
},
|
|
{
|
|
newPod: onePVCPod(azureDiskVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, unboundPVCPod},
|
|
filterName: azureDiskVolumeFilterType,
|
|
maxVols: 3,
|
|
test: "pod with unbound PVC is counted towards the PV limit",
|
|
},
|
|
{
|
|
newPod: unboundPVCPod2,
|
|
existingPods: []*v1.Pod{oneVolPod, unboundPVCPod},
|
|
filterName: azureDiskVolumeFilterType,
|
|
maxVols: 2,
|
|
test: "the same unbound PVC in multiple pods is counted towards the PV limit only once",
|
|
},
|
|
{
|
|
newPod: anotherUnboundPVCPod,
|
|
existingPods: []*v1.Pod{oneVolPod, unboundPVCPod},
|
|
filterName: azureDiskVolumeFilterType,
|
|
maxVols: 2,
|
|
test: "two different unbound PVCs are counted towards the PV limit as two volumes",
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.test, func(t *testing.T) {
|
|
node, csiNode := getNodeWithPodAndVolumeLimits("node", test.existingPods, int64(test.maxVols), test.filterName)
|
|
p := newNonCSILimits(test.filterName, getFakeCSINodeLister(csiNode), getFakeCSIStorageClassLister(test.filterName, test.driverName), getFakePVLister(test.filterName), getFakePVCLister(test.filterName)).(framework.FilterPlugin)
|
|
gotStatus := p.Filter(context.Background(), nil, test.newPod, node)
|
|
if !reflect.DeepEqual(gotStatus, test.wantStatus) {
|
|
t.Errorf("status does not match: %v, want: %v", gotStatus, test.wantStatus)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestCinderLimits(t *testing.T) {
|
|
twoVolCinderPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
Cinder: &v1.CinderVolumeSource{VolumeID: "tvp1"},
|
|
},
|
|
},
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
Cinder: &v1.CinderVolumeSource{VolumeID: "tvp2"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
oneVolCinderPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
Cinder: &v1.CinderVolumeSource{VolumeID: "ovp"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
tests := []struct {
|
|
newPod *v1.Pod
|
|
existingPods []*v1.Pod
|
|
filterName string
|
|
driverName string
|
|
maxVols int
|
|
test string
|
|
wantStatus *framework.Status
|
|
}{
|
|
{
|
|
newPod: oneVolCinderPod,
|
|
existingPods: []*v1.Pod{twoVolCinderPod},
|
|
filterName: cinderVolumeFilterType,
|
|
maxVols: 4,
|
|
test: "fits when node capacity >= new pod's Cinder volumes",
|
|
},
|
|
{
|
|
newPod: oneVolCinderPod,
|
|
existingPods: []*v1.Pod{twoVolCinderPod},
|
|
filterName: cinderVolumeFilterType,
|
|
maxVols: 2,
|
|
test: "not fit when node capacity < new pod's Cinder volumes",
|
|
wantStatus: framework.NewStatus(framework.Unschedulable, ErrReasonMaxVolumeCountExceeded),
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.test, func(t *testing.T) {
|
|
node, csiNode := getNodeWithPodAndVolumeLimits("node", test.existingPods, int64(test.maxVols), test.filterName)
|
|
p := newNonCSILimits(test.filterName, getFakeCSINodeLister(csiNode), getFakeCSIStorageClassLister(test.filterName, test.driverName), getFakePVLister(test.filterName), getFakePVCLister(test.filterName)).(framework.FilterPlugin)
|
|
gotStatus := p.Filter(context.Background(), nil, test.newPod, node)
|
|
if !reflect.DeepEqual(gotStatus, test.wantStatus) {
|
|
t.Errorf("status does not match: %v, want: %v", gotStatus, test.wantStatus)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
func TestEBSLimits(t *testing.T) {
|
|
oneVolPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
AWSElasticBlockStore: &v1.AWSElasticBlockStoreVolumeSource{VolumeID: "ovp"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
twoVolPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
AWSElasticBlockStore: &v1.AWSElasticBlockStoreVolumeSource{VolumeID: "tvp1"},
|
|
},
|
|
},
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
AWSElasticBlockStore: &v1.AWSElasticBlockStoreVolumeSource{VolumeID: "tvp2"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
unboundPVCwithInvalidSCPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "unboundPVCwithInvalidSCPod",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
unboundPVCwithDefaultSCPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "unboundPVCwithDefaultSCPod",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
splitVolsPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
HostPath: &v1.HostPathVolumeSource{},
|
|
},
|
|
},
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
AWSElasticBlockStore: &v1.AWSElasticBlockStoreVolumeSource{VolumeID: "svp"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
nonApplicablePod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
HostPath: &v1.HostPathVolumeSource{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
deletedPVCPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "deletedPVC",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
twoDeletedPVCPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "deletedPVC",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "anotherDeletedPVC",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
deletedPVPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "pvcWithDeletedPV",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
// deletedPVPod2 is a different pod than deletedPVPod but using the same PVC
|
|
deletedPVPod2 := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "pvcWithDeletedPV",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
// anotherDeletedPVPod is a different pod than deletedPVPod and uses another PVC
|
|
anotherDeletedPVPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "anotherPVCWithDeletedPV",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
emptyPod := &v1.Pod{
|
|
Spec: v1.PodSpec{},
|
|
}
|
|
unboundPVCPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "unboundPVC",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
// Different pod than unboundPVCPod, but using the same unbound PVC
|
|
unboundPVCPod2 := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "unboundPVC",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
// pod with unbound PVC that's different to unboundPVC
|
|
anotherUnboundPVCPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "anotherUnboundPVC",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
tests := []struct {
|
|
newPod *v1.Pod
|
|
existingPods []*v1.Pod
|
|
filterName string
|
|
driverName string
|
|
maxVols int
|
|
test string
|
|
wantStatus *framework.Status
|
|
}{
|
|
{
|
|
newPod: oneVolPod,
|
|
existingPods: []*v1.Pod{twoVolPod, oneVolPod},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 4,
|
|
test: "fits when node capacity >= new pod's EBS volumes",
|
|
},
|
|
{
|
|
newPod: twoVolPod,
|
|
existingPods: []*v1.Pod{oneVolPod},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 2,
|
|
test: "doesn't fit when node capacity < new pod's EBS volumes",
|
|
wantStatus: framework.NewStatus(framework.Unschedulable, ErrReasonMaxVolumeCountExceeded),
|
|
},
|
|
{
|
|
newPod: splitVolsPod,
|
|
existingPods: []*v1.Pod{twoVolPod},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 3,
|
|
test: "new pod's count ignores non-EBS volumes",
|
|
},
|
|
{
|
|
newPod: twoVolPod,
|
|
existingPods: []*v1.Pod{splitVolsPod, nonApplicablePod, emptyPod},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 3,
|
|
test: "existing pods' counts ignore non-EBS volumes",
|
|
},
|
|
{
|
|
newPod: onePVCPod(ebsVolumeFilterType),
|
|
existingPods: []*v1.Pod{splitVolsPod, nonApplicablePod, emptyPod},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 3,
|
|
test: "new pod's count considers PVCs backed by EBS volumes",
|
|
},
|
|
{
|
|
newPod: splitPVCPod(ebsVolumeFilterType),
|
|
existingPods: []*v1.Pod{splitVolsPod, oneVolPod},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 3,
|
|
test: "new pod's count ignores PVCs not backed by EBS volumes",
|
|
},
|
|
{
|
|
newPod: twoVolPod,
|
|
existingPods: []*v1.Pod{oneVolPod, onePVCPod(ebsVolumeFilterType)},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 3,
|
|
test: "existing pods' counts considers PVCs backed by EBS volumes",
|
|
wantStatus: framework.NewStatus(framework.Unschedulable, ErrReasonMaxVolumeCountExceeded),
|
|
},
|
|
{
|
|
newPod: twoVolPod,
|
|
existingPods: []*v1.Pod{oneVolPod, twoVolPod, onePVCPod(ebsVolumeFilterType)},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 4,
|
|
test: "already-mounted EBS volumes are always ok to allow",
|
|
},
|
|
{
|
|
newPod: splitVolsPod,
|
|
existingPods: []*v1.Pod{oneVolPod, oneVolPod, onePVCPod(ebsVolumeFilterType)},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 3,
|
|
test: "the same EBS volumes are not counted multiple times",
|
|
},
|
|
{
|
|
newPod: onePVCPod(ebsVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, deletedPVCPod},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 1,
|
|
test: "missing PVC is not counted towards the PV limit",
|
|
wantStatus: framework.NewStatus(framework.Unschedulable, ErrReasonMaxVolumeCountExceeded),
|
|
},
|
|
{
|
|
newPod: onePVCPod(ebsVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, deletedPVCPod},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 2,
|
|
test: "missing PVC is not counted towards the PV limit",
|
|
},
|
|
{
|
|
newPod: onePVCPod(ebsVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, twoDeletedPVCPod},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 2,
|
|
test: "two missing PVCs are not counted towards the PV limit twice",
|
|
},
|
|
{
|
|
newPod: unboundPVCwithInvalidSCPod,
|
|
existingPods: []*v1.Pod{oneVolPod},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 1,
|
|
test: "unbound PVC with invalid SC is not counted towards the PV limit",
|
|
},
|
|
{
|
|
newPod: unboundPVCwithDefaultSCPod,
|
|
existingPods: []*v1.Pod{oneVolPod},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 1,
|
|
test: "unbound PVC from different provisioner is not counted towards the PV limit",
|
|
},
|
|
|
|
{
|
|
newPod: onePVCPod(ebsVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, deletedPVPod},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 2,
|
|
test: "pod with missing PV is counted towards the PV limit",
|
|
wantStatus: framework.NewStatus(framework.Unschedulable, ErrReasonMaxVolumeCountExceeded),
|
|
},
|
|
{
|
|
newPod: onePVCPod(ebsVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, deletedPVPod},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 3,
|
|
test: "pod with missing PV is counted towards the PV limit",
|
|
},
|
|
{
|
|
newPod: deletedPVPod2,
|
|
existingPods: []*v1.Pod{oneVolPod, deletedPVPod},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 2,
|
|
test: "two pods missing the same PV are counted towards the PV limit only once",
|
|
},
|
|
{
|
|
newPod: anotherDeletedPVPod,
|
|
existingPods: []*v1.Pod{oneVolPod, deletedPVPod},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 2,
|
|
test: "two pods missing different PVs are counted towards the PV limit twice",
|
|
wantStatus: framework.NewStatus(framework.Unschedulable, ErrReasonMaxVolumeCountExceeded),
|
|
},
|
|
{
|
|
newPod: onePVCPod(ebsVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, unboundPVCPod},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 2,
|
|
test: "pod with unbound PVC is counted towards the PV limit",
|
|
wantStatus: framework.NewStatus(framework.Unschedulable, ErrReasonMaxVolumeCountExceeded),
|
|
},
|
|
{
|
|
newPod: onePVCPod(ebsVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, unboundPVCPod},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 3,
|
|
test: "pod with unbound PVC is counted towards the PV limit",
|
|
},
|
|
{
|
|
newPod: unboundPVCPod2,
|
|
existingPods: []*v1.Pod{oneVolPod, unboundPVCPod},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 2,
|
|
test: "the same unbound PVC in multiple pods is counted towards the PV limit only once",
|
|
},
|
|
{
|
|
newPod: anotherUnboundPVCPod,
|
|
existingPods: []*v1.Pod{oneVolPod, unboundPVCPod},
|
|
filterName: ebsVolumeFilterType,
|
|
driverName: csilibplugins.AWSEBSInTreePluginName,
|
|
maxVols: 2,
|
|
test: "two different unbound PVCs are counted towards the PV limit as two volumes",
|
|
wantStatus: framework.NewStatus(framework.Unschedulable, ErrReasonMaxVolumeCountExceeded),
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.test, func(t *testing.T) {
|
|
node, csiNode := getNodeWithPodAndVolumeLimits("node", test.existingPods, int64(test.maxVols), test.filterName)
|
|
p := newNonCSILimits(test.filterName, getFakeCSINodeLister(csiNode), getFakeCSIStorageClassLister(test.filterName, test.driverName), getFakePVLister(test.filterName), getFakePVCLister(test.filterName)).(framework.FilterPlugin)
|
|
gotStatus := p.Filter(context.Background(), nil, test.newPod, node)
|
|
if !reflect.DeepEqual(gotStatus, test.wantStatus) {
|
|
t.Errorf("status does not match: %v, want: %v", gotStatus, test.wantStatus)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestGCEPDLimits(t *testing.T) {
|
|
oneVolPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
AWSElasticBlockStore: &v1.AWSElasticBlockStoreVolumeSource{VolumeID: "ovp"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
twoVolPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
AWSElasticBlockStore: &v1.AWSElasticBlockStoreVolumeSource{VolumeID: "tvp1"},
|
|
},
|
|
},
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
AWSElasticBlockStore: &v1.AWSElasticBlockStoreVolumeSource{VolumeID: "tvp2"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
splitVolsPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
HostPath: &v1.HostPathVolumeSource{},
|
|
},
|
|
},
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
AWSElasticBlockStore: &v1.AWSElasticBlockStoreVolumeSource{VolumeID: "svp"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
nonApplicablePod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
HostPath: &v1.HostPathVolumeSource{},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
deletedPVCPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "deletedPVC",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
twoDeletedPVCPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "deletedPVC",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "anotherDeletedPVC",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
deletedPVPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "pvcWithDeletedPV",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
// deletedPVPod2 is a different pod than deletedPVPod but using the same PVC
|
|
deletedPVPod2 := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "pvcWithDeletedPV",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
// anotherDeletedPVPod is a different pod than deletedPVPod and uses another PVC
|
|
anotherDeletedPVPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "anotherPVCWithDeletedPV",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
emptyPod := &v1.Pod{
|
|
Spec: v1.PodSpec{},
|
|
}
|
|
unboundPVCPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "unboundPVC",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
// Different pod than unboundPVCPod, but using the same unbound PVC
|
|
unboundPVCPod2 := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "unboundPVC",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
// pod with unbound PVC that's different to unboundPVC
|
|
anotherUnboundPVCPod := &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "anotherUnboundPVC",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
tests := []struct {
|
|
newPod *v1.Pod
|
|
existingPods []*v1.Pod
|
|
filterName string
|
|
driverName string
|
|
maxVols int
|
|
test string
|
|
wantStatus *framework.Status
|
|
}{
|
|
{
|
|
newPod: oneVolPod,
|
|
existingPods: []*v1.Pod{twoVolPod, oneVolPod},
|
|
filterName: gcePDVolumeFilterType,
|
|
maxVols: 4,
|
|
test: "fits when node capacity >= new pod's GCE volumes",
|
|
},
|
|
{
|
|
newPod: twoVolPod,
|
|
existingPods: []*v1.Pod{oneVolPod},
|
|
filterName: gcePDVolumeFilterType,
|
|
maxVols: 2,
|
|
test: "fit when node capacity < new pod's GCE volumes",
|
|
},
|
|
{
|
|
newPod: splitVolsPod,
|
|
existingPods: []*v1.Pod{twoVolPod},
|
|
filterName: gcePDVolumeFilterType,
|
|
maxVols: 3,
|
|
test: "new pod's count ignores non-GCE volumes",
|
|
},
|
|
{
|
|
newPod: twoVolPod,
|
|
existingPods: []*v1.Pod{splitVolsPod, nonApplicablePod, emptyPod},
|
|
filterName: gcePDVolumeFilterType,
|
|
maxVols: 3,
|
|
test: "existing pods' counts ignore non-GCE volumes",
|
|
},
|
|
{
|
|
newPod: onePVCPod(gcePDVolumeFilterType),
|
|
existingPods: []*v1.Pod{splitVolsPod, nonApplicablePod, emptyPod},
|
|
filterName: gcePDVolumeFilterType,
|
|
maxVols: 3,
|
|
test: "new pod's count considers PVCs backed by GCE volumes",
|
|
},
|
|
{
|
|
newPod: splitPVCPod(gcePDVolumeFilterType),
|
|
existingPods: []*v1.Pod{splitVolsPod, oneVolPod},
|
|
filterName: gcePDVolumeFilterType,
|
|
maxVols: 3,
|
|
test: "new pod's count ignores PVCs not backed by GCE volumes",
|
|
},
|
|
{
|
|
newPod: twoVolPod,
|
|
existingPods: []*v1.Pod{oneVolPod, onePVCPod(gcePDVolumeFilterType)},
|
|
filterName: gcePDVolumeFilterType,
|
|
maxVols: 3,
|
|
test: "existing pods' counts considers PVCs backed by GCE volumes",
|
|
},
|
|
{
|
|
newPod: twoVolPod,
|
|
existingPods: []*v1.Pod{oneVolPod, twoVolPod, onePVCPod(gcePDVolumeFilterType)},
|
|
filterName: gcePDVolumeFilterType,
|
|
maxVols: 4,
|
|
test: "already-mounted EBS volumes are always ok to allow",
|
|
},
|
|
{
|
|
newPod: splitVolsPod,
|
|
existingPods: []*v1.Pod{oneVolPod, oneVolPod, onePVCPod(gcePDVolumeFilterType)},
|
|
filterName: gcePDVolumeFilterType,
|
|
maxVols: 3,
|
|
test: "the same GCE volumes are not counted multiple times",
|
|
},
|
|
{
|
|
newPod: onePVCPod(gcePDVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, deletedPVCPod},
|
|
filterName: gcePDVolumeFilterType,
|
|
maxVols: 2,
|
|
test: "pod with missing PVC is counted towards the PV limit",
|
|
},
|
|
{
|
|
newPod: onePVCPod(gcePDVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, deletedPVCPod},
|
|
filterName: gcePDVolumeFilterType,
|
|
maxVols: 3,
|
|
test: "pod with missing PVC is counted towards the PV limit",
|
|
},
|
|
{
|
|
newPod: onePVCPod(gcePDVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, twoDeletedPVCPod},
|
|
filterName: gcePDVolumeFilterType,
|
|
maxVols: 3,
|
|
test: "pod with missing two PVCs is counted towards the PV limit twice",
|
|
},
|
|
{
|
|
newPod: onePVCPod(gcePDVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, deletedPVPod},
|
|
filterName: gcePDVolumeFilterType,
|
|
maxVols: 2,
|
|
test: "pod with missing PV is counted towards the PV limit",
|
|
},
|
|
{
|
|
newPod: onePVCPod(gcePDVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, deletedPVPod},
|
|
filterName: gcePDVolumeFilterType,
|
|
maxVols: 3,
|
|
test: "pod with missing PV is counted towards the PV limit",
|
|
},
|
|
{
|
|
newPod: deletedPVPod2,
|
|
existingPods: []*v1.Pod{oneVolPod, deletedPVPod},
|
|
filterName: gcePDVolumeFilterType,
|
|
maxVols: 2,
|
|
test: "two pods missing the same PV are counted towards the PV limit only once",
|
|
},
|
|
{
|
|
newPod: anotherDeletedPVPod,
|
|
existingPods: []*v1.Pod{oneVolPod, deletedPVPod},
|
|
filterName: gcePDVolumeFilterType,
|
|
maxVols: 2,
|
|
test: "two pods missing different PVs are counted towards the PV limit twice",
|
|
},
|
|
{
|
|
newPod: onePVCPod(gcePDVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, unboundPVCPod},
|
|
filterName: gcePDVolumeFilterType,
|
|
maxVols: 2,
|
|
test: "pod with unbound PVC is counted towards the PV limit",
|
|
},
|
|
{
|
|
newPod: onePVCPod(gcePDVolumeFilterType),
|
|
existingPods: []*v1.Pod{oneVolPod, unboundPVCPod},
|
|
filterName: gcePDVolumeFilterType,
|
|
maxVols: 3,
|
|
test: "pod with unbound PVC is counted towards the PV limit",
|
|
},
|
|
{
|
|
newPod: unboundPVCPod2,
|
|
existingPods: []*v1.Pod{oneVolPod, unboundPVCPod},
|
|
filterName: gcePDVolumeFilterType,
|
|
maxVols: 2,
|
|
test: "the same unbound PVC in multiple pods is counted towards the PV limit only once",
|
|
},
|
|
{
|
|
newPod: anotherUnboundPVCPod,
|
|
existingPods: []*v1.Pod{oneVolPod, unboundPVCPod},
|
|
filterName: gcePDVolumeFilterType,
|
|
maxVols: 2,
|
|
test: "two different unbound PVCs are counted towards the PV limit as two volumes",
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.test, func(t *testing.T) {
|
|
node, csiNode := getNodeWithPodAndVolumeLimits("node", test.existingPods, int64(test.maxVols), test.filterName)
|
|
p := newNonCSILimits(test.filterName, getFakeCSINodeLister(csiNode), getFakeCSIStorageClassLister(test.filterName, test.driverName), getFakePVLister(test.filterName), getFakePVCLister(test.filterName)).(framework.FilterPlugin)
|
|
gotStatus := p.Filter(context.Background(), nil, test.newPod, node)
|
|
if !reflect.DeepEqual(gotStatus, test.wantStatus) {
|
|
t.Errorf("status does not match: %v, want: %v", gotStatus, test.wantStatus)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestGetMaxVols(t *testing.T) {
|
|
previousValue := os.Getenv(KubeMaxPDVols)
|
|
|
|
tests := []struct {
|
|
rawMaxVols string
|
|
expected int
|
|
name string
|
|
}{
|
|
{
|
|
rawMaxVols: "invalid",
|
|
expected: -1,
|
|
name: "Unable to parse maximum PD volumes value, using default value",
|
|
},
|
|
{
|
|
rawMaxVols: "-2",
|
|
expected: -1,
|
|
name: "Maximum PD volumes must be a positive value, using default value",
|
|
},
|
|
{
|
|
rawMaxVols: "40",
|
|
expected: 40,
|
|
name: "Parse maximum PD volumes value from env",
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
os.Setenv(KubeMaxPDVols, test.rawMaxVols)
|
|
result := getMaxVolLimitFromEnv()
|
|
if result != test.expected {
|
|
t.Errorf("expected %v got %v", test.expected, result)
|
|
}
|
|
})
|
|
}
|
|
|
|
os.Unsetenv(KubeMaxPDVols)
|
|
if previousValue != "" {
|
|
os.Setenv(KubeMaxPDVols, previousValue)
|
|
}
|
|
}
|
|
|
|
func getFakePVCLister(filterName string) fakeframework.PersistentVolumeClaimLister {
|
|
return fakeframework.PersistentVolumeClaimLister{
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "some" + filterName + "Vol"},
|
|
Spec: v1.PersistentVolumeClaimSpec{
|
|
VolumeName: "some" + filterName + "Vol",
|
|
StorageClassName: &filterName,
|
|
},
|
|
},
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "someNon" + filterName + "Vol"},
|
|
Spec: v1.PersistentVolumeClaimSpec{
|
|
VolumeName: "someNon" + filterName + "Vol",
|
|
StorageClassName: &filterName,
|
|
},
|
|
},
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "pvcWithDeletedPV"},
|
|
Spec: v1.PersistentVolumeClaimSpec{
|
|
VolumeName: "pvcWithDeletedPV",
|
|
StorageClassName: &filterName,
|
|
},
|
|
},
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "anotherPVCWithDeletedPV"},
|
|
Spec: v1.PersistentVolumeClaimSpec{
|
|
VolumeName: "anotherPVCWithDeletedPV",
|
|
StorageClassName: &filterName,
|
|
},
|
|
},
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "unboundPVC"},
|
|
Spec: v1.PersistentVolumeClaimSpec{
|
|
VolumeName: "",
|
|
StorageClassName: &filterName,
|
|
},
|
|
},
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "anotherUnboundPVC"},
|
|
Spec: v1.PersistentVolumeClaimSpec{
|
|
VolumeName: "",
|
|
StorageClassName: &filterName,
|
|
},
|
|
},
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "unboundPVCwithDefaultSCPod"},
|
|
Spec: v1.PersistentVolumeClaimSpec{
|
|
VolumeName: "",
|
|
StorageClassName: utilpointer.StringPtr("standard-sc"),
|
|
},
|
|
},
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "unboundPVCwithInvalidSCPod"},
|
|
Spec: v1.PersistentVolumeClaimSpec{
|
|
VolumeName: "",
|
|
StorageClassName: utilpointer.StringPtr("invalid-sc"),
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
func getFakePVLister(filterName string) fakeframework.PersistentVolumeLister {
|
|
return fakeframework.PersistentVolumeLister{
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "some" + filterName + "Vol"},
|
|
Spec: v1.PersistentVolumeSpec{
|
|
PersistentVolumeSource: v1.PersistentVolumeSource{
|
|
AWSElasticBlockStore: &v1.AWSElasticBlockStoreVolumeSource{VolumeID: strings.ToLower(filterName) + "Vol"},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "someNon" + filterName + "Vol"},
|
|
Spec: v1.PersistentVolumeSpec{
|
|
PersistentVolumeSource: v1.PersistentVolumeSource{},
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
func onePVCPod(filterName string) *v1.Pod {
|
|
return &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "some" + filterName + "Vol",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
func splitPVCPod(filterName string) *v1.Pod {
|
|
return &v1.Pod{
|
|
Spec: v1.PodSpec{
|
|
Volumes: []v1.Volume{
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "someNon" + filterName + "Vol",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
VolumeSource: v1.VolumeSource{
|
|
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
|
|
ClaimName: "some" + filterName + "Vol",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
}
|