2e2ae029c3
1) Fail if we can't read critical env vars 2) Don't rely on KUBE_ROOT env var when `go list` works 3) Don't rely on GOOS env var when `go env` works 4) Don't quietly ignore "can't read" errors Once we stop ignoring errors, some tests fail for real (and should always have failed). The "Imported k8s.io/staging constant" test seems to not be allowed at all anymore. Han said to nix it and he'd look async. Oversall this test is dodgy. You REALLY can't glue strings together and expect valid Go module paths. We should consider a deeper rework. |
||
|---|---|---|
| .. | ||
| documentation | ||
| sort | ||
| testdata | ||
| decode_metric.go | ||
| doc.go | ||
| error.go | ||
| find_stable_metric.go | ||
| main_test.go | ||
| main.go | ||
| metric.go | ||
| OWNERS | ||
| README.md | ||
| stability-utils.sh | ||
| test-update.sh | ||
| test-verify.sh | ||
| update-documentation-metrics.sh | ||
| update-documentation.sh | ||
This directory contains the regression test for controlling the list of stable metrics
If you add or remove a stable metric, this test will fail and you will need
to update the golden list of tests stored in testdata/. Changes to that file
require review by sig-instrumentation.
To update the list, run
./hack/update-generated-stable-metrics.sh
Add the changed file to your PR, then send for review.
If you want to test the stability framework, you can add metrics to the file in
test/instrumentation/testdata/pkg/kubelet/metrics/metrics.go and run test
verification via:
./test/instrumentation/test-verify.sh
To update the golden test list, you can run:
./test/instrumentation/test-update.sh
To update the list of documented metrics, please run:
./test/instrumentation/update-documentation-metrics.sh
To update the documented list of metrics for k8s/website, please run:
./test/instrumentation/update-documentation.sh
Then you need to copy the output to the appropriate website directory. Please define the directory in which the website repo lives in an env variable like so:
export WEBSITE_ROOT=<path to website root>
And then from the root of the k8s/k8s repository, please run this command:
cp ./test/instrumentation/documentation/documentation.md $WEBSITE_ROOT/content/en/docs/reference/instrumentation/metrics.md