
IsLikelyNotMountPoint determines if a directory is not a mountpoint. It is fast but not necessarily ALWAYS correct. If the path is in fact a bind mount from one part of a mount to another it will not be detected. mkdir /tmp/a /tmp/b; mount --bin /tmp/a /tmp/b; IsLikelyNotMountPoint("/tmp/b") will return true. When in fact /tmp/b is a mount point. So this patch renames the function and switches it from a positive to a negative (I could think of a good positive name). This should make future users of this function aware that it isn't quite perfect, but probably good enough.
350 lines
11 KiB
Go
350 lines
11 KiB
Go
/*
|
|
Copyright 2014 The Kubernetes Authors All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package aws_ebs
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path"
|
|
"path/filepath"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/golang/glog"
|
|
"k8s.io/kubernetes/pkg/api"
|
|
"k8s.io/kubernetes/pkg/cloudprovider"
|
|
"k8s.io/kubernetes/pkg/cloudprovider/providers/aws"
|
|
"k8s.io/kubernetes/pkg/types"
|
|
"k8s.io/kubernetes/pkg/util"
|
|
"k8s.io/kubernetes/pkg/util/exec"
|
|
"k8s.io/kubernetes/pkg/util/mount"
|
|
"k8s.io/kubernetes/pkg/volume"
|
|
)
|
|
|
|
// This is the primary entrypoint for volume plugins.
|
|
func ProbeVolumePlugins() []volume.VolumePlugin {
|
|
return []volume.VolumePlugin{&awsElasticBlockStorePlugin{nil}}
|
|
}
|
|
|
|
type awsElasticBlockStorePlugin struct {
|
|
host volume.VolumeHost
|
|
}
|
|
|
|
var _ volume.VolumePlugin = &awsElasticBlockStorePlugin{}
|
|
var _ volume.PersistentVolumePlugin = &awsElasticBlockStorePlugin{}
|
|
|
|
const (
|
|
awsElasticBlockStorePluginName = "kubernetes.io/aws-ebs"
|
|
)
|
|
|
|
func (plugin *awsElasticBlockStorePlugin) Init(host volume.VolumeHost) {
|
|
plugin.host = host
|
|
}
|
|
|
|
func (plugin *awsElasticBlockStorePlugin) Name() string {
|
|
return awsElasticBlockStorePluginName
|
|
}
|
|
|
|
func (plugin *awsElasticBlockStorePlugin) CanSupport(spec *volume.Spec) bool {
|
|
return spec.PersistentVolumeSource.AWSElasticBlockStore != nil || spec.VolumeSource.AWSElasticBlockStore != nil
|
|
}
|
|
|
|
func (plugin *awsElasticBlockStorePlugin) GetAccessModes() []api.PersistentVolumeAccessMode {
|
|
return []api.PersistentVolumeAccessMode{
|
|
api.ReadWriteOnce,
|
|
}
|
|
}
|
|
|
|
func (plugin *awsElasticBlockStorePlugin) NewBuilder(spec *volume.Spec, pod *api.Pod, _ volume.VolumeOptions, mounter mount.Interface) (volume.Builder, error) {
|
|
// Inject real implementations here, test through the internal function.
|
|
return plugin.newBuilderInternal(spec, pod.UID, &AWSDiskUtil{}, mounter)
|
|
}
|
|
|
|
func (plugin *awsElasticBlockStorePlugin) newBuilderInternal(spec *volume.Spec, podUID types.UID, manager ebsManager, mounter mount.Interface) (volume.Builder, error) {
|
|
// EBSs used directly in a pod have a ReadOnly flag set by the pod author.
|
|
// EBSs used as a PersistentVolume gets the ReadOnly flag indirectly through the persistent-claim volume used to mount the PV
|
|
var readOnly bool
|
|
var ebs *api.AWSElasticBlockStoreVolumeSource
|
|
if spec.VolumeSource.AWSElasticBlockStore != nil {
|
|
ebs = spec.VolumeSource.AWSElasticBlockStore
|
|
readOnly = ebs.ReadOnly
|
|
} else {
|
|
ebs = spec.PersistentVolumeSource.AWSElasticBlockStore
|
|
readOnly = spec.ReadOnly
|
|
}
|
|
|
|
volumeID := ebs.VolumeID
|
|
fsType := ebs.FSType
|
|
partition := ""
|
|
if ebs.Partition != 0 {
|
|
partition = strconv.Itoa(ebs.Partition)
|
|
}
|
|
|
|
return &awsElasticBlockStoreBuilder{
|
|
awsElasticBlockStore: &awsElasticBlockStore{
|
|
podUID: podUID,
|
|
volName: spec.Name,
|
|
volumeID: volumeID,
|
|
manager: manager,
|
|
mounter: mounter,
|
|
plugin: plugin,
|
|
},
|
|
fsType: fsType,
|
|
partition: partition,
|
|
readOnly: readOnly,
|
|
diskMounter: &awsSafeFormatAndMount{mounter, exec.New()}}, nil
|
|
}
|
|
|
|
func (plugin *awsElasticBlockStorePlugin) NewCleaner(volName string, podUID types.UID, mounter mount.Interface) (volume.Cleaner, error) {
|
|
// Inject real implementations here, test through the internal function.
|
|
return plugin.newCleanerInternal(volName, podUID, &AWSDiskUtil{}, mounter)
|
|
}
|
|
|
|
func (plugin *awsElasticBlockStorePlugin) newCleanerInternal(volName string, podUID types.UID, manager ebsManager, mounter mount.Interface) (volume.Cleaner, error) {
|
|
return &awsElasticBlockStoreCleaner{&awsElasticBlockStore{
|
|
podUID: podUID,
|
|
volName: volName,
|
|
manager: manager,
|
|
mounter: mounter,
|
|
plugin: plugin,
|
|
}}, nil
|
|
}
|
|
|
|
// Abstract interface to PD operations.
|
|
type ebsManager interface {
|
|
// Attaches the disk to the kubelet's host machine.
|
|
AttachAndMountDisk(b *awsElasticBlockStoreBuilder, globalPDPath string) error
|
|
// Detaches the disk from the kubelet's host machine.
|
|
DetachDisk(c *awsElasticBlockStoreCleaner) error
|
|
}
|
|
|
|
// awsElasticBlockStore volumes are disk resources provided by Google Compute Engine
|
|
// that are attached to the kubelet's host machine and exposed to the pod.
|
|
type awsElasticBlockStore struct {
|
|
volName string
|
|
podUID types.UID
|
|
// Unique id of the PD, used to find the disk resource in the provider.
|
|
volumeID string
|
|
// Utility interface that provides API calls to the provider to attach/detach disks.
|
|
manager ebsManager
|
|
// Mounter interface that provides system calls to mount the global path to the pod local path.
|
|
mounter mount.Interface
|
|
plugin *awsElasticBlockStorePlugin
|
|
}
|
|
|
|
func detachDiskLogError(ebs *awsElasticBlockStore) {
|
|
err := ebs.manager.DetachDisk(&awsElasticBlockStoreCleaner{ebs})
|
|
if err != nil {
|
|
glog.Warningf("Failed to detach disk: %v (%v)", ebs, err)
|
|
}
|
|
}
|
|
|
|
// getVolumeProvider returns the AWS Volumes interface
|
|
func (ebs *awsElasticBlockStore) getVolumeProvider() (aws_cloud.Volumes, error) {
|
|
name := "aws"
|
|
cloud, err := cloudprovider.GetCloudProvider(name, nil)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
volumes, ok := cloud.(aws_cloud.Volumes)
|
|
if !ok {
|
|
return nil, fmt.Errorf("Cloud provider does not support volumes")
|
|
}
|
|
return volumes, nil
|
|
}
|
|
|
|
type awsElasticBlockStoreBuilder struct {
|
|
*awsElasticBlockStore
|
|
// Filesystem type, optional.
|
|
fsType string
|
|
// Specifies the partition to mount
|
|
partition string
|
|
// Specifies whether the disk will be attached as read-only.
|
|
readOnly bool
|
|
// diskMounter provides the interface that is used to mount the actual block device.
|
|
diskMounter mount.Interface
|
|
}
|
|
|
|
var _ volume.Builder = &awsElasticBlockStoreBuilder{}
|
|
|
|
// SetUp attaches the disk and bind mounts to the volume path.
|
|
func (b *awsElasticBlockStoreBuilder) SetUp() error {
|
|
return b.SetUpAt(b.GetPath())
|
|
}
|
|
|
|
// SetUpAt attaches the disk and bind mounts to the volume path.
|
|
func (b *awsElasticBlockStoreBuilder) SetUpAt(dir string) error {
|
|
// TODO: handle failed mounts here.
|
|
notMnt, err := b.mounter.IsLikelyNotMountPoint(dir)
|
|
glog.V(4).Infof("PersistentDisk set up: %s %v %v", dir, !notMnt, err)
|
|
if err != nil && !os.IsNotExist(err) {
|
|
return err
|
|
}
|
|
if !notMnt {
|
|
return nil
|
|
}
|
|
|
|
globalPDPath := makeGlobalPDPath(b.plugin.host, b.volumeID)
|
|
if err := b.manager.AttachAndMountDisk(b, globalPDPath); err != nil {
|
|
return err
|
|
}
|
|
|
|
if err := os.MkdirAll(dir, 0750); err != nil {
|
|
// TODO: we should really eject the attach/detach out into its own control loop.
|
|
detachDiskLogError(b.awsElasticBlockStore)
|
|
return err
|
|
}
|
|
|
|
// Perform a bind mount to the full path to allow duplicate mounts of the same PD.
|
|
options := []string{"bind"}
|
|
if b.readOnly {
|
|
options = append(options, "ro")
|
|
}
|
|
err = b.mounter.Mount(globalPDPath, dir, "", options)
|
|
if err != nil {
|
|
notMnt, mntErr := b.mounter.IsLikelyNotMountPoint(dir)
|
|
if mntErr != nil {
|
|
glog.Errorf("IsLikelyNotMountPoint check failed: %v", mntErr)
|
|
return err
|
|
}
|
|
if !notMnt {
|
|
if mntErr = b.mounter.Unmount(dir); mntErr != nil {
|
|
glog.Errorf("Failed to unmount: %v", mntErr)
|
|
return err
|
|
}
|
|
notMnt, mntErr := b.mounter.IsLikelyNotMountPoint(dir)
|
|
if mntErr != nil {
|
|
glog.Errorf("IsLikelyNotMountPoint check failed: %v", mntErr)
|
|
return err
|
|
}
|
|
if !notMnt {
|
|
// This is very odd, we don't expect it. We'll try again next sync loop.
|
|
glog.Errorf("%s is still mounted, despite call to unmount(). Will try again next sync loop.", dir)
|
|
return err
|
|
}
|
|
}
|
|
os.Remove(dir)
|
|
// TODO: we should really eject the attach/detach out into its own control loop.
|
|
detachDiskLogError(b.awsElasticBlockStore)
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (b *awsElasticBlockStoreBuilder) IsReadOnly() bool {
|
|
return b.readOnly
|
|
}
|
|
|
|
func makeGlobalPDPath(host volume.VolumeHost, volumeID string) string {
|
|
// Clean up the URI to be more fs-friendly
|
|
name := volumeID
|
|
name = strings.Replace(name, "://", "/", -1)
|
|
return path.Join(host.GetPluginDir(awsElasticBlockStorePluginName), "mounts", name)
|
|
}
|
|
|
|
func getVolumeIDFromGlobalMount(host volume.VolumeHost, globalPath string) (string, error) {
|
|
basePath := path.Join(host.GetPluginDir(awsElasticBlockStorePluginName), "mounts")
|
|
rel, err := filepath.Rel(basePath, globalPath)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
if strings.Contains(rel, "../") {
|
|
return "", fmt.Errorf("Unexpected mount path: " + globalPath)
|
|
}
|
|
// Reverse the :// replacement done in makeGlobalPDPath
|
|
volumeID := rel
|
|
if strings.HasPrefix(volumeID, "aws/") {
|
|
volumeID = strings.Replace(volumeID, "aws/", "aws://", 1)
|
|
}
|
|
glog.V(2).Info("Mapping mount dir ", globalPath, " to volumeID ", volumeID)
|
|
return volumeID, nil
|
|
}
|
|
|
|
func (ebs *awsElasticBlockStore) GetPath() string {
|
|
name := awsElasticBlockStorePluginName
|
|
return ebs.plugin.host.GetPodVolumeDir(ebs.podUID, util.EscapeQualifiedNameForDisk(name), ebs.volName)
|
|
}
|
|
|
|
type awsElasticBlockStoreCleaner struct {
|
|
*awsElasticBlockStore
|
|
}
|
|
|
|
var _ volume.Cleaner = &awsElasticBlockStoreCleaner{}
|
|
|
|
// Unmounts the bind mount, and detaches the disk only if the PD
|
|
// resource was the last reference to that disk on the kubelet.
|
|
func (c *awsElasticBlockStoreCleaner) TearDown() error {
|
|
return c.TearDownAt(c.GetPath())
|
|
}
|
|
|
|
// Unmounts the bind mount, and detaches the disk only if the PD
|
|
// resource was the last reference to that disk on the kubelet.
|
|
func (c *awsElasticBlockStoreCleaner) TearDownAt(dir string) error {
|
|
notMnt, err := c.mounter.IsLikelyNotMountPoint(dir)
|
|
if err != nil {
|
|
glog.V(2).Info("Error checking if mountpoint ", dir, ": ", err)
|
|
return err
|
|
}
|
|
if notMnt {
|
|
glog.V(2).Info("Not mountpoint, deleting")
|
|
return os.Remove(dir)
|
|
}
|
|
|
|
refs, err := mount.GetMountRefs(c.mounter, dir)
|
|
if err != nil {
|
|
glog.V(2).Info("Error getting mountrefs for ", dir, ": ", err)
|
|
return err
|
|
}
|
|
if len(refs) == 0 {
|
|
glog.Warning("Did not find pod-mount for ", dir, " during tear-down")
|
|
}
|
|
// Unmount the bind-mount inside this pod
|
|
if err := c.mounter.Unmount(dir); err != nil {
|
|
glog.V(2).Info("Error unmounting dir ", dir, ": ", err)
|
|
return err
|
|
}
|
|
// If len(refs) is 1, then all bind mounts have been removed, and the
|
|
// remaining reference is the global mount. It is safe to detach.
|
|
if len(refs) == 1 {
|
|
// c.volumeID is not initially set for volume-cleaners, so set it here.
|
|
c.volumeID, err = getVolumeIDFromGlobalMount(c.plugin.host, refs[0])
|
|
if err != nil {
|
|
glog.V(2).Info("Could not determine volumeID from mountpoint ", refs[0], ": ", err)
|
|
return err
|
|
}
|
|
if err := c.manager.DetachDisk(&awsElasticBlockStoreCleaner{c.awsElasticBlockStore}); err != nil {
|
|
glog.V(2).Info("Error detaching disk ", c.volumeID, ": ", err)
|
|
return err
|
|
}
|
|
} else {
|
|
glog.V(2).Infof("Found multiple refs; won't detach EBS volume: %v", refs)
|
|
}
|
|
notMnt, mntErr := c.mounter.IsLikelyNotMountPoint(dir)
|
|
if mntErr != nil {
|
|
glog.Errorf("IsLikelyNotMountPoint check failed: %v", mntErr)
|
|
return err
|
|
}
|
|
if notMnt {
|
|
if err := os.Remove(dir); err != nil {
|
|
glog.V(2).Info("Error removing mountpoint ", dir, ": ", err)
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|