
This change makes it so that no escalation check is performed when updating only the garbage collector fields (owner references and finalizers) of RBAC resources. This allows the garbage collector to delete roles that grant permissions such as "create", which it will never have. Signed-off-by: Monis Khan <mkhan@redhat.com>
49 lines
1.5 KiB
Go
49 lines
1.5 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package rbac
|
|
|
|
import (
|
|
"k8s.io/apimachinery/pkg/api/meta"
|
|
"k8s.io/apimachinery/pkg/conversion"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
kapi "k8s.io/kubernetes/pkg/api"
|
|
)
|
|
|
|
// IsOnlyMutatingGCFields checks finalizers and ownerrefs which GC manipulates
|
|
// and indicates that only those fields are changing
|
|
func IsOnlyMutatingGCFields(obj, old runtime.Object, equalities conversion.Equalities) bool {
|
|
// make a copy of the newObj so that we can stomp for comparison
|
|
copied, err := kapi.Scheme.Copy(obj)
|
|
if err != nil {
|
|
// if we couldn't copy, don't fail, just make it do the check
|
|
return false
|
|
}
|
|
copiedMeta, err := meta.Accessor(copied)
|
|
if err != nil {
|
|
return false
|
|
}
|
|
oldMeta, err := meta.Accessor(old)
|
|
if err != nil {
|
|
return false
|
|
}
|
|
copiedMeta.SetOwnerReferences(oldMeta.GetOwnerReferences())
|
|
copiedMeta.SetFinalizers(oldMeta.GetFinalizers())
|
|
copiedMeta.SetSelfLink(oldMeta.GetSelfLink())
|
|
|
|
return equalities.DeepEqual(copied, old)
|
|
}
|