
As discussed during the SIG Testing meeting on January 10, 2023, failing Windows unit tests are now skipped. These changes should be reverted when the unit tests wil get fixed. Mentioned SIG Testing meeting: https://docs.google.com/document/d/1z8MQpr_jTwhmjLMUaqQyBk1EYG_Y_3D4y4YdMJ7V1Kk/edit#heading=h.qwblxf2uhgoo
728 lines
21 KiB
Go
728 lines
21 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package store
|
|
|
|
import (
|
|
"fmt"
|
|
"path/filepath"
|
|
"reflect"
|
|
"runtime"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/davecgh/go-spew/spew"
|
|
|
|
apiv1 "k8s.io/api/core/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/types"
|
|
"k8s.io/kubelet/config/v1beta1"
|
|
kubeletconfig "k8s.io/kubernetes/pkg/kubelet/apis/config"
|
|
"k8s.io/kubernetes/pkg/kubelet/apis/config/scheme"
|
|
"k8s.io/kubernetes/pkg/kubelet/kubeletconfig/checkpoint"
|
|
utilcodec "k8s.io/kubernetes/pkg/kubelet/kubeletconfig/util/codec"
|
|
utilfiles "k8s.io/kubernetes/pkg/kubelet/kubeletconfig/util/files"
|
|
utiltest "k8s.io/kubernetes/pkg/kubelet/kubeletconfig/util/test"
|
|
utilfs "k8s.io/kubernetes/pkg/util/filesystem"
|
|
)
|
|
|
|
func newInitializedFakeFsStore() (*fsStore, error) {
|
|
// Test with the default filesystem, the fake filesystem has an issue caused by afero: https://github.com/spf13/afero/issues/141
|
|
// The default filesystem also behaves more like production, so we should probably not mock the filesystem for unit tests.
|
|
fs := &utilfs.DefaultFs{}
|
|
|
|
tmpDir, err := fs.TempDir("", "fsstore-test-")
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
store := NewFsStore(fs, tmpDir)
|
|
if err := store.Initialize(); err != nil {
|
|
return nil, err
|
|
}
|
|
return store.(*fsStore), nil
|
|
}
|
|
|
|
func cleanupFakeFsStore(store *fsStore) {
|
|
_ = store.fs.RemoveAll(store.dir)
|
|
}
|
|
|
|
func TestFsStoreInitialize(t *testing.T) {
|
|
store, err := newInitializedFakeFsStore()
|
|
if err != nil {
|
|
t.Fatalf("fsStore.Initialize() failed with error: %v", err)
|
|
}
|
|
defer cleanupFakeFsStore(store)
|
|
|
|
// check that store.dir exists
|
|
if _, err := store.fs.Stat(store.dir); err != nil {
|
|
t.Fatalf("expect %q to exist, but stat failed with error: %v", store.dir, err)
|
|
}
|
|
|
|
// check that meta dir exists
|
|
if _, err := store.fs.Stat(store.metaPath("")); err != nil {
|
|
t.Fatalf("expect %q to exist, but stat failed with error: %v", store.metaPath(""), err)
|
|
}
|
|
|
|
// check that checkpoints dir exists
|
|
if _, err := store.fs.Stat(filepath.Join(store.dir, checkpointsDir)); err != nil {
|
|
t.Fatalf("expect %q to exist, but stat failed with error: %v", filepath.Join(store.dir, checkpointsDir), err)
|
|
}
|
|
|
|
// check that assignedFile exists
|
|
if _, err := store.fs.Stat(store.metaPath(assignedFile)); err != nil {
|
|
t.Fatalf("expect %q to exist, but stat failed with error: %v", store.metaPath(assignedFile), err)
|
|
}
|
|
|
|
// check that lastKnownGoodFile exists
|
|
if _, err := store.fs.Stat(store.metaPath(lastKnownGoodFile)); err != nil {
|
|
t.Fatalf("expect %q to exist, but stat failed with error: %v", store.metaPath(lastKnownGoodFile), err)
|
|
}
|
|
}
|
|
|
|
func TestFsStoreExists(t *testing.T) {
|
|
store, err := newInitializedFakeFsStore()
|
|
if err != nil {
|
|
t.Fatalf("error constructing store: %v", err)
|
|
}
|
|
defer cleanupFakeFsStore(store)
|
|
|
|
// checkpoint a payload
|
|
const (
|
|
uid = "uid"
|
|
resourceVersion = "1"
|
|
)
|
|
p, err := checkpoint.NewConfigMapPayload(&apiv1.ConfigMap{ObjectMeta: metav1.ObjectMeta{UID: uid, ResourceVersion: resourceVersion}})
|
|
if err != nil {
|
|
t.Fatalf("could not construct Payload, error: %v", err)
|
|
}
|
|
if err := store.Save(p); err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
|
|
cases := []struct {
|
|
desc string
|
|
uid types.UID
|
|
resourceVersion string
|
|
expect bool
|
|
err string
|
|
}{
|
|
{"exists", uid, resourceVersion, true, ""},
|
|
{"does not exist", "bogus-uid", "bogus-resourceVersion", false, ""},
|
|
{"ambiguous UID", "", "bogus-resourceVersion", false, "empty UID is ambiguous"},
|
|
{"ambiguous ResourceVersion", "bogus-uid", "", false, "empty ResourceVersion is ambiguous"},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.desc, func(t *testing.T) {
|
|
source, _, err := checkpoint.NewRemoteConfigSource(&apiv1.NodeConfigSource{
|
|
ConfigMap: &apiv1.ConfigMapNodeConfigSource{
|
|
Name: "name",
|
|
Namespace: "namespace",
|
|
UID: c.uid,
|
|
ResourceVersion: c.resourceVersion,
|
|
KubeletConfigKey: "kubelet",
|
|
}})
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
ok, err := store.Exists(source)
|
|
utiltest.ExpectError(t, err, c.err)
|
|
if err != nil {
|
|
return
|
|
}
|
|
if c.expect != ok {
|
|
t.Errorf("expect %t but got %t", c.expect, ok)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestFsStoreSave(t *testing.T) {
|
|
store, err := newInitializedFakeFsStore()
|
|
if err != nil {
|
|
t.Fatalf("error constructing store: %v", err)
|
|
}
|
|
defer cleanupFakeFsStore(store)
|
|
|
|
nameTooLong := func() string {
|
|
s := ""
|
|
for i := 0; i < 256; i++ {
|
|
s += "a"
|
|
}
|
|
return s
|
|
}()
|
|
|
|
const (
|
|
uid = "uid"
|
|
resourceVersion = "1"
|
|
)
|
|
|
|
cases := []struct {
|
|
desc string
|
|
uid types.UID
|
|
resourceVersion string
|
|
files map[string]string
|
|
err string
|
|
}{
|
|
{"valid payload", uid, resourceVersion, map[string]string{"foo": "foocontent", "bar": "barcontent"}, ""},
|
|
{"empty key name", uid, resourceVersion, map[string]string{"": "foocontent"}, "must not be empty"},
|
|
{"key name is not a base file name (foo/bar)", uid, resourceVersion, map[string]string{"foo/bar": "foocontent"}, "only base names are allowed"},
|
|
{"key name is not a base file name (/foo)", uid, resourceVersion, map[string]string{"/bar": "foocontent"}, "only base names are allowed"},
|
|
{"used .", uid, resourceVersion, map[string]string{".": "foocontent"}, "may not be '.' or '..'"},
|
|
{"used ..", uid, resourceVersion, map[string]string{"..": "foocontent"}, "may not be '.' or '..'"},
|
|
{"length violation", uid, resourceVersion, map[string]string{nameTooLong: "foocontent"}, "must be less than 255 characters"},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.desc, func(t *testing.T) {
|
|
// construct the payload
|
|
p, err := checkpoint.NewConfigMapPayload(&apiv1.ConfigMap{
|
|
ObjectMeta: metav1.ObjectMeta{UID: c.uid, ResourceVersion: c.resourceVersion},
|
|
Data: c.files,
|
|
})
|
|
// if no error, save the payload, otherwise skip straight to error handler
|
|
if err == nil {
|
|
err = store.Save(p)
|
|
}
|
|
utiltest.ExpectError(t, err, c.err)
|
|
if err != nil {
|
|
return
|
|
}
|
|
// read the saved checkpoint
|
|
m, err := mapFromCheckpoint(store, p.UID(), p.ResourceVersion())
|
|
if err != nil {
|
|
t.Fatalf("error loading checkpoint to map: %v", err)
|
|
}
|
|
// compare our expectation to what got saved
|
|
expect := p.Files()
|
|
if !reflect.DeepEqual(expect, m) {
|
|
t.Errorf("expect %v, but got %v", expect, m)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestFsStoreLoad(t *testing.T) {
|
|
store, err := newInitializedFakeFsStore()
|
|
if err != nil {
|
|
t.Fatalf("error constructing store: %v", err)
|
|
}
|
|
defer cleanupFakeFsStore(store)
|
|
|
|
// encode a kubelet configuration that has all defaults set
|
|
expect, err := newKubeletConfiguration()
|
|
if err != nil {
|
|
t.Fatalf("error constructing KubeletConfiguration: %v", err)
|
|
}
|
|
data, err := utilcodec.EncodeKubeletConfig(expect, v1beta1.SchemeGroupVersion)
|
|
if err != nil {
|
|
t.Fatalf("error encoding KubeletConfiguration: %v", err)
|
|
}
|
|
// construct a payload that contains the kubeletconfig
|
|
const (
|
|
uid = "uid"
|
|
resourceVersion = "1"
|
|
kubeletKey = "kubelet"
|
|
)
|
|
p, err := checkpoint.NewConfigMapPayload(&apiv1.ConfigMap{
|
|
ObjectMeta: metav1.ObjectMeta{UID: types.UID(uid), ResourceVersion: resourceVersion},
|
|
Data: map[string]string{
|
|
kubeletKey: string(data),
|
|
},
|
|
})
|
|
if err != nil {
|
|
t.Fatalf("error constructing payload: %v", err)
|
|
}
|
|
// save the payload
|
|
err = store.Save(p)
|
|
if err != nil {
|
|
t.Fatalf("error saving payload: %v", err)
|
|
}
|
|
|
|
cases := []struct {
|
|
desc string
|
|
uid types.UID
|
|
resourceVersion string
|
|
err string
|
|
skipOnWindows bool
|
|
}{
|
|
{"checkpoint exists", uid, resourceVersion, "", true},
|
|
{"checkpoint does not exist", "bogus-uid", "bogus-resourceVersion", "no checkpoint for source", false},
|
|
{"ambiguous UID", "", "bogus-resourceVersion", "empty UID is ambiguous", false},
|
|
{"ambiguous ResourceVersion", "bogus-uid", "", "empty ResourceVersion is ambiguous", false},
|
|
}
|
|
for _, c := range cases {
|
|
t.Run(c.desc, func(t *testing.T) {
|
|
// Skip tests that fail on Windows, as discussed during the SIG Testing meeting from January 10, 2023
|
|
if c.skipOnWindows && runtime.GOOS == "windows" {
|
|
t.Skip("Skipping test that fails on Windows")
|
|
}
|
|
|
|
source, _, err := checkpoint.NewRemoteConfigSource(&apiv1.NodeConfigSource{
|
|
ConfigMap: &apiv1.ConfigMapNodeConfigSource{
|
|
Name: "name",
|
|
Namespace: "namespace",
|
|
UID: c.uid,
|
|
ResourceVersion: c.resourceVersion,
|
|
KubeletConfigKey: kubeletKey,
|
|
}})
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
loaded, err := store.Load(source)
|
|
utiltest.ExpectError(t, err, c.err)
|
|
if err != nil {
|
|
return
|
|
}
|
|
if !reflect.DeepEqual(expect, loaded) {
|
|
t.Errorf("expect %#v, but got %#v", expect, loaded)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestFsStoreAssignedModified(t *testing.T) {
|
|
store, err := newInitializedFakeFsStore()
|
|
if err != nil {
|
|
t.Fatalf("error constructing store: %v", err)
|
|
}
|
|
defer cleanupFakeFsStore(store)
|
|
|
|
// create an empty assigned file, this is good enough for testing
|
|
saveTestSourceFile(t, store, assignedFile, nil)
|
|
|
|
// round the current time to the nearest second because some file systems do not support sub-second precision.
|
|
now := time.Now().Round(time.Second)
|
|
// set the timestamps to the current time, so we can compare to result of store.AssignedModified
|
|
err = store.fs.Chtimes(store.metaPath(assignedFile), now, now)
|
|
if err != nil {
|
|
t.Fatalf("could not change timestamps, error: %v", err)
|
|
}
|
|
|
|
modTime, err := store.AssignedModified()
|
|
if err != nil {
|
|
t.Fatalf("unable to determine modification time of assigned config source, error: %v", err)
|
|
}
|
|
if !now.Equal(modTime) {
|
|
t.Errorf("expect %q but got %q", now.Format(time.RFC3339), modTime.Format(time.RFC3339))
|
|
}
|
|
}
|
|
|
|
func TestFsStoreAssigned(t *testing.T) {
|
|
store, err := newInitializedFakeFsStore()
|
|
if err != nil {
|
|
t.Fatalf("error constructing store: %v", err)
|
|
}
|
|
defer cleanupFakeFsStore(store)
|
|
|
|
source, _, err := checkpoint.NewRemoteConfigSource(&apiv1.NodeConfigSource{
|
|
ConfigMap: &apiv1.ConfigMapNodeConfigSource{
|
|
Name: "name",
|
|
Namespace: "namespace",
|
|
UID: "uid",
|
|
KubeletConfigKey: "kubelet",
|
|
}})
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
|
|
cases := []struct {
|
|
desc string
|
|
expect checkpoint.RemoteConfigSource
|
|
err string
|
|
}{
|
|
{"default source", nil, ""},
|
|
{"non-default source", source, ""},
|
|
}
|
|
for _, c := range cases {
|
|
t.Run(c.desc, func(t *testing.T) {
|
|
// save the last known good source
|
|
saveTestSourceFile(t, store, assignedFile, c.expect)
|
|
|
|
// load last-known-good and compare to expected result
|
|
source, err := store.Assigned()
|
|
utiltest.ExpectError(t, err, c.err)
|
|
if err != nil {
|
|
return
|
|
}
|
|
if !checkpoint.EqualRemoteConfigSources(c.expect, source) {
|
|
t.Errorf("case %q, expect %q but got %q", spew.Sdump(c.expect), spew.Sdump(c.expect), spew.Sdump(source))
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestFsStoreLastKnownGood(t *testing.T) {
|
|
store, err := newInitializedFakeFsStore()
|
|
if err != nil {
|
|
t.Fatalf("error constructing store: %v", err)
|
|
}
|
|
defer cleanupFakeFsStore(store)
|
|
|
|
source, _, err := checkpoint.NewRemoteConfigSource(&apiv1.NodeConfigSource{
|
|
ConfigMap: &apiv1.ConfigMapNodeConfigSource{
|
|
Name: "name",
|
|
Namespace: "namespace",
|
|
UID: "uid",
|
|
KubeletConfigKey: "kubelet",
|
|
}})
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
|
|
cases := []struct {
|
|
desc string
|
|
expect checkpoint.RemoteConfigSource
|
|
err string
|
|
}{
|
|
{"default source", nil, ""},
|
|
{"non-default source", source, ""},
|
|
}
|
|
for _, c := range cases {
|
|
t.Run(c.desc, func(t *testing.T) {
|
|
// save the last known good source
|
|
saveTestSourceFile(t, store, lastKnownGoodFile, c.expect)
|
|
|
|
// load last-known-good and compare to expected result
|
|
source, err := store.LastKnownGood()
|
|
utiltest.ExpectError(t, err, c.err)
|
|
if err != nil {
|
|
return
|
|
}
|
|
if !checkpoint.EqualRemoteConfigSources(c.expect, source) {
|
|
t.Errorf("case %q, expect %q but got %q", spew.Sdump(c.expect), spew.Sdump(c.expect), spew.Sdump(source))
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestFsStoreSetAssigned(t *testing.T) {
|
|
store, err := newInitializedFakeFsStore()
|
|
if err != nil {
|
|
t.Fatalf("error constructing store: %v", err)
|
|
}
|
|
defer cleanupFakeFsStore(store)
|
|
|
|
cases := []struct {
|
|
desc string
|
|
source *apiv1.NodeConfigSource
|
|
expect string
|
|
err string
|
|
}{
|
|
{
|
|
desc: "nil source",
|
|
expect: "", // empty file
|
|
},
|
|
{
|
|
desc: "non-nil source",
|
|
source: &apiv1.NodeConfigSource{ConfigMap: &apiv1.ConfigMapNodeConfigSource{
|
|
Name: "name",
|
|
Namespace: "namespace",
|
|
UID: "uid",
|
|
ResourceVersion: "1",
|
|
KubeletConfigKey: "kubelet",
|
|
}},
|
|
expect: `apiVersion: kubelet.config.k8s.io/v1beta1
|
|
kind: SerializedNodeConfigSource
|
|
source:
|
|
configMap:
|
|
kubeletConfigKey: kubelet
|
|
name: name
|
|
namespace: namespace
|
|
resourceVersion: "1"
|
|
uid: uid
|
|
`,
|
|
},
|
|
{
|
|
desc: "missing UID",
|
|
source: &apiv1.NodeConfigSource{ConfigMap: &apiv1.ConfigMapNodeConfigSource{
|
|
Name: "name",
|
|
Namespace: "namespace",
|
|
ResourceVersion: "1",
|
|
KubeletConfigKey: "kubelet",
|
|
}},
|
|
err: "failed to write RemoteConfigSource, empty UID is ambiguous",
|
|
},
|
|
{
|
|
desc: "missing ResourceVersion",
|
|
source: &apiv1.NodeConfigSource{ConfigMap: &apiv1.ConfigMapNodeConfigSource{
|
|
Name: "name",
|
|
Namespace: "namespace",
|
|
UID: "uid",
|
|
KubeletConfigKey: "kubelet",
|
|
}},
|
|
err: "failed to write RemoteConfigSource, empty ResourceVersion is ambiguous",
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.desc, func(t *testing.T) {
|
|
var source checkpoint.RemoteConfigSource
|
|
if c.source != nil {
|
|
s, _, err := checkpoint.NewRemoteConfigSource(c.source)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
source = s
|
|
}
|
|
// save the assigned source
|
|
err = store.SetAssigned(source)
|
|
utiltest.ExpectError(t, err, c.err)
|
|
if err != nil {
|
|
return
|
|
}
|
|
// check that the source saved as we would expect
|
|
data := readTestSourceFile(t, store, assignedFile)
|
|
if c.expect != string(data) {
|
|
t.Errorf("expect assigned source file to contain %q, but got %q", c.expect, string(data))
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestFsStoreSetLastKnownGood(t *testing.T) {
|
|
store, err := newInitializedFakeFsStore()
|
|
if err != nil {
|
|
t.Fatalf("error constructing store: %v", err)
|
|
}
|
|
defer cleanupFakeFsStore(store)
|
|
|
|
cases := []struct {
|
|
desc string
|
|
source *apiv1.NodeConfigSource
|
|
expect string
|
|
err string
|
|
}{
|
|
{
|
|
desc: "nil source",
|
|
expect: "", // empty file
|
|
},
|
|
{
|
|
desc: "non-nil source",
|
|
source: &apiv1.NodeConfigSource{ConfigMap: &apiv1.ConfigMapNodeConfigSource{
|
|
Name: "name",
|
|
Namespace: "namespace",
|
|
UID: "uid",
|
|
ResourceVersion: "1",
|
|
KubeletConfigKey: "kubelet",
|
|
}},
|
|
expect: `apiVersion: kubelet.config.k8s.io/v1beta1
|
|
kind: SerializedNodeConfigSource
|
|
source:
|
|
configMap:
|
|
kubeletConfigKey: kubelet
|
|
name: name
|
|
namespace: namespace
|
|
resourceVersion: "1"
|
|
uid: uid
|
|
`,
|
|
},
|
|
{
|
|
desc: "missing UID",
|
|
source: &apiv1.NodeConfigSource{ConfigMap: &apiv1.ConfigMapNodeConfigSource{
|
|
Name: "name",
|
|
Namespace: "namespace",
|
|
ResourceVersion: "1",
|
|
KubeletConfigKey: "kubelet",
|
|
}},
|
|
err: "failed to write RemoteConfigSource, empty UID is ambiguous",
|
|
},
|
|
{
|
|
desc: "missing ResourceVersion",
|
|
source: &apiv1.NodeConfigSource{ConfigMap: &apiv1.ConfigMapNodeConfigSource{
|
|
Name: "name",
|
|
Namespace: "namespace",
|
|
UID: "uid",
|
|
KubeletConfigKey: "kubelet",
|
|
}},
|
|
err: "failed to write RemoteConfigSource, empty ResourceVersion is ambiguous",
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.desc, func(t *testing.T) {
|
|
var source checkpoint.RemoteConfigSource
|
|
if c.source != nil {
|
|
s, _, err := checkpoint.NewRemoteConfigSource(c.source)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
source = s
|
|
}
|
|
// save the assigned source
|
|
err = store.SetLastKnownGood(source)
|
|
utiltest.ExpectError(t, err, c.err)
|
|
if err != nil {
|
|
return
|
|
}
|
|
// check that the source saved as we would expect
|
|
data := readTestSourceFile(t, store, lastKnownGoodFile)
|
|
if c.expect != string(data) {
|
|
t.Errorf("expect assigned source file to contain %q, but got %q", c.expect, string(data))
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestFsStoreReset(t *testing.T) {
|
|
store, err := newInitializedFakeFsStore()
|
|
if err != nil {
|
|
t.Fatalf("error constructing store: %v", err)
|
|
}
|
|
defer cleanupFakeFsStore(store)
|
|
|
|
source, _, err := checkpoint.NewRemoteConfigSource(&apiv1.NodeConfigSource{ConfigMap: &apiv1.ConfigMapNodeConfigSource{
|
|
Name: "name",
|
|
Namespace: "namespace",
|
|
UID: "uid",
|
|
KubeletConfigKey: "kubelet",
|
|
}})
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
otherSource, _, err := checkpoint.NewRemoteConfigSource(&apiv1.NodeConfigSource{ConfigMap: &apiv1.ConfigMapNodeConfigSource{
|
|
Name: "other-name",
|
|
Namespace: "namespace",
|
|
UID: "other-uid",
|
|
KubeletConfigKey: "kubelet",
|
|
}})
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
cases := []struct {
|
|
desc string
|
|
assigned checkpoint.RemoteConfigSource
|
|
lastKnownGood checkpoint.RemoteConfigSource
|
|
updated bool
|
|
}{
|
|
{"nil -> nil", nil, nil, false},
|
|
{"source -> nil", source, nil, true},
|
|
{"nil -> source", nil, source, false},
|
|
{"source -> source", source, source, true},
|
|
{"source -> otherSource", source, otherSource, true},
|
|
{"otherSource -> source", otherSource, source, true},
|
|
}
|
|
for _, c := range cases {
|
|
t.Run(c.desc, func(t *testing.T) {
|
|
// manually save the sources to their respective files
|
|
saveTestSourceFile(t, store, assignedFile, c.assigned)
|
|
saveTestSourceFile(t, store, lastKnownGoodFile, c.lastKnownGood)
|
|
|
|
// reset
|
|
updated, err := store.Reset()
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
|
|
// make sure the files were emptied
|
|
if size := testSourceFileSize(t, store, assignedFile); size > 0 {
|
|
t.Errorf("case %q, expect source file %q to be empty but got %d bytes", c.desc, assignedFile, size)
|
|
}
|
|
if size := testSourceFileSize(t, store, lastKnownGoodFile); size > 0 {
|
|
t.Errorf("case %q, expect source file %q to be empty but got %d bytes", c.desc, lastKnownGoodFile, size)
|
|
}
|
|
|
|
// make sure Assigned() and LastKnownGood() both return nil
|
|
assigned, err := store.Assigned()
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
lastKnownGood, err := store.LastKnownGood()
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if assigned != nil || lastKnownGood != nil {
|
|
t.Errorf("case %q, expect nil for assigned and last-known-good checkpoints, but still have %q and %q, respectively",
|
|
c.desc, assigned, lastKnownGood)
|
|
}
|
|
if c.updated != updated {
|
|
t.Errorf("case %q, expect reset to return %t, but got %t", c.desc, c.updated, updated)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func mapFromCheckpoint(store *fsStore, uid, resourceVersion string) (map[string]string, error) {
|
|
files, err := store.fs.ReadDir(store.checkpointPath(uid, resourceVersion))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
m := map[string]string{}
|
|
for _, f := range files {
|
|
// expect no subdirs, only regular files
|
|
if !f.Type().IsRegular() {
|
|
return nil, fmt.Errorf("expect only regular files in checkpoint dir %q", uid)
|
|
}
|
|
// read the file contents and build the map
|
|
data, err := store.fs.ReadFile(filepath.Join(store.checkpointPath(uid, resourceVersion), f.Name()))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
m[f.Name()] = string(data)
|
|
}
|
|
return m, nil
|
|
}
|
|
|
|
func readTestSourceFile(t *testing.T, store *fsStore, relPath string) []byte {
|
|
data, err := store.fs.ReadFile(store.metaPath(relPath))
|
|
if err != nil {
|
|
t.Fatalf("unable to read test source file, error: %v", err)
|
|
}
|
|
return data
|
|
}
|
|
|
|
func saveTestSourceFile(t *testing.T, store *fsStore, relPath string, source checkpoint.RemoteConfigSource) {
|
|
if source != nil {
|
|
data, err := source.Encode()
|
|
if err != nil {
|
|
t.Fatalf("unable to save test source file, error: %v", err)
|
|
}
|
|
err = utilfiles.ReplaceFile(store.fs, store.metaPath(relPath), data)
|
|
if err != nil {
|
|
t.Fatalf("unable to save test source file, error: %v", err)
|
|
}
|
|
} else {
|
|
err := utilfiles.ReplaceFile(store.fs, store.metaPath(relPath), []byte{})
|
|
if err != nil {
|
|
t.Fatalf("unable to save test source file, error: %v", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func testSourceFileSize(t *testing.T, store *fsStore, relPath string) int64 {
|
|
info, err := store.fs.Stat(store.metaPath(relPath))
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
return info.Size()
|
|
}
|
|
|
|
// newKubeletConfiguration will create a new KubeletConfiguration with default values set
|
|
func newKubeletConfiguration() (*kubeletconfig.KubeletConfiguration, error) {
|
|
s, _, err := scheme.NewSchemeAndCodecs()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
versioned := &v1beta1.KubeletConfiguration{}
|
|
s.Default(versioned)
|
|
config := &kubeletconfig.KubeletConfiguration{}
|
|
if err := s.Convert(versioned, config, nil); err != nil {
|
|
return nil, err
|
|
}
|
|
return config, nil
|
|
}
|