50b377fe4e
Previously only "auto" was supported, a value that was inconsistent with Kubernetes naming patterns.
906 lines
34 KiB
Go
906 lines
34 KiB
Go
/*
|
|
Copyright 2019 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package proxy
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
|
|
v1 "k8s.io/api/core/v1"
|
|
"k8s.io/apimachinery/pkg/types"
|
|
"k8s.io/apimachinery/pkg/util/sets"
|
|
utilfeature "k8s.io/apiserver/pkg/util/feature"
|
|
featuregatetesting "k8s.io/component-base/featuregate/testing"
|
|
"k8s.io/kubernetes/pkg/features"
|
|
)
|
|
|
|
func TestFilterEndpoints(t *testing.T) {
|
|
type endpoint struct {
|
|
ip string
|
|
zoneHints sets.String
|
|
}
|
|
testCases := []struct {
|
|
name string
|
|
epsProxyingEnabled bool
|
|
serviceTopologyEnabled bool
|
|
hintsEnabled bool
|
|
nodeLabels map[string]string
|
|
serviceInfo ServicePort
|
|
endpoints []endpoint
|
|
expectedEndpoints []endpoint
|
|
}{{
|
|
name: "hints + eps proxying enabled, hints annotation == auto",
|
|
hintsEnabled: true,
|
|
epsProxyingEnabled: true,
|
|
nodeLabels: map[string]string{v1.LabelTopologyZone: "zone-a"},
|
|
serviceInfo: &BaseServiceInfo{nodeLocalExternal: false, hintsAnnotation: "auto"},
|
|
endpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5", zoneHints: sets.NewString("zone-c")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
expectedEndpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
}, {
|
|
name: "hints + eps proxying enabled, hints annotation == disabled, hints ignored",
|
|
hintsEnabled: true,
|
|
epsProxyingEnabled: true,
|
|
nodeLabels: map[string]string{v1.LabelTopologyZone: "zone-a"},
|
|
serviceInfo: &BaseServiceInfo{nodeLocalExternal: false, hintsAnnotation: "disabled"},
|
|
endpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5", zoneHints: sets.NewString("zone-c")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
expectedEndpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5", zoneHints: sets.NewString("zone-c")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
}, {
|
|
name: "hints + eps proxying enabled, hints annotation == aUto (wrong capitalization), hints ignored",
|
|
hintsEnabled: true,
|
|
epsProxyingEnabled: true,
|
|
nodeLabels: map[string]string{v1.LabelTopologyZone: "zone-a"},
|
|
serviceInfo: &BaseServiceInfo{nodeLocalExternal: false, hintsAnnotation: "aUto"},
|
|
endpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5", zoneHints: sets.NewString("zone-c")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
expectedEndpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5", zoneHints: sets.NewString("zone-c")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
}, {
|
|
name: "hints + eps proxying enabled, hints annotation empty, hints ignored",
|
|
hintsEnabled: true,
|
|
epsProxyingEnabled: true,
|
|
nodeLabels: map[string]string{v1.LabelTopologyZone: "zone-a"},
|
|
serviceInfo: &BaseServiceInfo{nodeLocalExternal: false},
|
|
endpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5", zoneHints: sets.NewString("zone-c")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
expectedEndpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5", zoneHints: sets.NewString("zone-c")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
}, {
|
|
name: "hints enabled, eps proxying not, hints are ignored",
|
|
hintsEnabled: true,
|
|
epsProxyingEnabled: false,
|
|
nodeLabels: map[string]string{v1.LabelTopologyZone: "zone-a"},
|
|
serviceInfo: &BaseServiceInfo{nodeLocalExternal: false},
|
|
endpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5", zoneHints: sets.NewString("zone-c")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
expectedEndpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5", zoneHints: sets.NewString("zone-c")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
}, {
|
|
name: "node local endpoints, hints are ignored",
|
|
hintsEnabled: true,
|
|
epsProxyingEnabled: true,
|
|
nodeLabels: map[string]string{v1.LabelTopologyZone: "zone-a"},
|
|
serviceInfo: &BaseServiceInfo{nodeLocalExternal: true},
|
|
endpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5", zoneHints: sets.NewString("zone-c")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
expectedEndpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5", zoneHints: sets.NewString("zone-c")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
}, {
|
|
name: "all gates enabled, serviceTopology gate takes precedence and hints are ignored",
|
|
hintsEnabled: true,
|
|
epsProxyingEnabled: true,
|
|
serviceTopologyEnabled: true,
|
|
nodeLabels: map[string]string{v1.LabelTopologyZone: "zone-a"},
|
|
serviceInfo: &BaseServiceInfo{nodeLocalExternal: true},
|
|
endpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5", zoneHints: sets.NewString("zone-c")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
expectedEndpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5", zoneHints: sets.NewString("zone-c")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
}}
|
|
|
|
endpointsToStringArray := func(endpoints []Endpoint) []string {
|
|
result := make([]string, 0, len(endpoints))
|
|
for _, ep := range endpoints {
|
|
result = append(result, ep.String())
|
|
}
|
|
return result
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.EndpointSliceProxying, tc.epsProxyingEnabled)()
|
|
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.ServiceTopology, tc.serviceTopologyEnabled)()
|
|
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.TopologyAwareHints, tc.hintsEnabled)()
|
|
|
|
endpoints := []Endpoint{}
|
|
for _, ep := range tc.endpoints {
|
|
endpoints = append(endpoints, &BaseEndpointInfo{Endpoint: ep.ip, ZoneHints: ep.zoneHints})
|
|
}
|
|
|
|
expectedEndpoints := []Endpoint{}
|
|
for _, ep := range tc.expectedEndpoints {
|
|
expectedEndpoints = append(expectedEndpoints, &BaseEndpointInfo{Endpoint: ep.ip, ZoneHints: ep.zoneHints})
|
|
}
|
|
|
|
filteredEndpoints := FilterEndpoints(endpoints, tc.serviceInfo, tc.nodeLabels)
|
|
if len(filteredEndpoints) != len(expectedEndpoints) {
|
|
t.Errorf("expected %d filtered endpoints, got %d", len(expectedEndpoints), len(filteredEndpoints))
|
|
}
|
|
if !reflect.DeepEqual(filteredEndpoints, expectedEndpoints) {
|
|
t.Errorf("expected %v, got %v", endpointsToStringArray(expectedEndpoints), endpointsToStringArray(filteredEndpoints))
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_filterEndpointsWithHints(t *testing.T) {
|
|
type endpoint struct {
|
|
ip string
|
|
zoneHints sets.String
|
|
}
|
|
testCases := []struct {
|
|
name string
|
|
nodeLabels map[string]string
|
|
hintsAnnotation string
|
|
endpoints []endpoint
|
|
expectedEndpoints []endpoint
|
|
}{{
|
|
name: "empty node labels",
|
|
nodeLabels: map[string]string{},
|
|
hintsAnnotation: "auto",
|
|
endpoints: []endpoint{{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")}},
|
|
expectedEndpoints: []endpoint{{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")}},
|
|
}, {
|
|
name: "empty zone label",
|
|
nodeLabels: map[string]string{v1.LabelTopologyZone: ""},
|
|
hintsAnnotation: "auto",
|
|
endpoints: []endpoint{{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")}},
|
|
expectedEndpoints: []endpoint{{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")}},
|
|
}, {
|
|
name: "node in different zone, no endpoint filtering",
|
|
nodeLabels: map[string]string{v1.LabelTopologyZone: "zone-b"},
|
|
hintsAnnotation: "auto",
|
|
endpoints: []endpoint{{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")}},
|
|
expectedEndpoints: []endpoint{{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")}},
|
|
}, {
|
|
name: "normal endpoint filtering, auto annotation",
|
|
nodeLabels: map[string]string{v1.LabelTopologyZone: "zone-a"},
|
|
hintsAnnotation: "auto",
|
|
endpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5", zoneHints: sets.NewString("zone-c")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
expectedEndpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
}, {
|
|
name: "normal endpoint filtering, Auto annotation",
|
|
nodeLabels: map[string]string{v1.LabelTopologyZone: "zone-a"},
|
|
hintsAnnotation: "Auto",
|
|
endpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5", zoneHints: sets.NewString("zone-c")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
expectedEndpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
}, {
|
|
name: "hintsAnnotation empty, no filtering applied",
|
|
nodeLabels: map[string]string{v1.LabelTopologyZone: "zone-a"},
|
|
hintsAnnotation: "",
|
|
endpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5", zoneHints: sets.NewString("zone-c")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
expectedEndpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5", zoneHints: sets.NewString("zone-c")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
}, {
|
|
name: "hintsAnnotation disabled, no filtering applied",
|
|
nodeLabels: map[string]string{v1.LabelTopologyZone: "zone-a"},
|
|
hintsAnnotation: "disabled",
|
|
endpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5", zoneHints: sets.NewString("zone-c")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
expectedEndpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5", zoneHints: sets.NewString("zone-c")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
}, {
|
|
name: "missing hints, no filtering applied",
|
|
nodeLabels: map[string]string{v1.LabelTopologyZone: "zone-a"},
|
|
hintsAnnotation: "auto",
|
|
endpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5"},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
expectedEndpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b")},
|
|
{ip: "10.1.2.5"},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-a")},
|
|
},
|
|
}, {
|
|
name: "multiple hints per endpoint, filtering includes any endpoint with zone included",
|
|
nodeLabels: map[string]string{v1.LabelTopologyZone: "zone-c"},
|
|
hintsAnnotation: "auto",
|
|
endpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a", "zone-b", "zone-c")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b", "zone-c")},
|
|
{ip: "10.1.2.5", zoneHints: sets.NewString("zone-b", "zone-d")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-c")},
|
|
},
|
|
expectedEndpoints: []endpoint{
|
|
{ip: "10.1.2.3", zoneHints: sets.NewString("zone-a", "zone-b", "zone-c")},
|
|
{ip: "10.1.2.4", zoneHints: sets.NewString("zone-b", "zone-c")},
|
|
{ip: "10.1.2.6", zoneHints: sets.NewString("zone-c")},
|
|
},
|
|
}}
|
|
|
|
endpointsToStringArray := func(endpoints []Endpoint) []string {
|
|
result := make([]string, 0, len(endpoints))
|
|
for _, ep := range endpoints {
|
|
result = append(result, ep.String())
|
|
}
|
|
return result
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
endpoints := []Endpoint{}
|
|
for _, ep := range tc.endpoints {
|
|
endpoints = append(endpoints, &BaseEndpointInfo{Endpoint: ep.ip, ZoneHints: ep.zoneHints})
|
|
}
|
|
|
|
expectedEndpoints := []Endpoint{}
|
|
for _, ep := range tc.expectedEndpoints {
|
|
expectedEndpoints = append(expectedEndpoints, &BaseEndpointInfo{Endpoint: ep.ip, ZoneHints: ep.zoneHints})
|
|
}
|
|
|
|
filteredEndpoints := filterEndpointsWithHints(endpoints, tc.hintsAnnotation, tc.nodeLabels)
|
|
if len(filteredEndpoints) != len(expectedEndpoints) {
|
|
t.Errorf("expected %d filtered endpoints, got %d", len(expectedEndpoints), len(filteredEndpoints))
|
|
}
|
|
if !reflect.DeepEqual(filteredEndpoints, expectedEndpoints) {
|
|
t.Errorf("expected %v, got %v", endpointsToStringArray(expectedEndpoints), endpointsToStringArray(filteredEndpoints))
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_deprecatedTopologyFilter(t *testing.T) {
|
|
type endpoint struct {
|
|
Endpoint string
|
|
NodeName types.NodeName
|
|
}
|
|
testCases := []struct {
|
|
Name string
|
|
nodeLabels map[types.NodeName]map[string]string
|
|
endpoints []endpoint
|
|
currentNodeName types.NodeName
|
|
topologyKeys []string
|
|
expected []endpoint
|
|
}{
|
|
{
|
|
// Case[0]: no topology key and endpoints at all = 0 endpoints
|
|
Name: "no topology key and endpoints",
|
|
nodeLabels: map[types.NodeName]map[string]string{
|
|
"testNode1": {
|
|
"kubernetes.io/hostname": "10.0.0.1",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
}},
|
|
endpoints: []endpoint{},
|
|
currentNodeName: "testNode1",
|
|
topologyKeys: nil,
|
|
expected: []endpoint{},
|
|
},
|
|
{
|
|
// Case[1]: no topology key, 2 nodes each with 2 endpoints = 4
|
|
// endpoints
|
|
Name: "no topology key but have endpoints",
|
|
nodeLabels: map[types.NodeName]map[string]string{
|
|
"testNode1": {
|
|
"kubernetes.io/hostname": "testNode1",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode2": {
|
|
"kubernetes.io/hostname": "testNode2",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
},
|
|
endpoints: []endpoint{
|
|
{Endpoint: "1.1.1.1:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.1.2:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.2.1:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.2.2:11", NodeName: "testNode2"},
|
|
},
|
|
currentNodeName: "testNode1",
|
|
topologyKeys: nil,
|
|
expected: []endpoint{
|
|
{Endpoint: "1.1.1.1:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.1.2:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.2.1:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.2.2:11", NodeName: "testNode2"},
|
|
},
|
|
},
|
|
{
|
|
// Case[2]: 1 topology key (hostname), 2 nodes each with 2 endpoints
|
|
// 1 match = 2 endpoints
|
|
Name: "one topology key with one node matched",
|
|
nodeLabels: map[types.NodeName]map[string]string{
|
|
"testNode1": {
|
|
"kubernetes.io/hostname": "testNode1",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode2": {
|
|
"kubernetes.io/hostname": "testNode2",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
},
|
|
endpoints: []endpoint{
|
|
{Endpoint: "1.1.1.1:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.1.2:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.2.1:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.2.2:11", NodeName: "testNode2"},
|
|
},
|
|
currentNodeName: "testNode1",
|
|
topologyKeys: []string{"kubernetes.io/hostname"},
|
|
expected: []endpoint{
|
|
{Endpoint: "1.1.1.1:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.1.2:11", NodeName: "testNode1"},
|
|
},
|
|
},
|
|
{
|
|
// Case[3]: 1 topology key (hostname), 2 nodes each with 2 endpoints
|
|
// no match = 0 endpoints
|
|
Name: "one topology key without node matched",
|
|
nodeLabels: map[types.NodeName]map[string]string{
|
|
"testNode1": {
|
|
"kubernetes.io/hostname": "testNode1",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode2": {
|
|
"kubernetes.io/hostname": "testNode2",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode3": {
|
|
"kubernetes.io/hostname": "testNode3",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
},
|
|
endpoints: []endpoint{
|
|
{Endpoint: "1.1.1.1:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.1.2:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.2.1:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.2.2:11", NodeName: "testNode2"},
|
|
},
|
|
currentNodeName: "testNode3",
|
|
topologyKeys: []string{"kubernetes.io/hostname"},
|
|
expected: []endpoint{},
|
|
},
|
|
{
|
|
// Case[4]: 1 topology key (zone), 2 nodes in zone a, 2 nodes in
|
|
// zone b, each with 2 endpoints = 4 endpoints
|
|
Name: "one topology key with multiple nodes matched",
|
|
nodeLabels: map[types.NodeName]map[string]string{
|
|
"testNode1": {
|
|
"kubernetes.io/hostname": "testNode1",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode2": {
|
|
"kubernetes.io/hostname": "testNode2",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode3": {
|
|
"kubernetes.io/hostname": "testNode3",
|
|
"topology.kubernetes.io/zone": "90002",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode4": {
|
|
"kubernetes.io/hostname": "testNode4",
|
|
"topology.kubernetes.io/zone": "90002",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
},
|
|
endpoints: []endpoint{
|
|
{Endpoint: "1.1.1.1:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.1.2:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.2.1:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.2.2:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.3.1:11", NodeName: "testNode3"},
|
|
{Endpoint: "1.1.3.2:11", NodeName: "testNode3"},
|
|
{Endpoint: "1.1.4.1:11", NodeName: "testNode4"},
|
|
{Endpoint: "1.1.4.2:11", NodeName: "testNode4"},
|
|
},
|
|
currentNodeName: "testNode2",
|
|
topologyKeys: []string{"topology.kubernetes.io/zone"},
|
|
expected: []endpoint{
|
|
{Endpoint: "1.1.1.1:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.1.2:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.2.1:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.2.2:11", NodeName: "testNode2"},
|
|
},
|
|
},
|
|
{
|
|
// Case[5]: 2 topology keys (hostname, zone), 2 nodes each with 2
|
|
// endpoints, 1 hostname match = 2 endpoints (2nd key ignored)
|
|
Name: "early match in multiple topology keys",
|
|
nodeLabels: map[types.NodeName]map[string]string{
|
|
"testNode1": {
|
|
"kubernetes.io/hostname": "testNode1",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode2": {
|
|
"kubernetes.io/hostname": "testNode2",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode3": {
|
|
"kubernetes.io/hostname": "testNode3",
|
|
"topology.kubernetes.io/zone": "90002",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode4": {
|
|
"kubernetes.io/hostname": "testNode4",
|
|
"topology.kubernetes.io/zone": "90002",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
},
|
|
endpoints: []endpoint{
|
|
{Endpoint: "1.1.1.1:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.1.2:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.2.1:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.2.2:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.3.1:11", NodeName: "testNode3"},
|
|
{Endpoint: "1.1.3.2:11", NodeName: "testNode3"},
|
|
{Endpoint: "1.1.4.1:11", NodeName: "testNode4"},
|
|
{Endpoint: "1.1.4.2:11", NodeName: "testNode4"},
|
|
},
|
|
currentNodeName: "testNode2",
|
|
topologyKeys: []string{"kubernetes.io/hostname"},
|
|
expected: []endpoint{
|
|
{Endpoint: "1.1.2.1:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.2.2:11", NodeName: "testNode2"},
|
|
},
|
|
},
|
|
{
|
|
// Case[6]: 2 topology keys (hostname, zone), 2 nodes in zone a, 2
|
|
// nodes in zone b, each with 2 endpoints, no hostname match, 1 zone
|
|
// match = 4 endpoints
|
|
Name: "later match in multiple topology keys",
|
|
nodeLabels: map[types.NodeName]map[string]string{
|
|
"testNode1": {
|
|
"kubernetes.io/hostname": "testNode1",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode2": {
|
|
"kubernetes.io/hostname": "testNode2",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode3": {
|
|
"kubernetes.io/hostname": "testNode3",
|
|
"topology.kubernetes.io/zone": "90002",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode4": {
|
|
"kubernetes.io/hostname": "testNode4",
|
|
"topology.kubernetes.io/zone": "90002",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode5": {
|
|
"kubernetes.io/hostname": "testNode5",
|
|
"topology.kubernetes.io/zone": "90002",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
},
|
|
endpoints: []endpoint{
|
|
{Endpoint: "1.1.1.1:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.1.2:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.2.1:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.2.2:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.3.1:11", NodeName: "testNode3"},
|
|
{Endpoint: "1.1.3.2:11", NodeName: "testNode3"},
|
|
{Endpoint: "1.1.4.1:11", NodeName: "testNode4"},
|
|
{Endpoint: "1.1.4.2:11", NodeName: "testNode4"},
|
|
},
|
|
currentNodeName: "testNode5",
|
|
topologyKeys: []string{"kubernetes.io/hostname", "topology.kubernetes.io/zone"},
|
|
expected: []endpoint{
|
|
{Endpoint: "1.1.3.1:11", NodeName: "testNode3"},
|
|
{Endpoint: "1.1.3.2:11", NodeName: "testNode3"},
|
|
{Endpoint: "1.1.4.1:11", NodeName: "testNode4"},
|
|
{Endpoint: "1.1.4.2:11", NodeName: "testNode4"},
|
|
},
|
|
},
|
|
{
|
|
// Case[7]: 2 topology keys (hostname, zone), 2 nodes in zone a, 2
|
|
// nodes in zone b, each with 2 endpoints, no hostname match, no zone
|
|
// match = 0 endpoints
|
|
Name: "multiple topology keys without node matched",
|
|
nodeLabels: map[types.NodeName]map[string]string{
|
|
"testNode1": {
|
|
"kubernetes.io/hostname": "testNode1",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode2": {
|
|
"kubernetes.io/hostname": "testNode2",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode3": {
|
|
"kubernetes.io/hostname": "testNode3",
|
|
"topology.kubernetes.io/zone": "90002",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode4": {
|
|
"kubernetes.io/hostname": "testNode4",
|
|
"topology.kubernetes.io/zone": "90002",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode5": {
|
|
"kubernetes.io/hostname": "testNode5",
|
|
"topology.kubernetes.io/zone": "90003",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
},
|
|
endpoints: []endpoint{
|
|
{Endpoint: "1.1.1.1:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.1.2:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.2.1:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.2.2:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.3.1:11", NodeName: "testNode3"},
|
|
{Endpoint: "1.1.3.2:11", NodeName: "testNode3"},
|
|
{Endpoint: "1.1.4.1:11", NodeName: "testNode4"},
|
|
{Endpoint: "1.1.4.2:11", NodeName: "testNode4"},
|
|
},
|
|
currentNodeName: "testNode5",
|
|
topologyKeys: []string{"kubernetes.io/hostname", "topology.kubernetes.io/zone"},
|
|
expected: []endpoint{},
|
|
},
|
|
{
|
|
// Case[8]: 2 topology keys (hostname, "*"), 2 nodes each with 2
|
|
// endpoints, 1 match hostname = 2 endpoints
|
|
Name: "multiple topology keys matched node when 'Any' key ignored",
|
|
nodeLabels: map[types.NodeName]map[string]string{
|
|
"testNode1": {
|
|
"kubernetes.io/hostname": "testNode1",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode2": {
|
|
"kubernetes.io/hostname": "testNode2",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
},
|
|
endpoints: []endpoint{
|
|
{Endpoint: "1.1.1.1:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.1.2:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.2.1:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.2.2:11", NodeName: "testNode2"},
|
|
},
|
|
currentNodeName: "testNode1",
|
|
topologyKeys: []string{"kubernetes.io/hostname", v1.TopologyKeyAny},
|
|
expected: []endpoint{
|
|
{Endpoint: "1.1.1.1:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.1.2:11", NodeName: "testNode1"},
|
|
},
|
|
},
|
|
{
|
|
// Case[9]: 2 topology keys (hostname, "*"), 2 nodes each with 2
|
|
// endpoints, no hostname match, catch-all ("*") matched with 4
|
|
// endpoints
|
|
Name: "two topology keys matched node with 'Any' key",
|
|
nodeLabels: map[types.NodeName]map[string]string{
|
|
"testNode1": {
|
|
"kubernetes.io/hostname": "testNode1",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode2": {
|
|
"kubernetes.io/hostname": "testNode2",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode3": {
|
|
"kubernetes.io/hostname": "testNode3",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
},
|
|
endpoints: []endpoint{
|
|
{Endpoint: "1.1.1.1:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.1.2:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.2.1:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.2.2:11", NodeName: "testNode2"},
|
|
},
|
|
currentNodeName: "testNode3",
|
|
topologyKeys: []string{"kubernetes.io/hostname", v1.TopologyKeyAny},
|
|
expected: []endpoint{
|
|
{Endpoint: "1.1.1.1:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.1.2:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.2.1:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.2.2:11", NodeName: "testNode2"},
|
|
},
|
|
},
|
|
{
|
|
// Case[10]: 3 topology keys (hostname, zone, "*"), 2 nodes in zone a,
|
|
// 2 nodes in zone b, each with 2 endpoints, no hostname match, no
|
|
// zone, catch-all ("*") matched with 8 endpoints
|
|
Name: "multiple topology keys matched node with 'Any' key",
|
|
nodeLabels: map[types.NodeName]map[string]string{
|
|
"testNode1": {
|
|
"kubernetes.io/hostname": "testNode1",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode2": {
|
|
"kubernetes.io/hostname": "testNode2",
|
|
"topology.kubernetes.io/zone": "90001",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode3": {
|
|
"kubernetes.io/hostname": "testNode3",
|
|
"topology.kubernetes.io/zone": "90002",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode4": {
|
|
"kubernetes.io/hostname": "testNode4",
|
|
"topology.kubernetes.io/zone": "90002",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
"testNode5": {
|
|
"kubernetes.io/hostname": "testNode5",
|
|
"topology.kubernetes.io/zone": "90003",
|
|
"topology.kubernetes.io/region": "cd",
|
|
},
|
|
},
|
|
endpoints: []endpoint{
|
|
{Endpoint: "1.1.1.1:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.1.2:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.2.1:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.2.2:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.3.1:11", NodeName: "testNode3"},
|
|
{Endpoint: "1.1.3.2:11", NodeName: "testNode3"},
|
|
{Endpoint: "1.1.4.1:11", NodeName: "testNode4"},
|
|
{Endpoint: "1.1.4.2:11", NodeName: "testNode4"},
|
|
},
|
|
currentNodeName: "testNode5",
|
|
topologyKeys: []string{"kubernetes.io/hostname", "topology.kubernetes.io/zone", v1.TopologyKeyAny},
|
|
expected: []endpoint{
|
|
{Endpoint: "1.1.1.1:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.1.2:11", NodeName: "testNode1"},
|
|
{Endpoint: "1.1.2.1:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.2.2:11", NodeName: "testNode2"},
|
|
{Endpoint: "1.1.3.1:11", NodeName: "testNode3"},
|
|
{Endpoint: "1.1.3.2:11", NodeName: "testNode3"},
|
|
{Endpoint: "1.1.4.1:11", NodeName: "testNode4"},
|
|
{Endpoint: "1.1.4.2:11", NodeName: "testNode4"},
|
|
},
|
|
},
|
|
}
|
|
endpointsToStringArray := func(endpoints []endpoint) []string {
|
|
result := make([]string, 0, len(endpoints))
|
|
for _, ep := range endpoints {
|
|
result = append(result, ep.Endpoint)
|
|
}
|
|
return result
|
|
}
|
|
for _, tc := range testCases {
|
|
t.Run(tc.Name, func(t *testing.T) {
|
|
m := make(map[Endpoint]endpoint)
|
|
endpoints := []Endpoint{}
|
|
for _, ep := range tc.endpoints {
|
|
var e Endpoint = &BaseEndpointInfo{Endpoint: ep.Endpoint, Topology: tc.nodeLabels[ep.NodeName]}
|
|
m[e] = ep
|
|
endpoints = append(endpoints, e)
|
|
}
|
|
currentNodeLabels := tc.nodeLabels[tc.currentNodeName]
|
|
filteredEndpoint := []endpoint{}
|
|
for _, ep := range deprecatedTopologyFilter(currentNodeLabels, tc.topologyKeys, endpoints) {
|
|
filteredEndpoint = append(filteredEndpoint, m[ep])
|
|
}
|
|
if !reflect.DeepEqual(filteredEndpoint, tc.expected) {
|
|
t.Errorf("expected %v, got %v", endpointsToStringArray(tc.expected), endpointsToStringArray(filteredEndpoint))
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_filterEndpointsInternalTrafficPolicy(t *testing.T) {
|
|
cluster := v1.ServiceInternalTrafficPolicyCluster
|
|
local := v1.ServiceInternalTrafficPolicyLocal
|
|
|
|
testCases := []struct {
|
|
name string
|
|
internalTrafficPolicy *v1.ServiceInternalTrafficPolicyType
|
|
endpoints []Endpoint
|
|
expected []Endpoint
|
|
featureGateOn bool
|
|
}{
|
|
{
|
|
name: "no internalTrafficPolicy with empty endpoints",
|
|
internalTrafficPolicy: nil,
|
|
endpoints: []Endpoint{},
|
|
expected: []Endpoint{},
|
|
featureGateOn: true,
|
|
},
|
|
{
|
|
name: "no internalTrafficPolicy with non-empty endpoints",
|
|
internalTrafficPolicy: nil,
|
|
endpoints: []Endpoint{
|
|
&BaseEndpointInfo{Endpoint: "10.0.0.0:80", IsLocal: true},
|
|
&BaseEndpointInfo{Endpoint: "10.0.0.1:80", IsLocal: false},
|
|
},
|
|
expected: []Endpoint{
|
|
&BaseEndpointInfo{Endpoint: "10.0.0.0:80", IsLocal: true},
|
|
&BaseEndpointInfo{Endpoint: "10.0.0.1:80", IsLocal: false},
|
|
},
|
|
featureGateOn: true,
|
|
},
|
|
{
|
|
name: "internalTrafficPolicy is cluster",
|
|
internalTrafficPolicy: &cluster,
|
|
endpoints: []Endpoint{
|
|
&BaseEndpointInfo{Endpoint: "10.0.0.0:80", IsLocal: true},
|
|
&BaseEndpointInfo{Endpoint: "10.0.0.1:80", IsLocal: false},
|
|
},
|
|
expected: []Endpoint{
|
|
&BaseEndpointInfo{Endpoint: "10.0.0.0:80", IsLocal: true},
|
|
&BaseEndpointInfo{Endpoint: "10.0.0.1:80", IsLocal: false},
|
|
},
|
|
featureGateOn: true,
|
|
},
|
|
{
|
|
name: "internalTrafficPolicy is local with non-zero local endpoints",
|
|
internalTrafficPolicy: &local,
|
|
endpoints: []Endpoint{
|
|
&BaseEndpointInfo{Endpoint: "10.0.0.0:80", IsLocal: true},
|
|
&BaseEndpointInfo{Endpoint: "10.0.0.1:80", IsLocal: false},
|
|
},
|
|
expected: []Endpoint{
|
|
&BaseEndpointInfo{Endpoint: "10.0.0.0:80", IsLocal: true},
|
|
},
|
|
featureGateOn: true,
|
|
},
|
|
{
|
|
name: "internalTrafficPolicy is local with zero local endpoints",
|
|
internalTrafficPolicy: &local,
|
|
endpoints: []Endpoint{
|
|
&BaseEndpointInfo{Endpoint: "10.0.0.0:80", IsLocal: false},
|
|
&BaseEndpointInfo{Endpoint: "10.0.0.1:80", IsLocal: false},
|
|
&BaseEndpointInfo{Endpoint: "10.0.0.2:80", IsLocal: false},
|
|
},
|
|
expected: nil,
|
|
featureGateOn: true,
|
|
},
|
|
{
|
|
name: "feature gate is off, internalTrafficPolicy is local with non-empty endpoints",
|
|
internalTrafficPolicy: &local,
|
|
endpoints: []Endpoint{
|
|
&BaseEndpointInfo{Endpoint: "10.0.0.0:80", IsLocal: true},
|
|
&BaseEndpointInfo{Endpoint: "10.0.0.1:80", IsLocal: false},
|
|
&BaseEndpointInfo{Endpoint: "10.0.0.2:80", IsLocal: false},
|
|
},
|
|
expected: []Endpoint{
|
|
&BaseEndpointInfo{Endpoint: "10.0.0.0:80", IsLocal: true},
|
|
&BaseEndpointInfo{Endpoint: "10.0.0.1:80", IsLocal: false},
|
|
&BaseEndpointInfo{Endpoint: "10.0.0.2:80", IsLocal: false},
|
|
},
|
|
featureGateOn: false,
|
|
},
|
|
}
|
|
for _, tc := range testCases {
|
|
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.ServiceInternalTrafficPolicy, tc.featureGateOn)()
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
filteredEndpoint := filterEndpointsInternalTrafficPolicy(tc.internalTrafficPolicy, tc.endpoints)
|
|
if !reflect.DeepEqual(filteredEndpoint, tc.expected) {
|
|
t.Errorf("expected %v, got %v", tc.expected, filteredEndpoint)
|
|
}
|
|
})
|
|
}
|
|
}
|