eac2049fc9
Previously, the fake RESTClient in client-go required a Registry. It used the Registry to fetch the GroupVersion for the fake client. However, the way it did so was dubious in some cases (it hard-coded the default API group in places), and not strictly necssary. This updates the fake client to just recieve the GroupVersion and internal group name directly, instead of requiring a Registry, so that it can be consumed in unit tests where a Registry isn't necessarily readily available (e.g. elsewhere in client-go).
240 lines
8.8 KiB
Go
240 lines
8.8 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package set
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"io"
|
|
"io/ioutil"
|
|
"net/http"
|
|
"path"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
"k8s.io/apimachinery/pkg/runtime/schema"
|
|
"k8s.io/client-go/rest/fake"
|
|
"k8s.io/kubernetes/pkg/api"
|
|
"k8s.io/kubernetes/pkg/api/legacyscheme"
|
|
"k8s.io/kubernetes/pkg/api/testapi"
|
|
"k8s.io/kubernetes/pkg/apis/apps"
|
|
"k8s.io/kubernetes/pkg/apis/batch"
|
|
"k8s.io/kubernetes/pkg/apis/extensions"
|
|
cmdtesting "k8s.io/kubernetes/pkg/kubectl/cmd/testing"
|
|
"k8s.io/kubernetes/pkg/kubectl/resource"
|
|
"k8s.io/kubernetes/pkg/printers"
|
|
)
|
|
|
|
const serviceAccount = "serviceaccount1"
|
|
const serviceAccountMissingErrString = "serviceaccount is required"
|
|
const resourceMissingErrString = `You must provide one or more resources by argument or filename.
|
|
Example resource specifications include:
|
|
'-f rsrc.yaml'
|
|
'--filename=rsrc.json'
|
|
'<resource> <name>'
|
|
'<resource>'`
|
|
|
|
func TestServiceAccountLocal(t *testing.T) {
|
|
inputs := []struct {
|
|
yaml string
|
|
apiGroup string
|
|
}{
|
|
{yaml: "../../../../test/fixtures/doc-yaml/user-guide/replication.yaml", apiGroup: api.GroupName},
|
|
{yaml: "../../../../test/fixtures/doc-yaml/admin/daemon.yaml", apiGroup: extensions.GroupName},
|
|
{yaml: "../../../../test/fixtures/doc-yaml/user-guide/replicaset/redis-slave.yaml", apiGroup: extensions.GroupName},
|
|
{yaml: "../../../../test/fixtures/doc-yaml/user-guide/job.yaml", apiGroup: batch.GroupName},
|
|
{yaml: "../../../../test/fixtures/doc-yaml/user-guide/deployment.yaml", apiGroup: extensions.GroupName},
|
|
{yaml: "../../../../examples/storage/minio/minio-distributed-statefulset.yaml", apiGroup: apps.GroupName},
|
|
}
|
|
|
|
f, tf, _, _ := cmdtesting.NewAPIFactory()
|
|
tf.Client = &fake.RESTClient{
|
|
GroupVersion: legacyscheme.Registry.GroupOrDie(api.GroupName).GroupVersion,
|
|
Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) {
|
|
t.Fatalf("unexpected request: %s %#v\n%#v", req.Method, req.URL, req)
|
|
return nil, nil
|
|
}),
|
|
}
|
|
tf.Namespace = "test"
|
|
out := new(bytes.Buffer)
|
|
cmd := NewCmdServiceAccount(f, out, out)
|
|
cmd.SetOutput(out)
|
|
cmd.Flags().Set("output", "yaml")
|
|
cmd.Flags().Set("local", "true")
|
|
for _, input := range inputs {
|
|
testapi.Default = testapi.Groups[input.apiGroup]
|
|
tf.Printer = printers.NewVersionedPrinter(&printers.YAMLPrinter{}, testapi.Default.Converter(), *testapi.Default.GroupVersion())
|
|
saConfig := serviceAccountConfig{fileNameOptions: resource.FilenameOptions{
|
|
Filenames: []string{input.yaml}},
|
|
out: out,
|
|
local: true}
|
|
err := saConfig.Complete(f, cmd, []string{serviceAccount})
|
|
assert.NoError(t, err)
|
|
err = saConfig.Run()
|
|
assert.NoError(t, err)
|
|
assert.Contains(t, out.String(), "serviceAccountName: "+serviceAccount, fmt.Sprintf("serviceaccount not updated for %s", input.yaml))
|
|
}
|
|
}
|
|
|
|
func TestServiceAccountRemote(t *testing.T) {
|
|
inputs := []struct {
|
|
object runtime.Object
|
|
apiPrefix, apiGroup string
|
|
args []string
|
|
}{
|
|
{
|
|
object: &extensions.ReplicaSet{
|
|
TypeMeta: metav1.TypeMeta{Kind: "ReplicaSet", APIVersion: legacyscheme.Registry.GroupOrDie(extensions.GroupName).GroupVersion.String()},
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
},
|
|
apiPrefix: "/apis", apiGroup: extensions.GroupName,
|
|
args: []string{"replicaset", "nginx", serviceAccount},
|
|
},
|
|
{
|
|
object: &extensions.DaemonSet{
|
|
TypeMeta: metav1.TypeMeta{Kind: "DaemonSet", APIVersion: legacyscheme.Registry.GroupOrDie(extensions.GroupName).GroupVersion.String()},
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
},
|
|
apiPrefix: "/apis", apiGroup: extensions.GroupName,
|
|
args: []string{"daemonset", "nginx", serviceAccount},
|
|
},
|
|
{
|
|
object: &api.ReplicationController{
|
|
TypeMeta: metav1.TypeMeta{Kind: "ReplicationController", APIVersion: legacyscheme.Registry.GroupOrDie(api.GroupName).GroupVersion.String()},
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
},
|
|
apiPrefix: "/api", apiGroup: api.GroupName,
|
|
args: []string{"replicationcontroller", "nginx", serviceAccount}},
|
|
{
|
|
object: &extensions.Deployment{
|
|
TypeMeta: metav1.TypeMeta{Kind: "Deployment", APIVersion: legacyscheme.Registry.GroupOrDie(extensions.GroupName).GroupVersion.String()},
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
},
|
|
apiPrefix: "/apis", apiGroup: extensions.GroupName,
|
|
args: []string{"deployment", "nginx", serviceAccount},
|
|
},
|
|
{
|
|
object: &batch.Job{
|
|
TypeMeta: metav1.TypeMeta{Kind: "Job", APIVersion: legacyscheme.Registry.GroupOrDie(batch.GroupName).GroupVersion.String()},
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
},
|
|
apiPrefix: "/apis", apiGroup: batch.GroupName,
|
|
args: []string{"job", "nginx", serviceAccount},
|
|
},
|
|
{
|
|
object: &apps.StatefulSet{
|
|
TypeMeta: metav1.TypeMeta{Kind: "StatefulSet", APIVersion: legacyscheme.Registry.GroupOrDie(apps.GroupName).GroupVersion.String()},
|
|
ObjectMeta: metav1.ObjectMeta{Name: "nginx"},
|
|
},
|
|
apiPrefix: "/apis", apiGroup: apps.GroupName,
|
|
args: []string{"statefulset", "nginx", serviceAccount},
|
|
},
|
|
}
|
|
for _, input := range inputs {
|
|
|
|
groupVersion := legacyscheme.Registry.GroupOrDie(input.apiGroup).GroupVersion
|
|
testapi.Default = testapi.Groups[input.apiGroup]
|
|
f, tf, codec, _ := cmdtesting.NewAPIFactory()
|
|
tf.Printer = printers.NewVersionedPrinter(&printers.YAMLPrinter{}, testapi.Default.Converter(), *testapi.Default.GroupVersion())
|
|
tf.Namespace = "test"
|
|
tf.CategoryExpander = resource.LegacyCategoryExpander
|
|
tf.Client = &fake.RESTClient{
|
|
GroupVersion: legacyscheme.Registry.GroupOrDie(input.apiGroup).GroupVersion,
|
|
NegotiatedSerializer: testapi.Default.NegotiatedSerializer(),
|
|
Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) {
|
|
resourcePath := testapi.Default.ResourcePath(input.args[0]+"s", tf.Namespace, input.args[1])
|
|
switch p, m := req.URL.Path, req.Method; {
|
|
case p == resourcePath && m == http.MethodGet:
|
|
return &http.Response{StatusCode: http.StatusOK, Header: defaultHeader(), Body: objBody(codec, input.object)}, nil
|
|
case p == resourcePath && m == http.MethodPatch:
|
|
stream, err := req.GetBody()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
bytes, err := ioutil.ReadAll(stream)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
assert.Contains(t, string(bytes), `"serviceAccountName":`+`"`+serviceAccount+`"`, fmt.Sprintf("serviceaccount not updated for %#v", input.object))
|
|
return &http.Response{StatusCode: http.StatusOK, Header: defaultHeader(), Body: objBody(codec, input.object)}, nil
|
|
default:
|
|
t.Errorf("%s: unexpected request: %s %#v\n%#v", "serviceaccount", req.Method, req.URL, req)
|
|
return nil, fmt.Errorf("unexpected request")
|
|
}
|
|
}),
|
|
VersionedAPIPath: path.Join(input.apiPrefix, groupVersion.String()),
|
|
}
|
|
out := new(bytes.Buffer)
|
|
cmd := NewCmdServiceAccount(f, out, out)
|
|
cmd.SetOutput(out)
|
|
cmd.Flags().Set("output", "yaml")
|
|
|
|
saConfig := serviceAccountConfig{
|
|
out: out,
|
|
local: false}
|
|
err := saConfig.Complete(f, cmd, input.args)
|
|
assert.NoError(t, err)
|
|
err = saConfig.Run()
|
|
assert.NoError(t, err)
|
|
}
|
|
}
|
|
|
|
func TestServiceAccountValidation(t *testing.T) {
|
|
inputs := []struct {
|
|
args []string
|
|
errorString string
|
|
}{
|
|
{args: []string{}, errorString: serviceAccountMissingErrString},
|
|
{args: []string{serviceAccount}, errorString: resourceMissingErrString},
|
|
}
|
|
for _, input := range inputs {
|
|
f, tf, _, _ := cmdtesting.NewAPIFactory()
|
|
tf.Client = &fake.RESTClient{
|
|
GroupVersion: schema.GroupVersion{Version: "v1"},
|
|
Client: fake.CreateHTTPClient(func(req *http.Request) (*http.Response, error) {
|
|
t.Fatalf("unexpected request: %s %#v\n%#v", req.Method, req.URL, req)
|
|
return nil, nil
|
|
}),
|
|
}
|
|
tf.Namespace = "test"
|
|
out := bytes.NewBuffer([]byte{})
|
|
cmd := NewCmdServiceAccount(f, out, out)
|
|
cmd.SetOutput(out)
|
|
|
|
saConfig := &serviceAccountConfig{}
|
|
err := saConfig.Complete(f, cmd, input.args)
|
|
assert.EqualError(t, err, input.errorString)
|
|
}
|
|
}
|
|
|
|
func objBody(codec runtime.Codec, obj runtime.Object) io.ReadCloser {
|
|
return bytesBody([]byte(runtime.EncodeOrDie(codec, obj)))
|
|
}
|
|
|
|
func defaultHeader() http.Header {
|
|
header := http.Header{}
|
|
header.Set("Content-Type", runtime.ContentTypeJSON)
|
|
return header
|
|
}
|
|
|
|
func bytesBody(bodyBytes []byte) io.ReadCloser {
|
|
return ioutil.NopCloser(bytes.NewReader(bodyBytes))
|
|
}
|