
In order to adopt ginkgo incrementally, let's start by replacing test/e2e/driver.go with a call to ginkgo runner and convert each of the other tests to a small Decscribe() snippet that simply calls the legacy TestXYZ function. From this basis we can take further incremental steps by converting individual tests to native ginkgo format, using Fail() for all failure cases, using By() for logs, enabling JUnit reports, etc. Tested: - cmd/e2e builds and `make check` passes. - Running _output/bin/.../e2e on an alive cluster works. - Running the full hack/e2e-test.sh works as expected.
60 lines
1.6 KiB
Go
60 lines
1.6 KiB
Go
/*
|
|
Copyright 2014 Google Inc. All rights reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package e2e
|
|
|
|
import (
|
|
"github.com/GoogleCloudPlatform/kubernetes/pkg/client"
|
|
"github.com/golang/glog"
|
|
|
|
. "github.com/onsi/ginkgo"
|
|
. "github.com/onsi/gomega"
|
|
)
|
|
|
|
// TestImportantURLs validates that URLs that people depend on haven't moved.
|
|
// ***IMPORTANT*** Do *not* fix this test just by changing the path. If you moved a URL
|
|
// you can break upstream dependencies.
|
|
func TestImportantURLs(c *client.Client) bool {
|
|
tests := []struct {
|
|
path string
|
|
}{
|
|
{path: "/validate"},
|
|
{path: "/healthz"},
|
|
// TODO: test proxy links here
|
|
}
|
|
ok := true
|
|
for _, test := range tests {
|
|
glog.Infof("testing: %s", test.path)
|
|
data, err := c.RESTClient.Get().
|
|
AbsPath(test.path).
|
|
Do().
|
|
Raw()
|
|
if err != nil {
|
|
glog.Errorf("Failed: %v\nBody: %s", err, string(data))
|
|
ok = false
|
|
}
|
|
}
|
|
return ok
|
|
}
|
|
|
|
var _ = Describe("TestImportantURLs", func() {
|
|
It("should pass", func() {
|
|
// TODO: Instead of OrDie, client should Fail the test if there's a problem.
|
|
// In general tests should Fail() instead of glog.Fatalf().
|
|
Expect(TestImportantURLs(loadClientOrDie())).To(BeTrue())
|
|
})
|
|
})
|