
Pods in scheduler cache contains both the scheduled pods and those not scheduled yet in scheduling queue. This commit adds the second group of pods into consideration while comparing the cache.
162 lines
4.0 KiB
Go
162 lines
4.0 KiB
Go
/*
|
|
Copyright 2018 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package factory
|
|
|
|
import (
|
|
"sort"
|
|
"strings"
|
|
|
|
"github.com/golang/glog"
|
|
"k8s.io/api/core/v1"
|
|
policy "k8s.io/api/policy/v1beta1"
|
|
"k8s.io/apimachinery/pkg/labels"
|
|
corelisters "k8s.io/client-go/listers/core/v1"
|
|
v1beta1 "k8s.io/client-go/listers/policy/v1beta1"
|
|
"k8s.io/kubernetes/pkg/scheduler/core"
|
|
"k8s.io/kubernetes/pkg/scheduler/schedulercache"
|
|
)
|
|
|
|
type cacheComparer struct {
|
|
nodeLister corelisters.NodeLister
|
|
podLister corelisters.PodLister
|
|
pdbLister v1beta1.PodDisruptionBudgetLister
|
|
cache schedulercache.Cache
|
|
podQueue core.SchedulingQueue
|
|
|
|
compareStrategy
|
|
}
|
|
|
|
func (c *cacheComparer) Compare() error {
|
|
glog.V(3).Info("cache comparer started")
|
|
defer glog.V(3).Info("cache comparer finished")
|
|
|
|
nodes, err := c.nodeLister.List(labels.Everything())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
pods, err := c.podLister.List(labels.Everything())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
pdbs, err := c.pdbLister.List(labels.Everything())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
snapshot := c.cache.Snapshot()
|
|
|
|
waitingPods := c.podQueue.WaitingPods()
|
|
|
|
if missed, redundant := c.CompareNodes(nodes, snapshot.Nodes); len(missed)+len(redundant) != 0 {
|
|
glog.Warningf("cache mismatch: missed nodes: %s; redundant nodes: %s", missed, redundant)
|
|
}
|
|
|
|
if missed, redundant := c.ComparePods(pods, waitingPods, snapshot.Nodes); len(missed)+len(redundant) != 0 {
|
|
glog.Warningf("cache mismatch: missed pods: %s; redundant pods: %s", missed, redundant)
|
|
}
|
|
|
|
if missed, redundant := c.ComparePdbs(pdbs, snapshot.Pdbs); len(missed)+len(redundant) != 0 {
|
|
glog.Warningf("cache mismatch: missed pdbs: %s; redundant pdbs: %s", missed, redundant)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
type compareStrategy struct {
|
|
}
|
|
|
|
func (c compareStrategy) CompareNodes(nodes []*v1.Node, nodeinfos map[string]*schedulercache.NodeInfo) (missed, redundant []string) {
|
|
actual := []string{}
|
|
for _, node := range nodes {
|
|
actual = append(actual, node.Name)
|
|
}
|
|
|
|
cached := []string{}
|
|
for nodeName := range nodeinfos {
|
|
cached = append(cached, nodeName)
|
|
}
|
|
|
|
return compareStrings(actual, cached)
|
|
}
|
|
|
|
func (c compareStrategy) ComparePods(pods, waitingPods []*v1.Pod, nodeinfos map[string]*schedulercache.NodeInfo) (missed, redundant []string) {
|
|
actual := []string{}
|
|
for _, pod := range pods {
|
|
actual = append(actual, string(pod.UID))
|
|
}
|
|
|
|
cached := []string{}
|
|
for _, nodeinfo := range nodeinfos {
|
|
for _, pod := range nodeinfo.Pods() {
|
|
cached = append(cached, string(pod.UID))
|
|
}
|
|
}
|
|
for _, pod := range waitingPods {
|
|
cached = append(cached, string(pod.UID))
|
|
}
|
|
|
|
return compareStrings(actual, cached)
|
|
}
|
|
|
|
func (c compareStrategy) ComparePdbs(pdbs []*policy.PodDisruptionBudget, pdbCache map[string]*policy.PodDisruptionBudget) (missed, redundant []string) {
|
|
actual := []string{}
|
|
for _, pdb := range pdbs {
|
|
actual = append(actual, string(pdb.Name))
|
|
}
|
|
|
|
cached := []string{}
|
|
for pdbName := range pdbCache {
|
|
cached = append(cached, pdbName)
|
|
}
|
|
|
|
return compareStrings(actual, cached)
|
|
}
|
|
|
|
func compareStrings(actual, cached []string) (missed, redundant []string) {
|
|
missed, redundant = []string{}, []string{}
|
|
|
|
sort.Strings(actual)
|
|
sort.Strings(cached)
|
|
|
|
compare := func(i, j int) int {
|
|
if i == len(actual) {
|
|
return 1
|
|
} else if j == len(cached) {
|
|
return -1
|
|
}
|
|
return strings.Compare(actual[i], cached[j])
|
|
}
|
|
|
|
for i, j := 0, 0; i < len(actual) || j < len(cached); {
|
|
switch compare(i, j) {
|
|
case 0:
|
|
i++
|
|
j++
|
|
case -1:
|
|
missed = append(missed, actual[i])
|
|
i++
|
|
case 1:
|
|
redundant = append(redundant, cached[j])
|
|
j++
|
|
}
|
|
}
|
|
|
|
return
|
|
}
|