History

Kubernetes Submit Queue 2dee2105d6 Merge pull request #62063 from atlassian/no-mutation-unstructuredcontent Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Make UnstructuredContent return contents without mutating the source What this PR does / why we need it: This PR solves the issues described in #56316 Before this change: - A call to `UnstructuredContent()` potentially modified `Object` - The values returned by `UnstructuredContent()` could be manipulated to modify the value in `Object`. Going through the history it looks like this behavior was added before the addition of `SetUnstructuredContent()`. IMO it makes more sense now to use `SetUnstructuredContent()` or make changes to the exposed `Object` property - `UnstructuredList` did not implement the behavior described in the godoc. The godoc stated that the value returned should be mutable, but if u.Object == nil the map returned had no effect on Object With this PR I'm proposing `UnstructuredContent()` returns the data without providing the contract of a mutable map. It also ensures all implementations of the `Unstructured` interface abide by the doc Which issue(s) this PR fixes: Fixes #56316 Special notes for your reviewer: This PR continues work started in #57713. Release note: ```release-note NONE ``` /kind bug /sig api-machinery /cc sttts deads2k		2018-04-05 17:03:57 -07:00
..
src/k8s.io	Merge pull request #62063 from atlassian/no-mutation-unstructuredcontent	2018-04-05 17:03:57 -07:00
BUILD	generated	2018-02-27 21:21:14 -08:00
OWNERS
README.md	Add link to k8s.io/sample-controller	2017-10-19 15:46:36 +01:00

README.md

External Repository Staging Area

This directory is the staging area for packages that have been split to their own repository. The content here will be periodically published to respective top-level k8s.io repositories.

Repositories currently staged here:

The code in the staging/ directory is authoritative, i.e. the only copy of the code. You can directly modify such code.

Using staged repositories from Kubernetes code

Kubernetes code uses the repositories in this directory via symlinks in the vendor/k8s.io directory into this staging area. For example, when Kubernetes code imports a package from the k8s.io/client-go repository, that import is resolved to staging/src/k8s.io/client-go relative to the project root:

// pkg/example/some_code.go
package example

import (
  "k8s.io/client-go/dynamic" // resolves to staging/src/k8s.io/client-go/dynamic
)

Once the change-over to external repositories is complete, these repositories will actually be vendored from k8s.io/<package-name>.