59c0523bca
* Squashed commit of the following: commit 7f774dcb54b511a3956aed0fac5c803f145e383a Author: Jay Vyas (jayunit100) <jvyas@vmware.com> Date: Fri Jun 18 10:58:16 2021 +0000 fix commit message commit 0ac09650742f02004dbb227310057ea3760c4da9 Author: jay vyas <jvyas@vmware.com> Date: Thu Jun 17 07:50:33 2021 -0400 Update test/e2e/network/netpol/kubemanager.go Co-authored-by: Antonio Ojea <antonio.ojea.garcia@gmail.com> commit 6a8bf0a6a2690dac56fec2bdcdce929311c513ca Author: jay vyas <jvyas@vmware.com> Date: Sun Jun 13 08:17:25 2021 -0400 Implement Service polling for network policy suite to remove reliance on CoreDNS when verifying network policys Update test/e2e/network/netpol/probe.go Co-authored-by: Antonio Ojea <antonio.ojea.garcia@gmail.com> Add deafultNS to use service probe commit b9c17a48327aab35a855540c2294a51137aa4a48 Author: Matthew Fenwick <mfenwick100@gmail.com> Date: Thu May 27 07:30:59 2021 -0400 address code review comments for networkpolicy decoupling from dns commit e23ef6ff0d189cf2ed80dbafed9881d68402cb56 Author: jay vyas <jvyas@vmware.com> Date: Wed May 26 13:30:21 2021 -0400 NetworkPolicy decoupling from DNS gofmt remove old function * model refactor * minor * dropped getK8sModel func * dropped modelMap, added global model in BeforeEach and subsequent changes Co-authored-by: Rajas Kakodkar <rajaskakodkar16@gmail.com>
test/e2e
This is home to e2e tests used for presubmit, periodic, and postsubmit jobs.
Some of these jobs are merge-blocking, some are release-blocking.
e2e test ownership
All e2e tests must adhere to the following policies:
- the test must be owned by one and only one SIG
- the test must live in/underneath a sig-owned package matching pattern:
test/e2e/[{subpath}/]{sig}/..., e.g.test/e2e/auth- all tests owned by sig-authtest/e2e/common/storage- all testscommonto cluster-level and node-level e2e tests, owned by sig-nodetest/e2e/upgrade/apps- all tests used inupgradetesting, owned by sig-apps
- each sig-owned package should have an OWNERS file defining relevant approvers and labels for the owning sig, e.g.
# test/e2e/node/OWNERS
# See the OWNERS docs at https://go.k8s.io/owners
approvers:
- alice
- bob
- cynthia
emeritus_approvers:
- dave
reviewers:
- sig-node-reviewers
labels:
- sig/node
- packages that use
{subpath}should have animports.gofile importing sig-owned packages (for ginkgo's benefit), e.g.
// test/e2e/common/imports.go
package common
import (
// ensure these packages are scanned by ginkgo for e2e tests
_ "k8s.io/kubernetes/test/e2e/common/network"
_ "k8s.io/kubernetes/test/e2e/common/node"
_ "k8s.io/kubernetes/test/e2e/common/storage"
)
- test ownership must be declared via a top-level SIGDescribe call defined in the sig-owned package, e.g.
// test/e2e/lifecycle/framework.go
package lifecycle
import "github.com/onsi/ginkgo"
// SIGDescribe annotates the test with the SIG label.
func SIGDescribe(text string, body func()) bool {
return ginkgo.Describe("[sig-cluster-lifecycle] "+text, body)
}
// test/e2e/lifecycle/bootstrap/bootstrap_signer.go
package bootstrap
import (
"github.com/onsi/ginkgo"
"k8s.io/kubernetes/test/e2e/lifecycle"
)
var _ = lifecycle.SIGDescribe("[Feature:BootstrapTokens]", func() {
/* ... */
ginkgo.It("should sign the new added bootstrap tokens", func() {
/* ... */
})
/* etc */
})
These polices are enforced:
- via the merge-blocking presubmit job
pull-kubernetes-verify - which ends up running
hack/verify-e2e-test-ownership.sh - which can also be run via
make verify WHAT=e2e-test-ownership