6dcec345df
Introduce a new `admission` subpackage to factor out the responsability to create `PodAdmitResult` objects. This enables resource manager to report specific errors in Allocate() and to bubble up them in the relevant fields of the `PodAdmitResult`. To demonstrate the approach we refactor TopologyAffinityError as a proper error. Co-authored-by: Kevin Klues <kklues@nvidia.com> Co-authored-by: Swati Sehgal <swsehgal@redhat.com> Signed-off-by: Francesco Romani <fromani@redhat.com>
88 lines
1.8 KiB
Go
88 lines
1.8 KiB
Go
/*
|
|
Copyright 2021 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package admission
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
)
|
|
|
|
type TestAdmissionError struct {
|
|
message string
|
|
reason string
|
|
}
|
|
|
|
func (e *TestAdmissionError) Error() string {
|
|
return e.message
|
|
}
|
|
|
|
func (e *TestAdmissionError) Type() string {
|
|
return e.reason
|
|
}
|
|
|
|
func TestAdmissionErrors(t *testing.T) {
|
|
testCases := []struct {
|
|
Error error
|
|
expectedAdmissionError bool
|
|
}{
|
|
{
|
|
nil,
|
|
false,
|
|
},
|
|
{
|
|
errors.New("Not an AdmissionError error"),
|
|
false,
|
|
},
|
|
{
|
|
&TestAdmissionError{
|
|
"Is an AdmissionError error",
|
|
"TestAdmissionError",
|
|
},
|
|
true,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
h := GetPodAdmitResult(tc.Error)
|
|
if tc.Error == nil {
|
|
if !h.Admit {
|
|
t.Errorf("expected PodAdmitResult.Admit = true")
|
|
}
|
|
continue
|
|
}
|
|
|
|
if h.Admit {
|
|
t.Errorf("expected PodAdmitResult.Admit = false")
|
|
}
|
|
|
|
if tc.expectedAdmissionError {
|
|
err, ok := tc.Error.(*TestAdmissionError)
|
|
if !ok {
|
|
t.Errorf("expected TestAdmissionError")
|
|
}
|
|
if h.Reason != err.reason {
|
|
t.Errorf("expected PodAdmitResult.Reason = %v, got %v", err.reason, h.Reason)
|
|
}
|
|
continue
|
|
}
|
|
|
|
if h.Reason != ErrorReasonUnexpected {
|
|
t.Errorf("expected PodAdmitResult.Reason = %v, got %v", ErrorReasonUnexpected, h.Reason)
|
|
}
|
|
}
|
|
}
|