029fd47757
Using a "normal" CSI driver for an inline ephemeral volume may have unexpected and potentially harmful effects when the driver gets a NodePublishVolume call that it isn't expecting. To prevent that mistake, driver deployments for a driver that supports such volumes must: - deploy a CSIDriver object for the driver - list "ephemeral" as one of the supported modes The default is "persistent", so existing deployments continue to work and are automatically protected against incorrect usage. This commit contains the API change. Generated code and manual code which uses the new API follow.
114 lines
4.0 KiB
Go
114 lines
4.0 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package v1beta1_test
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
|
|
storagev1beta1 "k8s.io/api/storage/v1beta1"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
utilfeature "k8s.io/apiserver/pkg/util/feature"
|
|
featuregatetesting "k8s.io/component-base/featuregate/testing"
|
|
"k8s.io/kubernetes/pkg/api/legacyscheme"
|
|
_ "k8s.io/kubernetes/pkg/apis/storage/install"
|
|
"k8s.io/kubernetes/pkg/features"
|
|
)
|
|
|
|
func roundTrip(t *testing.T, obj runtime.Object) runtime.Object {
|
|
codec := legacyscheme.Codecs.LegacyCodec(storagev1beta1.SchemeGroupVersion)
|
|
data, err := runtime.Encode(codec, obj)
|
|
if err != nil {
|
|
t.Errorf("%v\n %#v", err, obj)
|
|
return nil
|
|
}
|
|
obj2, err := runtime.Decode(codec, data)
|
|
if err != nil {
|
|
t.Errorf("%v\nData: %s\nSource: %#v", err, string(data), obj)
|
|
return nil
|
|
}
|
|
obj3 := reflect.New(reflect.TypeOf(obj).Elem()).Interface().(runtime.Object)
|
|
err = legacyscheme.Scheme.Convert(obj2, obj3, nil)
|
|
if err != nil {
|
|
t.Errorf("%v\nSource: %#v", err, obj2)
|
|
return nil
|
|
}
|
|
return obj3
|
|
}
|
|
|
|
func TestSetDefaultVolumeBindingMode(t *testing.T) {
|
|
class := &storagev1beta1.StorageClass{}
|
|
|
|
// field should be defaulted
|
|
defaultMode := storagev1beta1.VolumeBindingImmediate
|
|
output := roundTrip(t, runtime.Object(class)).(*storagev1beta1.StorageClass)
|
|
outMode := output.VolumeBindingMode
|
|
if outMode == nil {
|
|
t.Errorf("Expected VolumeBindingMode to be defaulted to: %+v, got: nil", defaultMode)
|
|
} else if *outMode != defaultMode {
|
|
t.Errorf("Expected VolumeBindingMode to be defaulted to: %+v, got: %+v", defaultMode, outMode)
|
|
}
|
|
}
|
|
|
|
func TestSetDefaultAttachRequired(t *testing.T) {
|
|
driver := &storagev1beta1.CSIDriver{}
|
|
|
|
// field should be defaulted
|
|
defaultAttach := true
|
|
defaultPodInfo := false
|
|
output := roundTrip(t, runtime.Object(driver)).(*storagev1beta1.CSIDriver)
|
|
outAttach := output.Spec.AttachRequired
|
|
if outAttach == nil {
|
|
t.Errorf("Expected AttachRequired to be defaulted to: %+v, got: nil", defaultAttach)
|
|
} else if *outAttach != defaultAttach {
|
|
t.Errorf("Expected AttachRequired to be defaulted to: %+v, got: %+v", defaultAttach, outAttach)
|
|
}
|
|
outPodInfo := output.Spec.PodInfoOnMount
|
|
if outPodInfo == nil {
|
|
t.Errorf("Expected PodInfoOnMount to be defaulted to: %+v, got: nil", defaultPodInfo)
|
|
} else if *outPodInfo != defaultPodInfo {
|
|
t.Errorf("Expected PodInfoOnMount to be defaulted to: %+v, got: %+v", defaultPodInfo, outPodInfo)
|
|
}
|
|
}
|
|
|
|
func TestSetDefaultVolumeLifecycleModesEnabled(t *testing.T) {
|
|
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.CSIInlineVolume, true)()
|
|
driver := &storagev1beta1.CSIDriver{}
|
|
|
|
// field should be defaulted
|
|
defaultMode := storagev1beta1.VolumeLifecyclePersistent
|
|
output := roundTrip(t, runtime.Object(driver)).(*storagev1beta1.CSIDriver)
|
|
outModes := output.Spec.VolumeLifecycleModes
|
|
if len(outModes) != 1 {
|
|
t.Errorf("Expected VolumeLifecycleModes to be defaulted to: %+v, got: %+v", defaultMode, outModes)
|
|
} else if outModes[0] != defaultMode {
|
|
t.Errorf("Expected VolumeLifecycleModes to be defaulted to: %+v, got: %+v", defaultMode, outModes)
|
|
}
|
|
}
|
|
|
|
func TestSetDefaultVolumeLifecycleModesDisabled(t *testing.T) {
|
|
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.CSIInlineVolume, false)()
|
|
driver := &storagev1beta1.CSIDriver{}
|
|
|
|
// field should not be defaulted
|
|
output := roundTrip(t, runtime.Object(driver)).(*storagev1beta1.CSIDriver)
|
|
outModes := output.Spec.VolumeLifecycleModes
|
|
if outModes != nil {
|
|
t.Errorf("Expected VolumeLifecycleModes to remain nil, got: %+v", outModes)
|
|
}
|
|
}
|