b99a9094cc
Automatic merge from submit-queue CRI: Image pullable support in dockershim For #33189. The new test `ImageID should be set to the manifest digest (from RepoDigests) when available` introduced in #33014 is failing, because: 1) `docker-pullable://` conversion is not supported in dockershim; 2) `kuberuntime` and `dockershim` is using `ListImages with image name filter` to check whether image presents. However, `ListImages` doesn't support filter with `digest`. This PR: 1) Change `kuberuntime.IsImagePresent` to use `runtime.ImageStatus` and `dockershim.InspectImage` instead. ***Notice an API change: `ImageStatus` should return `(nil, nil)` for non-existing image.*** 2) Add `docker-pullable://` support. 3) Fix `RemoveImage` in dockershim https://github.com/kubernetes/kubernetes/pull/29316. I've tried myself, the test can pass now. @yujuhong @feiskyer @yifan-gu /cc @kubernetes/sig-node |
||
|---|---|---|
| .. | ||
| convert_test.go | ||
| convert.go | ||
| doc.go | ||
| docker_container_test.go | ||
| docker_container.go | ||
| docker_image_test.go | ||
| docker_image.go | ||
| docker_sandbox_test.go | ||
| docker_sandbox.go | ||
| docker_service_test.go | ||
| docker_service.go | ||
| helpers_test.go | ||
| helpers.go | ||
| legacy.go | ||
| naming_test.go | ||
| naming.go | ||