0a37f09c32
In most cases `dir` arg of `SetUpAt()` method of `volume.Mounter` interface is the same as `mounter.GetPath()` because we usually call `SetUpAt()` from `SetUp()` like this:"
```
func (ed *emptyDir) SetUp(mounterArgs volume.MounterArgs) error {
return ed.SetUpAt(ed.GetPath(), mounterArgs)
}
```
(this example is from `volume/emptydir/empty_dir.go`, but there are plenty other examples like that in `volume/*`)
However, there is currently one exception. This is from `volume/projected/projected.go`:
```
if err := wrapped.SetUpAt(dir, mounterArgs); err != nil {
return err
}
```
(see 96306f144a/pkg/volume/projected/projected.go (L203))
In this case `dir` is not equal to `wrapped.GetPath()` and `volume.SetVolumeOwnership()` fails when called from `SetUpAt()` of wrapped volume:
```
lstat /var/lib/kubelet/pods/a2f6e58f-7edf-4c48-a97c-ef1b8fd3caf6/volumes/kubernetes.io~empty-dir/wrapped_kube-api-access-knvkv: no such file or directory
```
To fix the issue let's pass `dir` arg to `volume.SetVolumeOwnership()` explicitly, and use it instead of `mounter.GetPath()`.
99 lines
3.0 KiB
Go
99 lines
3.0 KiB
Go
/*
|
|
Copyright 2015 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package fc
|
|
|
|
import (
|
|
"os"
|
|
|
|
v1 "k8s.io/api/core/v1"
|
|
"k8s.io/klog/v2"
|
|
"k8s.io/mount-utils"
|
|
|
|
"k8s.io/kubernetes/pkg/volume"
|
|
"k8s.io/kubernetes/pkg/volume/util"
|
|
)
|
|
|
|
// Abstract interface to disk operations.
|
|
type diskManager interface {
|
|
MakeGlobalPDName(disk fcDisk) string
|
|
MakeGlobalVDPDName(disk fcDisk) string
|
|
// Attaches the disk to the kubelet's host machine.
|
|
AttachDisk(b fcDiskMounter) (string, error)
|
|
// Detaches the disk from the kubelet's host machine.
|
|
DetachDisk(disk fcDiskUnmounter, devicePath string) error
|
|
// Detaches the block disk from the kubelet's host machine.
|
|
DetachBlockFCDisk(disk fcDiskUnmapper, mntPath, devicePath string) error
|
|
}
|
|
|
|
// utility to mount a disk based filesystem
|
|
func diskSetUp(manager diskManager, b fcDiskMounter, volPath string, mounter mount.Interface, fsGroup *int64, fsGroupChangePolicy *v1.PodFSGroupChangePolicy) error {
|
|
globalPDPath := manager.MakeGlobalPDName(*b.fcDisk)
|
|
noMnt, err := mounter.IsLikelyNotMountPoint(volPath)
|
|
|
|
if err != nil && !os.IsNotExist(err) {
|
|
klog.Errorf("cannot validate mountpoint: %s", volPath)
|
|
return err
|
|
}
|
|
if !noMnt {
|
|
return nil
|
|
}
|
|
if err := os.MkdirAll(volPath, 0750); err != nil {
|
|
klog.Errorf("failed to mkdir:%s", volPath)
|
|
return err
|
|
}
|
|
// Perform a bind mount to the full path to allow duplicate mounts of the same disk.
|
|
options := []string{"bind"}
|
|
if b.readOnly {
|
|
options = append(options, "ro")
|
|
}
|
|
mountOptions := util.JoinMountOptions(options, b.mountOptions)
|
|
err = mounter.MountSensitiveWithoutSystemd(globalPDPath, volPath, "", mountOptions, nil)
|
|
if err != nil {
|
|
klog.Errorf("Failed to bind mount: source:%s, target:%s, err:%v", globalPDPath, volPath, err)
|
|
noMnt, mntErr := b.mounter.IsLikelyNotMountPoint(volPath)
|
|
if mntErr != nil {
|
|
klog.Errorf("IsLikelyNotMountPoint check failed: %v", mntErr)
|
|
return err
|
|
}
|
|
if !noMnt {
|
|
if mntErr = b.mounter.Unmount(volPath); mntErr != nil {
|
|
klog.Errorf("Failed to unmount: %v", mntErr)
|
|
return err
|
|
}
|
|
noMnt, mntErr = b.mounter.IsLikelyNotMountPoint(volPath)
|
|
if mntErr != nil {
|
|
klog.Errorf("IsLikelyNotMountPoint check failed: %v", mntErr)
|
|
return err
|
|
}
|
|
if !noMnt {
|
|
// will most likely retry on next sync loop.
|
|
klog.Errorf("%s is still mounted, despite call to unmount(). Will try again next sync loop.", volPath)
|
|
return err
|
|
}
|
|
}
|
|
os.Remove(volPath)
|
|
|
|
return err
|
|
}
|
|
|
|
if !b.readOnly {
|
|
volume.SetVolumeOwnership(&b, volPath, fsGroup, fsGroupChangePolicy, util.FSGroupCompleteHook(b.plugin, nil))
|
|
}
|
|
|
|
return nil
|
|
}
|