
Automatic merge from submit-queue (batch tested with PRs 36626, 37294, 37463, 37943, 36541) Remove duplicate describer errs Downstream issue https://github.com/openshift/origin/issues/11846 **Release note**: ```release-note release-note-none ``` The `describe` command iterates through a list of infos received from the server and aggregates a list of errors while attempting to call each resource's respective describer. When a resource exists, but does not have a describer set, such as `Event`, the `describe` command outputs the same error `error: no description has been implemented for "Event"` for each info. ``` $ kubectl describe events no description has been implemented for "Event" no description has been implemented for "Event" no description has been implemented for "Event" no description has been implemented for "Event" no description has been implemented for "Event" no description has been implemented for "Event" no description has been implemented for "Event" no description has been implemented for "Event" no description has been implemented for "Event" no description has been implemented for "Event" no description has been implemented for "Event" no description has been implemented for "Event" no description has been implemented for "Event" no description has been implemented for "Event" ``` @kubernetes/kubectl @fabianofranz
206 lines
6.2 KiB
Go
206 lines
6.2 KiB
Go
/*
|
|
Copyright 2014 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
"strings"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
apierrors "k8s.io/kubernetes/pkg/api/errors"
|
|
"k8s.io/kubernetes/pkg/api/meta"
|
|
"k8s.io/kubernetes/pkg/kubectl"
|
|
"k8s.io/kubernetes/pkg/kubectl/cmd/templates"
|
|
cmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util"
|
|
"k8s.io/kubernetes/pkg/kubectl/resource"
|
|
"k8s.io/kubernetes/pkg/runtime"
|
|
utilerrors "k8s.io/kubernetes/pkg/util/errors"
|
|
"k8s.io/kubernetes/pkg/util/sets"
|
|
)
|
|
|
|
var (
|
|
describe_long = templates.LongDesc(`
|
|
Show details of a specific resource or group of resources.
|
|
This command joins many API calls together to form a detailed description of a
|
|
given resource or group of resources.
|
|
|
|
$ kubectl describe TYPE NAME_PREFIX
|
|
|
|
will first check for an exact match on TYPE and NAME_PREFIX. If no such resource
|
|
exists, it will output details for every resource that has a name prefixed with NAME_PREFIX.
|
|
|
|
` + valid_resources)
|
|
|
|
describe_example = templates.Examples(`
|
|
# Describe a node
|
|
kubectl describe nodes kubernetes-node-emt8.c.myproject.internal
|
|
|
|
# Describe a pod
|
|
kubectl describe pods/nginx
|
|
|
|
# Describe a pod identified by type and name in "pod.json"
|
|
kubectl describe -f pod.json
|
|
|
|
# Describe all pods
|
|
kubectl describe pods
|
|
|
|
# Describe pods by label name=myLabel
|
|
kubectl describe po -l name=myLabel
|
|
|
|
# Describe all pods managed by the 'frontend' replication controller (rc-created pods
|
|
# get the name of the rc as a prefix in the pod the name).
|
|
kubectl describe pods frontend`)
|
|
)
|
|
|
|
func NewCmdDescribe(f cmdutil.Factory, out, cmdErr io.Writer) *cobra.Command {
|
|
options := &resource.FilenameOptions{}
|
|
describerSettings := &kubectl.DescriberSettings{}
|
|
|
|
validArgs := kubectl.DescribableResources()
|
|
argAliases := kubectl.ResourceAliases(validArgs)
|
|
|
|
cmd := &cobra.Command{
|
|
Use: "describe (-f FILENAME | TYPE [NAME_PREFIX | -l label] | TYPE/NAME)",
|
|
Short: "Show details of a specific resource or group of resources",
|
|
Long: describe_long,
|
|
Example: describe_example,
|
|
Run: func(cmd *cobra.Command, args []string) {
|
|
err := RunDescribe(f, out, cmdErr, cmd, args, options, describerSettings)
|
|
cmdutil.CheckErr(err)
|
|
},
|
|
ValidArgs: validArgs,
|
|
ArgAliases: argAliases,
|
|
}
|
|
usage := "containing the resource to describe"
|
|
cmdutil.AddFilenameOptionFlags(cmd, options, usage)
|
|
cmd.Flags().StringP("selector", "l", "", "Selector (label query) to filter on, supports '=', '==', and '!='.")
|
|
cmd.Flags().Bool("all-namespaces", false, "If present, list the requested object(s) across all namespaces. Namespace in current context is ignored even if specified with --namespace.")
|
|
cmd.Flags().BoolVar(&describerSettings.ShowEvents, "show-events", true, "If true, display events related to the described object.")
|
|
cmdutil.AddInclude3rdPartyFlags(cmd)
|
|
return cmd
|
|
}
|
|
|
|
func RunDescribe(f cmdutil.Factory, out, cmdErr io.Writer, cmd *cobra.Command, args []string, options *resource.FilenameOptions, describerSettings *kubectl.DescriberSettings) error {
|
|
selector := cmdutil.GetFlagString(cmd, "selector")
|
|
allNamespaces := cmdutil.GetFlagBool(cmd, "all-namespaces")
|
|
cmdNamespace, enforceNamespace, err := f.DefaultNamespace()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if allNamespaces {
|
|
enforceNamespace = false
|
|
}
|
|
if len(args) == 0 && cmdutil.IsFilenameEmpty(options.Filenames) {
|
|
fmt.Fprint(cmdErr, "You must specify the type of resource to describe. ", valid_resources)
|
|
return cmdutil.UsageError(cmd, "Required resource not specified.")
|
|
}
|
|
|
|
mapper, typer := f.Object()
|
|
r := resource.NewBuilder(mapper, typer, resource.ClientMapperFunc(f.ClientForMapping), f.Decoder(true)).
|
|
ContinueOnError().
|
|
NamespaceParam(cmdNamespace).DefaultNamespace().AllNamespaces(allNamespaces).
|
|
FilenameParam(enforceNamespace, options).
|
|
SelectorParam(selector).
|
|
ResourceTypeOrNameArgs(true, args...).
|
|
Flatten().
|
|
Do()
|
|
err = r.Err()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
allErrs := []error{}
|
|
infos, err := r.Infos()
|
|
if err != nil {
|
|
if apierrors.IsNotFound(err) && len(args) == 2 {
|
|
return DescribeMatchingResources(mapper, typer, f, cmdNamespace, args[0], args[1], describerSettings, out, err)
|
|
}
|
|
allErrs = append(allErrs, err)
|
|
}
|
|
|
|
errs := sets.NewString()
|
|
first := true
|
|
for _, info := range infos {
|
|
mapping := info.ResourceMapping()
|
|
describer, err := f.Describer(mapping)
|
|
if err != nil {
|
|
if errs.Has(err.Error()) {
|
|
continue
|
|
}
|
|
allErrs = append(allErrs, err)
|
|
errs.Insert(err.Error())
|
|
continue
|
|
}
|
|
s, err := describer.Describe(info.Namespace, info.Name, *describerSettings)
|
|
if err != nil {
|
|
if errs.Has(err.Error()) {
|
|
continue
|
|
}
|
|
allErrs = append(allErrs, err)
|
|
errs.Insert(err.Error())
|
|
continue
|
|
}
|
|
if first {
|
|
first = false
|
|
fmt.Fprint(out, s)
|
|
} else {
|
|
fmt.Fprintf(out, "\n\n%s", s)
|
|
}
|
|
}
|
|
|
|
return utilerrors.NewAggregate(allErrs)
|
|
}
|
|
|
|
func DescribeMatchingResources(mapper meta.RESTMapper, typer runtime.ObjectTyper, f cmdutil.Factory, namespace, rsrc, prefix string, describerSettings *kubectl.DescriberSettings, out io.Writer, originalError error) error {
|
|
r := resource.NewBuilder(mapper, typer, resource.ClientMapperFunc(f.ClientForMapping), f.Decoder(true)).
|
|
NamespaceParam(namespace).DefaultNamespace().
|
|
ResourceTypeOrNameArgs(true, rsrc).
|
|
SingleResourceType().
|
|
Flatten().
|
|
Do()
|
|
mapping, err := r.ResourceMapping()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
describer, err := f.Describer(mapping)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
infos, err := r.Infos()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
isFound := false
|
|
for ix := range infos {
|
|
info := infos[ix]
|
|
if strings.HasPrefix(info.Name, prefix) {
|
|
isFound = true
|
|
s, err := describer.Describe(info.Namespace, info.Name, *describerSettings)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
fmt.Fprintf(out, "%s\n", s)
|
|
}
|
|
}
|
|
if !isFound {
|
|
return originalError
|
|
}
|
|
return nil
|
|
}
|