kubernetes/pkg/kubelet/oom/oom_watcher_linux_test.go
mattjmcnaughton 9077603b97
Add richer unit tests for OomWatcher
Add unit tests for OomWatcher that actually test the logic defined in
the `Start` method. As a result of an earlier refactor, its now trivial
to mock the OOMInstance events which the `oom_watcher` is supposed to be
watching.
2020-01-14 07:57:06 -05:00

180 lines
5.3 KiB
Go

/*
Copyright 2015 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package oom
import (
"fmt"
"testing"
"time"
v1 "k8s.io/api/core/v1"
"k8s.io/client-go/tools/record"
"github.com/google/cadvisor/utils/oomparser"
"github.com/stretchr/testify/assert"
)
type fakeStreamer struct {
oomInstancesToStream []*oomparser.OomInstance
}
func (fs *fakeStreamer) StreamOoms(outStream chan<- *oomparser.OomInstance) {
for _, oomInstance := range fs.oomInstancesToStream {
outStream <- oomInstance
}
}
// TestStartingWatcher tests that the watcher, using the actual streamer
// and not the fake, starts successfully.
func TestStartingWatcher(t *testing.T) {
fakeRecorder := &record.FakeRecorder{}
node := &v1.ObjectReference{}
oomWatcher, err := NewWatcher(fakeRecorder)
assert.NoError(t, err)
assert.NoError(t, oomWatcher.Start(node))
}
// TestWatcherRecordsEventsForOomEvents ensures that our OomInstances coming
// from `StreamOoms` are translated into events in our recorder.
func TestWatcherRecordsEventsForOomEvents(t *testing.T) {
oomInstancesToStream := []*oomparser.OomInstance{
{
Pid: 1000,
ProcessName: "fakeProcess",
TimeOfDeath: time.Now(),
ContainerName: recordEventContainerName,
VictimContainerName: "some-container",
},
}
numExpectedOomEvents := len(oomInstancesToStream)
fakeStreamer := &fakeStreamer{
oomInstancesToStream: oomInstancesToStream,
}
fakeRecorder := record.NewFakeRecorder(numExpectedOomEvents)
node := &v1.ObjectReference{}
oomWatcher := &realWatcher{
recorder: fakeRecorder,
oomStreamer: fakeStreamer,
}
assert.NoError(t, oomWatcher.Start(node))
eventsRecorded := getRecordedEvents(fakeRecorder, numExpectedOomEvents)
assert.Equal(t, numExpectedOomEvents, len(eventsRecorded))
}
func getRecordedEvents(fakeRecorder *record.FakeRecorder, numExpectedOomEvents int) []string {
eventsRecorded := []string{}
select {
case event := <-fakeRecorder.Events:
eventsRecorded = append(eventsRecorded, event)
if len(eventsRecorded) == numExpectedOomEvents {
break
}
case <-time.After(10 * time.Second):
break
}
return eventsRecorded
}
// TestWatcherRecordsEventsForOomEventsCorrectContainerName verifies that we
// only record OOM events when the container name is the one for which we want
// to record events (i.e. /).
func TestWatcherRecordsEventsForOomEventsCorrectContainerName(t *testing.T) {
// By "incorrect" container name, we mean a container name for which we
// don't want to record an oom event.
numOomEventsWithIncorrectContainerName := 1
oomInstancesToStream := []*oomparser.OomInstance{
{
Pid: 1000,
ProcessName: "fakeProcess",
TimeOfDeath: time.Now(),
ContainerName: recordEventContainerName,
VictimContainerName: "some-container",
},
{
Pid: 1000,
ProcessName: "fakeProcess",
TimeOfDeath: time.Now(),
ContainerName: "/dont-record-oom-event",
VictimContainerName: "some-container",
},
}
numExpectedOomEvents := len(oomInstancesToStream) - numOomEventsWithIncorrectContainerName
fakeStreamer := &fakeStreamer{
oomInstancesToStream: oomInstancesToStream,
}
fakeRecorder := record.NewFakeRecorder(numExpectedOomEvents)
node := &v1.ObjectReference{}
oomWatcher := &realWatcher{
recorder: fakeRecorder,
oomStreamer: fakeStreamer,
}
assert.NoError(t, oomWatcher.Start(node))
eventsRecorded := getRecordedEvents(fakeRecorder, numExpectedOomEvents)
assert.Equal(t, numExpectedOomEvents, len(eventsRecorded))
}
// TestWatcherRecordsEventsForOomEventsWithAdditionalInfo verifies that our the
// emitted event has the proper pid/process data when appropriate.
func TestWatcherRecordsEventsForOomEventsWithAdditionalInfo(t *testing.T) {
// The process and event info should appear in the event message.
eventPid := 1000
processName := "fakeProcess"
oomInstancesToStream := []*oomparser.OomInstance{
{
Pid: eventPid,
ProcessName: processName,
TimeOfDeath: time.Now(),
ContainerName: recordEventContainerName,
VictimContainerName: "some-container",
},
}
numExpectedOomEvents := len(oomInstancesToStream)
fakeStreamer := &fakeStreamer{
oomInstancesToStream: oomInstancesToStream,
}
fakeRecorder := record.NewFakeRecorder(numExpectedOomEvents)
node := &v1.ObjectReference{}
oomWatcher := &realWatcher{
recorder: fakeRecorder,
oomStreamer: fakeStreamer,
}
assert.NoError(t, oomWatcher.Start(node))
eventsRecorded := getRecordedEvents(fakeRecorder, numExpectedOomEvents)
assert.Equal(t, numExpectedOomEvents, len(eventsRecorded))
assert.Contains(t, eventsRecorded[0], systemOOMEvent)
assert.Contains(t, eventsRecorded[0], fmt.Sprintf("pid: %d", eventPid))
assert.Contains(t, eventsRecorded[0], fmt.Sprintf("victim process: %s", processName))
}