github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
92940fa80d
kubernetes/pkg/controller
History
mattjmcnaughton 92940fa80d
Remove recorder.PastEventf method 
The `recorder.PastEventf` method wasn't actually working as advertised.
It was supposed to accept a timestamp, which would be used when
generating the event. However, as the
[source code](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/tools/record/event.go#L316)
shows, this `timestamp` was never actually used.

In other words, `PastEventf` is identical to `Eventf`.

We have two options: one would be to fix `PastEventf` so that it works
as advertised. The other would be to delete `PastEventf` and only
support `Eventf`.

Ultimately, I could only find one use of `PastEventf` in the code base,
so I propose we just delete `PastEventf` and convert all uses to
`Eventf`.
2019-12-30 12:00:23 -05:00
..
apis/config Migrate components to EndpointsLeases leader election lock 2019-10-28 09:09:03 +01:00
bootstrap move util/metrics to component-base 2019-10-08 14:42:31 +02:00
certificates unify alias of api errors under pkg and staging 2019-12-26 16:42:28 +08:00
cloud Cloud node controller: Only call once into cloud provider 2019-12-17 20:03:27 +01:00
clusterroleaggregation move WaitForCacheSync to the sharedInformer package 2019-08-22 16:13:41 +01:00
cronjob Eliminate some default conversions 2019-11-06 14:08:15 +01:00
daemon Merge pull request #86229 from ahg-g/ahg-ds 2019-12-13 00:26:54 -08:00
deployment slim down some lister expansions 2019-12-07 08:27:06 +08:00
disruption Rename PodDisruptionsAllowed to DisruptionsAllowed in type PodDisruptionBudgetStatus 2019-12-03 14:26:35 -08:00
endpoint Remove use of testapi codecs, selflink, resourcepath functions 2019-12-13 11:56:29 -05:00
endpointslice Fixing Potential Race Condition in EndpointSlice Controller. 2019-12-26 12:15:38 -08:00
garbagecollector pkg/controller: fix staticcheck warning 2019-11-07 16:46:47 +08:00
history Remove use of testapi codecs, selflink, resourcepath functions 2019-12-13 11:56:29 -05:00
job Merge pull request #86142 from raz-bn/add-complete-event 2019-12-16 23:43:58 -08:00
namespace pkg/controller: fix staticcheck warning 2019-11-07 16:46:47 +08:00
nodeipam fix multiple node cidr masks in providerless build 2019-11-19 09:47:45 -08:00
nodelifecycle Merge pull request #84933 from krzysied/node_controller_v_level 2019-11-08 09:00:40 -08:00
podautoscaler Adds tests 2019-12-10 18:09:20 +01:00
podgc Merge pull request #84288 from wojtek-t/cleanup_conversions_registrations 2019-10-25 22:53:22 -07:00
replicaset Do not swallow timeout in manageReplicas 2019-12-12 11:27:36 -08:00
replication Autogenerated code 2019-10-24 20:21:00 +02:00
resourcequota Autogenerated code 2019-10-24 20:21:00 +02:00
route move util/metrics to component-base 2019-10-08 14:42:31 +02:00
service Remove use of testapi codecs, selflink, resourcepath functions 2019-12-13 11:56:29 -05:00
serviceaccount unify alias of api errors under pkg and staging 2019-12-26 16:42:28 +08:00
statefulset Correct spelling mistakes 2019-11-06 20:25:19 +08:00
testutil Remove recorder.PastEventf method 2019-12-30 12:00:23 -05:00
ttl move WaitForCacheSync to the sharedInformer package 2019-08-22 16:13:41 +01:00
ttlafterfinished Autogenerated code 2019-10-24 20:21:00 +02:00
util Promoting EndpointSlices to beta 2019-11-13 14:20:19 -08:00
volume unify alias of api errors under pkg and staging 2019-12-26 16:42:28 +08:00
.import-restrictions Remove pkg/util/mount (moved out of tree) 2019-11-15 08:29:12 -07:00
BUILD Remove use of testapi codecs, selflink, resourcepath functions 2019-12-13 11:56:29 -05:00
client_builder_dynamic.go Migrate the controller to use TokenRequest and rotate token periodically 2019-03-25 14:54:22 +08:00
client_builder.go Migrate the controller to use TokenRequest and rotate token periodically 2019-03-25 14:54:22 +08:00
controller_ref_manager_test.go remove unused code of (pkg/controller) 2018-10-09 08:15:30 +08:00
controller_ref_manager.go fix unsafe JSON construction 2019-10-10 09:44:54 +08:00
controller_utils_test.go Remove use of testapi codecs, selflink, resourcepath functions 2019-12-13 11:56:29 -05:00
controller_utils.go Merge pull request #84123 from smarterclayton/terminating_cause 2019-11-04 07:55:41 -08:00
doc.go Use Go canonical import paths 2016-07-16 13:48:21 -04:00
informer_factory.go Use metadata informers instead of dynamic informers in controller manager 2019-07-11 12:18:52 -04:00
lookup_cache.go Use fnv.New32a() in hash instead adler32 2017-02-15 14:03:54 +08:00
OWNERS Updated OWNERS files to include link to docs 2019-02-04 22:33:12 +01:00