102124464a
We will have two layers of the validation. - the first part of the validation logic will be implemented under the `ValidateKubeletConfiguration` method - the second one that requires knowledge about machine topology and node allocatable resources will be implemented under the memory manager. Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
65 lines
2.3 KiB
Go
65 lines
2.3 KiB
Go
/*
|
|
Copyright 2018 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package validation
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
v1 "k8s.io/api/core/v1"
|
|
corev1helper "k8s.io/kubernetes/pkg/apis/core/v1/helper"
|
|
kubeletconfig "k8s.io/kubernetes/pkg/kubelet/apis/config"
|
|
)
|
|
|
|
// validateReservedMemory validates the reserved memory configuration and returns an error if it is invalid.
|
|
func validateReservedMemoryConfiguration(kc *kubeletconfig.KubeletConfiguration) []error {
|
|
if len(kc.ReservedMemory) == 0 {
|
|
return nil
|
|
}
|
|
|
|
var errors []error
|
|
|
|
numaTypeDuplicates := map[int32]map[v1.ResourceName]bool{}
|
|
for _, reservedMemory := range kc.ReservedMemory {
|
|
numaNode := reservedMemory.NumaNode
|
|
if _, ok := numaTypeDuplicates[numaNode]; !ok {
|
|
numaTypeDuplicates[numaNode] = map[v1.ResourceName]bool{}
|
|
}
|
|
|
|
for resourceName, q := range reservedMemory.Limits {
|
|
if !reservedMemorySupportedLimit(resourceName) {
|
|
errors = append(errors, fmt.Errorf("the limit type %q for NUMA node %d is not supported, only %v is accepted", resourceName, numaNode, []v1.ResourceName{v1.ResourceMemory, v1.ResourceHugePagesPrefix + "<HugePageSize>"}))
|
|
}
|
|
|
|
// validates that the limit has non-zero value
|
|
if q.IsZero() {
|
|
errors = append(errors, fmt.Errorf("reserved memory may not be zero for NUMA node %d and resource %q", numaNode, resourceName))
|
|
}
|
|
|
|
// validates that no duplication for NUMA node and limit type occurred
|
|
if _, ok := numaTypeDuplicates[numaNode][resourceName]; ok {
|
|
errors = append(errors, fmt.Errorf("the reserved memory has a duplicate value for NUMA node %d and resource %q", numaNode, resourceName))
|
|
}
|
|
numaTypeDuplicates[numaNode][resourceName] = true
|
|
}
|
|
}
|
|
return errors
|
|
}
|
|
|
|
func reservedMemorySupportedLimit(resourceName v1.ResourceName) bool {
|
|
return corev1helper.IsHugePageResourceName(resourceName) || resourceName == v1.ResourceMemory
|
|
}
|