963697564a
Automatic merge from submit-queue (batch tested with PRs 50890, 52484, 52542, 52567, 50672). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Fix return 0 error in DefaultSubCommandRun Fixes https://github.com/kubernetes/kubernetes/issues/50644 @mengqiy most of our command didn't return 1 when error, is because it invoke `DefaultSubCommandRun` which created in this pr https://github.com/kubernetes/kubernetes/pull/35206, I'm not sure if it's ok to directly add an `os.Exit` in that function, so also cc @juanvallejo @fabianofranz for review. also @apelisse @mengqiy I think we don't have any test for check return value now ? cmiiw, I will add some test in test-cmd since it's easy to write scripts check return value, wdyt ? |
||
|---|---|---|
| .. | ||
| helpers | ||
| BUILD | ||
| build.sh | ||
| cross.sh | ||
| make-help.sh | ||
| test-cmd-util.sh | ||
| test-cmd.sh | ||
| test-e2e-node.sh | ||
| test-federation-cmd.sh | ||
| test-integration.sh | ||
| test-kubeadm-cmd.sh | ||
| test.sh | ||
| verify.sh | ||
| vet.sh | ||