github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
98d55db5ec
kubernetes/pkg/kubectl/cmd
History
Kubernetes Submit Queue fac05d9c81 Merge pull request #36174 from JacobTanenbaum/v2resource_fixes 
Automatic merge from submit-queue

V2resource fixes

when using kubectl set resources it resets all resource fields that are not being set.

for example
$ kubectl set resources deployments nginx --limits=cpu=100m

followed by

$ kubectl set resources deployments nginx --limits=memory=256Mi

would result in the nginx deployment only limiting memory at 256Mi with the previous
limit placed on the cpu being wiped out. This behavior is corrected so that each invocation
only modifies fields set in that command and changed the testing so that the desired behavior
is checked.

Also a typo:

you must specify an update to requests or limits or (in the form of --requests/--limits)

corrected to

you must specify an update to requests or limits (in the form of --requests/--limits)

Implemented both the dry run and local flags.

Added test cases to show that both flags are operating as intended.
Removed the print statement "running in local mode" as in PR#35112

The original PR associated with these fixes where reverted due to causing a flake in hack/make-rules/test-cmd.sh, I gave the 'kubectl set resources' tests there own deployment and set the terminationGracePeriodSeconds to 0 and have run test-cmd.sh for hours without hitting the flake
2016-11-15 21:03:06 -08:00
..
config Set non-zero exit code on failures for kubectl. 2016-11-12 07:40:54 -05:00
rollout support patch list of primitives 2016-11-09 11:46:59 -08:00
set Merge pull request #36174 from JacobTanenbaum/v2resource_fixes 2016-11-15 21:03:06 -08:00
templates autogenerated 2016-10-21 17:32:32 -07:00
testing Add caching for discovery info 2016-11-04 21:17:12 +01:00
util support patch list of primitives 2016-11-09 11:46:59 -08:00
annotate_test.go support patch list of primitives 2016-11-09 11:46:59 -08:00
annotate.go support patch list of primitives 2016-11-09 11:46:59 -08:00
apiversions.go update various commands to adapt the new Factory interface 2016-10-13 21:01:14 +08:00
apply_test.go support patch list of primitives 2016-11-09 11:46:59 -08:00
apply.go Merge pull request #35647 from ymqytw/patch_primitive_list 2016-11-11 14:36:44 -08:00
attach_test.go move client/unversioned/fake to client/restclient/fake 2016-10-29 14:22:02 -07:00
attach.go include multiple versions in clientset 2016-10-29 13:30:47 -07:00
autoscale.go Use our own normalizers for cmd examples and descriptions 2016-10-17 11:49:55 -02:00
BUILD Merge pull request #35543 from philips/improve-version 2016-11-14 22:39:21 -08:00
certificates.go implement kubectl procelain csr commands 2016-11-08 06:33:46 -08:00
clusterinfo_dump_test.go Move the common test functions from cmd_test.go to cmd/testing/fake.go 2016-10-19 08:53:26 +10:00
clusterinfo_dump.go Use our own normalizers for cmd examples and descriptions 2016-10-17 11:49:55 -02:00
clusterinfo.go Use our own normalizers for cmd examples and descriptions 2016-10-17 11:49:55 -02:00
cmd_test.go support patch list of primitives 2016-11-09 11:46:59 -08:00
cmd.go Merge pull request #30237 from mikedanese/csr-porcelain 2016-11-09 16:57:49 -08:00
completion.go Add boilerplate to kubectl completion bash 2016-10-21 14:07:38 -07:00
convert.go Fix handling lists in kubectl convert 2016-11-10 18:19:30 -02:00
cp_test.go add kubectl cp 2016-10-29 20:24:54 -07:00
cp.go add kubectl cp 2016-10-29 20:24:54 -07:00
create_configmap_test.go move client/unversioned/fake to client/restclient/fake 2016-10-29 14:22:02 -07:00
create_configmap.go Use our own normalizers for cmd examples and descriptions 2016-10-17 11:49:55 -02:00
create_deployment_test.go Move the common test functions from cmd_test.go to cmd/testing/fake.go 2016-10-19 08:53:26 +10:00
create_deployment.go Use our own normalizers for cmd examples and descriptions 2016-10-17 11:49:55 -02:00
create_namespace_test.go move client/unversioned/fake to client/restclient/fake 2016-10-29 14:22:02 -07:00
create_namespace.go Use our own normalizers for cmd examples and descriptions 2016-10-17 11:49:55 -02:00
create_quota_test.go move client/unversioned/fake to client/restclient/fake 2016-10-29 14:22:02 -07:00
create_quota.go Use our own normalizers for cmd examples and descriptions 2016-10-17 11:49:55 -02:00
create_secret_test.go move client/unversioned/fake to client/restclient/fake 2016-10-29 14:22:02 -07:00
create_secret.go update default run function for sub-commands 2016-10-31 10:08:12 -04:00
create_service_test.go move client/unversioned/fake to client/restclient/fake 2016-10-29 14:22:02 -07:00
create_service.go update default run function for sub-commands 2016-10-31 10:08:12 -04:00
create_serviceaccount_test.go move client/unversioned/fake to client/restclient/fake 2016-10-29 14:22:02 -07:00
create_serviceaccount.go Use our own normalizers for cmd examples and descriptions 2016-10-17 11:49:55 -02:00
create_test.go move client/unversioned/fake to client/restclient/fake 2016-10-29 14:22:02 -07:00
create.go update default run function for sub-commands 2016-10-31 10:08:12 -04:00
delete_test.go make kubectl get generic with respect to objects 2016-11-04 09:04:57 -04:00
delete.go Merge pull request #35484 from smarterclayton/delete_warning 2016-11-05 11:19:04 -07:00
describe_test.go move client/unversioned/fake to client/restclient/fake 2016-10-29 14:22:02 -07:00
describe.go Use our own normalizers for cmd examples and descriptions 2016-10-17 11:49:55 -02:00
drain_test.go Fix kubectl drain for statefulset and use eviciton for drain if possible 2016-11-07 16:13:06 -08:00
drain.go Merge pull request #36211 from brendandburns/cordon 2016-11-08 16:05:53 -08:00
edit.go support patch list of primitives 2016-11-09 11:46:59 -08:00
exec_test.go move client/unversioned/fake to client/restclient/fake 2016-10-29 14:22:02 -07:00
exec.go include multiple versions in clientset 2016-10-29 13:30:47 -07:00
explain.go Use our own normalizers for cmd examples and descriptions 2016-10-17 11:49:55 -02:00
expose_test.go move client/unversioned/fake to client/restclient/fake 2016-10-29 14:22:02 -07:00
expose.go Use our own normalizers for cmd examples and descriptions 2016-10-17 11:49:55 -02:00
get_test.go make kubectl get generic with respect to objects 2016-11-04 09:04:57 -04:00
get.go make kubectl get generic with respect to objects 2016-11-04 09:04:57 -04:00
help.go Use our own normalizers for cmd examples and descriptions 2016-10-17 11:49:55 -02:00
label_test.go support patch list of primitives 2016-11-09 11:46:59 -08:00
label.go support patch list of primitives 2016-11-09 11:46:59 -08:00
logs_test.go move client/unversioned/fake to client/restclient/fake 2016-10-29 14:22:02 -07:00
logs.go Use our own normalizers for cmd examples and descriptions 2016-10-17 11:49:55 -02:00
options.go update kubectl help output for better organization 2016-08-20 08:03:39 +08:00
patch_test.go support patch list of primitives 2016-11-09 11:46:59 -08:00
patch.go support patch list of primitives 2016-11-09 11:46:59 -08:00
portforward_test.go move client/unversioned/fake to client/restclient/fake 2016-10-29 14:22:02 -07:00
portforward.go include multiple versions in clientset 2016-10-29 13:30:47 -07:00
proxy.go Use our own normalizers for cmd examples and descriptions 2016-10-17 11:49:55 -02:00
replace_test.go move client/unversioned/fake to client/restclient/fake 2016-10-29 14:22:02 -07:00
replace.go make kubectl replace generic 2016-11-04 07:50:31 -04:00
rollingupdate_test.go Move the common test functions from cmd_test.go to cmd/testing/fake.go 2016-10-19 08:53:26 +10:00
rollingupdate.go Update clientset generator to use RESTClient interface instead of the RESTClient data type 2016-10-21 10:13:51 +02:00
run_test.go Merge pull request #35732 from fabianofranz/run_cant_dryrun_with_attach 2016-10-30 13:07:28 -07:00
run.go Merge pull request #36355 from soltysh/deprecate_extensionsjob 2016-11-08 07:18:40 -08:00
scale.go support patch list of primitives 2016-11-09 11:46:59 -08:00
stop.go Use our own normalizers for cmd examples and descriptions 2016-10-17 11:49:55 -02:00
taint_test.go support patch list of primitives 2016-11-09 11:46:59 -08:00
taint.go support patch list of primitives 2016-11-09 11:46:59 -08:00
top_node_test.go move client/unversioned/fake to client/restclient/fake 2016-10-29 14:22:02 -07:00
top_node.go include multiple versions in clientset 2016-10-29 13:30:47 -07:00
top_pod_test.go move client/unversioned/fake to client/restclient/fake 2016-10-29 14:22:02 -07:00
top_pod.go include multiple versions in clientset 2016-10-29 13:30:47 -07:00
top_test.go update default run function for sub-commands 2016-10-31 10:08:12 -04:00
top.go update default run function for sub-commands 2016-10-31 10:08:12 -04:00
version.go kubectl: add less verbose version 2016-11-10 14:07:42 -08:00