b351745c1c
On IPv6 clusters, one of the most frequent problems I encounter is
assumptions that one can build a URL with a host and port simply by
using Sprintf, like this:
```go
fmt.Sprintf("http://%s:%d/foo", host, port)
```
When `host` is an IPv6 address, this produces an invalid URL as it must
be bracketed, like this:
```
http://[2001:4860:4860::8888]:9443
```
This change fixes the occurences of joining a host and port with the
purpose built `net.JoinHostPort` function.
I encounter this problem often enough that I started to [write a linter
for it](https://github.com/stbenjam/go-sprintf-host-port). I don't
think the linter is quite ready for wide use yet, but I did run it
against the Kube codebase and found these. While the host portion in
some of these changes may always be an FQDN or IPv4 IP today, it's an
easy thing that can break later on.
88 lines
2.8 KiB
Go
88 lines
2.8 KiB
Go
/*
|
|
Copyright 2019 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package windows
|
|
|
|
import (
|
|
"fmt"
|
|
"net"
|
|
"strconv"
|
|
|
|
v1 "k8s.io/api/core/v1"
|
|
clientset "k8s.io/client-go/kubernetes"
|
|
|
|
"k8s.io/kubernetes/test/e2e/framework"
|
|
e2enode "k8s.io/kubernetes/test/e2e/framework/node"
|
|
e2eservice "k8s.io/kubernetes/test/e2e/framework/service"
|
|
e2eskipper "k8s.io/kubernetes/test/e2e/framework/skipper"
|
|
admissionapi "k8s.io/pod-security-admission/api"
|
|
|
|
"github.com/onsi/ginkgo"
|
|
)
|
|
|
|
var _ = SIGDescribe("Services", func() {
|
|
f := framework.NewDefaultFramework("services")
|
|
f.NamespacePodSecurityEnforceLevel = admissionapi.LevelPrivileged
|
|
|
|
var cs clientset.Interface
|
|
|
|
ginkgo.BeforeEach(func() {
|
|
//Only for Windows containers
|
|
e2eskipper.SkipUnlessNodeOSDistroIs("windows")
|
|
cs = f.ClientSet
|
|
})
|
|
ginkgo.It("should be able to create a functioning NodePort service for Windows", func() {
|
|
serviceName := "nodeport-test"
|
|
ns := f.Namespace.Name
|
|
|
|
jig := e2eservice.NewTestJig(cs, ns, serviceName)
|
|
nodeIP, err := e2enode.PickIP(jig.Client)
|
|
framework.ExpectNoError(err)
|
|
|
|
ginkgo.By("creating service " + serviceName + " with type=NodePort in namespace " + ns)
|
|
svc, err := jig.CreateTCPService(func(svc *v1.Service) {
|
|
svc.Spec.Type = v1.ServiceTypeNodePort
|
|
})
|
|
framework.ExpectNoError(err)
|
|
|
|
nodePort := int(svc.Spec.Ports[0].NodePort)
|
|
|
|
ginkgo.By("creating Pod to be part of service " + serviceName)
|
|
// tweak the Jig to use windows...
|
|
windowsNodeSelectorTweak := func(rc *v1.ReplicationController) {
|
|
rc.Spec.Template.Spec.NodeSelector = map[string]string{
|
|
"kubernetes.io/os": "windows",
|
|
}
|
|
}
|
|
_, err = jig.Run(windowsNodeSelectorTweak)
|
|
framework.ExpectNoError(err)
|
|
|
|
//using hybrid_network methods
|
|
ginkgo.By("creating Windows testing Pod")
|
|
testPod := createTestPod(f, windowsBusyBoximage, windowsOS)
|
|
testPod = f.PodClient().CreateSync(testPod)
|
|
|
|
ginkgo.By("verifying that pod has the correct nodeSelector")
|
|
// Admission controllers may sometimes do the wrong thing
|
|
framework.ExpectEqual(testPod.Spec.NodeSelector["kubernetes.io/os"], "windows")
|
|
|
|
ginkgo.By(fmt.Sprintf("checking connectivity Pod to curl http://%s:%d", nodeIP, nodePort))
|
|
assertConsistentConnectivity(f, testPod.ObjectMeta.Name, windowsOS, windowsCheck(fmt.Sprintf("http://%s", net.JoinHostPort(nodeIP, strconv.Itoa(nodePort)))))
|
|
|
|
})
|
|
|
|
})
|