
* namespace by name default labelling Co-authored-by: Jordan Liggitt <jordan@liggitt.net> Co-authored-by: Abhishek Raut <rauta@vmware.com> * Make some logic improvement into default namespace label * Fix unit tests * minor change to trigger the CI * Correct some tests and validation behaviors * Add Canonicalize normalization and improve validation * Remove label validation that should be dealt by strategy * Update defaults_test.go add fuzzer ns spec * remove the finalizer thingy * Fix integration test * Add namespace canonicalize unit test * Improve validation code and code comments * move validation of labels to validateupdate * spacex will save us all * add comment to testget * readablility of canonicalize * Added namespace finalize and status update validation * comment about ungenerated names * correcting a missing line on storage_test * Update the namespace validation unit test * Add more missing unit test changes * Let's just blast the value. Also documenting the workflow here * Remove unnecessary validations Co-authored-by: Jordan Liggitt <jordan@liggitt.net> Co-authored-by: Abhishek Raut <rauta@vmware.com> Co-authored-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com>
168 lines
6.3 KiB
Go
168 lines
6.3 KiB
Go
/*
|
|
Copyright 2014 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package namespace
|
|
|
|
import (
|
|
"testing"
|
|
|
|
v1 "k8s.io/api/core/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
genericapirequest "k8s.io/apiserver/pkg/endpoints/request"
|
|
utilfeature "k8s.io/apiserver/pkg/util/feature"
|
|
featuregatetesting "k8s.io/component-base/featuregate/testing"
|
|
apitesting "k8s.io/kubernetes/pkg/api/testing"
|
|
api "k8s.io/kubernetes/pkg/apis/core"
|
|
"k8s.io/kubernetes/pkg/features"
|
|
|
|
// ensure types are installed
|
|
_ "k8s.io/kubernetes/pkg/apis/core/install"
|
|
)
|
|
|
|
func TestNamespaceStrategy(t *testing.T) {
|
|
ctx := genericapirequest.NewDefaultContext()
|
|
if Strategy.NamespaceScoped() {
|
|
t.Errorf("Namespaces should not be namespace scoped")
|
|
}
|
|
if Strategy.AllowCreateOnUpdate() {
|
|
t.Errorf("Namespaces should not allow create on update")
|
|
}
|
|
namespace := &api.Namespace{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "foo", ResourceVersion: "10", Labels: map[string]string{v1.LabelMetadataName: "foo"}},
|
|
Status: api.NamespaceStatus{Phase: api.NamespaceTerminating},
|
|
}
|
|
Strategy.PrepareForCreate(ctx, namespace)
|
|
if namespace.Status.Phase != api.NamespaceActive {
|
|
t.Errorf("Namespaces do not allow setting phase on create")
|
|
}
|
|
if len(namespace.Spec.Finalizers) != 1 || namespace.Spec.Finalizers[0] != api.FinalizerKubernetes {
|
|
t.Errorf("Prepare For Create should have added kubernetes finalizer")
|
|
}
|
|
errs := Strategy.Validate(ctx, namespace)
|
|
if len(errs) != 0 {
|
|
t.Errorf("Unexpected error validating %v", errs)
|
|
}
|
|
invalidNamespace := &api.Namespace{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "bar", ResourceVersion: "4"},
|
|
}
|
|
// ensure we copy spec.finalizers from old to new
|
|
Strategy.PrepareForUpdate(ctx, invalidNamespace, namespace)
|
|
if len(invalidNamespace.Spec.Finalizers) != 1 || invalidNamespace.Spec.Finalizers[0] != api.FinalizerKubernetes {
|
|
t.Errorf("PrepareForUpdate should have preserved old.spec.finalizers")
|
|
}
|
|
errs = Strategy.ValidateUpdate(ctx, invalidNamespace, namespace)
|
|
if len(errs) == 0 {
|
|
t.Errorf("Expected a validation error")
|
|
}
|
|
if invalidNamespace.ResourceVersion != "4" {
|
|
t.Errorf("Incoming resource version on update should not be mutated")
|
|
}
|
|
}
|
|
|
|
func TestNamespaceDefaultLabelCanonicalize(t *testing.T) {
|
|
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.NamespaceDefaultLabelName, true)()
|
|
|
|
namespace := &api.Namespace{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "foo"},
|
|
}
|
|
|
|
Strategy.Canonicalize(namespace)
|
|
if namespace.Labels[v1.LabelMetadataName] != namespace.Name {
|
|
t.Errorf("Invalid namespace, default label was not added")
|
|
}
|
|
}
|
|
|
|
func TestNamespaceStatusStrategy(t *testing.T) {
|
|
ctx := genericapirequest.NewDefaultContext()
|
|
if StatusStrategy.NamespaceScoped() {
|
|
t.Errorf("Namespaces should not be namespace scoped")
|
|
}
|
|
if StatusStrategy.AllowCreateOnUpdate() {
|
|
t.Errorf("Namespaces should not allow create on update")
|
|
}
|
|
now := metav1.Now()
|
|
oldNamespace := &api.Namespace{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "foo", ResourceVersion: "10", DeletionTimestamp: &now,
|
|
Labels: map[string]string{v1.LabelMetadataName: "foo"}},
|
|
Spec: api.NamespaceSpec{Finalizers: []api.FinalizerName{"kubernetes"}},
|
|
Status: api.NamespaceStatus{Phase: api.NamespaceActive},
|
|
}
|
|
namespace := &api.Namespace{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "foo", ResourceVersion: "9", DeletionTimestamp: &now,
|
|
Labels: map[string]string{v1.LabelMetadataName: "foo"}},
|
|
Status: api.NamespaceStatus{Phase: api.NamespaceTerminating},
|
|
}
|
|
StatusStrategy.PrepareForUpdate(ctx, namespace, oldNamespace)
|
|
if namespace.Status.Phase != api.NamespaceTerminating {
|
|
t.Errorf("Namespace status updates should allow change of phase: %v", namespace.Status.Phase)
|
|
}
|
|
if len(namespace.Spec.Finalizers) != 1 || namespace.Spec.Finalizers[0] != api.FinalizerKubernetes {
|
|
t.Errorf("PrepareForUpdate should have preserved old finalizers")
|
|
}
|
|
errs := StatusStrategy.ValidateUpdate(ctx, namespace, oldNamespace)
|
|
if len(errs) != 0 {
|
|
t.Errorf("Unexpected error %v", errs)
|
|
}
|
|
if namespace.ResourceVersion != "9" {
|
|
t.Errorf("Incoming resource version on update should not be mutated")
|
|
}
|
|
}
|
|
|
|
func TestNamespaceFinalizeStrategy(t *testing.T) {
|
|
ctx := genericapirequest.NewDefaultContext()
|
|
if FinalizeStrategy.NamespaceScoped() {
|
|
t.Errorf("Namespaces should not be namespace scoped")
|
|
}
|
|
if FinalizeStrategy.AllowCreateOnUpdate() {
|
|
t.Errorf("Namespaces should not allow create on update")
|
|
}
|
|
oldNamespace := &api.Namespace{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "foo", ResourceVersion: "10",
|
|
Labels: map[string]string{v1.LabelMetadataName: "foo"}},
|
|
Spec: api.NamespaceSpec{Finalizers: []api.FinalizerName{"kubernetes", "example.com/org"}},
|
|
Status: api.NamespaceStatus{Phase: api.NamespaceActive},
|
|
}
|
|
namespace := &api.Namespace{
|
|
ObjectMeta: metav1.ObjectMeta{Name: "foo", ResourceVersion: "9",
|
|
Labels: map[string]string{v1.LabelMetadataName: "foo"}},
|
|
Spec: api.NamespaceSpec{Finalizers: []api.FinalizerName{"example.com/foo"}},
|
|
Status: api.NamespaceStatus{Phase: api.NamespaceTerminating},
|
|
}
|
|
FinalizeStrategy.PrepareForUpdate(ctx, namespace, oldNamespace)
|
|
if namespace.Status.Phase != api.NamespaceActive {
|
|
t.Errorf("finalize updates should not allow change of phase: %v", namespace.Status.Phase)
|
|
}
|
|
if len(namespace.Spec.Finalizers) != 1 || string(namespace.Spec.Finalizers[0]) != "example.com/foo" {
|
|
t.Errorf("PrepareForUpdate should have modified finalizers")
|
|
}
|
|
errs := StatusStrategy.ValidateUpdate(ctx, namespace, oldNamespace)
|
|
if len(errs) != 0 {
|
|
t.Errorf("Unexpected error %v", errs)
|
|
}
|
|
if namespace.ResourceVersion != "9" {
|
|
t.Errorf("Incoming resource version on update should not be mutated")
|
|
}
|
|
}
|
|
|
|
func TestSelectableFieldLabelConversions(t *testing.T) {
|
|
apitesting.TestSelectableFieldLabelConversionsOfKind(t,
|
|
"v1",
|
|
"Namespace",
|
|
NamespaceToSelectableFields(&api.Namespace{}),
|
|
map[string]string{"name": "metadata.name"},
|
|
)
|
|
}
|