github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
a69752c81f
kubernetes/pkg/controller
History
Kubernetes Submit Queue a69752c81f Merge pull request #31944 from m1093782566/m109-master-fix-found 
Automatic merge from submit-queue

[Pet Set] Clean up code

<!--  Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md
2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md
3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes
-->

**What this PR does / why we need it**:

Clean code of petset, from:

```
func (p *apiServerPetClient) getPVC(pvcName, pvcNamespace string) (*api.PersistentVolumeClaim, bool, error)
```

to:

```
func (p *apiServerPetClient) getPVC(pvcName, pvcNamespace string) (*api.PersistentVolumeClaim, error) 
```

I think the 2nd(bool type) return value of [getPVC](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/petset/pet.go#L228) is unnecessary, as the caller can be responsible for checking the error type and tell if it exists via the [error type](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/petset/pet.go#L231-L233).

So, I remove the 2nd return value of `getPVC()`.

The benefit of this change is that we can simplify the code of `getPVC()` while don't increase the caller's code.
2016-09-09 15:00:22 -07:00
..
certificates add names for workqueues to gather controller latency/depth metrics 2016-08-30 09:51:50 -04:00
daemon fix log message to include ds name 2016-09-05 18:57:04 -07:00
deployment add names for workqueues to gather controller latency/depth metrics 2016-08-30 09:51:50 -04:00
disruption add names for workqueues to gather controller latency/depth metrics 2016-08-30 09:51:50 -04:00
endpoint Logging for service restart e2e clarity 2016-09-01 14:49:52 -07:00
framework Collapse duplicate informer creation paths 2016-08-04 09:02:13 +02:00
garbagecollector Merge pull request #31271 from deads2k/self-sar 2016-09-08 01:29:48 -07:00
job add names for workqueues to gather controller latency/depth metrics 2016-08-30 09:51:50 -04:00
namespace Merge pull request #31917 from derekwaynecarr/delete-pods-last 2016-09-02 00:50:02 -07:00
node Change the eviction metric type and fix rate-limited-timed-queue 2016-09-08 12:20:51 +02:00
petset Merge pull request #31944 from m1093782566/m109-master-fix-found 2016-09-09 15:00:22 -07:00
podautoscaler Merge pull request #28759 from xiang90/pas 2016-09-06 00:38:46 -07:00
podgc Use Go canonical import paths 2016-07-16 13:48:21 -04:00
replicaset add names for workqueues to gather controller latency/depth metrics 2016-08-30 09:51:50 -04:00
replication Fix debugging log in RC 2016-09-06 08:50:44 +02:00
resourcequota add names for workqueues to gather controller latency/depth metrics 2016-08-30 09:51:50 -04:00
route Use Go canonical import paths 2016-07-16 13:48:21 -04:00
scheduledjob Fix the bug that SJ sees finished jobs as unexpected 2016-08-25 17:01:22 -07:00
service persist services need to be retried in service controller cache. 2016-08-23 14:49:54 +08:00
serviceaccount add names for workqueues to gather controller latency/depth metrics 2016-08-30 09:51:50 -04:00
volume Do not report warning event when an nknown provisioner is requested 2016-09-07 09:11:41 +02:00
controller_ref_manager.go fix tests; convert IsPodActive to operate on *Pod 2016-08-17 13:05:37 -07:00
controller_utils_test.go fix tests; convert IsPodActive to operate on *Pod 2016-08-17 13:05:37 -07:00
controller_utils.go Don't validate selector that is already validated 2016-08-22 09:39:32 +02:00
doc.go Use Go canonical import paths 2016-07-16 13:48:21 -04:00
lookup_cache.go Remove "All rights reserved" from all the headers. 2016-06-29 17:47:36 -07:00
OWNERS Remove myself from a bunch of OWNERS files, as I am too overloaded 2016-05-11 13:34:51 -07:00