fa0dd46ab7
Before this change, Authorize() method was just returning an error, regardless of whether the user is unauthorized or whether there is some other unrelated error. Returning boolean with information about user authorization and error (which should be unrelated to the authorization) separately will make it easier to debug. Fixes #27974
84 lines
2.1 KiB
Go
84 lines
2.1 KiB
Go
/*
|
|
Copyright 2014 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package union
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"k8s.io/kubernetes/pkg/auth/authorizer"
|
|
)
|
|
|
|
type mockAuthzHandler struct {
|
|
isAuthorized bool
|
|
err error
|
|
}
|
|
|
|
func (mock *mockAuthzHandler) Authorize(a authorizer.Attributes) (bool, string, error) {
|
|
if mock.err != nil {
|
|
return false, "", mock.err
|
|
}
|
|
if !mock.isAuthorized {
|
|
return false, "", nil
|
|
}
|
|
return true, "", nil
|
|
}
|
|
|
|
func TestAuthorizationSecondPasses(t *testing.T) {
|
|
handler1 := &mockAuthzHandler{isAuthorized: false}
|
|
handler2 := &mockAuthzHandler{isAuthorized: true}
|
|
authzHandler := New(handler1, handler2)
|
|
|
|
authorized, _, _ := authzHandler.Authorize(nil)
|
|
if !authorized {
|
|
t.Errorf("Unexpected authorization failure")
|
|
}
|
|
}
|
|
|
|
func TestAuthorizationFirstPasses(t *testing.T) {
|
|
handler1 := &mockAuthzHandler{isAuthorized: true}
|
|
handler2 := &mockAuthzHandler{isAuthorized: false}
|
|
authzHandler := New(handler1, handler2)
|
|
|
|
authorized, _, _ := authzHandler.Authorize(nil)
|
|
if !authorized {
|
|
t.Errorf("Unexpected authorization failure")
|
|
}
|
|
}
|
|
|
|
func TestAuthorizationNonePasses(t *testing.T) {
|
|
handler1 := &mockAuthzHandler{isAuthorized: false}
|
|
handler2 := &mockAuthzHandler{isAuthorized: false}
|
|
authzHandler := New(handler1, handler2)
|
|
|
|
authorized, _, _ := authzHandler.Authorize(nil)
|
|
if authorized {
|
|
t.Errorf("Expected failed authorization")
|
|
}
|
|
}
|
|
|
|
func TestAuthorizationError(t *testing.T) {
|
|
handler1 := &mockAuthzHandler{err: fmt.Errorf("foo")}
|
|
handler2 := &mockAuthzHandler{err: fmt.Errorf("foo")}
|
|
authzHandler := New(handler1, handler2)
|
|
|
|
_, _, err := authzHandler.Authorize(nil)
|
|
if err == nil {
|
|
t.Errorf("Expected error: %v", err)
|
|
}
|
|
}
|