70deeb0ae4
When node is deleted, attach-detach controller cache may contain stale information of this node, and update node status fails in reconciler loop. But one node update failure should not block updating other nodes. Also the warning message easily flush the log file. This PR is just a quick fix of this issue. More complete fix including make sure controller cache up to date will be addressed in another PR.
131 lines
3.6 KiB
Go
131 lines
3.6 KiB
Go
/*
|
|
Copyright 2016 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
// Package statusupdater implements interfaces that enable updating the status
|
|
// of API objects.
|
|
package statusupdater
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
|
|
"github.com/golang/glog"
|
|
|
|
"k8s.io/kubernetes/pkg/api"
|
|
"k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset"
|
|
"k8s.io/kubernetes/pkg/controller/framework"
|
|
"k8s.io/kubernetes/pkg/controller/volume/attachdetach/cache"
|
|
"k8s.io/kubernetes/pkg/util/strategicpatch"
|
|
)
|
|
|
|
// NodeStatusUpdater defines a set of operations for updating the
|
|
// VolumesAttached field in the Node Status.
|
|
type NodeStatusUpdater interface {
|
|
// Gets a list of node statuses that should be updated from the actual state
|
|
// of the world and updates them.
|
|
UpdateNodeStatuses() error
|
|
}
|
|
|
|
// NewNodeStatusUpdater returns a new instance of NodeStatusUpdater.
|
|
func NewNodeStatusUpdater(
|
|
kubeClient internalclientset.Interface,
|
|
nodeInformer framework.SharedInformer,
|
|
actualStateOfWorld cache.ActualStateOfWorld) NodeStatusUpdater {
|
|
return &nodeStatusUpdater{
|
|
actualStateOfWorld: actualStateOfWorld,
|
|
nodeInformer: nodeInformer,
|
|
kubeClient: kubeClient,
|
|
}
|
|
}
|
|
|
|
type nodeStatusUpdater struct {
|
|
kubeClient internalclientset.Interface
|
|
nodeInformer framework.SharedInformer
|
|
actualStateOfWorld cache.ActualStateOfWorld
|
|
}
|
|
|
|
func (nsu *nodeStatusUpdater) UpdateNodeStatuses() error {
|
|
nodesToUpdate := nsu.actualStateOfWorld.GetVolumesToReportAttached()
|
|
for nodeName, attachedVolumes := range nodesToUpdate {
|
|
nodeObj, exists, err := nsu.nodeInformer.GetStore().GetByKey(nodeName)
|
|
if nodeObj == nil || !exists || err != nil {
|
|
// If node does not exist, its status cannot be updated, log error and move on.
|
|
glog.V(5).Infof(
|
|
"Could not update node status. Failed to find node %q in NodeInformer cache. %v",
|
|
nodeName,
|
|
err)
|
|
continue
|
|
}
|
|
|
|
node, ok := nodeObj.(*api.Node)
|
|
if !ok || node == nil {
|
|
return fmt.Errorf(
|
|
"failed to cast %q object %#v to Node",
|
|
nodeName,
|
|
nodeObj)
|
|
}
|
|
|
|
oldData, err := json.Marshal(node)
|
|
if err != nil {
|
|
return fmt.Errorf(
|
|
"failed to Marshal oldData for node %q. %v",
|
|
nodeName,
|
|
err)
|
|
}
|
|
|
|
node.Status.VolumesAttached = attachedVolumes
|
|
|
|
newData, err := json.Marshal(node)
|
|
if err != nil {
|
|
return fmt.Errorf(
|
|
"failed to Marshal newData for node %q. %v",
|
|
nodeName,
|
|
err)
|
|
}
|
|
|
|
patchBytes, err :=
|
|
strategicpatch.CreateStrategicMergePatch(oldData, newData, node)
|
|
if err != nil {
|
|
return fmt.Errorf(
|
|
"failed to CreateStrategicMergePatch for node %q. %v",
|
|
nodeName,
|
|
err)
|
|
}
|
|
|
|
_, err = nsu.kubeClient.Core().Nodes().PatchStatus(nodeName, patchBytes)
|
|
if err != nil {
|
|
return fmt.Errorf(
|
|
"failed to kubeClient.Core().Nodes().Patch for node %q. %v",
|
|
nodeName,
|
|
err)
|
|
}
|
|
|
|
err = nsu.actualStateOfWorld.ResetNodeStatusUpdateNeeded(nodeName)
|
|
if err != nil {
|
|
return fmt.Errorf(
|
|
"failed to ResetNodeStatusUpdateNeeded for node %q. %v",
|
|
nodeName,
|
|
err)
|
|
}
|
|
|
|
glog.V(3).Infof(
|
|
"Updating status for node %q succeeded. patchBytes: %q",
|
|
nodeName,
|
|
string(patchBytes))
|
|
}
|
|
return nil
|
|
}
|