99a6a8ab16
Repro case: $ make clean generated_files $ hack/update-generated-protobuf.sh This would complain about not finding `fmt`, and it was indicating the wrong GOROOT. The problem was that the first step built binaries for generating code, which *embeds* the value of GOROOT into the binary. The whole tree was bind-mounted into the build container and then JUST the dockerized dir was mounted over it. The in-container build tried to use the existing binaries, but GOROOT is wrong. This change whites-out the whole _output dir. I first made just an anonymous volume for _output, but docker makes that as root, which means I can't write to it from our non-root build. So I just put it in the data container. This seems to work. The biggest change this makes is that the $GOPATH/bin/ and $GOPATH/pkg/ dirs will persist across dockerized builds.
53 lines
1.7 KiB
Bash
Executable File
53 lines
1.7 KiB
Bash
Executable File
#!/bin/bash
|
|
|
|
# Copyright 2015 The Kubernetes Authors.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
set -o errexit
|
|
set -o nounset
|
|
set -o pipefail
|
|
|
|
KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
|
|
source "${KUBE_ROOT}/hack/lib/init.sh"
|
|
|
|
kube::golang::setup_env
|
|
|
|
BINS=(
|
|
cmd/libs/go2idl/go-to-protobuf
|
|
cmd/libs/go2idl/go-to-protobuf/protoc-gen-gogo
|
|
)
|
|
make -C "${KUBE_ROOT}" WHAT="${BINS[*]}"
|
|
|
|
if [[ -z "$(which protoc)" || "$(protoc --version)" != "libprotoc 3.0."* ]]; then
|
|
echo "Generating protobuf requires protoc 3.0.0-beta1 or newer. Please download and"
|
|
echo "install the platform appropriate Protobuf package for your OS: "
|
|
echo
|
|
echo " https://github.com/google/protobuf/releases"
|
|
echo
|
|
echo "WARNING: Protobuf changes are not being validated"
|
|
exit 1
|
|
fi
|
|
|
|
gotoprotobuf=$(kube::util::find-binary "go-to-protobuf")
|
|
|
|
# requires the 'proto' tag to build (will remove when ready)
|
|
# searches for the protoc-gen-gogo extension in the output directory
|
|
# satisfies import of github.com/gogo/protobuf/gogoproto/gogo.proto and the
|
|
# core Google protobuf types
|
|
PATH="${KUBE_ROOT}/_output/bin:${PATH}" \
|
|
"${gotoprotobuf}" \
|
|
--proto-import="${KUBE_ROOT}/vendor" \
|
|
--proto-import="${KUBE_ROOT}/third_party/protobuf" \
|
|
$@
|